[tahoe-lafs-trac-stream] [tahoe-lafs] #2052: Automate testing of merge requests to streamline review.

tahoe-lafs trac at tahoe-lafs.org
Thu Aug 8 00:17:49 UTC 2013


#2052: Automate testing of merge requests to streamline review.
--------------------------+-----------------------------------------
     Reporter:  nejucomo  |      Owner:  daira
         Type:  defect    |     Status:  new
     Priority:  normal    |  Milestone:  undecided
    Component:  unknown   |    Version:  1.10.0
   Resolution:            |   Keywords:  dev-infrastructure buildbot
Launchpad Bug:            |
--------------------------+-----------------------------------------

Comment (by daira):

 I don't think it is actually a problem if this is post-review rather than
 pre-review (i.e. it is something you do if you would have committed the
 code anyway in the old flow).

 An issue here is that commits can be added to a pull request at any time,
 so the committer should specify a precise commit hash to be tested. I seem
 to remember that was the conclusion of the discussion we had a while ago,
 as well (or at least that it is what I was arguing for then).

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2052#comment:1>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list