[tahoe-lafs-trac-stream] [tahoe-lafs] #2125: don't cache failures!

[tahoe-lafs]

#2125: don't cache failures!
-------------------------------+---------------------------
 Reporter:  zooko              |          Owner:
     Type:  defect             |         Status:  new
 Priority:  normal             |      Milestone:  undecided
Component:  code-frontend-web  |        Version:  1.10.0
 Keywords:                     |  Launchpad Bug:
-------------------------------+---------------------------
 I just had a transient failure to load a file (due to #2116), and then
 every subsequent attempt to load that file got an "HTTP/1.1 304 Not
 Modified". Inspecting the headers shows me that my browser is sending:

 {{{
 If-None-Match:  wjdbbu5qjheyfxmwgy5onsx6qy
 }}}

 and the Tahoe-LAFS gateway sent back:

 {{{
 Etag:   wjdbbu5qjheyfxmwgy5onsx6qy-
 }}}

 This is a bug! ''Only'' successful file fetches should get an Etag.
 Error/failure notices like this one should not:

 {{{
 NoSharesError: no shares could be found. Zero shares usually indicates a
 corrupt URI, or that no servers were connected, but it might also indicate
 severe corruption. You should perform a filecheck on this object to learn
 more.

 The full error message is:
 no shares (need 1). Last failure: None
 }}}

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2125>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage