[tahoe-lafs-trac-stream] [tahoe-lafs] #2125: don't cache failures!

tahoe-lafs trac at tahoe-lafs.org
Sun Dec 1 21:16:35 UTC 2013


#2125: don't cache failures!
-----------------------------------+-----------------------
     Reporter:  zooko              |      Owner:
         Type:  defect             |     Status:  new
     Priority:  normal             |  Milestone:  undecided
    Component:  code-frontend-web  |    Version:  1.10.0
   Resolution:                     |   Keywords:
Launchpad Bug:                     |
-----------------------------------+-----------------------

Comment (by zooko):

 To fix this ticket, you should first extend the unit tests so that they
 exercise the case of making a request of the WUI, which request results in
 a !NoSharesError, and then your test should give WUI a red flag if the WUI
 sets the Etag on that. Or, well, I guess it should give it a red flag if
 it sets the ''same'' Etag value on a failure message result as it does on
 a successful delivery of the file. (Because it would be legit for the WUI
 to set an Etag on the failure message result as long as it sets that Etag
 iff the exactly same failure message result is the answer.)

 Here is a previous patch by Brian that extended these tests to cover a
 similar situation. You could model your patch that extends the tests on
 this patch:

 [5d404db89/trunk]

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2125#comment:1>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list