[tahoe-lafs-trac-stream] [tahoe-lafs] #2015: leasedb: high file descriptor usage exposed by tests

[tahoe-lafs]

#2015: leasedb: high file descriptor usage exposed by tests
-------------------------+-------------------------------------------------
     Reporter:  daira    |      Owner:  zooko
         Type:  defect   |     Status:  assigned
     Priority:  major    |  Milestone:  1.11.0
    Component:  code-    |    Version:  1.10.0
  storage                |   Keywords:  leasedb tests reliability file-
   Resolution:           |  descriptor leak test-needed
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by markberger):

 The patch also causes the following tests to fail:
 {{{
 [ERROR]
 Traceback (most recent call last):
   File "/Users/markberger/Code/tahoe-
 fork/src/allmydata/storage/server.py", line 258, in <lambda>
     canary))
   File "/Users/markberger/Code/tahoe-
 fork/src/allmydata/storage/backends/disk/disk_backend.py", line 167, in
 make_bucket_writer
     bw = BucketWriter(account, immsh, canary)
   File "/Users/markberger/Code/tahoe-
 fork/src/allmydata/storage/bucket.py", line 28, in __init__
     share.get_allocated_data_length(), SHARETYPE_IMMUTABLE)
   File "/Users/markberger/Code/tahoe-
 fork/src/allmydata/storage/account.py", line 54, in add_share
     self._leasedb.add_new_share(storage_index, shnum, used_space,
 sharetype)
   File "/Users/markberger/Code/tahoe-
 fork/src/allmydata/storage/leasedb.py", line 167, in add_new_share
     self._cursor.execute("INSERT OR REPLACE INTO `shares`"
 exceptions.AttributeError: LeaseDB instance has no attribute '_cursor'

 allmydata.test.test_storage.AccountingCrawlerWithDiskBackend.test_basic
 allmydata.test.test_storage.AccountingCrawlerWithDiskBackend.test_expire_age
 allmydata.test.test_storage.AccountingCrawlerWithDiskBackend.test_expire_cutoff_date
 allmydata.test.test_storage.AccountingCrawlerWithDiskBackend.test_limited_history
 }}}

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2015#comment:11>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage