[tahoe-lafs-trac-stream] [tahoe-lafs] #1819: cloud backend: merge to trunk

[tahoe-lafs]

#1819: cloud backend: merge to trunk
------------------------------+-----------------------------------
     Reporter:  davidsarah    |      Owner:  davidsarah
         Type:  enhancement   |     Status:  assigned
     Priority:  major         |  Milestone:  1.11.0
    Component:  code-storage  |    Version:  1.9.2
   Resolution:                |   Keywords:  cloud-backend leasedb
Launchpad Bug:                |
------------------------------+-----------------------------------

Comment (by daira):

 Preserving these github comments relating to
 [https://github.com/LeastAuthority/tahoe-
 lafs/commit/b0fc09876076df5104a72787701c6fdeb7c70719 b0fc0987] to stop
 them getting clobbered by a force-push:

 > zooko: How is this different than setting {{{expire.enabled = false}}}
 (as described in [source:docs/garbage-collection.rst])?
 >
 > daira: {{{expire.enabled}}} controls whether leases expire (that is,
 whether leases past their expiry timestamp are removed). This setting,
 which is just intended for debugging, controls whether shares with no
 leases are removed. Setting {{{expire.enabled}}} to false would not have
 had any effect on the kind of bug I believed was present in the accounting
 crawler.
 >
 > zooko: I see. Thanks. I'd rather we not commit code to trunk which is,
 like this, solely for debugging.
 >
 > daira: Hmm. We have lots of code that is just for debugging.
 >
 > zooko: Well, this patch, I don't feel particularly good about. It makes
 it harder for someone reading the code, and for little gain. We could use
 other ways to disable share deletion for debugging, next time we want to
 do that.
 >
 > daira: I'm sorry you don't feel good about this patch. I'll probably
 omit it when rebasing the branch to trunk, but I'd like to keep it on this
 branch until I've debugged #1921 and confirmed that #1987 is invalid.
 >
 > zooko: Okay!

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1819#comment:9>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage