[tahoe-lafs-trac-stream] [tahoe-lafs] #1975: remove the last use of notifyOnDisconnect, in server selection

[tahoe-lafs]

#1975: remove the last use of notifyOnDisconnect, in server selection
-----------------------------+---------------------------
 Reporter:  zooko            |          Owner:
     Type:  defect           |         Status:  new
 Priority:  normal           |      Milestone:  undecided
Component:  code-network     |        Version:  1.10.0
 Keywords:  foolscap upload  |  Launchpad Bug:
-----------------------------+---------------------------
 Please read the description of #816 for context. There is, I believe, a
 bug in foolscap's {{{notifyOnDisconnect}}}. We only use it in one place
 now, which is in the share allocation algorithm's server selection. We
 might want to keep using it there, even though it is buggy, because it
 doesn't matter that much whether it works or not -- it just changes the
 order of shares. Or we might want to remove the use of it, for similar
 reasons. It would also be possible to make the server selection more
 complicated in order to order the shares nicely even when a server fails
 to accept the share that you originally intended for it, but that might
 not be worth the complexity cost.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1975>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage