#1975 new defect

remove the last use of notifyOnDisconnect, in server selection

Reported by: zooko Owned by:
Priority: normal Milestone: soon
Component: code-network Version: 1.10.0
Keywords: foolscap upload notifyOnDisconnect Cc:
Launchpad Bug:

Description

Please read the description of #816 for context. There is, I believe, a bug in foolscap's notifyOnDisconnect. We only use it in one place now, which is in the share allocation algorithm's server selection. We might want to keep using it there, even though it is buggy, because it doesn't matter that much whether it works or not -- it just changes the order of shares. Or we might want to remove the use of it, for similar reasons. It would also be possible to make the server selection more complicated in order to order the shares nicely even when a server fails to accept the share that you originally intended for it, but that might not be worth the complexity cost.

Change History (9)

comment:1 Changed at 2013-05-23T03:12:53Z by daira

I think that it's possible to retain the deterministic allocation without too much complexity. We should consider this when designing the changes to share allocation for #1130, #1382, and related tickets.

comment:2 Changed at 2013-06-25T16:17:05Z by zooko

  • Keywords notifyOnDisconnect added

comment:4 Changed at 2015-08-25T17:34:25Z by zooko

I would still like to kill our reliance on the notifyOnDisconnect feature of Foolscap, which is actually buggy in practice (see comment:3:ticket:1768), and which cannot be made bug-free even in principle, and which we don't really need very much.

comment:5 Changed at 2015-08-25T20:18:37Z by daira

  • Milestone changed from undecided to 1.11.0

+1

comment:6 Changed at 2016-03-22T05:02:52Z by warner

  • Milestone changed from 1.11.0 to 1.12.0

Milestone renamed

comment:7 Changed at 2016-06-28T18:20:37Z by warner

  • Milestone changed from 1.12.0 to 1.13.0

moving most tickets from 1.12 to 1.13 so we can release 1.12 with magic-folders

comment:8 Changed at 2020-06-30T14:45:13Z by exarkun

  • Milestone changed from 1.13.0 to 1.15.0

Moving open issues out of closed milestones.

comment:9 Changed at 2021-03-30T18:40:19Z by meejah

  • Milestone changed from 1.15.0 to soon

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.