remove the last use of notifyOnDisconnect, in server selection

[zooko]

Please read the description of #816 for context. There is, I believe, a bug in foolscap's notifyOnDisconnect. We only use it in one place now, which is in the share allocation algorithm's server selection. We might want to keep using it there, even though it is buggy, because it doesn't matter that much whether it works or not -- it just changes the order of shares. Or we might want to remove the use of it, for similar reasons. It would also be possible to make the server selection more complicated in order to order the shares nicely even when a server fails to accept the share that you originally intended for it, but that might not be worth the complexity cost.

[daira]

I think that it's possible to retain the deterministic allocation without too much complexity. We should consider this when designing the changes to share allocation for #1130, #1382, and related tickets.

[zooko]

Please see comment:3:ticket:1768.

[zooko]

I would still like to kill our reliance on the notifyOnDisconnect feature of Foolscap, which is actually buggy in practice (see comment:3:ticket:1768), and which cannot be made bug-free even in principle, and which we don't really need very much.

[daira]

+1

[warner]

Milestone renamed

[warner]

moving most tickets from 1.12 to 1.13 so we can release 1.12 with magic-folders

[exarkun]

Moving open issues out of closed milestones.

[meejah]

Ticket retargeted after milestone closed