wui: the "report an incident" feature doesn't submit incident reports

[leif]

In the web ui there is a section titled "Report an Incident" with a text input box labeled "What went wrong?" and a button labeled "Report". Upon entering text in the box and clicking report, it returns a page saying "Thank you for your report!".

It seems reasonable to assume that clicking this button has submitted a report to someone via the internet.

In fact, it has not. What it actually is doing is dumping an internal ring buffer of logs to a .flog.bz2 file in ~/.tahoe/logs/incidents/ which can be viewed using the tahoe @flogtool web-open command (or other flogtool commands). It might be useful to share this file with the developers, but no report is being automatically sent to them.

An easy fix would be to replace the "Report" button with a "Save" button, and replace the text "Report an Incident" with something like "Save an incident report".

A nicer improvement would be to make it possible to access the page rendered by flogtool web-open from directly within the wui, without needing to write the file to disk and open it via the commandline. (Perhaps a separate ticket should be opened for that.)

Related: #1936 (the tahoe-lafs logging system is hard to discover)

[leif]

Submitted pull request: ​https://github.com/tahoe-lafs/tahoe-lafs/pull/43

[daira]

Reviewing.

[daira]

Reviewed and has tests, will commit.

[Leif Ryge <leif@…>]

In 30924a506ced5c1f06e034b4f1482217746255ca/trunk:

properly describe saving incident reports. closes #1974