[tahoe-lafs-trac-stream] [tahoe-lafs] #1153: need tests for create-{client, node} with default nodedir

[tahoe-lafs]

#1153: need tests for create-{client, node} with default nodedir
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  davidsarah
  davidsarah             |     Status:  assigned
         Type:  defect   |  Milestone:  soon
     Priority:  normal   |    Version:  1.7.1
    Component:  code-    |   Keywords:  test-needed unfinished-business
  nodeadmin              |  config
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by zooko):

 * keywords:  test-needed unfinished-business => test-needed unfinished-
     business config


Old description:

> We shouldn't create a node at the actual default basedir (which might
> already exist), which is why there are no existing tests for this.
>
> However, we could:
>  * check that the result of
> [source:src/allmydata/scripts/common.py at 4615#L10 get_default_nodedir] is
> sensible;
>  * mock {{{get_default_nodedir}}} to return a default nodedir under the
> {{{_trial_temp}}} directory.
>
> To test the logic for getting the default nodedir from the registry entry
> on Windows, we can mock {{{sys.platform}}} and
> {{{allmydata.windows.registry.get_registry_value}}}.

New description:

 We shouldn't create a node at the actual default basedir (which might
 already exist), which is why there are no existing tests for this.

 However, we could:
  * check that the result of
 [source:src/allmydata/scripts/common.py at 4615#L10 get_default_nodedir] is
 sensible;
  * mock {{{get_default_nodedir}}} to return a default nodedir under the
 {{{_trial_temp}}} directory.

 To test the logic for getting the default nodedir from the registry entry
 on Windows, we can mock {{{sys.platform}}} and
 {{{allmydata.windows.registry.get_registry_value}}}.

--

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1153#comment:5>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage