#1153 assigned defect

need tests for create-{client, node} with default nodedir

Reported by: davidsarah Owned by: davidsarah
Priority: normal Milestone: soon
Component: code-nodeadmin Version: 1.7.1
Keywords: test-needed unfinished-business config Cc: zancas
Launchpad Bug:

Description (last modified by zooko)

We shouldn't create a node at the actual default basedir (which might already exist), which is why there are no existing tests for this.

However, we could:

  • check that the result of get_default_nodedir is sensible;
  • mock get_default_nodedir to return a default nodedir under the _trial_temp directory.

To test the logic for getting the default nodedir from the registry entry on Windows, we can mock sys.platform and allmydata.windows.registry.get_registry_value.

Change History (5)

comment:1 Changed at 2010-08-14T06:38:04Z by zooko

  • Keywords unfinished-business added
  • Milestone changed from 1.8.0 to soon

comment:2 Changed at 2011-08-18T03:51:34Z by zooko

  • Cc zancas added

comment:3 Changed at 2012-04-01T05:17:55Z by davidsarah

  • Milestone changed from soon to 1.11.0
  • Priority changed from major to normal

comment:4 Changed at 2012-06-29T13:14:29Z by davidsarah

  • Owner set to davidsarah
  • Status changed from new to assigned

comment:5 Changed at 2013-10-07T15:44:37Z by zooko

  • Description modified (diff)
  • Keywords config added
Note: See TracTickets for help on using tickets.