[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2300: missing git tags causes tests to fail
Tahoe-LAFS
trac at tahoe-lafs.org
Fri Sep 19 21:19:46 UTC 2014
#2300: missing git tags causes tests to fail
-----------------------+------------------------
Reporter: warner | Owner:
Type: defect | Status: new
Priority: normal | Milestone: 1.12.0
Component: packaging | Version: 1.10.0
Keywords: | Launchpad Bug:
-----------------------+------------------------
kaoline tried to run `setup.py test` in a tree that was cloned from
zancas's github repo. This failed when something tried to `import
allmydata._version`.
Zancas's repo lacks tags, so kaoline's tree lacked them too. `setup.py
build` ran without complaint, but it did not create
`src/allmydata/_version.py` as usual, because the `git describe --tags
--dirty --always` command (copied from Versioneer) didn't see any tags, so
setup.py didn't deduce a version string, so it didn't create
`_version.py`. This is ok for setup.py, but actually trying to use tahoe
(including running tests) fails, since `__init__.py` fails to do its
`import _version`.
Modern Versioneer handles this better (by faking a "0.0" tag if it can't
find any others). The code in tahoe's setup.py is copied from an older
form of Versioneer. The best fix (after 1.11) is probably to switch over
to Versioneer altogether, instead of copying fragments of it into setup.py
.
Meanwhile, I'd recommend that developers start by cloning the official
repo at https://github.com/tahoe-lafs/tahoe-lafs.git , which should get
them all the correct tags.
--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2300>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list