[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2231: when multiple commits are pushed, only the last one can trigger a trac auto-commit message

[Tahoe-LAFS]

#2231: when multiple commits are pushed, only the last one can trigger a trac
auto-commit message
------------------------------------+-----------------------
     Reporter:  daira               |      Owner:
         Type:  defect              |     Status:  closed
     Priority:  normal              |  Milestone:  undecided
    Component:  dev-infrastructure  |    Version:  1.10.0
   Resolution:  fixed               |   Keywords:  trac
Launchpad Bug:                      |
------------------------------------+-----------------------
Changes (by warner):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I fixed this. It turns out the notification script was always telling trac
 that the most-recent commit was new. This was wrong in both directions:

 * if multiple revisions appeared at the same time, such as when you land a
 merge commit or pushed multiple commits together, trac would only hear
 about the last one
 * if an unrelated branch was pushed, trac would hear about the latest
 commit (on master) again, causing multiple ticket comments, and multiple
 emails to be sent.

 I fixed it to stash the old repo branch (`OLD=git rev-parse master`) and
 use that to build a new list (`REVS=git rev-list ^OLD master`). That list
 will be empty if nothing has changed.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2231#comment:1>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage