#2231 closed defect (fixed)

when multiple commits are pushed, only the last one can trigger a trac auto-commit message

Reported by: daira Owned by:
Priority: normal Milestone: undecided
Component: dev-infrastructure Version: 1.10.0
Keywords: trac Cc:
Launchpad Bug:


For example: [77767e9e12cbd3e03f8ad917f6d3e8c1e4918c43/trunk] and [4889129f3732219cb9cedb1eb27dec3da3f22db2/trunk] were committed at the same time, one with 'fixes #1847' and the other with 'refs #1847' in the commit message. Only the latter appeared automatically on #1847.

Change History (3)

comment:1 Changed at 2015-04-28T23:00:03Z by warner

  • Resolution set to fixed
  • Status changed from new to closed

I fixed this. It turns out the notification script was always telling trac that the most-recent commit was new. This was wrong in both directions:

  • if multiple revisions appeared at the same time, such as when you land a merge commit or pushed multiple commits together, trac would only hear about the last one
  • if an unrelated branch was pushed, trac would hear about the latest commit (on master) again, causing multiple ticket comments, and multiple emails to be sent.

I fixed it to stash the old repo branch (OLD=git rev-parse master) and use that to build a new list (REVS=git rev-list ^OLD master). That list will be empty if nothing has changed.

comment:2 Changed at 2015-04-28T23:56:11Z by daira

Could this change have caused #2413?

comment:3 Changed at 2015-04-28T23:57:35Z by daira

Oh, #2413 might be a duplicate of the second issue above (and therefore now fixed).

Note: See TracTickets for help on using tickets.