[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2543: suspicious code — bug? dead code?

[Tahoe-LAFS]

#2543: suspicious code — bug? dead code?
---------------------+---------------------------
 Reporter:  zooko    |          Owner:  daira
     Type:  defect   |         Status:  new
 Priority:  normal   |      Milestone:  undecided
Component:  unknown  |        Version:  1.10.1
 Keywords:           |  Launchpad Bug:
---------------------+---------------------------
 {{{
 diff --git a/src/allmydata/mutable/layout.py
 b/src/allmydata/mutable/layout.py
 index b938794..68d2992 100644
 --- a/src/allmydata/mutable/layout.py
 +++ b/src/allmydata/mutable/layout.py
 @@ -1164,6 +1164,7 @@ class MDMFSlotWriteProxy:
                                    self._secrets,
                                    tw_vectors,
                                    self._readv)
 +XXX this is not an addBoth so the failure will never (??) get passed to
 _result()
          def _result(results):
              if isinstance(results, failure.Failure) or not results[0]:
                  # Do nothing; the write was unsuccessful.
 }}}

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2543>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage