suspicious code — bug? dead code?

[zooko]

diff --git a/src/allmydata/mutable/layout.py b/src/allmydata/mutable/layout.py
index b938794..68d2992 100644
--- a/src/allmydata/mutable/layout.py
+++ b/src/allmydata/mutable/layout.py
@@ -1164,6 +1164,7 @@ class MDMFSlotWriteProxy:
                                   self._secrets,
                                   tw_vectors,
                                   self._readv)
+XXX this is not an addBoth so the failure will never (??) get passed to _result()
         def _result(results):
             if isinstance(results, failure.Failure) or not results[0]:
                 # Do nothing; the write was unsuccessful.

[daira]

Yes, this looks wrong.

[daira]

I believe the correct fix for this is just to change addCallback to addBoth. We do not have a test; it seems that it would probably go in test_mutable.py, but there are no existing tests there that simulate failures from slot_testv_and_readv_and_writev.

[daira]

We agreed to just change addCallback to addBoth.

[Daira Hopwood <daira@…>]

In 278ee0d/trunk:

Fix an error handling path that would never have been reached. fixes ticket:2543

Signed-off-by: Daira Hopwood <daira@…>

[warner]

Milestone renamed