[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2509: Magic Folder: clean up use of is_ready

[Tahoe-LAFS]

#2509: Magic Folder: clean up use of is_ready
-------------------------------------+-------------------------------------
     Reporter:  daira                |      Owner:  daira
         Type:  defect               |     Status:  new
     Priority:  normal               |  Milestone:  soon
    Component:  code-frontend-       |    Version:  n/a
  magic-folder                       |   Keywords:  otf-magic-folder-
   Resolution:                       |  objective4 cleanup
Launchpad Bug:                       |
-------------------------------------+-------------------------------------
Description changed by daira:

Old description:

> As of [https://github.com/tahoe-lafs/tahoe-
> lafs/blob/665c36e45cab3487f279ccae44f79f606613c8f2/src/allmydata/frontends/magic_folder.py
> 665c36e4]:
>
> Class `MagicFolder` has an `is_ready` attribute that is not needed.
>
> `QueueMixin._append_to_deque` references `self.is_ready`, but that is
> only initialised in `Uploader`, not `Downloader`. This works only because
> `_append_to_deque` is not called in `Downloader`
> (`_add_batch_to_download_queue` is used instead).

New description:

 As of [https://github.com/tahoe-lafs/tahoe-
 lafs/blob/665c36e45cab3487f279ccae44f79f606613c8f2/src/allmydata/frontends/magic_folder.py
 665c36e4]:

 Class `MagicFolder` has a redundant `is_ready` attribute.

 `QueueMixin._append_to_deque` references `self.is_ready`, but that is only
 initialised in `Uploader`, not `Downloader`. This works only because
 `_append_to_deque` is not called in `Downloader`
 (`_add_batch_to_download_queue` is used instead).

--

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2509#comment:1>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage