#2509 closed defect (fixed)

Magic Folder: clean up use of is_ready

Reported by: daira Owned by: daira
Priority: normal Milestone: soon
Component: code-frontend-magic-folder Version: n/a
Keywords: otf-magic-folder-objective4 cleanup Cc:
Launchpad Bug:

Description (last modified by daira)

As of 665c36e4:

Class MagicFolder has a redundant is_ready attribute.

QueueMixin._append_to_deque references self.is_ready, but that is only initialised in Uploader, not Downloader. This works only because _append_to_deque is not called in Downloader (_add_batch_to_download_queue is used instead).

Change History (3)

comment:1 Changed at 2015-09-22T08:07:57Z by daira

  • Description modified (diff)

comment:2 Changed at 2015-11-03T03:39:54Z by daira

Fixed on the 2553.do-not-read-from-own-dmd.3 branch.

comment:3 Changed at 2015-11-04T01:18:50Z by daira

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.