[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2769: DirtyReactor failure in test_iputil.ListAddresses.test_list_async when offline

[Tahoe-LAFS]

#2769: DirtyReactor failure in test_iputil.ListAddresses.test_list_async when
offline
--------------------+------------------------
 Reporter:  warner  |          Owner:
     Type:  defect  |         Status:  new
 Priority:  minor   |      Milestone:  soon
Component:  code    |        Version:  1.11.0
 Keywords:          |  Launchpad Bug:
--------------------+------------------------
 I ran the test suite from an airplane yesterday (offline), and hit a
 !DirtyReactorError in `test_iputil.ListAddresses.test_list_async`. I
 traced it down to a failure in the call to `udpprot.transport.connect()`.
 That failure is expected (when offline), and caught, but in doing so the
 function fails to call `port.stopListening()`, and leaves the
 `DatagramProtocol` listening. That's what is dirty about the reactor at
 the end of the test.

 I've got a simple patch that moves the `stopListening()` into a `finally:`
 block.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2769>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage