[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2769: DirtyReactor failure in test_iputil.ListAddresses.test_list_async when offline

[Tahoe-LAFS]

#2769: DirtyReactor failure in test_iputil.ListAddresses.test_list_async when
offline
------------------------+-------------------------------------
     Reporter:  warner  |      Owner:  Brian Warner <warner@…>
         Type:  defect  |     Status:  closed
     Priority:  minor   |  Milestone:  soon
    Component:  code    |    Version:  1.11.0
   Resolution:  fixed   |   Keywords:
Launchpad Bug:          |
------------------------+-------------------------------------
Changes (by Brian Warner <warner@…>):

 * owner:   => Brian Warner <warner@…>
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ce548687f814dc64f6434a0cdf62391d4956ec96/trunk"
 ce54868/trunk]:
 {{{
 #!CommitTicketReference repository="trunk"
 revision="ce548687f814dc64f6434a0cdf62391d4956ec96"
 iputil.py: avoid DirtyReactorError when running tests offline

 The udpprot.transport.connect() fails if we don't have a network
 connection, but the port is still listening, so trial gives us a
 DirtyReactorError. The fix is a "finally:" which does
 port.stopListening() even in this case.

 Closes ticket:2769
 }}}

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2769#comment:1>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage