[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2795: copy fixed allocate_tcp_port() from Foolscap

[Tahoe-LAFS]

#2795: copy fixed allocate_tcp_port() from Foolscap
--------------------+------------------------
 Reporter:  warner  |          Owner:  warner
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  1.12.0
Component:  code    |        Version:  1.11.0
 Keywords:          |  Launchpad Bug:
--------------------+------------------------
 The synchronous node startup work (#2491) used a function I wrote for
 Foolscap, named `allocate_tcp_port()`, which.. wait for it.. allocates a
 TCP port. But it had a bug, which occasionally (maybe 1 out of 5000
 trials) returns a port which is actually in use, which causes an
 EADDRINUSE when you try to listen on it. Given the number of port
 allocations performed by the unit test suite, I think this was causing
 spurious failures in maybe 2-5% of test runs.

 [https://foolscap.lothar.com/trac/ticket/258 Foolscap#258] fixes the bug
 (the details are platform-specific). So the task is just to copy the
 updated function over into `src/allmydata/util/iputil.py`.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2795>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage