#2795 closed defect (fixed)
copy fixed allocate_tcp_port() from Foolscap
Reported by: | warner | Owned by: | warner |
---|---|---|---|
Priority: | normal | Milestone: | 1.12.0 |
Component: | code | Version: | 1.11.0 |
Keywords: | Cc: | ||
Launchpad Bug: |
Description
The synchronous node startup work (#2491) used a function I wrote for Foolscap, named allocate_tcp_port(), which.. wait for it.. allocates a TCP port. But it had a bug, which occasionally (maybe 1 out of 5000 trials) returns a port which is actually in use, which causes an EADDRINUSE when you try to listen on it. Given the number of port allocations performed by the unit test suite, I think this was causing spurious failures in maybe 2-5% of test runs.
Foolscap#258 fixes the bug (the details are platform-specific). So the task is just to copy the updated function over into src/allmydata/util/iputil.py.
Change History (2)
comment:1 Changed at 2016-07-07T02:52:04Z by Brian Warner <warner@…>
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed at 2016-09-02T06:04:11Z by Brian Warner <warner@…>
In 57e7f7b/trunk:
Note: See
TracTickets for help on using
tickets.
In 3402f75/trunk: