[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1346: desert-island test can pass incorrectly because packages are installed

[Tahoe-LAFS]

#1346: desert-island test can pass incorrectly because packages are installed
---------------------------------+-----------------------------------------
     Reporter:  davidsarah       |      Owner:  davidsarah
         Type:  defect           |     Status:  closed
     Priority:  major            |  Milestone:  1.11.0
    Component:  dev-             |    Version:  1.8.1
  infrastructure                 |
   Resolution:  fixed            |   Keywords:  buildbot desert-island sumo
Launchpad Bug:                   |
---------------------------------+-----------------------------------------
Changes (by warner):

 * status:  assigned => closed
 * resolution:   => fixed
 * milestone:  soon (release n/a) => 1.11.0


Old description:

> The desert-island test should be testing that the contents of the deps
> tarball are sufficient to build without downloading. It's actually
> testing that those contents plus any locally installed packages, are
> sufficient to build without downloading.
>
> For example, a SUMO build of 1.8.2b1, with no dependencies installed,
> will download setuptools_trial from PyPI in order to build zfec. That
> [http://tahoe-lafs.org/buildbot/builders/clean/builds/2707/steps/test-
> desert-island/logs/stdio isn't caught by the desert-island builder]
> because it has zfec locally installed.
>
> In fact that builder has pycryptopp, mock, pyasn1, pycrypto, Nevow,
> foolscap, Twisted, zope.interface, simplejson, zfec, pyOpenSSL, pyutil,
> argparse, and zbase32 installed, so it is not using any of those from the
> tarball.
>
> I believe the test should warn if it has any lines that start with "Using
> ".

New description:

 The desert-island test should be testing that the contents of the deps
 tarball are sufficient to build without downloading. It's actually testing
 that those contents plus any locally installed packages, are sufficient to
 build without downloading.

 For example, a SUMO build of 1.8.2b1, with no dependencies installed, will
 download setuptools_trial from PyPI in order to build zfec. That [http
 ://tahoe-lafs.org/buildbot/builders/clean/builds/2707/steps/test-desert-
 island/logs/stdio isn't caught by the desert-island builder] because it
 has zfec locally installed.

 In fact that builder has pycryptopp, mock, pyasn1, pycrypto, Nevow,
 foolscap, Twisted, zope.interface, simplejson, zfec, pyOpenSSL, pyutil,
 argparse, and zbase32 installed, so it is not using any of those from the
 tarball.

 I believe the test should warn if it has any lines that start with "Using
 ".

--

Comment:

 We no longer provide SUMO tarballs, and the new desert-island procedure
 uses the pip wheel cache. Also, everything is now tested in a virtualenv.
 So I'm going to close this one.

 We might want to have a new ticket to exercise the recommended desert-
 island procedure, but I'm not currently convinced we really need it.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1346#comment:6>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage