Opened at 2011-01-31T00:13:35Z
Closed at 2016-03-27T18:34:22Z
#1346 closed defect (fixed)
desert-island test can pass incorrectly because packages are installed
| Reported by: | davidsarah | Owned by: | davidsarah |
|---|---|---|---|
| Priority: | major | Milestone: | 1.11.0 |
| Component: | dev-infrastructure | Version: | 1.8.1 |
| Keywords: | buildbot desert-island sumo | Cc: | zooko |
| Launchpad Bug: |
Description (last modified by warner)
The desert-island test should be testing that the contents of the deps tarball are sufficient to build without downloading. It's actually testing that those contents plus any locally installed packages, are sufficient to build without downloading.
For example, a SUMO build of 1.8.2b1, with no dependencies installed, will download setuptools_trial from PyPI in order to build zfec. That isn't caught by the desert-island builder because it has zfec locally installed.
In fact that builder has pycryptopp, mock, pyasn1, pycrypto, Nevow, foolscap, Twisted, zope.interface, simplejson, zfec, pyOpenSSL, pyutil, argparse, and zbase32 installed, so it is not using any of those from the tarball.
I believe the test should warn if it has any lines that start with "Using ".
Change History (6)
comment:1 Changed at 2011-02-02T22:05:27Z by zooko
- Cc zooko added
comment:2 follow-up: ↓ 3 Changed at 2011-08-01T18:14:46Z by zooko
comment:3 in reply to: ↑ 2 Changed at 2011-08-16T04:30:14Z by davidsarah
Replying to zooko:
It would be really great to have a layer of isolation between the code-under-test, which in this case is the source tree and its build system, from the test-code which in this case is the buildbot itself and the other code on the host's system. The Python "virtualenv" tool might be pretty well-suited for this. I think that's what its raison d'etre is.
This is #1464.
comment:4 Changed at 2012-03-29T16:10:43Z by zooko
- Priority changed from critical to major
comment:5 Changed at 2012-03-29T20:09:48Z by davidsarah
- Owner changed from somebody to davidsarah
- Status changed from new to assigned
comment:6 Changed at 2016-03-27T18:34:22Z by warner
- Description modified (diff)
- Milestone changed from soon (release n/a) to 1.11.0
- Resolution set to fixed
- Status changed from assigned to closed
We no longer provide SUMO tarballs, and the new desert-island procedure uses the pip wheel cache. Also, everything is now tested in a virtualenv. So I'm going to close this one.
We might want to have a new ticket to exercise the recommended desert-island procedure, but I'm not currently convinced we really need it.
It would be really great to have a layer of isolation between the code-under-test, which in this case is the source tree and its build system, from the test-code which in this case is the buildbot itself and the other code on the host's system. The Python "virtualenv" tool might be pretty well-suited for this. I think that's what its raison d'etre is.