[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2997: Magic-Folder doesn't ask for subtree events on Windows

[Tahoe-LAFS]

#2997: Magic-Folder doesn't ask for subtree events on Windows
---------------------+---------------------------
 Reporter:  exarkun  |          Owner:
     Type:  defect   |         Status:  new
 Priority:  normal   |      Milestone:  undecided
Component:  unknown  |        Version:  1.12.1
 Keywords:           |  Launchpad Bug:
---------------------+---------------------------
 In `windows/inotify.py`, `ReadDirectoryChangesW` gets called with
 `bWatchSubtree=0`.  This means only notifications for changes to the
 direct contents of the opened directory are returned.  For example, if the
 directory is "foo" then events for "foo/bar" will be returned but not for
 "foo/bar/baz".

 This means changes nested in the tree somewhere aren't picked up until the
 periodic traverse-everything scan notices them.

 Note the code _appears_ to pass `bWatchSubtree=1` but because the values
 of `TRUE` and `FALSE` are inverted in the file it actually passes `0`.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2997>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage