Opened at 2019-03-12T23:26:48Z

Closed at 2019-03-14T15:21:11Z

#2997 closed defect (fixed)

Magic-Folder doesn't ask for subtree events on Windows

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: unknown Version: 1.12.1
Keywords: review-needed Cc:
Launchpad Bug:

Description

In windows/inotify.py, ReadDirectoryChangesW gets called with bWatchSubtree=0. This means only notifications for changes to the direct contents of the opened directory are returned. For example, if the directory is "foo" then events for "foo/bar" will be returned but not for "foo/bar/baz".

This means changes nested in the tree somewhere aren't picked up until the periodic traverse-everything scan notices them.

Note the code _appears_ to pass bWatchSubtree=1 but because the values of TRUE and FALSE are inverted in the file it actually passes 0.

Change History (2)

comment:2 Changed at 2019-03-14T15:21:11Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 9046bcc/trunk:

Merge pull request #570 from tahoe-lafs/2997.windows-magic-folder-watch-subtree

Make Magic-Folders more responsive on Windows (and fix the test suite).

Fixes: ticket:2997

Note: See TracTickets for help on using tickets.