[tahoe-lafs-trac-stream] [Tahoe-LAFS] #3456: Fold common_py3 back into common

[Tahoe-LAFS]

#3456: Fold common_py3 back into common
------------------------------+------------------------------
     Reporter:  chadwhitacre  |      Owner:  chadwhitacre
         Type:  task          |     Status:  assigned
     Priority:  normal        |  Milestone:  Support Python 3
    Component:  code          |    Version:  n/a
   Resolution:                |   Keywords:
Launchpad Bug:                |
------------------------------+------------------------------

Comment (by chadwhitacre):

 Reviewing the [https://github.com/tahoe-lafs/tahoe-
 lafs/commits/e981fea00790765af81422d1c02dba0cfd4295e1/src/allmydata/test/common_py3.py
 history] of common_py3.py, here is a list of commits to undo:

 1. [https://github.com/tahoe-lafs/tahoe-
 lafs/commit/a758f32edfd816ca4d56e797767fdaa4312f5bb1 LoggingServiceParent,
 ShouldFailMixin] (common)
 1. [https://github.com/tahoe-lafs/tahoe-
 lafs/commit/416ab643359c10e80f9ef0b18e8e4d173757bde5 Marker, FakeCanary]
 1. [https://github.com/tahoe-lafs/tahoe-
 lafs/commit/e13c0cf4d34dacf00b51c0d788fd859197467ac2 ReallyEqualMixin]
 1. [https://github.com/tahoe-lafs/tahoe-
 lafs/commit/44143d1b083acf23b93bbfb5eb37a23e9af22934 ShouldFailMixin]
 (common_util, [https://github.com/tahoe-lafs/tahoe-
 lafs/commit/d195ae43232b654371d1f3d476fc0b7bde640be9 cf.])
 1. [https://github.com/tahoe-lafs/tahoe-
 lafs/commit/bf134019797b2fadc8f92405720b1956e4b2fbc5 SignalMixin]
 1. [https://github.com/tahoe-lafs/tahoe-
 lafs/commit/51e9c2183cf15268985412481b01112f8b2a5b77 TimezoneMixin]

 This isn't simply a revert, however, since the classes have changed since
 being moved into common_py3. It's the current version of each class that
 we want to move back. Also, they came from different sources (common,
 common_util, etc.) and I plan to move them each back where they came
 from—so this isn't a simple copy/paste into common.py.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3456#comment:2>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage