Opened at 2020-10-01T01:45:36Z

Closed at 2020-10-23T14:30:02Z

#3456 closed task (fixed)

Fold common_py3 back into common

Reported by: chadwhitacre Owned by: chadwhitacre
Priority: normal Milestone: Support Python 3
Component: code Version: n/a
Keywords: review Cc:
Launchpad Bug:

Description

Pursuant to ​https://github.com/tahoe-lafs/tahoe-lafs/pull/823/files#r494347203 ff.

Change History (4)

comment:1 Changed at 2020-10-01T01:46:19Z by chadwhitacre

  • Owner set to chadwhitacre
  • Status changed from new to assigned

comment:2 Changed at 2020-10-01T02:13:18Z by chadwhitacre

Reviewing the ​history of common_py3.py, here is a list of commits to undo:

  1. ​LoggingServiceParent, ShouldFailMixin (common)
  2. ​Marker, FakeCanary
  3. ​ReallyEqualMixin, skip_if_cannot_represent_filename
  4. ​ShouldFailMixin (common_util, ​cf.)
  5. ​SignalMixin
  6. ​TimezoneMixin

This isn't simply a revert, however, since the classes have changed since being moved into common_py3. It's the current version of each class that we want to move back. Also, they came from different sources (common, common_util, etc.) and I plan to move them each back where they came from—so this isn't a simple copy/paste into common.py.

Last edited at 2020-10-01T02:34:30Z by chadwhitacre (previous) (diff)

comment:4 Changed at 2020-10-23T14:30:02Z by exarkun

  • Resolution set to fixed
  • Status changed from assigned to closed

The PR was merged in ​https://github.com/tahoe-lafs/tahoe-lafs/commit/2fe2acf4c72d5921d92ed7474bfd92565c136c8a

Note: See TracTickets for help on using tickets.