[tahoe-lafs-trac-stream] [Tahoe-LAFS] #3460: StorageFarmBroker._got_announcement unnecessarily makes a storage server for duplicate announcements

[Tahoe-LAFS]

#3460: StorageFarmBroker._got_announcement unnecessarily makes a storage server
for duplicate announcements
---------------------+---------------------------
 Reporter:  exarkun  |          Owner:
     Type:  defect   |         Status:  new
 Priority:  normal   |      Milestone:  undecided
Component:  unknown  |        Version:  n/a
 Keywords:           |  Launchpad Bug:
---------------------+---------------------------
 `_got_announcement` first creates a new `NativeStorageServer` for the
 announcement it has received.  Then, it checks to see if it already has a
 storage server with a matching server id with an announcement equal to the
 one just received.  If it is equal, it throws away the newly created
 `NativeStorageServer` and abandons processing of the new announcement.

 Instead, it should do the check before creating the new
 `NativeStorageServer`.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3460>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage