#3460 closed defect (fixed)

StorageFarmBroker._got_announcement unnecessarily makes a storage server for duplicate announcements

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: unknown Version: n/a
Keywords: review Cc:
Launchpad Bug:


_got_announcement first creates a new NativeStorageServer for the announcement it has received. Then, it checks to see if it already has a storage server with a matching server id with an announcement equal to the one just received. If it is equal, it throws away the newly created NativeStorageServer and abandons processing of the new announcement.

Instead, it should do the check before creating the new NativeStorageServer.

Change History (2)

comment:2 Changed at 2020-10-16T12:55:16Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In f15086d/trunk:

Merge pull request #844 from tahoe-lafs/3460.improved-got_announcement

Improved _got_announcement

Fixes: ticket:3460

Note: See TracTickets for help on using tickets.