[tahoe-lafs-trac-stream] [Tahoe-LAFS] #3470: The eventual-send in OneShotObserverList is unnecessary and in the way

[Tahoe-LAFS]

#3470: The eventual-send in OneShotObserverList is unnecessary and in the way
---------------------+---------------------------
 Reporter:  exarkun  |          Owner:
     Type:  defect   |         Status:  new
 Priority:  normal   |      Milestone:  undecided
Component:  unknown  |        Version:  n/a
 Keywords:           |  Launchpad Bug:
---------------------+---------------------------
 `OneShotObserverList` uses `eventually` in `_fire` to avoid having the
 `fire` method (and its caller) on the call stack when it fires the waiting
 Deferreds.

 I don't know if this was once required to make something work but it is no
 longer required to make any test in the current test suite pass.

 Since it introduces a dependency on the global reactor onto all code that
 uses `OneShotObserverList` (directly or indirectly) it makes testing much
 more difficult.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3470>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage