Opened at 2020-10-14T14:55:27Z
Closed at 2020-10-15T21:37:37Z
#3470 closed defect (fixed)
The eventual-send in OneShotObserverList is unnecessary and in the way
| Reported by: | exarkun | Owned by: | GitHub <noreply@…> |
|---|---|---|---|
| Priority: | normal | Milestone: | undecided |
| Component: | unknown | Version: | n/a |
| Keywords: | review | Cc: | |
| Launchpad Bug: |
Description
OneShotObserverList uses eventually in _fire to avoid having the fire method (and its caller) on the call stack when it fires the waiting Deferreds.
I don't know if this was once required to make something work but it is no longer required to make any test in the current test suite pass.
Since it introduces a dependency on the global reactor onto all code that uses OneShotObserverList (directly or indirectly) it makes testing much more difficult.
Change History (2)
comment:1 Changed at 2020-10-14T14:57:47Z by exarkun
- Keywords review added
comment:2 Changed at 2020-10-15T21:37:37Z by GitHub <noreply@…>
- Owner set to GitHub <noreply@…>
- Resolution set to fixed
- Status changed from new to closed
In 99fe617/trunk:
Note: See
TracTickets for help on using
tickets.
https://github.com/tahoe-lafs/tahoe-lafs/pull/857