Ticket #1429: 1429-rerecord-and-add-test-of-absent-localdir.darcs.patch

File 1429-rerecord-and-add-test-of-absent-localdir.darcs.patch, 38.1 KB (added by zooko, at 2011-08-09T22:24:56Z)
Line 
14 patches for repository /home/zooko/playground/tahoe-lafs/pristine:
2
3Tue Aug  9 15:59:13 MDT 2011  zooko@zooko.com
4  * drop-upload: unit tests for the configuration options being named "cap" instead of "uri"
5  This is a subset of a patch that David-Sarah attached to #1429. This is just the unit-tests part of that patch, and uses darcs record instead of hunks to change the names.
6  refs #1429
7
8Tue Aug  9 16:01:15 MDT 2011  zooko@zooko.com
9  * drop-upload test for non-existent local dir separately from test for non-directory local dir
10  A candidate patch for #1429 has a bug when it is using FilePath.is_dir() to detect whether the configured local dir exists and is a directory. FilePath.is_dir() raises exception, instead of returning False, if the thing doesn't exist. This test is to make sure that DropUploader.__init__ raise different exceptions for those two cases.
11  refs #1429
12
13Tue Aug  9 16:05:08 MDT 2011  zooko@zooko.com
14  * drop-upload: rename the 'upload.uri' parameter to 'upload.dircap', and a couple of cleanups to error messages. refs #1429
15  I rerecorded this patch, originally by David-Sarah, to use "darcs replace" instead of editing to do the renames. This uncovered one missed rename in Client.init_drop_uploader. (Which also means that code isn't exercised by the current unit tests.)
16  refs #1429
17
18Tue Aug  9 16:09:30 MDT 2011  zooko@zooko.com
19  * drop-upload: report the configured local directory being absent differently from it being a file
20  refs #1429
21
22New patches:
23
24[drop-upload: unit tests for the configuration options being named "cap" instead of "uri"
25zooko@zooko.com**20110809215913
26 Ignore-this: 958c78fffb3d76b3e4817647f824e7f9
27 This is a subset of a patch that David-Sarah attached to #1429. This is just the unit-tests part of that patch, and uses darcs record instead of hunks to change the names.
28 refs #1429
29] {
30hunk ./src/allmydata/test/test_drop_upload.py 175
31 
32             self.shouldFail(AssertionError, 'bad URI', 'not a directory URI',
33                             DropUploader, client, 'bad', errors_dir, inotify=fake_inotify)
34-            self.shouldFail(AssertionError, 'non-directory URI', 'not a directory URI',
35+            self.shouldFail(AssertionError, 'non-directory cap', 'does not refer to a directory',
36                             DropUploader, client, 'URI:LIT:foo', errors_dir, inotify=fake_inotify)
37hunk ./src/allmydata/test/test_drop_upload.py 177
38-            self.shouldFail(AssertionError, 'readonly directory URI', 'does not refer to a writeable directory',
39+            self.shouldFail(AssertionError, 'readonly dircap', 'is not a writecap to a directory',
40                             DropUploader, client, readonly_uri, errors_dir, inotify=fake_inotify)
41         d.addCallback(_made_upload_dir)
42         return d
43replace ./src/allmydata/test/test_drop_upload.py [A-Za-z_0-9] readonly_uri readonly_dircap
44replace ./src/allmydata/test/test_drop_upload.py [A-Za-z_0-9] upload_uri upload_dircap
45}
46[drop-upload test for non-existent local dir separately from test for non-directory local dir
47zooko@zooko.com**20110809220115
48 Ignore-this: cd85f345c02f5cb71b1c1527bd4ebddc
49 A candidate patch for #1429 has a bug when it is using FilePath.is_dir() to detect whether the configured local dir exists and is a directory. FilePath.is_dir() raises exception, instead of returning False, if the thing doesn't exist. This test is to make sure that DropUploader.__init__ raise different exceptions for those two cases.
50 refs #1429
51] {
52hunk ./src/allmydata/test/test_drop_upload.py 170
53 
54             self.shouldFail(AssertionError, 'invalid local dir', 'could not be represented',
55                             DropUploader, client, upload_dircap, '\xFF', inotify=fake_inotify)
56-            self.shouldFail(AssertionError, 'non-existant local dir', 'not an existing directory',
57+            self.shouldFail(AssertionError, 'non-existant local dir', 'there is no directory',
58                             DropUploader, client, upload_dircap, os.path.join(self.basedir, "Laputa"), inotify=fake_inotify)
59 
60hunk ./src/allmydata/test/test_drop_upload.py 173
61-            self.shouldFail(AssertionError, 'bad URI', 'not a directory URI',
62+            fp = filepath.FilePath(self.basedir).child('IM_NOT_A_DIR')
63+            fp.touch()
64+            self.shouldFail(AssertionError, 'non-existant local dir', 'is not a directory',
65+                            DropUploader, client, upload_dircap, fp.path, inotify=fake_inotify)
66+
67+            self.shouldFail(AssertionError, 'bad cap', 'does not refer to a directory',
68                             DropUploader, client, 'bad', errors_dir, inotify=fake_inotify)
69             self.shouldFail(AssertionError, 'non-directory cap', 'does not refer to a directory',
70                             DropUploader, client, 'URI:LIT:foo', errors_dir, inotify=fake_inotify)
71}
72[drop-upload: rename the 'upload.uri' parameter to 'upload.dircap', and a couple of cleanups to error messages. refs #1429
73zooko@zooko.com**20110809220508
74 Ignore-this: 4846368cbe331e8653bdce1f314e276b
75 I rerecorded this patch, originally by David-Sarah, to use "darcs replace" instead of editing to do the renames. This uncovered one missed rename in Client.init_drop_uploader. (Which also means that code isn't exercised by the current unit tests.)
76 refs #1429
77] {
78hunk ./docs/frontends/drop-upload.rst 46
79 ``enabled = (boolean, optional)``
80 
81     If this is ``True``, drop-upload will be enabled (provided that the
82-    ``upload.uri`` and ``local.directory`` fields are also set). The default
83-    value is ``False``.
84+    ``upload.uri`` and ``local.directory`` fields are also set). The
85+    default value is ``False``.
86 
87hunk ./docs/frontends/drop-upload.rst 49
88-``upload.uri = (URI)``
89+``upload.uri = (directory writecap)``
90 
91hunk ./docs/frontends/drop-upload.rst 51
92-    This is the Tahoe URI of an existing mutable directory to be used as
93-    the target of uploads. It must be the full URI of the directory
94-    (starting with ``URI:DIR2:``), and cannot include an alias or path.
95+    This is a writecap pointing to an existing mutable directory to be used
96+    as the target of uploads. It will start with ``URI:DIR2:``, and cannot
97+    include an alias or path.
98 
99 ``local.directory = (UTF-8 path)``
100 
101replace ./docs/frontends/drop-upload.rst [A-Za-z_0-9\-\.] upload.uri upload.dircap
102replace ./src/allmydata/client.py [A-Za-z_0-9] upload_uri upload_dircap
103replace ./src/allmydata/client.py [A-Za-z_0-9\-\.] upload.uri upload.dircap
104hunk ./src/allmydata/frontends/drop_upload.py 26
105             else:
106                 local_dir = local_dir_u.encode(get_filesystem_encoding())
107         except (UnicodeEncodeError, UnicodeDecodeError):
108-            raise AssertionError("The drop-upload path %s was not valid UTF-8 or could not be represented in the filesystem encoding."
109+            raise AssertionError("The '[drop_upload] local.directory' parameter %s was not valid UTF-8 or "
110+                                 "could not be represented in the filesystem encoding."
111                                  % quote_output(local_dir_utf8))
112 
113         self._client = client
114hunk ./src/allmydata/frontends/drop_upload.py 42
115         if not self._local_path.isdir():
116             raise AssertionError("The drop-upload local path %r was not an existing directory." % quote_output(local_dir_u))
117 
118-        # TODO: allow a path rather than an URI.
119+        # TODO: allow a path rather than a cap URI.
120         self._parent = self._client.create_node_from_uri(upload_uri)
121         if not IDirectoryNode.providedBy(self._parent):
122hunk ./src/allmydata/frontends/drop_upload.py 45
123-            raise AssertionError("The drop-upload remote URI is not a directory URI.")
124+            raise AssertionError("The '[drop_upload] upload.dircap' parameter does not refer to a directory.")
125         if self._parent.is_unknown() or self._parent.is_readonly():
126hunk ./src/allmydata/frontends/drop_upload.py 47
127-            raise AssertionError("The drop-upload remote URI does not refer to a writeable directory.")
128+            raise AssertionError("The '[drop_upload] upload.dircap' parameter is not a writecap to a directory.")
129 
130         self._uploaded_callback = lambda ign: None
131 
132replace ./src/allmydata/frontends/drop_upload.py [A-Za-z_0-9] upload_uri upload_dircap
133hunk ./src/allmydata/scripts/create_node.py 158
134     c.write("[drop_upload]\n")
135     c.write("# Shall this node automatically upload files created or modified in a local directory?\n")
136     c.write("enabled = false\n")
137-    c.write("# This must be an URI for a writeable directory.\n")
138+    c.write("# This must be a mutable directory writecap.\n")
139     c.write("upload.uri =\n")
140     c.write("local.directory = ~/drop_upload\n")
141     c.write("\n")
142replace ./src/allmydata/scripts/create_node.py [A-Za-z_0-9\-\.] upload.uri upload.dircap
143}
144[drop-upload: report the configured local directory being absent differently from it being a file
145zooko@zooko.com**20110809220930
146 Ignore-this: a08879100f5f20e609be3f0ffa3b25cc
147 refs #1429
148] {
149hunk ./src/allmydata/frontends/drop_upload.py 39
150             from twisted.internet import inotify
151         self._inotify = inotify
152 
153+        if not self._local_path.exists():
154+            raise AssertionError("The '[drop_upload] local.directory' parameter was %s but there is no directory at that location." % quote_output(local_dir_u))
155         if not self._local_path.isdir():
156hunk ./src/allmydata/frontends/drop_upload.py 42
157-            raise AssertionError("The drop-upload local path %r was not an existing directory." % quote_output(local_dir_u))
158+            raise AssertionError("The '[drop_upload] local.directory' parameter was %s but the thing at that location is not a directory." % quote_output(local_dir_u))
159 
160         # TODO: allow a path rather than a cap URI.
161         self._parent = self._client.create_node_from_uri(upload_dircap)
162}
163
164Context:
165
166[Work around ref #1472 by having test_drop_upload delete the non-ASCII directories it creates.
167david-sarah@jacaranda.org**20110809012334
168 Ignore-this: 5881fd5db419ba8ad12e0b2a82f6c4f0
169]
170[Remove all trailing whitespace from .py files.
171david-sarah@jacaranda.org**20110809001117
172 Ignore-this: d2658b5ce44af70cc606ae4d3085b7cc
173]
174[test_drop_upload.py: fix unused imports. refs #1429
175david-sarah@jacaranda.org**20110808235422
176 Ignore-this: 834f6b946bfea699d7d8c743edd66671
177]
178[Documentation for drop-upload frontend. refs #1429
179david-sarah@jacaranda.org**20110808182146
180 Ignore-this: b33110834e586c0b784d1736c2af5779
181]
182[Drop-upload frontend, rerecorded for 1.9 beta (and correcting a minor mistake). Includes some fixes for Windows but not the Windows inotify implementation. fixes #1429
183david-sarah@jacaranda.org**20110808234049
184 Ignore-this: 67f824c7f554e9a3a85f9fd2e1123d97
185]
186[node.py: ensure that client and introducer nodes record their port number and use that port on the next restart, fixing a regression caused by #1385. fixes #1469.
187david-sarah@jacaranda.org**20110806221934
188 Ignore-this: 1aa9d340b6570320ab2f9edc89c9e0a8
189]
190[test_runner.py: fix a race condition in the test when NODE_URL_FILE is written before PORTNUM_FILE. refs #1469
191david-sarah@jacaranda.org**20110806231842
192 Ignore-this: ab01ae7cec3a073e29eec473e64052a0
193]
194[test_runner.py: cleanups of HOTLINE_FILE writing and removal.
195david-sarah@jacaranda.org**20110806231652
196 Ignore-this: 25f5c5d6f5d8faebb26a4ce80110a335
197]
198[test_runner.py: remove an unused constant.
199david-sarah@jacaranda.org**20110806221416
200 Ignore-this: eade2695cbabbea9cafeaa8debe410bb
201]
202[node.py: fix the error path for a missing config option so that it works for a Unicode base directory.
203david-sarah@jacaranda.org**20110806221007
204 Ignore-this: 4eb9cc04b2ce05182a274a0d69dafaf3
205]
206[test_runner.py: test that client and introducer nodes record their port number and use that port on the next restart. This tests for a regression caused by ref #1385.
207david-sarah@jacaranda.org**20110806220635
208 Ignore-this: 40a0c040b142dbddd47e69b3c3712f5
209]
210[test_runner.py: fix a bug in CreateNode.do_create introduced in changeset [5114] when the tahoe.cfg file has been written with CRLF line endings. refs #1385
211david-sarah@jacaranda.org**20110804003032
212 Ignore-this: 7b7afdcf99da6671afac2d42828883eb
213]
214[test_client.py: repair Basic.test_error_on_old_config_files. refs #1385
215david-sarah@jacaranda.org**20110803235036
216 Ignore-this: 31e2a9c3febe55948de7e144353663e
217]
218[test_checker.py: increase timeout for TooParallel.test_immutable again. The ARM buildslave took 38 seconds, so 40 seconds is too close to the edge; make it 80.
219david-sarah@jacaranda.org**20110803214042
220 Ignore-this: 2d8026a6b25534e01738f78d6c7495cb
221]
222[test_runner.py: fix RunNode.test_introducer to not rely on the mtime of introducer.furl to detect when the node has restarted. Instead we detect when node.url has been written. refs #1385
223david-sarah@jacaranda.org**20110803180917
224 Ignore-this: 11ddc43b107beca42cb78af88c5c394c
225]
226[Further improve error message about old config files. refs #1385
227david-sarah@jacaranda.org**20110803174546
228 Ignore-this: 9d6cc3c288d9863dce58faafb3855917
229]
230[Slightly improve error message about old config files (avoid unnecessary Unicode escaping). refs #1385
231david-sarah@jacaranda.org**20110803163848
232 Ignore-this: a3e3930fba7ccf90b8db3d2ed5829df4
233]
234[test_checker.py: increase timeout for TooParallel.test_immutable (was consistently failing on ARM buildslave).
235david-sarah@jacaranda.org**20110803163213
236 Ignore-this: d0efceaf12628e8791862b80c85b5d56
237]
238[Fix the bug that prevents an introducer from starting when introducer.furl already exists. Also remove some dead code that used to read old config files, and rename 'warn_about_old_config_files' to reflect that it's not a warning. refs #1385
239david-sarah@jacaranda.org**20110803013212
240 Ignore-this: 2d6cd14bd06a7493b26f2027aff78f4d
241]
242[test_runner.py: modify RunNode.test_introducer to test that starting an introducer works when the introducer.furl file already exists. refs #1385
243david-sarah@jacaranda.org**20110803012704
244 Ignore-this: 8cf7f27ac4bfbb5ad8ca4a974106d437
245]
246[verifier: correct a bug introduced in changeset [5106] that caused us to only verify the first block of a file. refs #1395
247david-sarah@jacaranda.org**20110802172437
248 Ignore-this: 87fb77854a839ff217dce73544775b11
249]
250[test_repairer: add a deterministic test of share data corruption that always flips the bits of the last byte of the share data. refs #1395
251david-sarah@jacaranda.org**20110802175841
252 Ignore-this: 72f54603785007e88220c8d979e08be7
253]
254[verifier: serialize the fetching of blocks within a share so that we don't use too much RAM
255zooko@zooko.com**20110802063703
256 Ignore-this: debd9bac07dcbb6803f835a9e2eabaa1
257 
258 Shares are still verified in parallel, but within a share, don't request a
259 block until the previous block has been verified and the memory we used to hold
260 it has been freed up.
261 
262 Patch originally due to Brian. This version has a mockery-patchery-style test
263 which is "low tech" (it implements the patching inline in the test code instead
264 of using an extension of the mock.patch() function from the mock library) and
265 which unpatches in case of exception.
266 
267 fixes #1395
268]
269[add docs about timing-channel attacks
270Brian Warner <warner@lothar.com>**20110802044541
271 Ignore-this: 73114d5f5ed9ce252597b707dba3a194
272]
273['test-coverage' now needs PYTHONPATH=. to find TOP/twisted/plugins/
274Brian Warner <warner@lothar.com>**20110802041952
275 Ignore-this: d40f1f4cb426ea1c362fc961baedde2
276]
277[reject old-style (pre-Tahoe-LAFS-v1.3) configuration files
278zooko@zooko.com**20110801232423
279 Ignore-this: b58218fcc064cc75ad8f05ed0c38902b
280 Check for the existence of any of them and if any are found raise exception which will abort the startup of the node.
281 This is a backwards-incompatible change for anyone who is still using old-style configuration files.
282 fixes #1385
283]
284[whitespace-cleanup
285zooko@zooko.com**20110725015546
286 Ignore-this: 442970d0545183b97adc7bd66657876c
287]
288[tests: use fileutil.write() instead of open() to ensure timely close even without CPython-style reference counting
289zooko@zooko.com**20110331145427
290 Ignore-this: 75aae4ab8e5fa0ad698f998aaa1888ce
291 Some of these already had an explicit close() but I went ahead and replaced them with fileutil.write() as well for the sake of uniformity.
292]
293[remove nodeid from WriteBucketProxy classes and customers
294warner@lothar.com**20110801224317
295 Ignore-this: e55334bb0095de11711eeb3af827e8e8
296 refs #1363
297]
298[remove get_serverid() from ReadBucketProxy and customers, including Checker
299warner@lothar.com**20110801224307
300 Ignore-this: 837aba457bc853e4fd413ab1a94519cb
301 and debug.py dump-share commands
302 refs #1363
303]
304[Address Kevan's comment in #776 about Options classes missed when adding 'self.command_name'. refs #776, #1359
305david-sarah@jacaranda.org**20110801221317
306 Ignore-this: 8881d42cf7e6a1d15468291b0cb8fab9
307]
308[docs/frontends/webapi.rst: change some more instances of 'delete' or 'remove' to 'unlink', change some section titles, and use two blank lines between all sections. refs #776, #1104
309david-sarah@jacaranda.org**20110801220919
310 Ignore-this: 572327591137bb05c24c44812d4b163f
311]
312[cleanup: implement rm as a synonym for unlink rather than vice-versa. refs #776
313david-sarah@jacaranda.org**20110801220108
314 Ignore-this: 598dcbed870f4f6bb9df62de9111b343
315]
316[docs/webapi.rst: address Kevan's comments about use of 'delete' on ref #1104
317david-sarah@jacaranda.org**20110801205356
318 Ignore-this: 4fbf03864934753c951ddeff64392491
319]
320[docs: some changes of 'delete' or 'rm' to 'unlink'. refs #1104
321david-sarah@jacaranda.org**20110713002722
322 Ignore-this: 304d2a330d5e6e77d5f1feed7814b21c
323]
324[WUI: change the label of the button to unlink a file from 'del' to 'unlink'. Also change some internal names to 'unlink', and allow 't=unlink' as a synonym for 't=delete' in the web-API interface. Incidentally, improve a test to check for the rename button as well as the unlink button. fixes #1104
325david-sarah@jacaranda.org**20110713001218
326 Ignore-this: 3eef6b3f81b94a9c0020a38eb20aa069
327]
328[src/allmydata/web/filenode.py: delete a stale comment that was made incorrect by changeset [3133].
329david-sarah@jacaranda.org**20110801203009
330 Ignore-this: b3912e95a874647027efdc97822dd10e
331]
332[fix typo introduced during rebasing of 'remove get_serverid from
333Brian Warner <warner@lothar.com>**20110801200341
334 Ignore-this: 4235b0f585c0533892193941dbbd89a8
335 DownloadStatus.add_dyhb_request and customers' patch, to fix test failure.
336]
337[remove get_serverid from DownloadStatus.add_dyhb_request and customers
338zooko@zooko.com**20110801185401
339 Ignore-this: db188c18566d2d0ab39a80c9dc8f6be6
340 This patch is a rebase of a patch originally written by Brian. I didn't change any of the intent of Brian's patch, just ported it to current trunk.
341 refs #1363
342]
343[remove get_serverid from DownloadStatus.add_block_request and customers
344zooko@zooko.com**20110801185344
345 Ignore-this: 8bfa8201d6147f69b0fbe31beea9c1e
346 This is a rebase of a patch Brian originally wrote. I haven't changed the intent of that patch, just ported it to trunk.
347 refs #1363
348]
349[apply zooko's advice: storage_client get_known_servers() returns a frozenset, caller sorts
350warner@lothar.com**20110801174452
351 Ignore-this: 2aa13ea6cbed4e9084bd604bf8633692
352 refs #1363
353]
354[test_immutable.Test: rewrite to use NoNetworkGrid, now takes 2.7s not 97s
355warner@lothar.com**20110801174444
356 Ignore-this: 54f30b5d7461d2b3514e2a0172f3a98c
357 remove now-unused ShareManglingMixin
358 refs #1363
359]
360[DownloadStatus.add_known_share wants to be used by Finder, web.status
361warner@lothar.com**20110801174436
362 Ignore-this: 1433bcd73099a579abe449f697f35f9
363 refs #1363
364]
365[replace IServer.name() with get_name(), and get_longname()
366warner@lothar.com**20110801174428
367 Ignore-this: e5a6f7f6687fd7732ddf41cfdd7c491b
368 
369 This patch was originally written by Brian, but was re-recorded by Zooko to use
370 darcs replace instead of hunks for any file in which it would result in fewer
371 total hunks.
372 refs #1363
373]
374[upload.py: apply David-Sarah's advice rename (un)contacted(2) trackers to first_pass/second_pass/next_pass
375zooko@zooko.com**20110801174143
376 Ignore-this: e36e1420bba0620a0107bd90032a5198
377 This patch was written by Brian but was re-recorded by Zooko (with David-Sarah looking on) to use darcs replace instead of editing to rename the three variables to their new names.
378 refs #1363
379]
380[Coalesce multiple Share.loop() calls, make downloads faster. Closes #1268.
381Brian Warner <warner@lothar.com>**20110801151834
382 Ignore-this: 48530fce36c01c0ff708f61c2de7e67a
383]
384[src/allmydata/_auto_deps.py: 'i686' is another way of spelling x86.
385david-sarah@jacaranda.org**20110801034035
386 Ignore-this: 6971e0621db2fba794d86395b4d51038
387]
388[tahoe_rm.py: better error message when there is no path. refs #1292
389david-sarah@jacaranda.org**20110122064212
390 Ignore-this: ff3bb2c9f376250e5fd77eb009e09018
391]
392[test_cli.py: Test for error message when 'tahoe rm' is invoked without a path. refs #1292
393david-sarah@jacaranda.org**20110104105108
394 Ignore-this: 29ec2f2e0251e446db96db002ad5dd7d
395]
396[src/allmydata/__init__.py: suppress a spurious warning from 'bin/tahoe --version[-and-path]' about twisted-web and twisted-core packages.
397david-sarah@jacaranda.org**20110801005209
398 Ignore-this: 50e7cd53cca57b1870d9df0361c7c709
399]
400[test_cli.py: use to_str on fields loaded using simplejson.loads in new tests. refs #1304
401david-sarah@jacaranda.org**20110730032521
402 Ignore-this: d1d6dfaefd1b4e733181bf127c79c00b
403]
404[cli: make 'tahoe cp' overwrite mutable files in-place
405Kevan Carstensen <kevan@isnotajoke.com>**20110729202039
406 Ignore-this: b2ad21a19439722f05c49bfd35b01855
407]
408[SFTP: write an error message to standard error for unrecognized shell commands. Change the existing message for shell sessions to be written to standard error, and refactor some duplicated code. Also change the lines of the error messages to end in CRLF, and take into account Kevan's review comments. fixes #1442, #1446
409david-sarah@jacaranda.org**20110729233102
410 Ignore-this: d2f2bb4664f25007d1602bf7333e2cdd
411]
412[src/allmydata/scripts/cli.py: fix pyflakes warning.
413david-sarah@jacaranda.org**20110728021402
414 Ignore-this: 94050140ddb99865295973f49927c509
415]
416[Fix the help synopses of CLI commands to include [options] in the right place. fixes #1359, fixes #636
417david-sarah@jacaranda.org**20110724225440
418 Ignore-this: 2a8e488a5f63dabfa9db9efd83768a5
419]
420[encodingutil: argv and output encodings are always the same on all platforms. Lose the unnecessary generality of them being different. fixes #1120
421david-sarah@jacaranda.org**20110629185356
422 Ignore-this: 5ebacbe6903dfa83ffd3ff8436a97787
423]
424[docs/man/tahoe.1: add man page. fixes #1420
425david-sarah@jacaranda.org**20110724171728
426 Ignore-this: fc7601ec7f25494288d6141d0ae0004c
427]
428[Update the dependency on zope.interface to fix an incompatiblity between Nevow and zope.interface 3.6.4. fixes #1435
429david-sarah@jacaranda.org**20110721234941
430 Ignore-this: 2ff3fcfc030fca1a4d4c7f1fed0f2aa9
431]
432[frontends/ftpd.py: remove the check for IWriteFile.close since we're now guaranteed to be using Twisted >= 10.1 which has it.
433david-sarah@jacaranda.org**20110722000320
434 Ignore-this: 55cd558b791526113db3f83c00ec328a
435]
436[Update the dependency on Twisted to >= 10.1. This allows us to simplify some documentation: it's no longer necessary to install pywin32 on Windows, or apply a patch to Twisted in order to use the FTP frontend. fixes #1274, #1438. refs #1429
437david-sarah@jacaranda.org**20110721233658
438 Ignore-this: 81b41745477163c9b39c0b59db91cc62
439]
440[misc/build_helpers/run_trial.py: undo change to block pywin32 (it didn't work because run_trial.py is no longer used). refs #1334
441david-sarah@jacaranda.org**20110722035402
442 Ignore-this: 5d03f544c4154f088e26c7107494bf39
443]
444[misc/build_helpers/run_trial.py: ensure that pywin32 is not on the sys.path when running the test suite. Includes some temporary debugging printouts that will be removed. refs #1334
445david-sarah@jacaranda.org**20110722024907
446 Ignore-this: 5141a9f83a4085ed4ca21f0bbb20bb9c
447]
448[docs/running.rst: use 'tahoe run ~/.tahoe' instead of 'tahoe run' (the default is the current directory, unlike 'tahoe start').
449david-sarah@jacaranda.org**20110718005949
450 Ignore-this: 81837fbce073e93d88a3e7ae3122458c
451]
452[docs/running.rst: say to put the introducer.furl in tahoe.cfg.
453david-sarah@jacaranda.org**20110717194315
454 Ignore-this: 954cc4c08e413e8c62685d58ff3e11f3
455]
456[README.txt: say that quickstart.rst is in the docs directory.
457david-sarah@jacaranda.org**20110717192400
458 Ignore-this: bc6d35a85c496b77dbef7570677ea42a
459]
460[setup: remove the dependency on foolscap's "secure_connections" extra, add a dependency on pyOpenSSL
461zooko@zooko.com**20110717114226
462 Ignore-this: df222120d41447ce4102616921626c82
463 fixes #1383
464]
465[test_sftp.py cleanup: remove a redundant definition of failUnlessReallyEqual.
466david-sarah@jacaranda.org**20110716181813
467 Ignore-this: 50113380b368c573f07ac6fe2eb1e97f
468]
469[docs: add missing link in NEWS.rst
470zooko@zooko.com**20110712153307
471 Ignore-this: be7b7eb81c03700b739daa1027d72b35
472]
473[contrib: remove the contributed fuse modules and the entire contrib/ directory, which is now empty
474zooko@zooko.com**20110712153229
475 Ignore-this: 723c4f9e2211027c79d711715d972c5
476 Also remove a couple of vestigial references to figleaf, which is long gone.
477 fixes #1409 (remove contrib/fuse)
478]
479[add Protovis.js-based download-status timeline visualization
480Brian Warner <warner@lothar.com>**20110629222606
481 Ignore-this: 477ccef5c51b30e246f5b6e04ab4a127
482 
483 provide status overlap info on the webapi t=json output, add decode/decrypt
484 rate tooltips, add zoomin/zoomout buttons
485]
486[add more download-status data, fix tests
487Brian Warner <warner@lothar.com>**20110629222555
488 Ignore-this: e9e0b7e0163f1e95858aa646b9b17b8c
489]
490[prepare for viz: improve DownloadStatus events
491Brian Warner <warner@lothar.com>**20110629222542
492 Ignore-this: 16d0bde6b734bb501aa6f1174b2b57be
493 
494 consolidate IDownloadStatusHandlingConsumer stuff into DownloadNode
495]
496[docs: fix error in crypto specification that was noticed by Taylor R Campbell <campbell+tahoe@mumble.net>
497zooko@zooko.com**20110629185711
498 Ignore-this: b921ed60c1c8ba3c390737fbcbe47a67
499]
500[setup.py: don't make bin/tahoe.pyscript executable. fixes #1347
501david-sarah@jacaranda.org**20110130235809
502 Ignore-this: 3454c8b5d9c2c77ace03de3ef2d9398a
503]
504[Makefile: remove targets relating to 'setup.py check_auto_deps' which no longer exists. fixes #1345
505david-sarah@jacaranda.org**20110626054124
506 Ignore-this: abb864427a1b91bd10d5132b4589fd90
507]
508[Makefile: add 'make check' as an alias for 'make test'. Also remove an unnecessary dependency of 'test' on 'build' and 'src/allmydata/_version.py'. fixes #1344
509david-sarah@jacaranda.org**20110623205528
510 Ignore-this: c63e23146c39195de52fb17c7c49b2da
511]
512[Rename test_package_initialization.py to (much shorter) test_import.py .
513Brian Warner <warner@lothar.com>**20110611190234
514 Ignore-this: 3eb3dbac73600eeff5cfa6b65d65822
515 
516 The former name was making my 'ls' listings hard to read, by forcing them
517 down to just two columns.
518]
519[tests: fix tests to accomodate [20110611153758-92b7f-0ba5e4726fb6318dac28fb762a6512a003f4c430]
520zooko@zooko.com**20110611163741
521 Ignore-this: 64073a5f39e7937e8e5e1314c1a302d1
522 Apparently none of the two authors (stercor, terrell), three reviewers (warner, davidsarah, terrell), or one committer (me) actually ran the tests. This is presumably due to #20.
523 fixes #1412
524]
525[wui: right-align the size column in the WUI
526zooko@zooko.com**20110611153758
527 Ignore-this: 492bdaf4373c96f59f90581c7daf7cd7
528 Thanks to Ted "stercor" Rolle Jr. and Terrell Russell.
529 fixes #1412
530]
531[docs: three minor fixes
532zooko@zooko.com**20110610121656
533 Ignore-this: fec96579eb95aceb2ad5fc01a814c8a2
534 CREDITS for arc for stats tweak
535 fix link to .zip file in quickstart.rst (thanks to ChosenOne for noticing)
536 English usage tweak
537]
538[docs/running.rst: fix stray HTML (not .rst) link noticed by ChosenOne.
539david-sarah@jacaranda.org**20110609223719
540 Ignore-this: fc50ac9c94792dcac6f1067df8ac0d4a
541]
542[server.py:  get_latencies now reports percentiles _only_ if there are sufficient observations for the interpretation of the percentile to be unambiguous.
543wilcoxjg@gmail.com**20110527120135
544 Ignore-this: 2e7029764bffc60e26f471d7c2b6611e
545 interfaces.py:  modified the return type of RIStatsProvider.get_stats to allow for None as a return value
546 NEWS.rst, stats.py: documentation of change to get_latencies
547 stats.rst: now documents percentile modification in get_latencies
548 test_storage.py:  test_latencies now expects None in output categories that contain too few samples for the associated percentile to be unambiguously reported.
549 fixes #1392
550]
551[corrected "k must never be smaller than N" to "k must never be greater than N"
552secorp@allmydata.org**20110425010308
553 Ignore-this: 233129505d6c70860087f22541805eac
554]
555[docs: revert link in relnotes.txt from NEWS.rst to NEWS, since the former did not exist at revision 5000.
556david-sarah@jacaranda.org**20110517011214
557 Ignore-this: 6a5be6e70241e3ec0575641f64343df7
558]
559[docs: convert NEWS to NEWS.rst and change all references to it.
560david-sarah@jacaranda.org**20110517010255
561 Ignore-this: a820b93ea10577c77e9c8206dbfe770d
562]
563[docs: remove out-of-date docs/testgrid/introducer.furl and containing directory. fixes #1404
564david-sarah@jacaranda.org**20110512140559
565 Ignore-this: 784548fc5367fac5450df1c46890876d
566]
567[scripts/common.py: don't assume that the default alias is always 'tahoe' (it is, but the API of get_alias doesn't say so). refs #1342
568david-sarah@jacaranda.org**20110130164923
569 Ignore-this: a271e77ce81d84bb4c43645b891d92eb
570]
571[setup: don't catch all Exception from check_requirement(), but only PackagingError and ImportError
572zooko@zooko.com**20110128142006
573 Ignore-this: 57d4bc9298b711e4bc9dc832c75295de
574 I noticed this because I had accidentally inserted a bug which caused AssertionError to be raised from check_requirement().
575]
576[M-x whitespace-cleanup
577zooko@zooko.com**20110510193653
578 Ignore-this: dea02f831298c0f65ad096960e7df5c7
579]
580[docs: fix typo in running.rst, thanks to arch_o_median
581zooko@zooko.com**20110510193633
582 Ignore-this: ca06de166a46abbc61140513918e79e8
583]
584[relnotes.txt: don't claim to work on Cygwin (which has been untested for some time). refs #1342
585david-sarah@jacaranda.org**20110204204902
586 Ignore-this: 85ef118a48453d93fa4cddc32d65b25b
587]
588[relnotes.txt: forseeable -> foreseeable. refs #1342
589david-sarah@jacaranda.org**20110204204116
590 Ignore-this: 746debc4d82f4031ebf75ab4031b3a9
591]
592[replace remaining .html docs with .rst docs
593zooko@zooko.com**20110510191650
594 Ignore-this: d557d960a986d4ac8216d1677d236399
595 Remove install.html (long since deprecated).
596 Also replace some obsolete references to install.html with references to quickstart.rst.
597 Fix some broken internal references within docs/historical/historical_known_issues.txt.
598 Thanks to Ravi Pinjala and Patrick McDonald.
599 refs #1227
600]
601[docs: FTP-and-SFTP.rst: fix a minor error and update the information about which version of Twisted fixes #1297
602zooko@zooko.com**20110428055232
603 Ignore-this: b63cfb4ebdbe32fb3b5f885255db4d39
604]
605[munin tahoe_files plugin: fix incorrect file count
606francois@ctrlaltdel.ch**20110428055312
607 Ignore-this: 334ba49a0bbd93b4a7b06a25697aba34
608 fixes #1391
609]
610[Fix a test failure in test_package_initialization on Python 2.4.x due to exceptions being stringified differently than in later versions of Python. refs #1389
611david-sarah@jacaranda.org**20110411190738
612 Ignore-this: 7847d26bc117c328c679f08a7baee519
613]
614[tests: add test for including the ImportError message and traceback entry in the summary of errors from importing dependencies. refs #1389
615david-sarah@jacaranda.org**20110410155844
616 Ignore-this: fbecdbeb0d06a0f875fe8d4030aabafa
617]
618[allmydata/__init__.py: preserve the message and last traceback entry (file, line number, function, and source line) of ImportErrors in the package versions string. fixes #1389
619david-sarah@jacaranda.org**20110410155705
620 Ignore-this: 2f87b8b327906cf8bfca9440a0904900
621]
622[remove unused variable detected by pyflakes
623zooko@zooko.com**20110407172231
624 Ignore-this: 7344652d5e0720af822070d91f03daf9
625]
626[allmydata/__init__.py: Nicer reporting of unparseable version numbers in dependencies. fixes #1388
627david-sarah@jacaranda.org**20110401202750
628 Ignore-this: 9c6bd599259d2405e1caadbb3e0d8c7f
629]
630[update FTP-and-SFTP.rst: the necessary patch is included in Twisted-10.1
631Brian Warner <warner@lothar.com>**20110325232511
632 Ignore-this: d5307faa6900f143193bfbe14e0f01a
633]
634[control.py: remove all uses of s.get_serverid()
635warner@lothar.com**20110227011203
636 Ignore-this: f80a787953bd7fa3d40e828bde00e855
637]
638[web: remove some uses of s.get_serverid(), not all
639warner@lothar.com**20110227011159
640 Ignore-this: a9347d9cf6436537a47edc6efde9f8be
641]
642[immutable/downloader/fetcher.py: remove all get_serverid() calls
643warner@lothar.com**20110227011156
644 Ignore-this: fb5ef018ade1749348b546ec24f7f09a
645]
646[immutable/downloader/fetcher.py: fix diversity bug in server-response handling
647warner@lothar.com**20110227011153
648 Ignore-this: bcd62232c9159371ae8a16ff63d22c1b
649 
650 When blocks terminate (either COMPLETE or CORRUPT/DEAD/BADSEGNUM), the
651 _shares_from_server dict was being popped incorrectly (using shnum as the
652 index instead of serverid). I'm still thinking through the consequences of
653 this bug. It was probably benign and really hard to detect. I think it would
654 cause us to incorrectly believe that we're pulling too many shares from a
655 server, and thus prefer a different server rather than asking for a second
656 share from the first server. The diversity code is intended to spread out the
657 number of shares simultaneously being requested from each server, but with
658 this bug, it might be spreading out the total number of shares requested at
659 all, not just simultaneously. (note that SegmentFetcher is scoped to a single
660 segment, so the effect doesn't last very long).
661]
662[immutable/downloader/share.py: reduce get_serverid(), one left, update ext deps
663warner@lothar.com**20110227011150
664 Ignore-this: d8d56dd8e7b280792b40105e13664554
665 
666 test_download.py: create+check MyShare instances better, make sure they share
667 Server objects, now that finder.py cares
668]
669[immutable/downloader/finder.py: reduce use of get_serverid(), one left
670warner@lothar.com**20110227011146
671 Ignore-this: 5785be173b491ae8a78faf5142892020
672]
673[immutable/offloaded.py: reduce use of get_serverid() a bit more
674warner@lothar.com**20110227011142
675 Ignore-this: b48acc1b2ae1b311da7f3ba4ffba38f
676]
677[immutable/upload.py: reduce use of get_serverid()
678warner@lothar.com**20110227011138
679 Ignore-this: ffdd7ff32bca890782119a6e9f1495f6
680]
681[immutable/checker.py: remove some uses of s.get_serverid(), not all
682warner@lothar.com**20110227011134
683 Ignore-this: e480a37efa9e94e8016d826c492f626e
684]
685[add remaining get_* methods to storage_client.Server, NoNetworkServer, and
686warner@lothar.com**20110227011132
687 Ignore-this: 6078279ddf42b179996a4b53bee8c421
688 MockIServer stubs
689]
690[upload.py: rearrange _make_trackers a bit, no behavior changes
691warner@lothar.com**20110227011128
692 Ignore-this: 296d4819e2af452b107177aef6ebb40f
693]
694[happinessutil.py: finally rename merge_peers to merge_servers
695warner@lothar.com**20110227011124
696 Ignore-this: c8cd381fea1dd888899cb71e4f86de6e
697]
698[test_upload.py: factor out FakeServerTracker
699warner@lothar.com**20110227011120
700 Ignore-this: 6c182cba90e908221099472cc159325b
701]
702[test_upload.py: server-vs-tracker cleanup
703warner@lothar.com**20110227011115
704 Ignore-this: 2915133be1a3ba456e8603885437e03
705]
706[happinessutil.py: server-vs-tracker cleanup
707warner@lothar.com**20110227011111
708 Ignore-this: b856c84033562d7d718cae7cb01085a9
709]
710[upload.py: more tracker-vs-server cleanup
711warner@lothar.com**20110227011107
712 Ignore-this: bb75ed2afef55e47c085b35def2de315
713]
714[upload.py: fix var names to avoid confusion between 'trackers' and 'servers'
715warner@lothar.com**20110227011103
716 Ignore-this: 5d5e3415b7d2732d92f42413c25d205d
717]
718[refactor: s/peer/server/ in immutable/upload, happinessutil.py, test_upload
719warner@lothar.com**20110227011100
720 Ignore-this: 7ea858755cbe5896ac212a925840fe68
721 
722 No behavioral changes, just updating variable/method names and log messages.
723 The effects outside these three files should be minimal: some exception
724 messages changed (to say "server" instead of "peer"), and some internal class
725 names were changed. A few things still use "peer" to minimize external
726 changes, like UploadResults.timings["peer_selection"] and
727 happinessutil.merge_peers, which can be changed later.
728]
729[storage_client.py: clean up test_add_server/test_add_descriptor, remove .test_servers
730warner@lothar.com**20110227011056
731 Ignore-this: efad933e78179d3d5fdcd6d1ef2b19cc
732]
733[test_client.py, upload.py:: remove KiB/MiB/etc constants, and other dead code
734warner@lothar.com**20110227011051
735 Ignore-this: dc83c5794c2afc4f81e592f689c0dc2d
736]
737[test: increase timeout on a network test because Francois's ARM machine hit that timeout
738zooko@zooko.com**20110317165909
739 Ignore-this: 380c345cdcbd196268ca5b65664ac85b
740 I'm skeptical that the test was proceeding correctly but ran out of time. It seems more likely that it had gotten hung. But if we raise the timeout to an even more extravagant number then we can be even more certain that the test was never going to finish.
741]
742[docs/configuration.rst: add a "Frontend Configuration" section
743Brian Warner <warner@lothar.com>**20110222014323
744 Ignore-this: 657018aa501fe4f0efef9851628444ca
745 
746 this points to docs/frontends/*.rst, which were previously underlinked
747]
748[web/filenode.py: avoid calling req.finish() on closed HTTP connections. Closes #1366
749"Brian Warner <warner@lothar.com>"**20110221061544
750 Ignore-this: 799d4de19933f2309b3c0c19a63bb888
751]
752[Add unit tests for cross_check_pkg_resources_versus_import, and a regression test for ref #1355. This requires a little refactoring to make it testable.
753david-sarah@jacaranda.org**20110221015817
754 Ignore-this: 51d181698f8c20d3aca58b057e9c475a
755]
756[allmydata/__init__.py: .name was used in place of the correct .__name__ when printing an exception. Also, robustify string formatting by using %r instead of %s in some places. fixes #1355.
757david-sarah@jacaranda.org**20110221020125
758 Ignore-this: b0744ed58f161bf188e037bad077fc48
759]
760[Refactor StorageFarmBroker handling of servers
761Brian Warner <warner@lothar.com>**20110221015804
762 Ignore-this: 842144ed92f5717699b8f580eab32a51
763 
764 Pass around IServer instance instead of (peerid, rref) tuple. Replace
765 "descriptor" with "server". Other replacements:
766 
767  get_all_servers -> get_connected_servers/get_known_servers
768  get_servers_for_index -> get_servers_for_psi (now returns IServers)
769 
770 This change still needs to be pushed further down: lots of code is now
771 getting the IServer and then distributing (peerid, rref) internally.
772 Instead, it ought to distribute the IServer internally and delay
773 extracting a serverid or rref until the last moment.
774 
775 no_network.py was updated to retain parallelism.
776]
777[TAG allmydata-tahoe-1.8.2
778warner@lothar.com**20110131020101]
779Patch bundle hash:
780524a8a1bf352905886c14f030df93ee1f030dbd8