1 | 1 patch for repository davidsarah@dev.allmydata.org:/home/darcs/tahoe/trunk: |
---|
2 | |
---|
3 | Sun Sep 4 03:01:08 BST 2011 david-sarah@jacaranda.org |
---|
4 | * SFTP: make sure that download failures are not dropped. fixes #1525 |
---|
5 | |
---|
6 | New patches: |
---|
7 | |
---|
8 | [SFTP: make sure that download failures are not dropped. fixes #1525 |
---|
9 | david-sarah@jacaranda.org**20110904020108 |
---|
10 | Ignore-this: 190e1e227fb921a4c883e1a095393e5c |
---|
11 | ] { |
---|
12 | hunk ./src/allmydata/frontends/sftpd.py 25 |
---|
13 | from twisted.internet.interfaces import ITransport |
---|
14 | |
---|
15 | from twisted.internet import defer |
---|
16 | -from twisted.internet.interfaces import IFinishableConsumer |
---|
17 | +from twisted.internet.interfaces import IConsumer |
---|
18 | from foolscap.api import eventually |
---|
19 | from allmydata.util import deferredutil |
---|
20 | |
---|
21 | hunk ./src/allmydata/frontends/sftpd.py 295 |
---|
22 | |
---|
23 | |
---|
24 | class OverwriteableFileConsumer(PrefixingLogMixin): |
---|
25 | - implements(IFinishableConsumer) |
---|
26 | + implements(IConsumer) |
---|
27 | """I act both as a consumer for the download of the original file contents, and as a |
---|
28 | wrapper for a temporary file that records the downloaded data and any overwrites. |
---|
29 | I use a priority queue to keep track of which regions of the file have been overwritten |
---|
30 | hunk ./src/allmydata/frontends/sftpd.py 322 |
---|
31 | self.milestones = [] # empty heap of (offset, d) |
---|
32 | self.overwrites = [] # empty heap of (start, end) |
---|
33 | self.is_closed = False |
---|
34 | - self.done = self.when_reached(download_size) # adds a milestone |
---|
35 | - self.is_done = False |
---|
36 | - def _signal_done(ign): |
---|
37 | - if noisy: self.log("DONE", level=NOISY) |
---|
38 | - self.is_done = True |
---|
39 | - self.done.addCallback(_signal_done) |
---|
40 | + self.done = defer.Deferred() |
---|
41 | + self.done_status = None # Failure -> download failed, not None or Failure -> download succeeded |
---|
42 | self.producer = None |
---|
43 | |
---|
44 | def get_file(self): |
---|
45 | hunk ./src/allmydata/frontends/sftpd.py 346 |
---|
46 | self.download_size = size |
---|
47 | |
---|
48 | if self.downloaded >= self.download_size: |
---|
49 | - self.finish() |
---|
50 | + self.download_succeeded("size changed") |
---|
51 | |
---|
52 | def registerProducer(self, p, streaming): |
---|
53 | if noisy: self.log(".registerProducer(%r, streaming=%r)" % (p, streaming), level=NOISY) |
---|
54 | hunk ./src/allmydata/frontends/sftpd.py 359 |
---|
55 | p.resumeProducing() |
---|
56 | else: |
---|
57 | def _iterate(): |
---|
58 | - if not self.is_done: |
---|
59 | + if self.done_status is None: |
---|
60 | p.resumeProducing() |
---|
61 | eventually(_iterate) |
---|
62 | _iterate() |
---|
63 | hunk ./src/allmydata/frontends/sftpd.py 426 |
---|
64 | return |
---|
65 | if noisy: self.log("MILESTONE %r %r" % (next, d), level=NOISY) |
---|
66 | heapq.heappop(self.milestones) |
---|
67 | - eventually(d.callback, None) |
---|
68 | + eventually(d.callback, "reached") |
---|
69 | |
---|
70 | if milestone >= self.download_size: |
---|
71 | hunk ./src/allmydata/frontends/sftpd.py 429 |
---|
72 | - self.finish() |
---|
73 | + self.download_succeeded("reached download_size") |
---|
74 | |
---|
75 | def overwrite(self, offset, data): |
---|
76 | if noisy: self.log(".overwrite(%r, <data of length %r>)" % (offset, len(data)), level=NOISY) |
---|
77 | hunk ./src/allmydata/frontends/sftpd.py 475 |
---|
78 | if noisy: self.log("truncating read to %r bytes" % (length,), level=NOISY) |
---|
79 | |
---|
80 | needed = min(offset + length, self.download_size) |
---|
81 | - d = self.when_reached(needed) |
---|
82 | - def _reached(ign): |
---|
83 | + # If we fail to reach the needed number of bytes, the read request will fail. |
---|
84 | + d = self.when_reached_or_failed(needed) |
---|
85 | + def _reached_in_read(res): |
---|
86 | # It is not necessarily the case that self.downloaded >= needed, because |
---|
87 | # the file might have been truncated (thus truncating the download) and |
---|
88 | # then extended. |
---|
89 | hunk ./src/allmydata/frontends/sftpd.py 483 |
---|
90 | |
---|
91 | assert self.current_size >= offset + length, (self.current_size, offset, length) |
---|
92 | - if noisy: self.log("self.f = %r" % (self.f,), level=NOISY) |
---|
93 | + if noisy: self.log("_reached_in_read(%r), self.f = %r" % (res, self.f), level=NOISY) |
---|
94 | self.f.seek(offset) |
---|
95 | return self.f.read(length) |
---|
96 | hunk ./src/allmydata/frontends/sftpd.py 486 |
---|
97 | - d.addCallback(_reached) |
---|
98 | + d.addCallback(_reached_in_read) |
---|
99 | return d |
---|
100 | |
---|
101 | hunk ./src/allmydata/frontends/sftpd.py 489 |
---|
102 | - def when_reached(self, index): |
---|
103 | - if noisy: self.log(".when_reached(%r)" % (index,), level=NOISY) |
---|
104 | - if index <= self.downloaded: # already reached |
---|
105 | + def when_reached_or_failed(self, index): |
---|
106 | + if noisy: self.log(".when_reached_or_failed(%r)" % (index,), level=NOISY) |
---|
107 | + def _reached(res): |
---|
108 | + if noisy: self.log("reached %r with result %r" % (index, res), level=NOISY) |
---|
109 | + return res |
---|
110 | + if self.done_status is not None: |
---|
111 | + return defer.execute(_reached, self.done_status) |
---|
112 | + if index <= self.downloaded: # already reached successfully |
---|
113 | if noisy: self.log("already reached %r" % (index,), level=NOISY) |
---|
114 | hunk ./src/allmydata/frontends/sftpd.py 498 |
---|
115 | - return defer.succeed(None) |
---|
116 | + return defer.succeed("already reached") |
---|
117 | d = defer.Deferred() |
---|
118 | hunk ./src/allmydata/frontends/sftpd.py 500 |
---|
119 | - def _reached(ign): |
---|
120 | - if noisy: self.log("reached %r" % (index,), level=NOISY) |
---|
121 | - return ign |
---|
122 | d.addCallback(_reached) |
---|
123 | heapq.heappush(self.milestones, (index, d)) |
---|
124 | return d |
---|
125 | hunk ./src/allmydata/frontends/sftpd.py 507 |
---|
126 | def when_done(self): |
---|
127 | return self.done |
---|
128 | |
---|
129 | - def finish(self): |
---|
130 | - """Called by the producer when it has finished producing, or when we have |
---|
131 | - received enough bytes, or as a result of a close. Defined by IFinishableConsumer.""" |
---|
132 | + def download_succeeded(self, res): |
---|
133 | + self.download_done(eventually_callback, res) |
---|
134 | + |
---|
135 | + def download_failed(self, err): |
---|
136 | + self.download_done(eventually_errback, err) |
---|
137 | + |
---|
138 | + def download_done(self, trigger, res): |
---|
139 | + # Only the first call to download_done counts, but we log subsequent calls |
---|
140 | + # (multiple calls are normal). |
---|
141 | + if self.done_status is not None: |
---|
142 | + self.log("IGNORING extra call to download_done with result %r; previous result was %r" |
---|
143 | + % (res, self.done_status), level=OPERATIONAL) |
---|
144 | + return |
---|
145 | + |
---|
146 | + self.log("DONE with result %r" % (res,), level=OPERATIONAL) |
---|
147 | + if res is None: |
---|
148 | + # Make sure we can distinguish success from not-done-yet. |
---|
149 | + res = "finished" |
---|
150 | + self.done_status = res |
---|
151 | + |
---|
152 | + trigger(self.done)(res) |
---|
153 | |
---|
154 | while len(self.milestones) > 0: |
---|
155 | (next, d) = self.milestones[0] |
---|
156 | hunk ./src/allmydata/frontends/sftpd.py 531 |
---|
157 | - if noisy: self.log("MILESTONE FINISH %r %r" % (next, d), level=NOISY) |
---|
158 | + if noisy: self.log("MILESTONE FINISH %r %r %r" % (next, d, res), level=NOISY) |
---|
159 | heapq.heappop(self.milestones) |
---|
160 | # The callback means that the milestone has been reached if |
---|
161 | # it is ever going to be. Note that the file may have been |
---|
162 | hunk ./src/allmydata/frontends/sftpd.py 536 |
---|
163 | # truncated to before the milestone. |
---|
164 | - eventually(d.callback, None) |
---|
165 | + trigger(d)(res) |
---|
166 | |
---|
167 | def close(self): |
---|
168 | if not self.is_closed: |
---|
169 | hunk ./src/allmydata/frontends/sftpd.py 545 |
---|
170 | self.f.close() |
---|
171 | except Exception, e: |
---|
172 | self.log("suppressed %r from close of temporary file %r" % (e, self.f), level=WEIRD) |
---|
173 | - self.finish() |
---|
174 | + self.download_succeeded("closed") |
---|
175 | + return self.done_status |
---|
176 | |
---|
177 | def unregisterProducer(self): |
---|
178 | pass |
---|
179 | hunk ./src/allmydata/frontends/sftpd.py 687 |
---|
180 | if (self.flags & FXF_TRUNC) or not filenode: |
---|
181 | # We're either truncating or creating the file, so we don't need the old contents. |
---|
182 | self.consumer = OverwriteableFileConsumer(0, tempfile_maker) |
---|
183 | - self.consumer.finish() |
---|
184 | + self.consumer.download_succeeded("download not needed") |
---|
185 | else: |
---|
186 | assert IFileNode.providedBy(filenode), filenode |
---|
187 | |
---|
188 | hunk ./src/allmydata/frontends/sftpd.py 700 |
---|
189 | |
---|
190 | self.consumer = OverwriteableFileConsumer(download_size, tempfile_maker) |
---|
191 | |
---|
192 | - version.read(self.consumer, 0, None) |
---|
193 | + d = version.read(self.consumer, 0, None) |
---|
194 | + d.addCallbacks(self.consumer.download_succeeded, self.consumer.download_failed) |
---|
195 | + # It is correct to drop d here. |
---|
196 | self.async.addCallback(_read) |
---|
197 | |
---|
198 | eventually(self.async.callback, None) |
---|
199 | hunk ./src/allmydata/frontends/sftpd.py 812 |
---|
200 | self.closed = True |
---|
201 | |
---|
202 | if not (self.flags & (FXF_WRITE | FXF_CREAT)): |
---|
203 | + # We never fail a close of a handle opened only for reading, even if the file |
---|
204 | + # failed to download. (We could not do so deterministically, because it would |
---|
205 | + # depend on whether we reached the point of failure before abandoning the |
---|
206 | + # download.) Any reads that depended on file content that could not be downloaded |
---|
207 | + # will have failed. |
---|
208 | def _readonly_close(): |
---|
209 | if self.consumer: |
---|
210 | self.consumer.close() |
---|
211 | hunk ./src/allmydata/frontends/sftpd.py 837 |
---|
212 | def _committed(res): |
---|
213 | if noisy: self.log("_committed(%r)" % (res,), level=NOISY) |
---|
214 | |
---|
215 | - self.consumer.close() |
---|
216 | + status = self.consumer.close() |
---|
217 | |
---|
218 | # We must close_notify before re-firing self.async. |
---|
219 | if self.close_notify: |
---|
220 | hunk ./src/allmydata/frontends/sftpd.py 842 |
---|
221 | self.close_notify(self.userpath, self.parent, self.childname, self) |
---|
222 | + |
---|
223 | + if not isinstance(res, Failure) and isinstance(status, Failure): |
---|
224 | + # Odd, because we don't expect a failure from close() but not from when_done(), but log it and fail anyway. |
---|
225 | + self.log("failure in _committed(%r) from %r.close: %r" % (res, self.consumer, status), level=WEIRD) |
---|
226 | + return status |
---|
227 | return res |
---|
228 | |
---|
229 | def _close(ign): |
---|
230 | } |
---|
231 | |
---|
232 | Context: |
---|
233 | |
---|
234 | [SFTP: add a comment about a subtle interaction between OverwriteableFileConsumer and GeneralSFTPFile, and test the case it is commenting on. |
---|
235 | david-sarah@jacaranda.org**20110903222304 |
---|
236 | Ignore-this: 980c61d4dd0119337f1463a69aeebaf0 |
---|
237 | ] |
---|
238 | [improve the storage/mutable.py asserts even more |
---|
239 | warner@lothar.com**20110901160543 |
---|
240 | Ignore-this: 5b2b13c49bc4034f96e6e3aaaa9a9946 |
---|
241 | ] |
---|
242 | [storage/mutable.py: special characters in struct.foo arguments indicate standard as opposed to native sizes, we should be using these characters in these asserts |
---|
243 | wilcoxjg@gmail.com**20110901084144 |
---|
244 | Ignore-this: 28ace2b2678642e4d7269ddab8c67f30 |
---|
245 | ] |
---|
246 | [test_mutable.Version: consolidate some tests, reduce runtime from 19s to 15s |
---|
247 | warner@lothar.com**20110831050451 |
---|
248 | Ignore-this: 64815284d9e536f8f3798b5f44cf580c |
---|
249 | ] |
---|
250 | [mutable/retrieve: handle the case where self._read_length is 0. |
---|
251 | Kevan Carstensen <kevan@isnotajoke.com>**20110830210141 |
---|
252 | Ignore-this: fceafbe485851ca53f2774e5a4fd8d30 |
---|
253 | |
---|
254 | Note that the downloader will still fetch a segment for a zero-length |
---|
255 | read, which is wasteful. Fixing that isn't specifically required to fix |
---|
256 | #1512, but it should probably be fixed before 1.9. |
---|
257 | ] |
---|
258 | [NEWS: added summary of all changes since 1.8.2. Needs editing. |
---|
259 | Brian Warner <warner@lothar.com>**20110830163205 |
---|
260 | Ignore-this: 273899b37a899fc6919b74572454b8b2 |
---|
261 | ] |
---|
262 | [test_mutable.Update: only upload the files needed for each test. refs #1500 |
---|
263 | Brian Warner <warner@lothar.com>**20110829072717 |
---|
264 | Ignore-this: 4d2ab4c7523af9054af7ecca9c3d9dc7 |
---|
265 | |
---|
266 | This first step shaves 15% off the runtime: from 139s to 119s on my laptop. |
---|
267 | It also fixes a couple of places where a Deferred was being dropped, which |
---|
268 | would cause two tests to run in parallel and also confuse error reporting. |
---|
269 | ] |
---|
270 | [Let Uploader retain History instead of passing it into upload(). Fixes #1079. |
---|
271 | Brian Warner <warner@lothar.com>**20110829063246 |
---|
272 | Ignore-this: 3902c58ec12bd4b2d876806248e19f17 |
---|
273 | |
---|
274 | This consistently records all immutable uploads in the Recent Uploads And |
---|
275 | Downloads page, regardless of code path. Previously, certain webapi upload |
---|
276 | operations (like PUT /uri/$DIRCAP/newchildname) failed to pass the History |
---|
277 | object and were left out. |
---|
278 | ] |
---|
279 | [Fix mutable publish/retrieve timing status displays. Fixes #1505. |
---|
280 | Brian Warner <warner@lothar.com>**20110828232221 |
---|
281 | Ignore-this: 4080ce065cf481b2180fd711c9772dd6 |
---|
282 | |
---|
283 | publish: |
---|
284 | * encrypt and encode times are cumulative, not just current-segment |
---|
285 | |
---|
286 | retrieve: |
---|
287 | * same for decrypt and decode times |
---|
288 | * update "current status" to include segment number |
---|
289 | * set status to Finished/Failed when download is complete |
---|
290 | * set progress to 1.0 when complete |
---|
291 | |
---|
292 | More improvements to consider: |
---|
293 | * progress is currently 0% or 100%: should calculate how many segments are |
---|
294 | involved (remembering retrieve can be less than the whole file) and set it |
---|
295 | to a fraction |
---|
296 | * "fetch" time is fuzzy: what we want is to know how much of the delay is not |
---|
297 | our own fault, but since we do decode/decrypt work while waiting for more |
---|
298 | shares, it's not straightforward |
---|
299 | ] |
---|
300 | [Teach 'tahoe debug catalog-shares about MDMF. Closes #1507. |
---|
301 | Brian Warner <warner@lothar.com>**20110828080931 |
---|
302 | Ignore-this: 56ef2951db1a648353d7daac6a04c7d1 |
---|
303 | ] |
---|
304 | [debug.py: remove some dead comments |
---|
305 | Brian Warner <warner@lothar.com>**20110828074556 |
---|
306 | Ignore-this: 40e74040dd4d14fd2f4e4baaae506b31 |
---|
307 | ] |
---|
308 | [hush pyflakes |
---|
309 | Brian Warner <warner@lothar.com>**20110828074254 |
---|
310 | Ignore-this: bef9d537a969fa82fe4decc4ba2acb09 |
---|
311 | ] |
---|
312 | [MutableFileNode.set_downloader_hints: never depend upon order of dict.values() |
---|
313 | Brian Warner <warner@lothar.com>**20110828074103 |
---|
314 | Ignore-this: caaf1aa518dbdde4d797b7f335230faa |
---|
315 | |
---|
316 | The old code was calculating the "extension parameters" (a list) from the |
---|
317 | downloader hints (a dictionary) with hints.values(), which is not stable, and |
---|
318 | would result in corrupted filecaps (with the 'k' and 'segsize' hints |
---|
319 | occasionally swapped). The new code always uses [k,segsize]. |
---|
320 | ] |
---|
321 | [layout.py: fix MDMF share layout documentation |
---|
322 | Brian Warner <warner@lothar.com>**20110828073921 |
---|
323 | Ignore-this: 3f13366fed75b5e31b51ae895450a225 |
---|
324 | ] |
---|
325 | [teach 'tahoe debug dump-share' about MDMF and offsets. refs #1507 |
---|
326 | Brian Warner <warner@lothar.com>**20110828073834 |
---|
327 | Ignore-this: 3a9d2ef9c47a72bf1506ba41199a1dea |
---|
328 | ] |
---|
329 | [test_mutable.Version.test_debug: use splitlines() to fix buildslaves |
---|
330 | Brian Warner <warner@lothar.com>**20110828064728 |
---|
331 | Ignore-this: c7f6245426fc80b9d1ae901d5218246a |
---|
332 | |
---|
333 | Any slave running in a directory with spaces in the name was miscounting |
---|
334 | shares, causing the test to fail. |
---|
335 | ] |
---|
336 | [test_mutable.Version: exercise 'tahoe debug find-shares' on MDMF. refs #1507 |
---|
337 | Brian Warner <warner@lothar.com>**20110828005542 |
---|
338 | Ignore-this: cb20bea1c28bfa50a72317d70e109672 |
---|
339 | |
---|
340 | Also changes NoNetworkGrid to put shares in storage/shares/ . |
---|
341 | ] |
---|
342 | [test_mutable.py: oops, missed a .todo |
---|
343 | Brian Warner <warner@lothar.com>**20110828002118 |
---|
344 | Ignore-this: fda09ae86481352b7a627c278d2a3940 |
---|
345 | ] |
---|
346 | [test_mutable: merge davidsarah's patch with my Version refactorings |
---|
347 | warner@lothar.com**20110827235707 |
---|
348 | Ignore-this: b5aaf481c90d99e33827273b5d118fd0 |
---|
349 | ] |
---|
350 | [test_mutable.Version: factor out some expensive uploads, save 25% runtime |
---|
351 | Brian Warner <warner@lothar.com>**20110827232737 |
---|
352 | Ignore-this: ea37383eb85ea0894b254fe4dfb45544 |
---|
353 | ] |
---|
354 | [SDMF: update filenode with correct k/N after Retrieve. Fixes #1510. |
---|
355 | Brian Warner <warner@lothar.com>**20110827225031 |
---|
356 | Ignore-this: b50ae6e1045818c400079f118b4ef48 |
---|
357 | |
---|
358 | Without this, we get a regression when modifying a mutable file that was |
---|
359 | created with more shares (larger N) than our current tahoe.cfg . The |
---|
360 | modification attempt creates new versions of the (0,1,..,newN-1) shares, but |
---|
361 | leaves the old versions of the (newN,..,oldN-1) shares alone (and throws a |
---|
362 | assertion error in SDMFSlotWriteProxy.finish_publishing in the process). |
---|
363 | |
---|
364 | The mixed versions that result (some shares with e.g. N=10, some with N=20, |
---|
365 | such that both versions are recoverable) cause problems for the Publish code, |
---|
366 | even before MDMF landed. Might be related to refs #1390 and refs #1042. |
---|
367 | ] |
---|
368 | [layout.py: annotate assertion to figure out 'tahoe backup' failure |
---|
369 | Brian Warner <warner@lothar.com>**20110827195253 |
---|
370 | Ignore-this: 9b92b954e3ed0d0f80154fff1ff674e5 |
---|
371 | ] |
---|
372 | [Add 'tahoe debug dump-cap' support for MDMF, DIR2-CHK, DIR2-MDMF. refs #1507. |
---|
373 | Brian Warner <warner@lothar.com>**20110827195048 |
---|
374 | Ignore-this: 61c6af5e33fc88e0251e697a50addb2c |
---|
375 | |
---|
376 | This also adds tests for all those cases, and fixes an omission in uri.py |
---|
377 | that broke parsing of DIR2-MDMF-Verifier and DIR2-CHK-Verifier. |
---|
378 | ] |
---|
379 | [MDMF: more writable/writeable consistentifications |
---|
380 | warner@lothar.com**20110827190602 |
---|
381 | Ignore-this: 22492a9e20c1819ddb12091062888b55 |
---|
382 | ] |
---|
383 | [MDMF: s/Writable/Writeable/g, for consistency with existing SDMF code |
---|
384 | warner@lothar.com**20110827183357 |
---|
385 | Ignore-this: 9dd312acedbdb2fc2f7bef0d0fb17c0b |
---|
386 | ] |
---|
387 | [test_mutable.Update: increase timeout from 120s to 400s, slaves are failing |
---|
388 | Brian Warner <warner@lothar.com>**20110825230140 |
---|
389 | Ignore-this: 101b1924a30cdbda9b2e419e95ca15ec |
---|
390 | ] |
---|
391 | [tests: fix check_memory test |
---|
392 | zooko@zooko.com**20110825201116 |
---|
393 | Ignore-this: 4d66299fa8cb61d2ca04b3f45344d835 |
---|
394 | fixes #1503 |
---|
395 | ] |
---|
396 | [docs/write_coordination.rst: fix formatting and add more specific warning about access via sshfs. |
---|
397 | david-sarah@jacaranda.org**20110831232148 |
---|
398 | Ignore-this: cd9c851d3eb4e0a1e088f337c291586c |
---|
399 | ] |
---|
400 | [setup.cfg: remove no-longer-supported test_mac_diskimage alias. refs #1479 |
---|
401 | david-sarah@jacaranda.org**20110826230345 |
---|
402 | Ignore-this: 40e908b8937322a290fb8012bfcad02a |
---|
403 | ] |
---|
404 | [TAG allmydata-tahoe-1.9.0a1 |
---|
405 | warner@lothar.com**20110825161122 |
---|
406 | Ignore-this: 3cbf49f00dbda58189f893c427f65605 |
---|
407 | ] |
---|
408 | [touch NEWS to trigger buildslaves |
---|
409 | warner@lothar.com**20110825161026 |
---|
410 | Ignore-this: 3d444737d005a9051780d15604166401 |
---|
411 | ] |
---|
412 | [test_mutable.Update: remove .timeout overrides, otherwise tests ERROR |
---|
413 | Brian Warner <warner@lothar.com>**20110825022455 |
---|
414 | Ignore-this: 140ea1f7207ffd68be40e112f6e3d310 |
---|
415 | ] |
---|
416 | [blacklist.py: add read() method too, for completeness |
---|
417 | warner@lothar.com**20110825021902 |
---|
418 | Ignore-this: c79a429f311b01732eba2a71119e84 |
---|
419 | ] |
---|
420 | [Additional tests for MDMF URIs and for zero-length files. refs #393 |
---|
421 | david-sarah@jacaranda.org**20110823011532 |
---|
422 | Ignore-this: a7cc0c09d1d2d72413f9cd227c47a9d5 |
---|
423 | ] |
---|
424 | [Additional tests for zero-length partial reads and updates to mutable versions. refs #393 |
---|
425 | david-sarah@jacaranda.org**20110822014111 |
---|
426 | Ignore-this: 5fc6f4d06e11910124e4a277ec8a43ea |
---|
427 | ] |
---|
428 | [Implementation, tests and docs for blacklists. This version allows listing directories containing a blacklisted child. Inclusion of blacklist.py fixed. fixes #1425 |
---|
429 | david-sarah@jacaranda.org**20110824155928 |
---|
430 | Ignore-this: a306f36bb6640eaf046e66dc4beeb11c |
---|
431 | ] |
---|
432 | [Make the immutable/read-only constraint checking for MDMF URIs identical to that for SSK URIs. refs #393 |
---|
433 | david-sarah@jacaranda.org**20110823012720 |
---|
434 | Ignore-this: e1f59d7ff2007c81dbef2aeb14abd721 |
---|
435 | ] |
---|
436 | [mutable/layout.py: fix unused import. refs #393 |
---|
437 | david-sarah@jacaranda.org**20110816225043 |
---|
438 | Ignore-this: 7c9d6d91521ceb9a7abd14b2c60c0604 |
---|
439 | ] |
---|
440 | [mutable/retrieve.py: cosmetics and remove a stale comment. refs #393 |
---|
441 | david-sarah@jacaranda.org**20110816214612 |
---|
442 | Ignore-this: 916e60c9dff1ef85595822e609ff34b7 |
---|
443 | ] |
---|
444 | [mutable/filenode.py: don't fetch more segments than necesasry to update the file |
---|
445 | Kevan Carstensen <kevan@isnotajoke.com>**20110813210005 |
---|
446 | Ignore-this: 2b0ad0533baa6f19f18851317dfc9f15 |
---|
447 | ] |
---|
448 | [test/test_mutable: test for incorrect div_ceil equations |
---|
449 | Kevan Carstensen <kevan@isnotajoke.com>**20110813183936 |
---|
450 | Ignore-this: 74e6061ab2ec5e706a1235611f87d5d6 |
---|
451 | ] |
---|
452 | [mutable/retrieve.py: use floor division to calculate segment boundaries, don't fetch more segments than necessary |
---|
453 | Kevan Carstensen <kevan@isnotajoke.com>**20110813183833 |
---|
454 | Ignore-this: 3e272249107afd3fbc1dd30c6a4f1e31 |
---|
455 | ] |
---|
456 | [mdmf: clean up boolean expressions, correct typos, remove self._paused, and don't unconditionally initialize block hash trees, asll as suggested by davidsarahs' review comments |
---|
457 | Kevan Carstensen <kevan@isnotajoke.com>**20110813183710 |
---|
458 | Ignore-this: cc6ad9f98b64f379151aa58b77b6c4e5 |
---|
459 | ] |
---|
460 | [now that tests pass with full-size keys, return test-keys to normal (522bit) |
---|
461 | warner@lothar.com**20110811175418 |
---|
462 | Ignore-this: dbce8a6699ba9a90d91cffbc8aa87900 |
---|
463 | ] |
---|
464 | [fix SHARE_HASH_CHAIN_SIZE computation |
---|
465 | warner@lothar.com**20110811175350 |
---|
466 | Ignore-this: 4508359d2207c8c1b7552b546697264 |
---|
467 | ] |
---|
468 | [More idiomatic resolution of the conflict between ticket393-MDMF-2 and trunk. refs #393 |
---|
469 | david-sarah@jacaranda.org**20110810202942 |
---|
470 | Ignore-this: 7fc54a30ab0bc6ce75b7d819800c1182 |
---|
471 | ] |
---|
472 | [Replace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE constant defined in test/common.py (part 2). refs #393 |
---|
473 | david-sarah@jacaranda.org**20110810202310 |
---|
474 | Ignore-this: 7fbd4d004279599bbcb10f7b31fb010f |
---|
475 | ] |
---|
476 | [Replace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE constant defined in test/common.py (part 1). refs #393 |
---|
477 | david-sarah@jacaranda.org**20110810202243 |
---|
478 | Ignore-this: c58d8130a2f383ff4421c632499b027b |
---|
479 | ] |
---|
480 | [merge some minor conflicts in test code from the 393-2 branch and trunk |
---|
481 | zooko@zooko.com**20110810172139 |
---|
482 | Ignore-this: 4a16f13eeae585c7c1dbe18c67072c90 |
---|
483 | ] |
---|
484 | [doc: eliminate the phrase "rootcap" from doc/frontends/FTP-and-SFTP.rst |
---|
485 | zooko@zooko.com**20110809132601 |
---|
486 | Ignore-this: f7e1dd212daa65c81fb57977bce24304 |
---|
487 | Two different people have asked me for help, saying they couldn't figure out what a "rootcap" is. Hopefully just calling it a "cap" will make it easier for them to find out from the other docs what it is. |
---|
488 | ] |
---|
489 | [test_web.py: fix a test failure dependent on whether simplejson.loads returns a unicode or str object. |
---|
490 | david-sarah@jacaranda.org**20110808213925 |
---|
491 | Ignore-this: f7b267be8be56fcabc968e3c89999490 |
---|
492 | ] |
---|
493 | [immutable/filenode: fix pyflakes warnings |
---|
494 | Kevan Carstensen <kevan@isnotajoke.com>**20110807004514 |
---|
495 | Ignore-this: e8d875bf8b1c5571e31b0eff42ecf64c |
---|
496 | ] |
---|
497 | [test: fix assorted tests broken by MDMF changes |
---|
498 | Kevan Carstensen <kevan@isnotajoke.com>**20110807004459 |
---|
499 | Ignore-this: 9a0dc7e5c74bfe840a9fce278619a103 |
---|
500 | ] |
---|
501 | [uri: add MDMF and MDMF directory caps, add extension hint support |
---|
502 | Kevan Carstensen <kevan@isnotajoke.com>**20110807004436 |
---|
503 | Ignore-this: 6486b7d4dc0e849c6b1e9cdfb6318eac |
---|
504 | ] |
---|
505 | [test/test_mutable: tests for MDMF |
---|
506 | Kevan Carstensen <kevan@isnotajoke.com>**20110807004414 |
---|
507 | Ignore-this: 29f9c3a806d67df0ed09c4f0d857d347 |
---|
508 | |
---|
509 | These are their own patch because they cut across a lot of the changes |
---|
510 | I've made in implementing MDMF in such a way as to make it difficult to |
---|
511 | split them up into the other patches. |
---|
512 | ] |
---|
513 | [webapi changes for MDMF |
---|
514 | Kevan Carstensen <kevan@isnotajoke.com>**20110807004348 |
---|
515 | Ignore-this: d6d4dac680baa4c99b05882b3828796c |
---|
516 | |
---|
517 | - Learn how to create MDMF files and directories through the |
---|
518 | mutable-type argument. |
---|
519 | - Operate with the interface changes associated with MDMF and #993. |
---|
520 | - Learn how to do partial updates of mutable files. |
---|
521 | ] |
---|
522 | [mutable/servermap: Rework the servermap to work with MDMF mutable files |
---|
523 | Kevan Carstensen <kevan@isnotajoke.com>**20110807004259 |
---|
524 | Ignore-this: 154b987fa0af716c41185b88ff7ee2e1 |
---|
525 | ] |
---|
526 | [dirnode: teach dirnode to make MDMF directories |
---|
527 | Kevan Carstensen <kevan@isnotajoke.com>**20110807004224 |
---|
528 | Ignore-this: 765ccd6a07ff752bf6057a3dab9e5abd |
---|
529 | ] |
---|
530 | [Fix some test failures caused by #393 patch. |
---|
531 | david-sarah@jacaranda.org**20110802032810 |
---|
532 | Ignore-this: 7f65e5adb5c859af289cea7011216fef |
---|
533 | ] |
---|
534 | [docs: amend configuration, webapi documentation to talk about MDMF |
---|
535 | Kevan Carstensen <kevan@isnotajoke.com>**20110802022056 |
---|
536 | Ignore-this: 4cab9b7e4ab79cc1efdabe2d457f27a6 |
---|
537 | ] |
---|
538 | [cli: teach CLI how to create MDMF mutable files |
---|
539 | Kevan Carstensen <kevan@isnotajoke.com>**20110802021613 |
---|
540 | Ignore-this: 18d0ff98e75be231eed3c53319e76936 |
---|
541 | |
---|
542 | Specifically, 'tahoe mkdir' and 'tahoe put' now take a --mutable-type |
---|
543 | argument. |
---|
544 | ] |
---|
545 | [frontends/sftpd: Resolve incompatibilities between SFTP frontend and MDMF changes |
---|
546 | Kevan Carstensen <kevan@isnotajoke.com>**20110802021207 |
---|
547 | Ignore-this: 5e0f6e961048f71d4eed6d30210ffd2e |
---|
548 | ] |
---|
549 | [mutable/layout: Define MDMF share format, write tools for working with MDMF share format |
---|
550 | Kevan Carstensen <kevan@isnotajoke.com>**20110802021120 |
---|
551 | Ignore-this: fa76ef4800939e19ba3cbc22a2eab4e |
---|
552 | |
---|
553 | The changes in layout.py are mostly concerned with the MDMF share |
---|
554 | format. In particular, we define read and write proxy objects used by |
---|
555 | retrieval, publishing, and other code to write and read the MDMF share |
---|
556 | format. We create equivalent proxies for SDMF objects so that these |
---|
557 | objects can be suitably general. |
---|
558 | ] |
---|
559 | [immutable/filenode: implement unified filenode interface |
---|
560 | Kevan Carstensen <kevan@isnotajoke.com>**20110802020905 |
---|
561 | Ignore-this: d9a442fc285157f134f5d1b4607c6a48 |
---|
562 | ] |
---|
563 | [immutable/literal.py: Implement interface changes in literal nodes. |
---|
564 | Kevan Carstensen <kevan@isnotajoke.com>**20110802020814 |
---|
565 | Ignore-this: 4371e71a50e65ce2607c4d67d3a32171 |
---|
566 | ] |
---|
567 | [test/common: Alter common test code to work with MDMF. |
---|
568 | Kevan Carstensen <kevan@isnotajoke.com>**20110802015643 |
---|
569 | Ignore-this: e564403182d0030439b168dd9f8726fa |
---|
570 | |
---|
571 | This mostly has to do with making the test code implement the new |
---|
572 | unified filenode interfaces. |
---|
573 | ] |
---|
574 | [mutable: train checker and repairer to work with MDMF mutable files |
---|
575 | Kevan Carstensen <kevan@isnotajoke.com>**20110802015140 |
---|
576 | Ignore-this: 8b1928925bed63708b71ab0de8d4306f |
---|
577 | ] |
---|
578 | [nodemaker: teach nodemaker about MDMF caps |
---|
579 | Kevan Carstensen <kevan@isnotajoke.com>**20110802014926 |
---|
580 | Ignore-this: 430c73121b6883b99626cfd652fc65c4 |
---|
581 | ] |
---|
582 | [client: teach client how to create and work with MDMF files |
---|
583 | Kevan Carstensen <kevan@isnotajoke.com>**20110802014811 |
---|
584 | Ignore-this: d72fbc4c2ca63f00d9ab9dc2919098ff |
---|
585 | ] |
---|
586 | [mutable/filenode: Modify mutable filenodes for use with MDMF |
---|
587 | Kevan Carstensen <kevan@isnotajoke.com>**20110802014501 |
---|
588 | Ignore-this: 3c230bb0ebe60a94c667b0ee0c3b28e0 |
---|
589 | |
---|
590 | In particular: |
---|
591 | - Break MutableFileNode and MutableFileVersion into distinct classes. |
---|
592 | - Implement the interface modifications made for MDMF. |
---|
593 | - Be aware of MDMF caps. |
---|
594 | - Learn how to create and work with MDMF files. |
---|
595 | ] |
---|
596 | [nodemaker: teach nodemaker how to create MDMF mutable files |
---|
597 | Kevan Carstensen <kevan@isnotajoke.com>**20110802014258 |
---|
598 | Ignore-this: 2bf1fd4f8c1d1ad0e855c678347b76c2 |
---|
599 | ] |
---|
600 | [interfaces: change interfaces to work with MDMF |
---|
601 | Kevan Carstensen <kevan@isnotajoke.com>**20110802014119 |
---|
602 | Ignore-this: 2f441022cf888c044bc9e6dd609db139 |
---|
603 | |
---|
604 | A lot of this work concerns #993, in that it unifies (to an extent) the |
---|
605 | interfaces of mutable and immutable files. |
---|
606 | ] |
---|
607 | [mutable/publish: teach the publisher how to publish MDMF mutable files |
---|
608 | Kevan Carstensen <kevan@isnotajoke.com>**20110802013931 |
---|
609 | Ignore-this: 115217ec2b289452ec774cb725da8a86 |
---|
610 | |
---|
611 | Like the downloader, the publisher needs some substantial changes to handle multiple segment mutable files. |
---|
612 | ] |
---|
613 | [mutable/retrieve: rework the mutable downloader to handle multiple-segment files |
---|
614 | Kevan Carstensen <kevan@isnotajoke.com>**20110802013524 |
---|
615 | Ignore-this: 398d11b5cb993b50e5e4fa6e7a3856dc |
---|
616 | |
---|
617 | The downloader needs substantial reworking to handle multiple segment |
---|
618 | mutable files, which it needs to handle for MDMF. |
---|
619 | ] |
---|
620 | [Fix repeated 'the' in license text. |
---|
621 | david-sarah@jacaranda.org**20110819204836 |
---|
622 | Ignore-this: b3bd4e9ec22029fe15533ad2a60003ad |
---|
623 | ] |
---|
624 | [Remove Non-Profit Open Software License from the set of 'added permission' licenses. Although it actually does qualify as an Open Source license (because it allows relicensing under plain OSL), its wording is unclear and could easily be misunderstood, and it contributes to incompatible license proliferation. |
---|
625 | david-sarah@jacaranda.org**20110819204742 |
---|
626 | Ignore-this: 7373819a6b5367581356728ea62cabb1 |
---|
627 | ] |
---|
628 | [docs: change links that pointed to COPYING.TGPPL.html to point to COPYING.TGPPL.rst instead |
---|
629 | zooko@zooko.com**20110819060142 |
---|
630 | Ignore-this: 301652554fd7ab4bfa5aa8f8a2863a9e |
---|
631 | ] |
---|
632 | [docs: formatting: reflow to fill-column 77 |
---|
633 | zooko@zooko.com**20110819060110 |
---|
634 | Ignore-this: ed1317c126f07c63b944bd2fa6aa2d21 |
---|
635 | ] |
---|
636 | [docs: formatting: M-x whitespace-cleanup |
---|
637 | zooko@zooko.com**20110819060041 |
---|
638 | Ignore-this: 8554b16a25067094d0dc4dc71e1b3950 |
---|
639 | ] |
---|
640 | [licensing: add to the list of licenses that we grant the added permission for |
---|
641 | zooko@zooko.com**20110819054656 |
---|
642 | Ignore-this: eb1490416ac6b7414a27f150a8a8a047 |
---|
643 | Added: most of the ones listed on the FSF's "List of Free Software, GPL Incompatible Licenses", plus the Non-Profit Open Software License. |
---|
644 | ] |
---|
645 | [docs: reflow the added text at the top of COPYING.GPL to fill-column 77 |
---|
646 | zooko@zooko.com**20110819053059 |
---|
647 | Ignore-this: e994ed6ffbcc12656406f11cb862ce99 |
---|
648 | ] |
---|
649 | [docs: reformat COPYING.TGPPL.html to COPYING.TGPPL.rst |
---|
650 | zooko@zooko.com**20110819052753 |
---|
651 | Ignore-this: 34ddf623e0a6de008ba859ca9c92b2fd |
---|
652 | ] |
---|
653 | [docs: reflow docs/logging.rst to fill-column 77 |
---|
654 | zooko@zooko.com**20110819044103 |
---|
655 | Ignore-this: a6901f2244995f278ddf8d75d29410bf |
---|
656 | ] |
---|
657 | [doc: fix formatting error in docs/logging.rst |
---|
658 | zooko@zooko.com**20110819043946 |
---|
659 | Ignore-this: fa182dbbe7f4fda15e0a8bfcf7f00051 |
---|
660 | ] |
---|
661 | [Cleanups for suppression of UserWarnings. refs #1435 |
---|
662 | david-sarah@jacaranda.org**20110818040749 |
---|
663 | Ignore-this: 3863ef399c1c382a1365d51f000d314c |
---|
664 | ] |
---|
665 | [suppress warning emitted by newer zope.interface with Nevow 0.10 |
---|
666 | zooko@zooko.com**20110817203134 |
---|
667 | Ignore-this: b86d4ce0ed1c0da76d1f9eaf8d08d9c4 |
---|
668 | refs #1435 |
---|
669 | ] |
---|
670 | [doc: formatting: reflow to fill-column=77 |
---|
671 | zooko@zooko.com**20110809132510 |
---|
672 | Ignore-this: 2d6d2e203d52925968b4451f36364792 |
---|
673 | ] |
---|
674 | [_auto_deps.py: change the requirement for zope.interface to <= 3.6.2, >= 3.6.6. fixes #1435 |
---|
675 | david-sarah@jacaranda.org**20110815025347 |
---|
676 | Ignore-this: 17a88c0f6573f044fbcd6b666667bd37 |
---|
677 | ] |
---|
678 | [allmydata/__init__.py, test_version.py: make version parsing understand '<=', with test. refs #1435 |
---|
679 | david-sarah@jacaranda.org**20110815035153 |
---|
680 | Ignore-this: 8c3a75f4a2b42b56bac48b5053c5e9c2 |
---|
681 | ] |
---|
682 | [Makefile and setup.py: remove setup.py commands that we no longer need, and their uses in the Makefile. Delete a stale and incorrect comment about updating _version.py. Also fix some coding style checks in the Makefile to operate on all source files. |
---|
683 | david-sarah@jacaranda.org**20110801031952 |
---|
684 | Ignore-this: 80a435dee3bc6e29058d4b37ff579922 |
---|
685 | ] |
---|
686 | [remove misc/debian[_helpers], rely upon official packaging instead. fixes #1454 |
---|
687 | warner@lothar.com**20110811182705 |
---|
688 | Ignore-this: 79673cafc7c108db49b5ab908d7b4668 |
---|
689 | ] |
---|
690 | [Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454 |
---|
691 | david-sarah@jacaranda.org**20110801031857 |
---|
692 | Ignore-this: 347cbeff45757db630ce34d0cfb84f92 |
---|
693 | ] |
---|
694 | [replace tabs with spaces in the #1441 'tahoe debug' synopsis |
---|
695 | warner@lothar.com**20110811173704 |
---|
696 | Ignore-this: 513fbfb18a3dd93119ea3700118df7ee |
---|
697 | ] |
---|
698 | [Correct the information printed by '/usr/bin/tahoe debug --help' on Debian/Ubuntu. fixes #1441 |
---|
699 | david-sarah@jacaranda.org**20110724162530 |
---|
700 | Ignore-this: 30d4b8c20e420e9a9d1b73eba1113ae |
---|
701 | ] |
---|
702 | [doc: edit the explanation of K-of-N tradeoffs |
---|
703 | zooko@zooko.com**20110804193409 |
---|
704 | Ignore-this: ab6f4e35a995c2099340b5c9c5d30f40 |
---|
705 | ] |
---|
706 | [doc: clean up formatting of doc/configuration.rst |
---|
707 | zooko@zooko.com**20110804192722 |
---|
708 | Ignore-this: 7a98a3a8afb7e5441ff1f534211199ba |
---|
709 | reflow to 77 chars line width, M-x white-space cleanup, blank link between name and definition |
---|
710 | ] |
---|
711 | [Add test for webopen. fixes #1149 |
---|
712 | david-sarah@jacaranda.org**20110724211659 |
---|
713 | Ignore-this: 1e22853f7eb05e24c3141d56a513f661 |
---|
714 | ] |
---|
715 | [test_client.py: relax a check in test_create_drop_uploader so that it should pass on Python 2.4.x. refs #1429 |
---|
716 | david-sarah@jacaranda.org**20110810052504 |
---|
717 | Ignore-this: 1380749ceaf33c30e26c50d57476616c |
---|
718 | ] |
---|
719 | [test/common_util.py: correct fix to mkdir_nonascii. refs #1472 |
---|
720 | david-sarah@jacaranda.org**20110810051906 |
---|
721 | Ignore-this: 93c0c33370bc47d95c26c4cce8e05290 |
---|
722 | ] |
---|
723 | [test/common_util.py: fix a typo. refs #1472 |
---|
724 | david-sarah@jacaranda.org**20110810044235 |
---|
725 | Ignore-this: f88643d7c82cb3577686d77bbff9e2bc |
---|
726 | ] |
---|
727 | [test_client.py, test_drop_upload.py: fix pyflakes warnings. |
---|
728 | david-sarah@jacaranda.org**20110810034505 |
---|
729 | Ignore-this: 1e2d71bf2f43d63cbb423d32a6f96793 |
---|
730 | ] |
---|
731 | [Factor out methods dealing with non-ASCII directories and filenames from test_drop_upload.py into common_util.py. refs #1429, #1472 |
---|
732 | david-sarah@jacaranda.org**20110810031558 |
---|
733 | Ignore-this: 3de8f945fa7a58fc318a1184bad0fd1a |
---|
734 | ] |
---|
735 | [test_client.py: add a test that the drop-uploader is initialized correctly by client.py. Also give the DropUploader service a name, which is necessary for the test. refs #1429 |
---|
736 | david-sarah@jacaranda.org**20110810030538 |
---|
737 | Ignore-this: 13d511ea9bbe9da2dcffe4a91ce94eae |
---|
738 | ] |
---|
739 | [drop-upload: rename 'start' method to 'startService', which is what you're supposed to use to start a Service. refs #1429 |
---|
740 | david-sarah@jacaranda.org**20110810030345 |
---|
741 | Ignore-this: d1f5e5c63937ea37be37324e2f1ae99d |
---|
742 | ] |
---|
743 | [test_drop_upload.py: add comment explaining why we don't use FilePath.setContent. refs #1429 |
---|
744 | david-sarah@jacaranda.org**20110810025942 |
---|
745 | Ignore-this: b95358030b63cb467d1d7f1b9a9b6978 |
---|
746 | ] |
---|
747 | [test_drop_upload.py: fix some grammatical and spelling nits. refs #1429 |
---|
748 | david-sarah@jacaranda.org**20110809221231 |
---|
749 | Ignore-this: fd331acddd9f754173f274a34fe62f03 |
---|
750 | ] |
---|
751 | [drop-upload: report the configured local directory being absent differently from it being a file |
---|
752 | zooko@zooko.com**20110809220930 |
---|
753 | Ignore-this: a08879100f5f20e609be3f0ffa3b25cc |
---|
754 | refs #1429 |
---|
755 | ] |
---|
756 | [drop-upload: rename the 'upload.uri' parameter to 'upload.dircap', and a couple of cleanups to error messages. refs #1429 |
---|
757 | zooko@zooko.com**20110809220508 |
---|
758 | Ignore-this: 4846368cbe331e8653bdce1f314e276b |
---|
759 | I rerecorded this patch, originally by David-Sarah, to use "darcs replace" instead of editing to do the renames. This uncovered one missed rename in Client.init_drop_uploader. (Which also means that code isn't exercised by the current unit tests.) |
---|
760 | refs #1429 |
---|
761 | ] |
---|
762 | [drop-upload test for non-existent local dir separately from test for non-directory local dir |
---|
763 | zooko@zooko.com**20110809220115 |
---|
764 | Ignore-this: cd85f345c02f5cb71b1c1527bd4ebddc |
---|
765 | A candidate patch for #1429 has a bug when it is using FilePath.is_dir() to detect whether the configured local dir exists and is a directory. FilePath.is_dir() raises exception, instead of returning False, if the thing doesn't exist. This test is to make sure that DropUploader.__init__ raise different exceptions for those two cases. |
---|
766 | refs #1429 |
---|
767 | ] |
---|
768 | [drop-upload: unit tests for the configuration options being named "cap" instead of "uri" |
---|
769 | zooko@zooko.com**20110809215913 |
---|
770 | Ignore-this: 958c78fffb3d76b3e4817647f824e7f9 |
---|
771 | This is a subset of a patch that David-Sarah attached to #1429. This is just the unit-tests part of that patch, and uses darcs record instead of hunks to change the names. |
---|
772 | refs #1429 |
---|
773 | ] |
---|
774 | [src/allmydata/storage/server.py: use the filesystem of storage/shares/, rather than storage/, to calculate remaining space. fixes #1384 |
---|
775 | david-sarah@jacaranda.org**20110719022752 |
---|
776 | Ignore-this: a4781043cfd453dbb66ae4f108d80bea |
---|
777 | ] |
---|
778 | [test_storage.py: test that we are using the filesystem of storage/shares/, rather than storage/, to calculate remaining space, and that the HTML status output reflects the values returned by fileutil.get_disk_stats. This version works with older versions of the mock library. refs #1384 |
---|
779 | david-sarah@jacaranda.org**20110809190722 |
---|
780 | Ignore-this: db447caca37a459ca49563efa58db58c |
---|
781 | ] |
---|
782 | [Work around ref #1472 by having test_drop_upload delete the non-ASCII directories it creates. |
---|
783 | david-sarah@jacaranda.org**20110809012334 |
---|
784 | Ignore-this: 5881fd5db419ba8ad12e0b2a82f6c4f0 |
---|
785 | ] |
---|
786 | [Remove all trailing whitespace from .py files. |
---|
787 | david-sarah@jacaranda.org**20110809001117 |
---|
788 | Ignore-this: d2658b5ce44af70cc606ae4d3085b7cc |
---|
789 | ] |
---|
790 | [test_drop_upload.py: fix unused imports. refs #1429 |
---|
791 | david-sarah@jacaranda.org**20110808235422 |
---|
792 | Ignore-this: 834f6b946bfea699d7d8c743edd66671 |
---|
793 | ] |
---|
794 | [Documentation for drop-upload frontend. refs #1429 |
---|
795 | david-sarah@jacaranda.org**20110808182146 |
---|
796 | Ignore-this: b33110834e586c0b784d1736c2af5779 |
---|
797 | ] |
---|
798 | [Drop-upload frontend, rerecorded for 1.9 beta (and correcting a minor mistake). Includes some fixes for Windows but not the Windows inotify implementation. fixes #1429 |
---|
799 | david-sarah@jacaranda.org**20110808234049 |
---|
800 | Ignore-this: 67f824c7f554e9a3a85f9fd2e1123d97 |
---|
801 | ] |
---|
802 | [node.py: ensure that client and introducer nodes record their port number and use that port on the next restart, fixing a regression caused by #1385. fixes #1469. |
---|
803 | david-sarah@jacaranda.org**20110806221934 |
---|
804 | Ignore-this: 1aa9d340b6570320ab2f9edc89c9e0a8 |
---|
805 | ] |
---|
806 | [test_runner.py: fix a race condition in the test when NODE_URL_FILE is written before PORTNUM_FILE. refs #1469 |
---|
807 | david-sarah@jacaranda.org**20110806231842 |
---|
808 | Ignore-this: ab01ae7cec3a073e29eec473e64052a0 |
---|
809 | ] |
---|
810 | [test_runner.py: cleanups of HOTLINE_FILE writing and removal. |
---|
811 | david-sarah@jacaranda.org**20110806231652 |
---|
812 | Ignore-this: 25f5c5d6f5d8faebb26a4ce80110a335 |
---|
813 | ] |
---|
814 | [test_runner.py: remove an unused constant. |
---|
815 | david-sarah@jacaranda.org**20110806221416 |
---|
816 | Ignore-this: eade2695cbabbea9cafeaa8debe410bb |
---|
817 | ] |
---|
818 | [node.py: fix the error path for a missing config option so that it works for a Unicode base directory. |
---|
819 | david-sarah@jacaranda.org**20110806221007 |
---|
820 | Ignore-this: 4eb9cc04b2ce05182a274a0d69dafaf3 |
---|
821 | ] |
---|
822 | [test_runner.py: test that client and introducer nodes record their port number and use that port on the next restart. This tests for a regression caused by ref #1385. |
---|
823 | david-sarah@jacaranda.org**20110806220635 |
---|
824 | Ignore-this: 40a0c040b142dbddd47e69b3c3712f5 |
---|
825 | ] |
---|
826 | [test_runner.py: fix a bug in CreateNode.do_create introduced in changeset [5114] when the tahoe.cfg file has been written with CRLF line endings. refs #1385 |
---|
827 | david-sarah@jacaranda.org**20110804003032 |
---|
828 | Ignore-this: 7b7afdcf99da6671afac2d42828883eb |
---|
829 | ] |
---|
830 | [test_client.py: repair Basic.test_error_on_old_config_files. refs #1385 |
---|
831 | david-sarah@jacaranda.org**20110803235036 |
---|
832 | Ignore-this: 31e2a9c3febe55948de7e144353663e |
---|
833 | ] |
---|
834 | [test_checker.py: increase timeout for TooParallel.test_immutable again. The ARM buildslave took 38 seconds, so 40 seconds is too close to the edge; make it 80. |
---|
835 | david-sarah@jacaranda.org**20110803214042 |
---|
836 | Ignore-this: 2d8026a6b25534e01738f78d6c7495cb |
---|
837 | ] |
---|
838 | [test_runner.py: fix RunNode.test_introducer to not rely on the mtime of introducer.furl to detect when the node has restarted. Instead we detect when node.url has been written. refs #1385 |
---|
839 | david-sarah@jacaranda.org**20110803180917 |
---|
840 | Ignore-this: 11ddc43b107beca42cb78af88c5c394c |
---|
841 | ] |
---|
842 | [Further improve error message about old config files. refs #1385 |
---|
843 | david-sarah@jacaranda.org**20110803174546 |
---|
844 | Ignore-this: 9d6cc3c288d9863dce58faafb3855917 |
---|
845 | ] |
---|
846 | [Slightly improve error message about old config files (avoid unnecessary Unicode escaping). refs #1385 |
---|
847 | david-sarah@jacaranda.org**20110803163848 |
---|
848 | Ignore-this: a3e3930fba7ccf90b8db3d2ed5829df4 |
---|
849 | ] |
---|
850 | [test_checker.py: increase timeout for TooParallel.test_immutable (was consistently failing on ARM buildslave). |
---|
851 | david-sarah@jacaranda.org**20110803163213 |
---|
852 | Ignore-this: d0efceaf12628e8791862b80c85b5d56 |
---|
853 | ] |
---|
854 | [Fix the bug that prevents an introducer from starting when introducer.furl already exists. Also remove some dead code that used to read old config files, and rename 'warn_about_old_config_files' to reflect that it's not a warning. refs #1385 |
---|
855 | david-sarah@jacaranda.org**20110803013212 |
---|
856 | Ignore-this: 2d6cd14bd06a7493b26f2027aff78f4d |
---|
857 | ] |
---|
858 | [test_runner.py: modify RunNode.test_introducer to test that starting an introducer works when the introducer.furl file already exists. refs #1385 |
---|
859 | david-sarah@jacaranda.org**20110803012704 |
---|
860 | Ignore-this: 8cf7f27ac4bfbb5ad8ca4a974106d437 |
---|
861 | ] |
---|
862 | [verifier: correct a bug introduced in changeset [5106] that caused us to only verify the first block of a file. refs #1395 |
---|
863 | david-sarah@jacaranda.org**20110802172437 |
---|
864 | Ignore-this: 87fb77854a839ff217dce73544775b11 |
---|
865 | ] |
---|
866 | [test_repairer: add a deterministic test of share data corruption that always flips the bits of the last byte of the share data. refs #1395 |
---|
867 | david-sarah@jacaranda.org**20110802175841 |
---|
868 | Ignore-this: 72f54603785007e88220c8d979e08be7 |
---|
869 | ] |
---|
870 | [verifier: serialize the fetching of blocks within a share so that we don't use too much RAM |
---|
871 | zooko@zooko.com**20110802063703 |
---|
872 | Ignore-this: debd9bac07dcbb6803f835a9e2eabaa1 |
---|
873 | |
---|
874 | Shares are still verified in parallel, but within a share, don't request a |
---|
875 | block until the previous block has been verified and the memory we used to hold |
---|
876 | it has been freed up. |
---|
877 | |
---|
878 | Patch originally due to Brian. This version has a mockery-patchery-style test |
---|
879 | which is "low tech" (it implements the patching inline in the test code instead |
---|
880 | of using an extension of the mock.patch() function from the mock library) and |
---|
881 | which unpatches in case of exception. |
---|
882 | |
---|
883 | fixes #1395 |
---|
884 | ] |
---|
885 | [add docs about timing-channel attacks |
---|
886 | Brian Warner <warner@lothar.com>**20110802044541 |
---|
887 | Ignore-this: 73114d5f5ed9ce252597b707dba3a194 |
---|
888 | ] |
---|
889 | ['test-coverage' now needs PYTHONPATH=. to find TOP/twisted/plugins/ |
---|
890 | Brian Warner <warner@lothar.com>**20110802041952 |
---|
891 | Ignore-this: d40f1f4cb426ea1c362fc961baedde2 |
---|
892 | ] |
---|
893 | [remove nodeid from WriteBucketProxy classes and customers |
---|
894 | warner@lothar.com**20110801224317 |
---|
895 | Ignore-this: e55334bb0095de11711eeb3af827e8e8 |
---|
896 | refs #1363 |
---|
897 | ] |
---|
898 | [remove get_serverid() from ReadBucketProxy and customers, including Checker |
---|
899 | warner@lothar.com**20110801224307 |
---|
900 | Ignore-this: 837aba457bc853e4fd413ab1a94519cb |
---|
901 | and debug.py dump-share commands |
---|
902 | refs #1363 |
---|
903 | ] |
---|
904 | [reject old-style (pre-Tahoe-LAFS-v1.3) configuration files |
---|
905 | zooko@zooko.com**20110801232423 |
---|
906 | Ignore-this: b58218fcc064cc75ad8f05ed0c38902b |
---|
907 | Check for the existence of any of them and if any are found raise exception which will abort the startup of the node. |
---|
908 | This is a backwards-incompatible change for anyone who is still using old-style configuration files. |
---|
909 | fixes #1385 |
---|
910 | ] |
---|
911 | [whitespace-cleanup |
---|
912 | zooko@zooko.com**20110725015546 |
---|
913 | Ignore-this: 442970d0545183b97adc7bd66657876c |
---|
914 | ] |
---|
915 | [tests: use fileutil.write() instead of open() to ensure timely close even without CPython-style reference counting |
---|
916 | zooko@zooko.com**20110331145427 |
---|
917 | Ignore-this: 75aae4ab8e5fa0ad698f998aaa1888ce |
---|
918 | Some of these already had an explicit close() but I went ahead and replaced them with fileutil.write() as well for the sake of uniformity. |
---|
919 | ] |
---|
920 | [Address Kevan's comment in #776 about Options classes missed when adding 'self.command_name'. refs #776, #1359 |
---|
921 | david-sarah@jacaranda.org**20110801221317 |
---|
922 | Ignore-this: 8881d42cf7e6a1d15468291b0cb8fab9 |
---|
923 | ] |
---|
924 | [docs/frontends/webapi.rst: change some more instances of 'delete' or 'remove' to 'unlink', change some section titles, and use two blank lines between all sections. refs #776, #1104 |
---|
925 | david-sarah@jacaranda.org**20110801220919 |
---|
926 | Ignore-this: 572327591137bb05c24c44812d4b163f |
---|
927 | ] |
---|
928 | [cleanup: implement rm as a synonym for unlink rather than vice-versa. refs #776 |
---|
929 | david-sarah@jacaranda.org**20110801220108 |
---|
930 | Ignore-this: 598dcbed870f4f6bb9df62de9111b343 |
---|
931 | ] |
---|
932 | [docs/webapi.rst: address Kevan's comments about use of 'delete' on ref #1104 |
---|
933 | david-sarah@jacaranda.org**20110801205356 |
---|
934 | Ignore-this: 4fbf03864934753c951ddeff64392491 |
---|
935 | ] |
---|
936 | [docs: some changes of 'delete' or 'rm' to 'unlink'. refs #1104 |
---|
937 | david-sarah@jacaranda.org**20110713002722 |
---|
938 | Ignore-this: 304d2a330d5e6e77d5f1feed7814b21c |
---|
939 | ] |
---|
940 | [WUI: change the label of the button to unlink a file from 'del' to 'unlink'. Also change some internal names to 'unlink', and allow 't=unlink' as a synonym for 't=delete' in the web-API interface. Incidentally, improve a test to check for the rename button as well as the unlink button. fixes #1104 |
---|
941 | david-sarah@jacaranda.org**20110713001218 |
---|
942 | Ignore-this: 3eef6b3f81b94a9c0020a38eb20aa069 |
---|
943 | ] |
---|
944 | [src/allmydata/web/filenode.py: delete a stale comment that was made incorrect by changeset [3133]. |
---|
945 | david-sarah@jacaranda.org**20110801203009 |
---|
946 | Ignore-this: b3912e95a874647027efdc97822dd10e |
---|
947 | ] |
---|
948 | [fix typo introduced during rebasing of 'remove get_serverid from |
---|
949 | Brian Warner <warner@lothar.com>**20110801200341 |
---|
950 | Ignore-this: 4235b0f585c0533892193941dbbd89a8 |
---|
951 | DownloadStatus.add_dyhb_request and customers' patch, to fix test failure. |
---|
952 | ] |
---|
953 | [remove get_serverid from DownloadStatus.add_dyhb_request and customers |
---|
954 | zooko@zooko.com**20110801185401 |
---|
955 | Ignore-this: db188c18566d2d0ab39a80c9dc8f6be6 |
---|
956 | This patch is a rebase of a patch originally written by Brian. I didn't change any of the intent of Brian's patch, just ported it to current trunk. |
---|
957 | refs #1363 |
---|
958 | ] |
---|
959 | [remove get_serverid from DownloadStatus.add_block_request and customers |
---|
960 | zooko@zooko.com**20110801185344 |
---|
961 | Ignore-this: 8bfa8201d6147f69b0fbe31beea9c1e |
---|
962 | This is a rebase of a patch Brian originally wrote. I haven't changed the intent of that patch, just ported it to trunk. |
---|
963 | refs #1363 |
---|
964 | ] |
---|
965 | [apply zooko's advice: storage_client get_known_servers() returns a frozenset, caller sorts |
---|
966 | warner@lothar.com**20110801174452 |
---|
967 | Ignore-this: 2aa13ea6cbed4e9084bd604bf8633692 |
---|
968 | refs #1363 |
---|
969 | ] |
---|
970 | [test_immutable.Test: rewrite to use NoNetworkGrid, now takes 2.7s not 97s |
---|
971 | warner@lothar.com**20110801174444 |
---|
972 | Ignore-this: 54f30b5d7461d2b3514e2a0172f3a98c |
---|
973 | remove now-unused ShareManglingMixin |
---|
974 | refs #1363 |
---|
975 | ] |
---|
976 | [DownloadStatus.add_known_share wants to be used by Finder, web.status |
---|
977 | warner@lothar.com**20110801174436 |
---|
978 | Ignore-this: 1433bcd73099a579abe449f697f35f9 |
---|
979 | refs #1363 |
---|
980 | ] |
---|
981 | [replace IServer.name() with get_name(), and get_longname() |
---|
982 | warner@lothar.com**20110801174428 |
---|
983 | Ignore-this: e5a6f7f6687fd7732ddf41cfdd7c491b |
---|
984 | |
---|
985 | This patch was originally written by Brian, but was re-recorded by Zooko to use |
---|
986 | darcs replace instead of hunks for any file in which it would result in fewer |
---|
987 | total hunks. |
---|
988 | refs #1363 |
---|
989 | ] |
---|
990 | [upload.py: apply David-Sarah's advice rename (un)contacted(2) trackers to first_pass/second_pass/next_pass |
---|
991 | zooko@zooko.com**20110801174143 |
---|
992 | Ignore-this: e36e1420bba0620a0107bd90032a5198 |
---|
993 | This patch was written by Brian but was re-recorded by Zooko (with David-Sarah looking on) to use darcs replace instead of editing to rename the three variables to their new names. |
---|
994 | refs #1363 |
---|
995 | ] |
---|
996 | [Coalesce multiple Share.loop() calls, make downloads faster. Closes #1268. |
---|
997 | Brian Warner <warner@lothar.com>**20110801151834 |
---|
998 | Ignore-this: 48530fce36c01c0ff708f61c2de7e67a |
---|
999 | ] |
---|
1000 | [src/allmydata/_auto_deps.py: 'i686' is another way of spelling x86. |
---|
1001 | david-sarah@jacaranda.org**20110801034035 |
---|
1002 | Ignore-this: 6971e0621db2fba794d86395b4d51038 |
---|
1003 | ] |
---|
1004 | [tahoe_rm.py: better error message when there is no path. refs #1292 |
---|
1005 | david-sarah@jacaranda.org**20110122064212 |
---|
1006 | Ignore-this: ff3bb2c9f376250e5fd77eb009e09018 |
---|
1007 | ] |
---|
1008 | [test_cli.py: Test for error message when 'tahoe rm' is invoked without a path. refs #1292 |
---|
1009 | david-sarah@jacaranda.org**20110104105108 |
---|
1010 | Ignore-this: 29ec2f2e0251e446db96db002ad5dd7d |
---|
1011 | ] |
---|
1012 | [src/allmydata/__init__.py: suppress a spurious warning from 'bin/tahoe --version[-and-path]' about twisted-web and twisted-core packages. |
---|
1013 | david-sarah@jacaranda.org**20110801005209 |
---|
1014 | Ignore-this: 50e7cd53cca57b1870d9df0361c7c709 |
---|
1015 | ] |
---|
1016 | [test_cli.py: use to_str on fields loaded using simplejson.loads in new tests. refs #1304 |
---|
1017 | david-sarah@jacaranda.org**20110730032521 |
---|
1018 | Ignore-this: d1d6dfaefd1b4e733181bf127c79c00b |
---|
1019 | ] |
---|
1020 | [cli: make 'tahoe cp' overwrite mutable files in-place |
---|
1021 | Kevan Carstensen <kevan@isnotajoke.com>**20110729202039 |
---|
1022 | Ignore-this: b2ad21a19439722f05c49bfd35b01855 |
---|
1023 | ] |
---|
1024 | [SFTP: write an error message to standard error for unrecognized shell commands. Change the existing message for shell sessions to be written to standard error, and refactor some duplicated code. Also change the lines of the error messages to end in CRLF, and take into account Kevan's review comments. fixes #1442, #1446 |
---|
1025 | david-sarah@jacaranda.org**20110729233102 |
---|
1026 | Ignore-this: d2f2bb4664f25007d1602bf7333e2cdd |
---|
1027 | ] |
---|
1028 | [src/allmydata/scripts/cli.py: fix pyflakes warning. |
---|
1029 | david-sarah@jacaranda.org**20110728021402 |
---|
1030 | Ignore-this: 94050140ddb99865295973f49927c509 |
---|
1031 | ] |
---|
1032 | [Fix the help synopses of CLI commands to include [options] in the right place. fixes #1359, fixes #636 |
---|
1033 | david-sarah@jacaranda.org**20110724225440 |
---|
1034 | Ignore-this: 2a8e488a5f63dabfa9db9efd83768a5 |
---|
1035 | ] |
---|
1036 | [encodingutil: argv and output encodings are always the same on all platforms. Lose the unnecessary generality of them being different. fixes #1120 |
---|
1037 | david-sarah@jacaranda.org**20110629185356 |
---|
1038 | Ignore-this: 5ebacbe6903dfa83ffd3ff8436a97787 |
---|
1039 | ] |
---|
1040 | [docs/man/tahoe.1: add man page. fixes #1420 |
---|
1041 | david-sarah@jacaranda.org**20110724171728 |
---|
1042 | Ignore-this: fc7601ec7f25494288d6141d0ae0004c |
---|
1043 | ] |
---|
1044 | [Update the dependency on zope.interface to fix an incompatiblity between Nevow and zope.interface 3.6.4. fixes #1435 |
---|
1045 | david-sarah@jacaranda.org**20110721234941 |
---|
1046 | Ignore-this: 2ff3fcfc030fca1a4d4c7f1fed0f2aa9 |
---|
1047 | ] |
---|
1048 | [frontends/ftpd.py: remove the check for IWriteFile.close since we're now guaranteed to be using Twisted >= 10.1 which has it. |
---|
1049 | david-sarah@jacaranda.org**20110722000320 |
---|
1050 | Ignore-this: 55cd558b791526113db3f83c00ec328a |
---|
1051 | ] |
---|
1052 | [Update the dependency on Twisted to >= 10.1. This allows us to simplify some documentation: it's no longer necessary to install pywin32 on Windows, or apply a patch to Twisted in order to use the FTP frontend. fixes #1274, #1438. refs #1429 |
---|
1053 | david-sarah@jacaranda.org**20110721233658 |
---|
1054 | Ignore-this: 81b41745477163c9b39c0b59db91cc62 |
---|
1055 | ] |
---|
1056 | [misc/build_helpers/run_trial.py: undo change to block pywin32 (it didn't work because run_trial.py is no longer used). refs #1334 |
---|
1057 | david-sarah@jacaranda.org**20110722035402 |
---|
1058 | Ignore-this: 5d03f544c4154f088e26c7107494bf39 |
---|
1059 | ] |
---|
1060 | [misc/build_helpers/run_trial.py: ensure that pywin32 is not on the sys.path when running the test suite. Includes some temporary debugging printouts that will be removed. refs #1334 |
---|
1061 | david-sarah@jacaranda.org**20110722024907 |
---|
1062 | Ignore-this: 5141a9f83a4085ed4ca21f0bbb20bb9c |
---|
1063 | ] |
---|
1064 | [docs/running.rst: use 'tahoe run ~/.tahoe' instead of 'tahoe run' (the default is the current directory, unlike 'tahoe start'). |
---|
1065 | david-sarah@jacaranda.org**20110718005949 |
---|
1066 | Ignore-this: 81837fbce073e93d88a3e7ae3122458c |
---|
1067 | ] |
---|
1068 | [docs/running.rst: say to put the introducer.furl in tahoe.cfg. |
---|
1069 | david-sarah@jacaranda.org**20110717194315 |
---|
1070 | Ignore-this: 954cc4c08e413e8c62685d58ff3e11f3 |
---|
1071 | ] |
---|
1072 | [README.txt: say that quickstart.rst is in the docs directory. |
---|
1073 | david-sarah@jacaranda.org**20110717192400 |
---|
1074 | Ignore-this: bc6d35a85c496b77dbef7570677ea42a |
---|
1075 | ] |
---|
1076 | [setup: remove the dependency on foolscap's "secure_connections" extra, add a dependency on pyOpenSSL |
---|
1077 | zooko@zooko.com**20110717114226 |
---|
1078 | Ignore-this: df222120d41447ce4102616921626c82 |
---|
1079 | fixes #1383 |
---|
1080 | ] |
---|
1081 | [test_sftp.py cleanup: remove a redundant definition of failUnlessReallyEqual. |
---|
1082 | david-sarah@jacaranda.org**20110716181813 |
---|
1083 | Ignore-this: 50113380b368c573f07ac6fe2eb1e97f |
---|
1084 | ] |
---|
1085 | [docs: add missing link in NEWS.rst |
---|
1086 | zooko@zooko.com**20110712153307 |
---|
1087 | Ignore-this: be7b7eb81c03700b739daa1027d72b35 |
---|
1088 | ] |
---|
1089 | [contrib: remove the contributed fuse modules and the entire contrib/ directory, which is now empty |
---|
1090 | zooko@zooko.com**20110712153229 |
---|
1091 | Ignore-this: 723c4f9e2211027c79d711715d972c5 |
---|
1092 | Also remove a couple of vestigial references to figleaf, which is long gone. |
---|
1093 | fixes #1409 (remove contrib/fuse) |
---|
1094 | ] |
---|
1095 | [add Protovis.js-based download-status timeline visualization |
---|
1096 | Brian Warner <warner@lothar.com>**20110629222606 |
---|
1097 | Ignore-this: 477ccef5c51b30e246f5b6e04ab4a127 |
---|
1098 | |
---|
1099 | provide status overlap info on the webapi t=json output, add decode/decrypt |
---|
1100 | rate tooltips, add zoomin/zoomout buttons |
---|
1101 | ] |
---|
1102 | [add more download-status data, fix tests |
---|
1103 | Brian Warner <warner@lothar.com>**20110629222555 |
---|
1104 | Ignore-this: e9e0b7e0163f1e95858aa646b9b17b8c |
---|
1105 | ] |
---|
1106 | [prepare for viz: improve DownloadStatus events |
---|
1107 | Brian Warner <warner@lothar.com>**20110629222542 |
---|
1108 | Ignore-this: 16d0bde6b734bb501aa6f1174b2b57be |
---|
1109 | |
---|
1110 | consolidate IDownloadStatusHandlingConsumer stuff into DownloadNode |
---|
1111 | ] |
---|
1112 | [docs: fix error in crypto specification that was noticed by Taylor R Campbell <campbell+tahoe@mumble.net> |
---|
1113 | zooko@zooko.com**20110629185711 |
---|
1114 | Ignore-this: b921ed60c1c8ba3c390737fbcbe47a67 |
---|
1115 | ] |
---|
1116 | [setup.py: don't make bin/tahoe.pyscript executable. fixes #1347 |
---|
1117 | david-sarah@jacaranda.org**20110130235809 |
---|
1118 | Ignore-this: 3454c8b5d9c2c77ace03de3ef2d9398a |
---|
1119 | ] |
---|
1120 | [Makefile: remove targets relating to 'setup.py check_auto_deps' which no longer exists. fixes #1345 |
---|
1121 | david-sarah@jacaranda.org**20110626054124 |
---|
1122 | Ignore-this: abb864427a1b91bd10d5132b4589fd90 |
---|
1123 | ] |
---|
1124 | [Makefile: add 'make check' as an alias for 'make test'. Also remove an unnecessary dependency of 'test' on 'build' and 'src/allmydata/_version.py'. fixes #1344 |
---|
1125 | david-sarah@jacaranda.org**20110623205528 |
---|
1126 | Ignore-this: c63e23146c39195de52fb17c7c49b2da |
---|
1127 | ] |
---|
1128 | [Rename test_package_initialization.py to (much shorter) test_import.py . |
---|
1129 | Brian Warner <warner@lothar.com>**20110611190234 |
---|
1130 | Ignore-this: 3eb3dbac73600eeff5cfa6b65d65822 |
---|
1131 | |
---|
1132 | The former name was making my 'ls' listings hard to read, by forcing them |
---|
1133 | down to just two columns. |
---|
1134 | ] |
---|
1135 | [tests: fix tests to accomodate [20110611153758-92b7f-0ba5e4726fb6318dac28fb762a6512a003f4c430] |
---|
1136 | zooko@zooko.com**20110611163741 |
---|
1137 | Ignore-this: 64073a5f39e7937e8e5e1314c1a302d1 |
---|
1138 | Apparently none of the two authors (stercor, terrell), three reviewers (warner, davidsarah, terrell), or one committer (me) actually ran the tests. This is presumably due to #20. |
---|
1139 | fixes #1412 |
---|
1140 | ] |
---|
1141 | [wui: right-align the size column in the WUI |
---|
1142 | zooko@zooko.com**20110611153758 |
---|
1143 | Ignore-this: 492bdaf4373c96f59f90581c7daf7cd7 |
---|
1144 | Thanks to Ted "stercor" Rolle Jr. and Terrell Russell. |
---|
1145 | fixes #1412 |
---|
1146 | ] |
---|
1147 | [docs: three minor fixes |
---|
1148 | zooko@zooko.com**20110610121656 |
---|
1149 | Ignore-this: fec96579eb95aceb2ad5fc01a814c8a2 |
---|
1150 | CREDITS for arc for stats tweak |
---|
1151 | fix link to .zip file in quickstart.rst (thanks to ChosenOne for noticing) |
---|
1152 | English usage tweak |
---|
1153 | ] |
---|
1154 | [docs/running.rst: fix stray HTML (not .rst) link noticed by ChosenOne. |
---|
1155 | david-sarah@jacaranda.org**20110609223719 |
---|
1156 | Ignore-this: fc50ac9c94792dcac6f1067df8ac0d4a |
---|
1157 | ] |
---|
1158 | [server.py: get_latencies now reports percentiles _only_ if there are sufficient observations for the interpretation of the percentile to be unambiguous. |
---|
1159 | wilcoxjg@gmail.com**20110527120135 |
---|
1160 | Ignore-this: 2e7029764bffc60e26f471d7c2b6611e |
---|
1161 | interfaces.py: modified the return type of RIStatsProvider.get_stats to allow for None as a return value |
---|
1162 | NEWS.rst, stats.py: documentation of change to get_latencies |
---|
1163 | stats.rst: now documents percentile modification in get_latencies |
---|
1164 | test_storage.py: test_latencies now expects None in output categories that contain too few samples for the associated percentile to be unambiguously reported. |
---|
1165 | fixes #1392 |
---|
1166 | ] |
---|
1167 | [docs: revert link in relnotes.txt from NEWS.rst to NEWS, since the former did not exist at revision 5000. |
---|
1168 | david-sarah@jacaranda.org**20110517011214 |
---|
1169 | Ignore-this: 6a5be6e70241e3ec0575641f64343df7 |
---|
1170 | ] |
---|
1171 | [docs: convert NEWS to NEWS.rst and change all references to it. |
---|
1172 | david-sarah@jacaranda.org**20110517010255 |
---|
1173 | Ignore-this: a820b93ea10577c77e9c8206dbfe770d |
---|
1174 | ] |
---|
1175 | [docs: remove out-of-date docs/testgrid/introducer.furl and containing directory. fixes #1404 |
---|
1176 | david-sarah@jacaranda.org**20110512140559 |
---|
1177 | Ignore-this: 784548fc5367fac5450df1c46890876d |
---|
1178 | ] |
---|
1179 | [scripts/common.py: don't assume that the default alias is always 'tahoe' (it is, but the API of get_alias doesn't say so). refs #1342 |
---|
1180 | david-sarah@jacaranda.org**20110130164923 |
---|
1181 | Ignore-this: a271e77ce81d84bb4c43645b891d92eb |
---|
1182 | ] |
---|
1183 | [setup: don't catch all Exception from check_requirement(), but only PackagingError and ImportError |
---|
1184 | zooko@zooko.com**20110128142006 |
---|
1185 | Ignore-this: 57d4bc9298b711e4bc9dc832c75295de |
---|
1186 | I noticed this because I had accidentally inserted a bug which caused AssertionError to be raised from check_requirement(). |
---|
1187 | ] |
---|
1188 | [M-x whitespace-cleanup |
---|
1189 | zooko@zooko.com**20110510193653 |
---|
1190 | Ignore-this: dea02f831298c0f65ad096960e7df5c7 |
---|
1191 | ] |
---|
1192 | [docs: fix typo in running.rst, thanks to arch_o_median |
---|
1193 | zooko@zooko.com**20110510193633 |
---|
1194 | Ignore-this: ca06de166a46abbc61140513918e79e8 |
---|
1195 | ] |
---|
1196 | [relnotes.txt: don't claim to work on Cygwin (which has been untested for some time). refs #1342 |
---|
1197 | david-sarah@jacaranda.org**20110204204902 |
---|
1198 | Ignore-this: 85ef118a48453d93fa4cddc32d65b25b |
---|
1199 | ] |
---|
1200 | [relnotes.txt: forseeable -> foreseeable. refs #1342 |
---|
1201 | david-sarah@jacaranda.org**20110204204116 |
---|
1202 | Ignore-this: 746debc4d82f4031ebf75ab4031b3a9 |
---|
1203 | ] |
---|
1204 | [replace remaining .html docs with .rst docs |
---|
1205 | zooko@zooko.com**20110510191650 |
---|
1206 | Ignore-this: d557d960a986d4ac8216d1677d236399 |
---|
1207 | Remove install.html (long since deprecated). |
---|
1208 | Also replace some obsolete references to install.html with references to quickstart.rst. |
---|
1209 | Fix some broken internal references within docs/historical/historical_known_issues.txt. |
---|
1210 | Thanks to Ravi Pinjala and Patrick McDonald. |
---|
1211 | refs #1227 |
---|
1212 | ] |
---|
1213 | [docs: FTP-and-SFTP.rst: fix a minor error and update the information about which version of Twisted fixes #1297 |
---|
1214 | zooko@zooko.com**20110428055232 |
---|
1215 | Ignore-this: b63cfb4ebdbe32fb3b5f885255db4d39 |
---|
1216 | ] |
---|
1217 | [munin tahoe_files plugin: fix incorrect file count |
---|
1218 | francois@ctrlaltdel.ch**20110428055312 |
---|
1219 | Ignore-this: 334ba49a0bbd93b4a7b06a25697aba34 |
---|
1220 | fixes #1391 |
---|
1221 | ] |
---|
1222 | [corrected "k must never be smaller than N" to "k must never be greater than N" |
---|
1223 | secorp@allmydata.org**20110425010308 |
---|
1224 | Ignore-this: 233129505d6c70860087f22541805eac |
---|
1225 | ] |
---|
1226 | [Fix a test failure in test_package_initialization on Python 2.4.x due to exceptions being stringified differently than in later versions of Python. refs #1389 |
---|
1227 | david-sarah@jacaranda.org**20110411190738 |
---|
1228 | Ignore-this: 7847d26bc117c328c679f08a7baee519 |
---|
1229 | ] |
---|
1230 | [tests: add test for including the ImportError message and traceback entry in the summary of errors from importing dependencies. refs #1389 |
---|
1231 | david-sarah@jacaranda.org**20110410155844 |
---|
1232 | Ignore-this: fbecdbeb0d06a0f875fe8d4030aabafa |
---|
1233 | ] |
---|
1234 | [allmydata/__init__.py: preserve the message and last traceback entry (file, line number, function, and source line) of ImportErrors in the package versions string. fixes #1389 |
---|
1235 | david-sarah@jacaranda.org**20110410155705 |
---|
1236 | Ignore-this: 2f87b8b327906cf8bfca9440a0904900 |
---|
1237 | ] |
---|
1238 | [remove unused variable detected by pyflakes |
---|
1239 | zooko@zooko.com**20110407172231 |
---|
1240 | Ignore-this: 7344652d5e0720af822070d91f03daf9 |
---|
1241 | ] |
---|
1242 | [allmydata/__init__.py: Nicer reporting of unparseable version numbers in dependencies. fixes #1388 |
---|
1243 | david-sarah@jacaranda.org**20110401202750 |
---|
1244 | Ignore-this: 9c6bd599259d2405e1caadbb3e0d8c7f |
---|
1245 | ] |
---|
1246 | [update FTP-and-SFTP.rst: the necessary patch is included in Twisted-10.1 |
---|
1247 | Brian Warner <warner@lothar.com>**20110325232511 |
---|
1248 | Ignore-this: d5307faa6900f143193bfbe14e0f01a |
---|
1249 | ] |
---|
1250 | [control.py: remove all uses of s.get_serverid() |
---|
1251 | warner@lothar.com**20110227011203 |
---|
1252 | Ignore-this: f80a787953bd7fa3d40e828bde00e855 |
---|
1253 | ] |
---|
1254 | [web: remove some uses of s.get_serverid(), not all |
---|
1255 | warner@lothar.com**20110227011159 |
---|
1256 | Ignore-this: a9347d9cf6436537a47edc6efde9f8be |
---|
1257 | ] |
---|
1258 | [immutable/downloader/fetcher.py: remove all get_serverid() calls |
---|
1259 | warner@lothar.com**20110227011156 |
---|
1260 | Ignore-this: fb5ef018ade1749348b546ec24f7f09a |
---|
1261 | ] |
---|
1262 | [immutable/downloader/fetcher.py: fix diversity bug in server-response handling |
---|
1263 | warner@lothar.com**20110227011153 |
---|
1264 | Ignore-this: bcd62232c9159371ae8a16ff63d22c1b |
---|
1265 | |
---|
1266 | When blocks terminate (either COMPLETE or CORRUPT/DEAD/BADSEGNUM), the |
---|
1267 | _shares_from_server dict was being popped incorrectly (using shnum as the |
---|
1268 | index instead of serverid). I'm still thinking through the consequences of |
---|
1269 | this bug. It was probably benign and really hard to detect. I think it would |
---|
1270 | cause us to incorrectly believe that we're pulling too many shares from a |
---|
1271 | server, and thus prefer a different server rather than asking for a second |
---|
1272 | share from the first server. The diversity code is intended to spread out the |
---|
1273 | number of shares simultaneously being requested from each server, but with |
---|
1274 | this bug, it might be spreading out the total number of shares requested at |
---|
1275 | all, not just simultaneously. (note that SegmentFetcher is scoped to a single |
---|
1276 | segment, so the effect doesn't last very long). |
---|
1277 | ] |
---|
1278 | [immutable/downloader/share.py: reduce get_serverid(), one left, update ext deps |
---|
1279 | warner@lothar.com**20110227011150 |
---|
1280 | Ignore-this: d8d56dd8e7b280792b40105e13664554 |
---|
1281 | |
---|
1282 | test_download.py: create+check MyShare instances better, make sure they share |
---|
1283 | Server objects, now that finder.py cares |
---|
1284 | ] |
---|
1285 | [immutable/downloader/finder.py: reduce use of get_serverid(), one left |
---|
1286 | warner@lothar.com**20110227011146 |
---|
1287 | Ignore-this: 5785be173b491ae8a78faf5142892020 |
---|
1288 | ] |
---|
1289 | [immutable/offloaded.py: reduce use of get_serverid() a bit more |
---|
1290 | warner@lothar.com**20110227011142 |
---|
1291 | Ignore-this: b48acc1b2ae1b311da7f3ba4ffba38f |
---|
1292 | ] |
---|
1293 | [immutable/upload.py: reduce use of get_serverid() |
---|
1294 | warner@lothar.com**20110227011138 |
---|
1295 | Ignore-this: ffdd7ff32bca890782119a6e9f1495f6 |
---|
1296 | ] |
---|
1297 | [immutable/checker.py: remove some uses of s.get_serverid(), not all |
---|
1298 | warner@lothar.com**20110227011134 |
---|
1299 | Ignore-this: e480a37efa9e94e8016d826c492f626e |
---|
1300 | ] |
---|
1301 | [add remaining get_* methods to storage_client.Server, NoNetworkServer, and |
---|
1302 | warner@lothar.com**20110227011132 |
---|
1303 | Ignore-this: 6078279ddf42b179996a4b53bee8c421 |
---|
1304 | MockIServer stubs |
---|
1305 | ] |
---|
1306 | [upload.py: rearrange _make_trackers a bit, no behavior changes |
---|
1307 | warner@lothar.com**20110227011128 |
---|
1308 | Ignore-this: 296d4819e2af452b107177aef6ebb40f |
---|
1309 | ] |
---|
1310 | [happinessutil.py: finally rename merge_peers to merge_servers |
---|
1311 | warner@lothar.com**20110227011124 |
---|
1312 | Ignore-this: c8cd381fea1dd888899cb71e4f86de6e |
---|
1313 | ] |
---|
1314 | [test_upload.py: factor out FakeServerTracker |
---|
1315 | warner@lothar.com**20110227011120 |
---|
1316 | Ignore-this: 6c182cba90e908221099472cc159325b |
---|
1317 | ] |
---|
1318 | [test_upload.py: server-vs-tracker cleanup |
---|
1319 | warner@lothar.com**20110227011115 |
---|
1320 | Ignore-this: 2915133be1a3ba456e8603885437e03 |
---|
1321 | ] |
---|
1322 | [happinessutil.py: server-vs-tracker cleanup |
---|
1323 | warner@lothar.com**20110227011111 |
---|
1324 | Ignore-this: b856c84033562d7d718cae7cb01085a9 |
---|
1325 | ] |
---|
1326 | [upload.py: more tracker-vs-server cleanup |
---|
1327 | warner@lothar.com**20110227011107 |
---|
1328 | Ignore-this: bb75ed2afef55e47c085b35def2de315 |
---|
1329 | ] |
---|
1330 | [upload.py: fix var names to avoid confusion between 'trackers' and 'servers' |
---|
1331 | warner@lothar.com**20110227011103 |
---|
1332 | Ignore-this: 5d5e3415b7d2732d92f42413c25d205d |
---|
1333 | ] |
---|
1334 | [refactor: s/peer/server/ in immutable/upload, happinessutil.py, test_upload |
---|
1335 | warner@lothar.com**20110227011100 |
---|
1336 | Ignore-this: 7ea858755cbe5896ac212a925840fe68 |
---|
1337 | |
---|
1338 | No behavioral changes, just updating variable/method names and log messages. |
---|
1339 | The effects outside these three files should be minimal: some exception |
---|
1340 | messages changed (to say "server" instead of "peer"), and some internal class |
---|
1341 | names were changed. A few things still use "peer" to minimize external |
---|
1342 | changes, like UploadResults.timings["peer_selection"] and |
---|
1343 | happinessutil.merge_peers, which can be changed later. |
---|
1344 | ] |
---|
1345 | [storage_client.py: clean up test_add_server/test_add_descriptor, remove .test_servers |
---|
1346 | warner@lothar.com**20110227011056 |
---|
1347 | Ignore-this: efad933e78179d3d5fdcd6d1ef2b19cc |
---|
1348 | ] |
---|
1349 | [test_client.py, upload.py:: remove KiB/MiB/etc constants, and other dead code |
---|
1350 | warner@lothar.com**20110227011051 |
---|
1351 | Ignore-this: dc83c5794c2afc4f81e592f689c0dc2d |
---|
1352 | ] |
---|
1353 | [test: increase timeout on a network test because Francois's ARM machine hit that timeout |
---|
1354 | zooko@zooko.com**20110317165909 |
---|
1355 | Ignore-this: 380c345cdcbd196268ca5b65664ac85b |
---|
1356 | I'm skeptical that the test was proceeding correctly but ran out of time. It seems more likely that it had gotten hung. But if we raise the timeout to an even more extravagant number then we can be even more certain that the test was never going to finish. |
---|
1357 | ] |
---|
1358 | [docs/configuration.rst: add a "Frontend Configuration" section |
---|
1359 | Brian Warner <warner@lothar.com>**20110222014323 |
---|
1360 | Ignore-this: 657018aa501fe4f0efef9851628444ca |
---|
1361 | |
---|
1362 | this points to docs/frontends/*.rst, which were previously underlinked |
---|
1363 | ] |
---|
1364 | [web/filenode.py: avoid calling req.finish() on closed HTTP connections. Closes #1366 |
---|
1365 | "Brian Warner <warner@lothar.com>"**20110221061544 |
---|
1366 | Ignore-this: 799d4de19933f2309b3c0c19a63bb888 |
---|
1367 | ] |
---|
1368 | [Add unit tests for cross_check_pkg_resources_versus_import, and a regression test for ref #1355. This requires a little refactoring to make it testable. |
---|
1369 | david-sarah@jacaranda.org**20110221015817 |
---|
1370 | Ignore-this: 51d181698f8c20d3aca58b057e9c475a |
---|
1371 | ] |
---|
1372 | [allmydata/__init__.py: .name was used in place of the correct .__name__ when printing an exception. Also, robustify string formatting by using %r instead of %s in some places. fixes #1355. |
---|
1373 | david-sarah@jacaranda.org**20110221020125 |
---|
1374 | Ignore-this: b0744ed58f161bf188e037bad077fc48 |
---|
1375 | ] |
---|
1376 | [Refactor StorageFarmBroker handling of servers |
---|
1377 | Brian Warner <warner@lothar.com>**20110221015804 |
---|
1378 | Ignore-this: 842144ed92f5717699b8f580eab32a51 |
---|
1379 | |
---|
1380 | Pass around IServer instance instead of (peerid, rref) tuple. Replace |
---|
1381 | "descriptor" with "server". Other replacements: |
---|
1382 | |
---|
1383 | get_all_servers -> get_connected_servers/get_known_servers |
---|
1384 | get_servers_for_index -> get_servers_for_psi (now returns IServers) |
---|
1385 | |
---|
1386 | This change still needs to be pushed further down: lots of code is now |
---|
1387 | getting the IServer and then distributing (peerid, rref) internally. |
---|
1388 | Instead, it ought to distribute the IServer internally and delay |
---|
1389 | extracting a serverid or rref until the last moment. |
---|
1390 | |
---|
1391 | no_network.py was updated to retain parallelism. |
---|
1392 | ] |
---|
1393 | [TAG allmydata-tahoe-1.8.2 |
---|
1394 | warner@lothar.com**20110131020101] |
---|
1395 | Patch bundle hash: |
---|
1396 | 5c631b3c7004fb3f10e5c4aa349ef0b20153920a |
---|