Ticket #1679: fix-1679.diff.txt

diff -rN -u old-1.9.2/src/allmydata/immutable/filenode.py new-1.9.2/src/allmydata/immutable/filenode.py
--- old-1.9.2/src/allmydata/immutable/filenode.py       2012-10-27 21:48:02.750754675 -0600
+++ new-1.9.2/src/allmydata/immutable/filenode.py       2012-10-27 21:48:02.944087254 -0600
@@ -22,6 +22,7 @@
 from allmydata.immutable.downloader.status import DownloadStatus
 
 class CiphertextFileNode:
+    # XXX should we make an ISomething interface for this? Maybe maybe IReadable subclass that ISomething?
     def __init__(self, verifycap, storage_broker, secret_holder,
                  terminator, history):
         assert isinstance(verifycap, uri.CHKFileVerifierURI)
@@ -87,6 +88,8 @@
     def raise_error(self):
         pass
 
+    def is_mutable(self):
+        return False
 
     def check_and_repair(self, monitor, verify=False, add_lease=False):
         verifycap = self._verifycap
diff -rN -u old-1.9.2/src/allmydata/nodemaker.py new-1.9.2/src/allmydata/nodemaker.py
--- old-1.9.2/src/allmydata/nodemaker.py        2012-10-27 21:48:02.774087918 -0600
+++ new-1.9.2/src/allmydata/nodemaker.py        2012-10-27 21:48:02.940753934 -0600
@@ -72,12 +72,12 @@
             cap = uri.from_string(bigcap, deep_immutable=deep_immutable,
                                   name=name)
             node = self._create_from_single_cap(cap)
-            if node:
-                self._node_cache[memokey] = node  # note: WeakValueDictionary
-            else:
+            if node is None:
                 # don't cache UnknownNode
                 node = UnknownNode(writecap, readcap,
                                    deep_immutable=deep_immutable, name=name)
+            elif node.is_mutable():
+                self._node_cache[memokey] = node  # note: WeakValueDictionary
 
         if self.blacklist:
             si = node.get_storage_index()