Ticket #1688: fix_ftpd_mtime.dpatch

File fix_ftpd_mtime.dpatch, 83.7 KB (added by lebek, at 2012-03-21T14:00:24Z)
Line 
11 patch for repository https://tahoe-lafs.org/source/tahoe-lafs/trunk:
2
3Wed Mar 21 13:48:18 GMT 2012  Peter Le Bek <peter@hyperplex.net>
4  * fix ftpd mtime retrieval
5
6New patches:
7
8[fix ftpd mtime retrieval
9Peter Le Bek <peter@hyperplex.net>**20120321134818
10 Ignore-this: cc7a40f475ff5277121c6149dd6dd220
11] hunk ./src/allmydata/frontends/ftpd.py 204
12             elif key == "hardlinks":
13                 value = 1
14             elif key == "modified":
15-                value = metadata.get("mtime", 0)
16+                if "linkmotime" in metadata.get("tahoe", {}):
17+                    value = metadata["tahoe"]["linkmotime"]
18+                else:
19+                    value = metadata.get("mtime", 0)
20             elif key == "owner":
21                 value = self.username
22             elif key == "group":
23
24Context:
25
26[Fix mutable status (mapupdate/retrieve/publish) to use serverids, not tubids
27Brian Warner <warner@lothar.com>**20120318000135
28 Ignore-this: 79354457b77fe2d8534fc0b792b6eb0c
29 
30 This still leaves immutable-publish results incorrectly using tubids instead
31 of serverids. That will need some more work, since it might change the Helper
32 interface.
33] 
34[IServer.get_name(): remove v0- prefix from displayed server names
35Brian Warner <warner@lothar.com>**20120318000135
36 Ignore-this: f3dc25be3ecca5935a4320ca53b70cad
37 
38 Don't remove the prefix if it isn't there: that avoids the need to fix tests
39 which use a bogus key (usually all-zeros).
40] 
41[Fix a missing comma in the last patch. refs #1295
42david-sarah@jacaranda.org**20120314235040
43 Ignore-this: 34327ffeabed65759ad511760f925e47
44] 
45[Temporarily suppress the DeprecationWarning about IFinishableConsumer; it's irritating, but not in a way that is likely to make me fix the underlying issue (#1525) any sooner :-). refs #1295
46david-sarah@jacaranda.org**20120314234729
47 Ignore-this: 2ab43c7893ed305a9d40023ec176d179
48] 
49[minor: hush pyflakes, move pycryptopp dep to unconditional section
50Brian Warner <warner@lothar.com>**20120314062035
51 Ignore-this: 786fae44ad106c7924f8c9644ee0e48d
52 
53 Also change Makefile's "pyflakes" rule to emit less output, so buildbot will
54 count errors properly.
55] 
56[Update find_links URLs in setup.cfg to https://tahoe-lafs.org. This is not just a doc change; look out for compatibility problems.
57david-sarah@jacaranda.org**20120313203041
58 Ignore-this: fd18113695c2a524972c389e8b52e2e8
59] 
60[Minor updates to URLs.
61david-sarah@jacaranda.org**20120313202853
62 Ignore-this: 2e5719e8cf19d7be73fbcba98dc1e5dd
63] 
64[Update more links from http: to https: in documentation and comments.
65david-sarah@jacaranda.org**20120313202654
66 Ignore-this: 2c11cef35639b101412c024896256529
67] 
68[new introducer: signed extensible dictionary-based messages! refs #466
69Brian Warner <warner@lothar.com>**20120314012432
70 Ignore-this: e87de488a26c11711cf6978c9fb1175c
71 
72 This introduces new client and server halves to the Introducer (renaming the
73 old one with a _V1 suffix). Both have fallbacks to accomodate talking to a
74 different version: the publishing client switches on whether the server's
75 .get_version() advertises V2 support, the server switches on which
76 subscription method was invoked by the subscribing client.
77 
78 The V2 protocol sends a three-tuple of (serialized announcement dictionary,
79 signature, pubkey) for each announcement. The V2 server dispatches messages
80 to subscribers according to the service-name, and throws errors for invalid
81 signatures, but does not otherwise examine the messages. The V2 receiver's
82 subscription callback will receive a (serverid, ann_dict) pair. The
83 'serverid' will be equal to the pubkey if all of the following are true:
84 
85   the originating client is V2, and was told a privkey to use
86   the announcement went through a V2 server
87   the signature is valid
88 
89 If not, 'serverid' will be equal to the tubid portion of the announced FURL,
90 as was the case for V1 receivers.
91 
92 Servers will create a keypair if one does not exist yet, stored in
93 private/server.privkey .
94 
95 The signed announcement dictionary puts the server FURL in a key named
96 "anonymous-storage-FURL", which anticipates upcoming Accounting-related
97 changes in the server advertisements. It also provides a key named
98 "permutation-seed-base32" to tell clients what permutation seed to use. This
99 is computed at startup, using tubid if there are existing shares, otherwise
100 the pubkey, to retain share-order compatibility for existing servers.
101] 
102['tahoe admin generate-keypair/derive-pubkey': add Ed25519 keypair commands
103Brian Warner <warner@lothar.com>**20120314012432
104 Ignore-this: 6dff9c61d97f746de338027b72cf1912
105 
106 Also add parse_privkey/parse_pubkey tools to util.keyutil
107] 
108[bump pycryptopp dependency to >=0.6.0, to get ed25519 signatures
109Brian Warner <warner@lothar.com>**20120314012432
110 Ignore-this: 6c1cf12a30567880ab2cc53c4282be11
111 
112 This is for the upcoming #466 signed-introducer code.
113] 
114[Update copyright notices. refs #1686
115david-sarah@jacaranda.org**20120313205057
116 Ignore-this: a6a4904001412248c4164f002b52f79a
117] 
118[Make the link on the Welcome page to 'https://tahoe-lafs.org/', not 'http:'. Includes a test. fixes #1682
119david-sarah@jacaranda.org**20120308231758
120 Ignore-this: b639c3da453b95ee7edca8090ea1b9aa
121] 
122[Update various references to allmydata.org or http://tahoe-lafs.org in comments, to https://tahoe-lafs.org. refs #1682
123david-sarah@jacaranda.org**20120308231719
124 Ignore-this: a71d00ea46af0a44e5c957df56d02adf
125] 
126[Suppress a warning from win32eventreactor on Windows (patch v2). fixes #1681
127david-sarah@jacaranda.org**20120227190317
128 Ignore-this: c7efe1065d45a00caf182a1de812f4bb
129] 
130[Add nickname/nodeid to storage-status web page. Closes #1204.
131Brian Warner <warner@lothar.com>**20120313025736
132 Ignore-this: 78e533e06c390221edd66c45ec96e34a
133 
134 Also add tahoe.css to the page, to make it look slightly prettier.
135] 
136[add some quick tests of the introducer/web improvements
137Brian Warner <warner@lothar.com>**20120312193536
138 Ignore-this: 9e31f368b1dfa586ab6e3f17707d9ec
139] 
140[introducer web page: add CSS styling, roughly match client Welcome page
141Brian Warner <warner@lothar.com>**20120307022505
142 Ignore-this: bfc450f394578a3463f31acc1019862
143 
144 Also add /static and the top-level /tahoe.css -type stuff to the introducer's
145 web server.
146] 
147[tahoe.css: fix #section typo, update welcome.xhtml to match
148Brian Warner <warner@lothar.com>**20120307022241
149 Ignore-this: 4e8a8382234aad017b093f8896b329d6
150 
151 The "#section" declaration (which matches id="section") should have been
152 ".section" (which matches class="section").
153 
154 The welcome page has a feature that I actually liked: the little "This
155 Client" sidebar sits just to the right of the start of the Controls block.
156 Fixing .section broke that (the clear:both introduces a gap, forcing the
157 Controls block to start strictly below the bottom of the This Client block).
158 So I also removed class="section" from the Controls block to allow them to
159 share the horizontal space again.
160] 
161[make provisioning/reliability work in the new location, fix tests
162Brian Warner <warner@lothar.com>**20120216222905
163 Ignore-this: 8a2923a54ca224fe69fe404e819aaaac
164] 
165[remove 'provisioning'/'reliability' from WUI, add to misc/operations_helpers
166Brian Warner <warner@lothar.com>**20120216222905
167 Ignore-this: 4090c8ac99f139393d9573b65cbbfe0c
168 
169 Also remove docs related to reliability/provisioning pages
170] 
171[provisioning.py: update disk sizes and usage numbers
172Brian Warner <warner@lothar.com>**20120213155708
173 Ignore-this: e47ee282bfba4beb2598b227add5250a
174] 
175[configuration.rst: another attempt to fix formatting of sample tahoe.cfg.
176david-sarah@jacaranda.org**20120131000949
177 Ignore-this: bb67b6c9bb191a1335eaadfe9594fa4f
178] 
179[configuration.rst: remove the obsolete sizelimit option from the sample tahoe.cfg. Also fix the RST formatting of blank lines in the file.
180david-sarah@jacaranda.org**20120131000643
181 Ignore-this: 9c5327edf031d8578c19383d950b17b9
182] 
183[Add a Python 3 blocker to setup.py, to display a better error message when it is run under Python 3.
184david-sarah@jacaranda.org**20120127015525
185 Ignore-this: 5f032794ecc8cd6c512a7ab9efffed2
186] 
187[Ensure that verification proceeds and stops when appropriate.
188Brian Warner <warner@lothar.com>**20120124205209
189 Ignore-this: 88278bbd6a3b33cf3b286feaa162ad02
190 
191 The removed assertions are appropriate for a download that seeks to
192 return plaintext to a caller; if we don't have at least k active remote
193 shares, then we can't hope to do that. They're not appropriate for a
194 verification operation; a user can try to verify a file that has fewer
195 than k shares available, so that shouldn't be treated as an error.
196 Instead, we proceed with fewer than k shares, and ensure that we
197 terminate the download if we have no shares at all and we're verifying.
198] 
199[Add test_verify_mdmf_all_bad_sharedata
200Brian Warner <warner@lothar.com>**20120124205209
201 Ignore-this: 52acb4f0256af764acb038f7c8344367
202 
203 test_verify_mdmf_all_bad_sharedata tests for the regression described
204 in ticket 1648. In particular, it will trigger the misplaced assertion
205 in the share activation code. It also tests to make sure that
206 verification continues with fewer than k shares.
207] 
208[Added clarification on how interface= works
209Brian Warner <warner@lothar.com>**20120124203821
210 Ignore-this: 57f86d178c8e4f3c62d15bf99dec7d0d
211] 
212[FTP-and-SFTP.rst: minor edits
213Brian Warner <warner@lothar.com>**20120124203654
214 Ignore-this: ec21fadb85cf7b3192d32b02c03c3656
215] 
216[Updated accounts.url directive per warner's suggestions
217Brian Warner <warner@lothar.com>**20120124203126
218 Ignore-this: 9297ec6406e11d4e1fe24ba3a06725e3
219] 
220[Added information on accounts.url directive
221Brian Warner <warner@lothar.com>**20120124203126
222 Ignore-this: 6d6142418eabdad789a2fc68f26b3ba1
223] 
224[docs: an extra newline to separate utf-8 BOF from comment for the sake of trac's rst renderer
225zooko@zooko.com**20120122212002
226 Ignore-this: 5c6d0dbfa1430681fa00494937537956
227] 
228[docs: a newline between the utf-8 BOF and the comment in order to prevent trac from misrendering the comment
229zooko@zooko.com**20120122211856
230 Ignore-this: 5e92cb88ba46b82227338522b834b90d
231 sheesh
232] 
233[docs: a comment to inform the (human) reader about encoding and to prevent someone from moving the title up to where it will interact with the utf-8 BOM and cause trac to mis-render the title
234zooko@zooko.com**20120122211731
235 Ignore-this: f7912a13ffba60408ec901a9586ce8a4
236] 
237[docs: insert another newline between utf-8 BOF and title
238zooko@zooko.com**20120122211427
239 Ignore-this: 1b3861ef7d4531acfa61fac31e14fe98
240] 
241[docs: insert newline after utf-8 BOF and before restructuredtext title
242zooko@zooko.com**20120122182127
243 Ignore-this: f947afe5bdfc9f44ba9bf7f0e585da7c
244] 
245[docs: remove utf-8 "BOM" which confuses trac's rst renderer
246zooko@zooko.com**20120122140052
247 Ignore-this: ba58c59a314f23c65de5443bd7b6ffcb
248] 
249[docs: try again to change RestructuredText titles to a format that trac will render
250zooko@zooko.com**20120122135613
251 Ignore-this: 588bbb627a95cd8317c809567cfa3e78
252] 
253[docs: backdoors.rst: fix title formatting
254zooko@zooko.com**20120122135125
255 Ignore-this: 5bf980c1a8703ee353cd747ae343176a
256] 
257[docs: backdoors.rst: stop using embedded URIs and tweak title so that trac will render it correctly; reflow to fill-column 77; M-x whitespace-cleanup
258zooko@zooko.com**20120122134319
259 Ignore-this: e1b5b3d2809040cfd7f13bb88ee8313d
260] 
261[update release process: git, not darcs, etc
262Brian Warner <warner@lothar.com>**20120113071257
263 Ignore-this: 2eaa1f0e93dc545989bb1e62b2446e1e
264] 
265[prepare to Org-ify how_to_make_a_tahoe-lafs_release: rename the file
266Brian Warner <warner@lothar.com>**20120113070153
267 Ignore-this: d9bb83dfd6c3b4c0ca0efd2adacdf63c
268] 
269[.gitignore: ignore generated test-coverage files too
270Brian Warner <warner@lothar.com>**20120113065629
271 Ignore-this: 4411c7d620f5865b8c4dedef7e5a8c33
272] 
273[merge relnotes, quickstart.rst from 1.9.1 release
274Brian Warner <warner@lothar.com>**20120112232420
275 Ignore-this: 6b535bb1a3bd5ea87ee12cc6b17eeb5c
276] 
277[retrieve.py: unconditionally check share-hash-tree. Fixes #1654.
278Brian Warner <warner@lothar.com>**20120112213553
279 Ignore-this: 7ddc903a382b52bc014262b3b4099165
280 
281 Add Kevan's unit test, update known_issues.rst
282] 
283[.gitignore: also ignore tahoe-deps and .tgz, to fix 'make tarballs'
284Brian Warner <warner@lothar.com>**20120112210925
285 Ignore-this: e8a7d942f123ee6bf4f2966ddc2742a3
286 
287 Otherwise, the get-version-from-git code thinks the tree is dirty, and
288 creates SUMO tarballs with -dirty in the name.
289] 
290[Makefile: fix 'make-version' to use git-or-darcs, not just darcs
291Brian Warner <warner@lothar.com>**20120112210654
292 Ignore-this: ae32660458b5ab036ab98f0d1cf4e414
293] 
294[_auto_deps.py: don't allow pycrypto 2.0.1. fixes #1631
295david-sarah@jacaranda.org**20120110195758
296 Ignore-this: de409a745c93a78b095dc72edd13a15d
297] 
298[MANIFEST.in: make git-based 'setup.py sdist' match darcs
299Brian Warner <warner@lothar.com>**20120109234637
300 Ignore-this: 92bf7d679e9d5696994efe39c40ae216
301 
302 Previously, tarballs generated from a git tree were lacking a lot of
303 important non-code files, like docs/
304] 
305[restore .gitignore, stop .darcs-boringfile it
306warner@lothar.com**20120109025243
307 Ignore-this: b37efcdab8662fe85660d68e3662b4b9
308] 
309[remove setuptools_darcs.egg
310warner@lothar.com**20120108225545
311 Ignore-this: 39711cf7a9856acd5a136038d58ca5ff
312] 
313[fix bundled data under git, remove setuptools_darcs
314Brian Warner <warner@lothar.com>**20120108221250
315 Ignore-this: ebfc0b267961523edd7e26c761b2554f
316 
317 This uses explicitly enumerated packages= and package_data= arguments to
318 setup(), rather than relying upon the convenient (but darcs-specific)
319 functions which would determine these values by asking the revision-control
320 system.
321 
322 Note that darcsver is still used, when building from a darcs tree.
323] 
324[mutable/retrieve.py: clean up control flow to avoid dropping errors
325Brian Warner <warner@lothar.com>**20120108221248
326 Ignore-this: 4e991bdf6399439d2cee3d743814a327
327 
328 * replace DeferredList with gatherResults, simplify result handling
329 * use BadShareError to signal recoverable problems in either fetch or
330   validate, catch after _validate_block
331 * _validate_block is thus not responsible for noticing fetch problems
332 * rename _validation_or_decoding_failed() to _handle_bad_share()
333 * _get_needed_hashes() returns two Deferreds, instead of a hard-to-unpack
334   DeferredList
335] 
336[mutable/layout.py: raise BadShareError instead of assert()
337Brian Warner <warner@lothar.com>**20120108221247
338 Ignore-this: 129891a807315f657b80576025135df8
339] 
340[mutable: don't tell server about corruption unless it's really CorruptShareError
341Brian Warner <warner@lothar.com>**20120108221245
342 Ignore-this: 90da01af1008477c45d333a0f74f1c5b
343] 
344[mutable: simplify Retrieve._process_segment() to use a gatherDeferred
345Brian Warner <warner@lothar.com>**20120108221244
346 Ignore-this: cfc7a56414889d02bffd747f1abad8ef
347] 
348[Retrieve.decode(): simplify setup of DeferredList-like argument
349Brian Warner <warner@lothar.com>**20120108221240
350 Ignore-this: c92d377bf4d65251240e59c8db5452af
351 
352 make it more obviously match the expectations of _decode_blocks() and
353 _maybe_decode_and_decrypt_segment()
354] 
355[mutable: add comments about the tricky DeferredList structures in retrieve
356Brian Warner <warner@lothar.com>**20120108221238
357 Ignore-this: da47db692fbdf11a3ce01a952a60d1a0
358] 
359[add test-git-ignore.py, to port the 'clean' buildbot test to git
360Brian Warner <warner@lothar.com>**20120108221232
361 Ignore-this: 442efa1eacc27b7ae2690645ed997894
362 
363 add .gitignore to match .darcs-boringfile, mostly
364] 
365[Use a private/drop_upload_dircap file instead of the [drop_upload]upload.dircap option in tahoe.cfg. Fail if the upload.dircap option is used, or options are missing. Also updates tests and docs. fixes #1593
366david-sarah@jacaranda.org**20111120232426
367 Ignore-this: d4ea9154e98902c5de055b6de23c48f9
368] 
369[test_mutable: don't use 75 shares (slow), now that the bug is fixed
370Brian Warner <warner@lothar.com>**20111228223819
371 Ignore-this: 930f1a24ebe9ed2ab25e4b2a16e36352
372 
373 I missed this part of Kevan's fix-1628.darcs.2.patch .
374] 
375[mutable publish: fix not-enough-shares detection. Refs #1628.
376Brian Warner <warner@lothar.com>**20111228055018
377 Ignore-this: 23db08d8d630268e208e1755509adf92
378 
379 This should match the "fix-1628.darcs.2.patch" attachment on that ticket.
380] 
381[mutable publish: track multiple servers-per-share. Fixes some of #1628.
382Brian Warner <warner@lothar.com>**20111228053358
383 Ignore-this: 6e8cb92e70273b81098f73ebf23164bd
384 
385 The remaining work is to write additional tests.
386 
387 src/allmydata/test/no_network.py:
388 
389  This supports tests in which servers leave the grid only to return with
390  their shares intact at a later time.
391 
392 src/allmydata/test/test_mutable.py:
393 
394  The UCWEs in the incident reports associated with #1628 all seem to be
395  associated with shares that the servermap knows about, but which aren't
396  accounted for during the publish process for whatever reason. Specifically,
397  it looks like the publisher is only capable of keeping track of a single
398  storage server for a given share. This makes the repair process worse than
399  it was pre-MDMF at updating all of the shares of a particular file to the
400  newest version, and can also cause spurious UCWEs. This test simulates such
401  a layout and fails if an UCWE is thrown. We need to write another test to
402  ensure that all copies of a share are updated to the latest version (or
403  alter this test to do that), so that the test suite doesn't pass unless both
404  regressions are fixed.
405 
406  We want the publisher to follow the existing share placement when uploading
407  a new version of a mutable file, and we don't want this test to pass unless
408  it does.
409 
410 src/allmydata/mutable/publish.py:
411 
412  Before this commit, the publisher only kept track of a single writer for
413  each share. This is insufficient to handle updates in which a single share
414  may live on multiple servers. In the best case, an update will only update
415  one of the existing shares instead of all of them. In some cases, the update
416  will encounter the existing shares when publishing some other share,
417  interpret it as a sign of an uncoordinated update, and fail. Keeping track
418  of all of the writers helps ensure that all existing shares are updated, and
419  helps avoid spurious uncoordinated write errors.
420] 
421[docs: how_to_make_a_tahoe-lafs_release.rst add Google+ page to publicity list, change to cute unicode checkboxes
422zooko@zooko.com**20111226151905
423 Ignore-this: c7c1e67761df48fa11c0dad1847c2d8
424] 
425[doc: about.rst: use unicode emdash, use non-embedded URIs, add clarificaiton of when a file gets its mutable-or-immutable nature
426zooko@zooko.com**20111206171908
427 Ignore-this: 61bc3f1582c68dcc9867da964fc9bb3a
428 embedded URIs, although documented here:
429 http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#embedded-uris
430 generate messages like this from rst2html --verbose:
431 
432 quickstart.rst:3: (INFO/1) Duplicate explicit target name: "the tahoe-dev mailing list".
433 
434 Also this patch prepends a "utf-8 BOM" to the beginning of the file.
435] 
436[minor cleanup: remove trailing spaces in misc/
437Brian Warner <warner@lothar.com>**20111218201841
438 Ignore-this: 69a8904c17d8fd930442d00e24b7b188
439] 
440[Tests for ref #1592.
441david-sarah@jacaranda.org**20111217043130
442 Ignore-this: a6713500ebe2d686581c6743b8a88f60
443] 
444[test_web.py cleanup: use failUnlessIn/failIfIn in preference to 'in' operator.
445david-sarah@jacaranda.org**20111217042710
446 Ignore-this: c351f4b1d162eca545ba657dc3c70c19
447] 
448[Marcus Wanner's favicon patch. fixes #1592
449david-sarah@jacaranda.org**20111217033201
450 Ignore-this: 3528c920379fe0d157441dafe9a7c5a8
451] 
452[setup.py: stop putting pyutil.version_class/etc in _version.py
453Brian Warner <warner@lothar.com>**20111205055049
454 Ignore-this: 926fa9a8a34a04f24ee6e006423e9c1
455 
456 allmydata.__version__ can just be a string, it doesn't need to be an instance
457 of some fancy NormalizedVersion class. Everything inside Tahoe uses
458 str(__version__) anyways.
459 
460 Also add .dev0 when a git tree is dirty.
461 
462 Closes #1466
463] 
464[setup.py: get version from git or darcs
465Brian Warner <warner@lothar.com>**20111205044001
466 Ignore-this: 5a406b33000446d85edc722298391220
467 
468 This replaces the setup.cfg aliases that run "darcsver" before each major
469 command with the new "update_version". update_version is defined in setup.py,
470 and tries to get a version string from either darcs or git (or leaves the
471 existing _version.py alone if neither VC metadata is available).
472 
473 Also clean up a tiny typo in verlib.py that messed up syntax hilighting.
474] 
475[docs/known_issues.rst: describe when the unauthorized access attack is known to be possible, and fix a link.
476david-sarah@jacaranda.org**20111118002013
477 Ignore-this: d89b1f1040a0a7ee0bde893d23612049
478] 
479[more tiny buildbot-testing whitespace changes
480warner@lothar.com**20111118002041
481 Ignore-this: e816e2a5ab939e2f7a89ef12b8a157d8
482] 
483[more tiny buildbot-testing whitespace changes
484warner@lothar.com**20111118001828
485 Ignore-this: 57bb52cba83ea9a19728ba0a8ffadb69
486] 
487[tiny change to exercise the buildbot hook
488warner@lothar.com**20111118001511
489 Ignore-this: 7220b7790b39f19f9721d9e93b755030
490] 
491[Strengthen description of unauthorized access attack in known_issues.rst.
492david-sarah@jacaranda.org**20111118000030
493 Ignore-this: e2f68f621fe666b6201542623aa4d182
494] 
495[remove remaining uses of nevow's "formless" module
496Brian Warner <warner@lothar.com>**20111117225423
497 Ignore-this: a128dea91a1c63b3bbefa34729344d69
498 
499 We're slowly moving away from Nevow, and marcusw's previous patch removed
500 uses of the formless CSS file, so now we can stop testing that nevow can find
501 that file, and remove the lingering unused "import formless" call.
502] 
503[1585-webui.darcs.patch
504Marcus Wanner <marcus@wanners.net>**20111117214923
505 Ignore-this: 23cf2a06c545be5f821c071d652178ee
506] 
507[Remove duplicate tahoe_css links from manifest.xhtml and rename-form.xhtml
508Brian Warner <warner@lothar.com>**20111116224225
509 Ignore-this: 12024fff17964607799928928b9aadf3
510 
511 They were probably meant to be links to webform_css, but we aren't really
512 using Nevow's form-generation code anyways, so they can just be removed.
513 Thanks to 'marcusw' for the catch.
514] 
515[iputil: handle openbsd5 (just like openbsd4)
516Brian Warner <warner@lothar.com>**20111115220423
517 Ignore-this: 64b28bd2fd06eb5230ea41d91540dd05
518 
519 Patch by 'sickness'. Closes #1584
520] 
521[Makefile count-lines: let it work on OS-X (-l not --lines), add XXX
522Brian Warner <warner@lothar.com>**20111109184227
523 Ignore-this: 204ace1dadc9ed27543c62965b4e6757
524 
525 OS-X's simple-minded /usr/bin/wc doesn't understand --lines, but everyone
526 understands -l .
527] 
528[setup.py: umask=022 for 'sdist', to avoid depending on environment
529Brian Warner <warner@lothar.com>**20111109183632
530 Ignore-this: acd5db88ba8f1972d618b14f9e5b803c
531 
532 The new tarball-building buildslave had a bogus umask set, causing the 1.9.0
533 tarballs to be non-other-user-readable (go-rwx), which is a hassle for
534 packaging. (The umask was correct on the old buildslave, but it was moved to
535 a new host shortly before the release). This should make sure tarballs are
536 correct despite the host's setting.
537 
538 Note to others: processes run under twistd get umask=077 unless you arrange
539 otherwise.
540] 
541[_auto_deps.py: blacklist PyCrypto 2.4.
542david-sarah@jacaranda.org**20111105022457
543 Ignore-this: 876cb24bc71589e735f48bf449cad81e
544] 
545[check-miscaptures.py: report the number of files that were not analysed due to syntax errors (and don't count them in the number of suspicious captures). refs #1555
546david-sarah@jacaranda.org**20111009050301
547 Ignore-this: 62ee03f4b8a96c292e75c097ad87d52e
548] 
549[check-miscaptures.py: handle corner cases around default arguments correctly. Also make a minor optimization when there are no assigned variables to consider. refs #1555
550david-sarah@jacaranda.org**20111009045023
551 Ignore-this: f49ece515620081da1d745ae6da19d21
552] 
553[check-miscaptures.py: Python doesn't really have declarations; report the topmost assignment. refs #1555
554david-sarah@jacaranda.org**20111009044800
555 Ignore-this: 4905c9dfe7726f433333e216a6760a4b
556] 
557[check-miscaptures.py: handle destructuring function arguments correctly. refs #1555
558david-sarah@jacaranda.org**20111009044710
559 Ignore-this: f9de7d95e94446507a206c88d3f98a23
560] 
561[check-miscaptures.py: check while loops and list comprehensions as well as for loops. Also fix a pyflakes warning. refs #1555
562david-sarah@jacaranda.org**20111009044022
563 Ignore-this: 6526e4e315ca6461b1fbc2da5568e444
564] 
565[Add misc/coding_tools/check-miscaptures.py to detect incorrect captures of variables declared in a for loop, and a 'make check-miscaptures' Makefile target to run it. (It is also run by 'make code-checks'.) This is a rewritten version that reports much fewer false positives, by determining captured variables more accurately. fixes #1555
566david-sarah@jacaranda.org**20111007074121
567 Ignore-this: 51318e9678d132c374ea557ab955e79e
568] 
569[Fix pyflakes warnings in misc/ directories other than misc/build_helpers. refs #1557
570david-sarah@jacaranda.org**20111007033031
571 Ignore-this: 7daf5862469732d8cabc355266622b74
572] 
573[Makefile: include misc/ directories other than misc/build_helpers in SOURCES. refs #1557
574david-sarah@jacaranda.org**20111007032958
575 Ignore-this: 31376ec01401df7972e83341dc65aa05
576] 
577[show-tool-versions: tolerate missing setuptools
578Brian Warner <warner@lothar.com>**20111101080010
579 Ignore-this: 72d4e440565273992beb4f010cbca699
580] 
581[show-tool-versions.py: condense output, hide file-not-found exceptions
582Brian Warner <warner@lothar.com>**20111101074532
583 Ignore-this: a15381a76077ef46a74a4ac40c9ae956
584] 
585[relnotes.txt: fix footnotes
586Brian Warner <warner@lothar.com>**20111101071935
587 Ignore-this: 668c1bd8618e21beed9bc6b23f048189
588] 
589[Rewrite download-status-timeline visualizer ('viz') with d3.js
590Brian Warner <warner@lothar.com>**20111101061821
591 Ignore-this: 6149b027bbae52c559ef5a8167240cab
592 
593 * use d3.js v2.4.6
594 * add a "toggle misc events" button, to get hash/bitmap-checking details
595 * only draw data that's on screen, for speed
596 * add fragment-arg to fetch timeline data.json from somewhere else
597] 
598[IServer refactoring: pass IServer instances around, instead of peerids
599Brian Warner <warner@lothar.com>**20111101040319
600 Ignore-this: 35e4698a0273a0311fe0ccedcc7881b5
601 
602 refs #1363
603 
604 This collapses 88 small incremental changes (each of which passes all tests)
605 into one big patch. The development process for the long path started with
606 adding some temporary scaffolding, changing one method at a time, then
607 removing the scaffolding. The individual pieces are as follows, in reverse
608 chronological order (the first patch is at the end of this comment):
609 
610  commit 9bbe4174fd0d98a6cf47a8ef96e85d9ef34b2f9a
611  Author: Brian Warner <warner@lothar.com>
612  Date:   Tue Oct 4 16:05:00 2011 -0400
613 
614      immutable/downloader/status.py: correct comment
615 
616   src/allmydata/immutable/downloader/status.py |    2 +-
617   1 files changed, 1 insertions(+), 1 deletions(-)
618 
619  commit 72146a7c7c91eac2f7c3ceb801eb7a1721376889
620  Author: Brian Warner <warner@lothar.com>
621  Date:   Tue Oct 4 15:46:20 2011 -0400
622 
623      remove temporary ServerMap._storage_broker
624 
625   src/allmydata/mutable/checker.py   |    2 +-
626   src/allmydata/mutable/filenode.py  |    2 +-
627   src/allmydata/mutable/publish.py   |    2 +-
628   src/allmydata/mutable/servermap.py |    5 ++---
629   src/allmydata/test/test_mutable.py |    8 ++++----
630   5 files changed, 9 insertions(+), 10 deletions(-)
631 
632  commit d703096b41632c47d76414b12672e076a422ff5c
633  Author: Brian Warner <warner@lothar.com>
634  Date:   Tue Oct 4 15:37:05 2011 -0400
635 
636      remove temporary storage_broker.get_server_for_id()
637 
638   src/allmydata/storage_client.py  |    3 ---
639   src/allmydata/test/no_network.py |   13 -------------
640   2 files changed, 0 insertions(+), 16 deletions(-)
641 
642  commit 620cc5d80882ef6f7decfd26af8a6c7c1ddf80d1
643  Author: Brian Warner <warner@lothar.com>
644  Date:   Tue Oct 4 12:50:06 2011 -0400
645 
646      API of Retrieve._try_to_validate_privkey(), trying to remove reader.server
647 
648   src/allmydata/mutable/retrieve.py |   10 +++++-----
649   1 files changed, 5 insertions(+), 5 deletions(-)
650 
651  commit 92f43f856f4a8b36c207d1b190ed8699b5a4ecb4
652  Author: Brian Warner <warner@lothar.com>
653  Date:   Tue Oct 4 12:48:08 2011 -0400
654 
655      API of Retrieve._validate_block(), trying to remove reader.server
656 
657   src/allmydata/mutable/retrieve.py |   14 +++++++-------
658   1 files changed, 7 insertions(+), 7 deletions(-)
659 
660  commit 572d5070761861a2190349d1ed8d85dbc25698a5
661  Author: Brian Warner <warner@lothar.com>
662  Date:   Tue Oct 4 12:36:58 2011 -0400
663 
664      API of Retrieve._mark_bad_share(), trying to remove reader.server
665 
666   src/allmydata/mutable/retrieve.py |   21 +++++++++------------
667   1 files changed, 9 insertions(+), 12 deletions(-)
668 
669  commit a793ff00c0de1e2eec7b46288fdf388c7a2bec89
670  Author: Brian Warner <warner@lothar.com>
671  Date:   Tue Oct 4 12:06:13 2011 -0400
672 
673      remove now-unused get_rref_for_serverid()
674 
675   src/allmydata/mutable/servermap.py |    3 ---
676   1 files changed, 0 insertions(+), 3 deletions(-)
677 
678  commit 1b9827cc9366bf90b93297fdd6832f2ad0480ce7
679  Author: Brian Warner <warner@lothar.com>
680  Date:   Tue Oct 4 12:03:09 2011 -0400
681 
682      Retrieve: stop adding .serverid attributes to readers
683 
684   src/allmydata/mutable/retrieve.py |    1 -
685   1 files changed, 0 insertions(+), 1 deletions(-)
686 
687  commit 5d4e9d491b19e49d2e443a1dfff2c672842c36ef
688  Author: Brian Warner <warner@lothar.com>
689  Date:   Tue Oct 4 12:03:34 2011 -0400
690 
691      return value of Retrieve(verify=True)
692 
693   src/allmydata/mutable/checker.py  |   11 ++++++-----
694   src/allmydata/mutable/retrieve.py |    3 +--
695   2 files changed, 7 insertions(+), 7 deletions(-)
696 
697  commit e9ab7978c384e1f677cb7779dc449b1044face82
698  Author: Brian Warner <warner@lothar.com>
699  Date:   Tue Oct 4 11:54:23 2011 -0400
700 
701      Retrieve._bad_shares (but not return value, used by Verifier)
702 
703   src/allmydata/mutable/retrieve.py |    7 ++++---
704   1 files changed, 4 insertions(+), 3 deletions(-)
705 
706  commit 2d91926de233ec5c881f30e36b4a30ad92ab42a9
707  Author: Brian Warner <warner@lothar.com>
708  Date:   Tue Oct 4 11:51:23 2011 -0400
709 
710      Publish: stop adding .serverid attributes to writers
711 
712   src/allmydata/mutable/publish.py |    9 ++-------
713   1 files changed, 2 insertions(+), 7 deletions(-)
714 
715  commit 47c7a0105dec7cbf4f7e0a3ce800bbb85b15df4a
716  Author: Brian Warner <warner@lothar.com>
717  Date:   Tue Oct 4 11:56:33 2011 -0400
718 
719      API of get_write_enabler()
720 
721   src/allmydata/mutable/filenode.py |    7 ++++---
722   src/allmydata/mutable/publish.py  |    4 ++--
723   src/allmydata/test/no_network.py  |    3 +++
724   3 files changed, 9 insertions(+), 5 deletions(-)
725 
726  commit 9196a5c6590fdbfd660325ea8358b345887d3db0
727  Author: Brian Warner <warner@lothar.com>
728  Date:   Tue Oct 4 11:46:24 2011 -0400
729 
730      API of get_(renewal|cancel)_secret()
731 
732   src/allmydata/mutable/filenode.py  |   14 ++++++++------
733   src/allmydata/mutable/publish.py   |    8 ++++----
734   src/allmydata/mutable/servermap.py |    5 ++---
735   3 files changed, 14 insertions(+), 13 deletions(-)
736 
737  commit de7c1552f8c163eff5b6d820b5fb3b21c1b47cb5
738  Author: Brian Warner <warner@lothar.com>
739  Date:   Tue Oct 4 11:41:52 2011 -0400
740 
741      API of CorruptShareError. Also comment out some related+unused test_web.py code
742 
743   src/allmydata/mutable/common.py    |   13 +++++--------
744   src/allmydata/mutable/retrieve.py  |   10 +++++-----
745   src/allmydata/mutable/servermap.py |    8 +++-----
746   src/allmydata/test/common.py       |   13 ++++++++-----
747   4 files changed, 21 insertions(+), 23 deletions(-)
748 
749  commit 2c1c314046b620c16f1e66d030c150d768b7d01e
750  Author: Brian Warner <warner@lothar.com>
751  Date:   Tue Oct 4 12:01:46 2011 -0400
752 
753      API of ServerMap.mark_bad_share()
754 
755   src/allmydata/mutable/publish.py   |    2 +-
756   src/allmydata/mutable/retrieve.py  |    6 +++---
757   src/allmydata/mutable/servermap.py |    6 ++----
758   src/allmydata/test/test_mutable.py |    3 +--
759   4 files changed, 7 insertions(+), 10 deletions(-)
760 
761  commit 1bed349030779fd0c378ae4e821384f953c6f6ff
762  Author: Brian Warner <warner@lothar.com>
763  Date:   Tue Oct 4 11:11:17 2011 -0400
764 
765      API+name of ServerMap.shares_on_server() : only for tests, so debug_ prefix
766 
767   src/allmydata/mutable/servermap.py |    7 ++-----
768   src/allmydata/test/test_mutable.py |    6 +++---
769   2 files changed, 5 insertions(+), 8 deletions(-)
770 
771  commit 2d32e448677d6b818692e801045d4115b29abf21
772  Author: Brian Warner <warner@lothar.com>
773  Date:   Tue Oct 4 11:07:10 2011 -0400
774 
775      API of ServerMap.all_servers_for_version()
776 
777   src/allmydata/mutable/servermap.py |    4 ++--
778   1 files changed, 2 insertions(+), 2 deletions(-)
779 
780  commit 48f3204d1889c3e7179578125c4bdef515af3d6a
781  Author: Brian Warner <warner@lothar.com>
782  Date:   Tue Oct 4 11:04:50 2011 -0400
783 
784      internals of ServerMap methods that use make_versionmap(), remove temp copy
785 
786   src/allmydata/mutable/servermap.py |   28 +++++++++----------------
787   1 files changed, 10 insertions(+), 18 deletions(-)
788 
789  commit 5c3da77b6c777a145bd5ddfaa4db849dc9495548
790  Author: Brian Warner <warner@lothar.com>
791  Date:   Tue Oct 4 11:01:28 2011 -0400
792 
793      API of ServerMap.make_versionmap()
794 
795   src/allmydata/mutable/checker.py   |    4 ++--
796   src/allmydata/mutable/retrieve.py  |    5 ++---
797   src/allmydata/mutable/servermap.py |    4 ++--
798   src/allmydata/test/test_mutable.py |    7 ++++---
799   4 files changed, 10 insertions(+), 10 deletions(-)
800 
801  commit b6882ece49afb4c507d118af2db346fa329209dc
802  Author: Brian Warner <warner@lothar.com>
803  Date:   Tue Oct 4 10:53:38 2011 -0400
804 
805      make a copy of ServerMap.make_versionmap() (_make_versionmap2) for internal use
806 
807   src/allmydata/mutable/servermap.py |   18 +++++++++++++-----
808   1 files changed, 13 insertions(+), 5 deletions(-)
809 
810  commit 963f8e63faf32b950eb1b8103cd2ff16fe8f0151
811  Author: Brian Warner <warner@lothar.com>
812  Date:   Tue Oct 4 00:45:58 2011 -0400
813 
814      API of RetrieveStatus.add_problem()
815 
816   src/allmydata/mutable/retrieve.py |    5 +++--
817   1 files changed, 3 insertions(+), 2 deletions(-)
818 
819  commit 4976d29ffae565a048851601c29013bbae2976d8
820  Author: Brian Warner <warner@lothar.com>
821  Date:   Tue Oct 4 00:45:05 2011 -0400
822 
823      API of RetrieveStatus.add_fetch_timing()
824 
825   src/allmydata/mutable/retrieve.py |    5 +++--
826   1 files changed, 3 insertions(+), 2 deletions(-)
827 
828  commit d057d3bbba72663ee148a8b916bc2d52be2e3982
829  Author: Brian Warner <warner@lothar.com>
830  Date:   Tue Oct 4 00:44:04 2011 -0400
831 
832      API of Retrieve.notify_server_corruption()
833 
834   src/allmydata/mutable/retrieve.py |    6 +++---
835   1 files changed, 3 insertions(+), 3 deletions(-)
836 
837  commit 8a2a81e46671c860610e0e96d6add1a57551f22d
838  Author: Brian Warner <warner@lothar.com>
839  Date:   Tue Oct 4 00:42:32 2011 -0400
840 
841      remove unused _outstanding_queries
842 
843   src/allmydata/mutable/retrieve.py |    1 -
844   1 files changed, 0 insertions(+), 1 deletions(-)
845 
846  commit 56d12cc9968d03ccd53764455c671122c4f391d1
847  Author: Brian Warner <warner@lothar.com>
848  Date:   Tue Oct 4 00:40:57 2011 -0400
849 
850      change Retrieve.remaining_sharemap
851 
852   src/allmydata/mutable/retrieve.py |    4 ++--
853   1 files changed, 2 insertions(+), 2 deletions(-)
854 
855  commit 4f0b7af4821f43290bfc70f2b1fc30149ad81281
856  Author: Brian Warner <warner@lothar.com>
857  Date:   Tue Oct 4 10:40:18 2011 -0400
858 
859      accessor for PublishStatus._problems
860 
861   src/allmydata/mutable/publish.py |    4 +++-
862   src/allmydata/web/status.py      |    2 +-
863   2 files changed, 4 insertions(+), 2 deletions(-)
864 
865  commit 627087cf66d0b8cc519f4d551a967a7bd9b6a741
866  Author: Brian Warner <warner@lothar.com>
867  Date:   Tue Oct 4 10:36:39 2011 -0400
868 
869      accessor for RetrieveStatus._problems
870 
871   src/allmydata/mutable/retrieve.py |    8 ++++++--
872   src/allmydata/web/status.py       |    2 +-
873   2 files changed, 7 insertions(+), 3 deletions(-)
874 
875  commit ca7dea81f03801b1c7353fc00ecba689268109cf
876  Author: Brian Warner <warner@lothar.com>
877  Date:   Tue Oct 4 00:35:32 2011 -0400
878 
879      add .server to "reader", so we can get at it later
880 
881   src/allmydata/mutable/retrieve.py |    5 +++--
882   1 files changed, 3 insertions(+), 2 deletions(-)
883 
884  commit 6ef516e24908ec195af084a7550d1921a5e983b0
885  Author: Brian Warner <warner@lothar.com>
886  Date:   Tue Oct 4 00:32:32 2011 -0400
887 
888      temporarily give Retrieve a _storage_broker, so it can map serverids to servers
889 
890   src/allmydata/mutable/checker.py   |    3 ++-
891   src/allmydata/mutable/filenode.py  |    6 ++++--
892   src/allmydata/mutable/retrieve.py  |    5 +++--
893   src/allmydata/test/test_mutable.py |    4 ++--
894   4 files changed, 11 insertions(+), 7 deletions(-)
895 
896  commit afe08e4dd3f4ff9ff7e8a2a8d28b181e3625bcc9
897  Author: Brian Warner <warner@lothar.com>
898  Date:   Tue Oct 4 00:21:51 2011 -0400
899 
900      mutable/retrieve.py: s/peer/server/
901 
902   src/allmydata/mutable/retrieve.py  |   82 +++++++++++++-------------
903   src/allmydata/test/test_mutable.py |    6 +-
904   2 files changed, 44 insertions(+), 44 deletions(-)
905 
906  commit 910afcb5d7f274880f68dd6cdb5b05f2bbc29adc
907  Author: Brian Warner <warner@lothar.com>
908  Date:   Tue Oct 4 00:16:01 2011 -0400
909 
910      web.status.PublishStatusPage: add comment, I think .problems isn't exercised
911 
912   src/allmydata/web/status.py |    2 ++
913   1 files changed, 2 insertions(+), 0 deletions(-)
914 
915  commit 311466dd8c931bbba40d590ade867704282e7f1a
916  Author: Brian Warner <warner@lothar.com>
917  Date:   Mon Oct 3 23:48:16 2011 -0400
918 
919      API of PublishStatus.add_per_server_time()
920 
921   src/allmydata/mutable/publish.py |    5 +++--
922   1 files changed, 3 insertions(+), 2 deletions(-)
923 
924  commit 2df5faa1b6cbfbaded520d2320305a62fe961118
925  Author: Brian Warner <warner@lothar.com>
926  Date:   Mon Oct 3 23:46:37 2011 -0400
927 
928      more simplifications
929 
930   src/allmydata/mutable/publish.py |    4 +---
931   1 files changed, 1 insertions(+), 3 deletions(-)
932 
933  commit 6ac4544a3da385f2aad9392f906b90192f4f919a
934  Author: Brian Warner <warner@lothar.com>
935  Date:   Mon Oct 3 23:44:08 2011 -0400
936 
937      API of ServerMap.version_on_server()
938 
939   src/allmydata/mutable/publish.py   |    2 +-
940   src/allmydata/mutable/servermap.py |    4 ++--
941   src/allmydata/test/test_mutable.py |    5 ++---
942   3 files changed, 5 insertions(+), 6 deletions(-)
943 
944  commit 3e187e322511072e4683329df6b2c6c733a66dba
945  Author: Brian Warner <warner@lothar.com>
946  Date:   Tue Oct 4 00:16:32 2011 -0400
947 
948      API of ServerMap.make_sharemap()
949 
950   src/allmydata/mutable/servermap.py |    4 ++--
951   src/allmydata/test/test_mutable.py |    7 ++++---
952   src/allmydata/web/status.py        |    4 ++--
953   3 files changed, 8 insertions(+), 7 deletions(-)
954 
955  commit 318feed8437bdd8d4943c6569d38f7b54b6313cc
956  Author: Brian Warner <warner@lothar.com>
957  Date:   Mon Oct 3 23:36:19 2011 -0400
958 
959      small cleanups
960 
961   src/allmydata/mutable/publish.py |    4 ++--
962   1 files changed, 2 insertions(+), 2 deletions(-)
963 
964  commit bd459ed5714e1db5a7163935c54b7b0b56db8349
965  Author: Brian Warner <warner@lothar.com>
966  Date:   Mon Oct 3 23:33:39 2011 -0400
967 
968      API of ServerMap.add_new_share()
969 
970   src/allmydata/mutable/publish.py   |    4 ++--
971   src/allmydata/mutable/servermap.py |    6 ++----
972   2 files changed, 4 insertions(+), 6 deletions(-)
973 
974  commit f2804fb6ed11d80088e0da8ed48e6c2922f2ffef
975  Author: Brian Warner <warner@lothar.com>
976  Date:   Mon Oct 3 23:30:26 2011 -0400
977 
978      API of ServerMap.get_bad_shares()
979 
980   src/allmydata/mutable/publish.py   |    3 +--
981   src/allmydata/mutable/servermap.py |    9 ++++-----
982   2 files changed, 5 insertions(+), 7 deletions(-)
983 
984  commit 965074a47b3ce1431cb46d9a233840afcf9105f5
985  Author: Brian Warner <warner@lothar.com>
986  Date:   Mon Oct 3 23:26:58 2011 -0400
987 
988      more small cleanups
989 
990   src/allmydata/mutable/publish.py |    6 +++---
991   1 files changed, 3 insertions(+), 3 deletions(-)
992 
993  commit 38020da34f034f8889947dd3dc05e087ffff7106
994  Author: Brian Warner <warner@lothar.com>
995  Date:   Mon Oct 3 23:18:47 2011 -0400
996 
997      change Publish.bad_share_checkstrings
998 
999   src/allmydata/mutable/publish.py |    6 +++---
1000   1 files changed, 3 insertions(+), 3 deletions(-)
1001 
1002  commit 5efebcbd2ee0c2f299ea86f7591d856c0f265304
1003  Author: Brian Warner <warner@lothar.com>
1004  Date:   Mon Oct 3 23:16:31 2011 -0400
1005 
1006      change internals of Publish.update_goal()
1007 
1008   src/allmydata/mutable/publish.py |    8 +++-----
1009   1 files changed, 3 insertions(+), 5 deletions(-)
1010 
1011  commit e91b55ff4c2a69165b71f2c7b217ac319ff4c527
1012  Author: Brian Warner <warner@lothar.com>
1013  Date:   Mon Oct 3 23:11:42 2011 -0400
1014 
1015      get rid of Publish.connections
1016 
1017   src/allmydata/mutable/publish.py |   27 +++++----------------------
1018   1 files changed, 5 insertions(+), 22 deletions(-)
1019 
1020  commit 64e9a53b3229ebe2f9ebf7ed502d539311d0e037
1021  Author: Brian Warner <warner@lothar.com>
1022  Date:   Mon Oct 3 23:05:32 2011 -0400
1023 
1024      change Publish.bad_servers
1025 
1026   src/allmydata/mutable/publish.py |   10 +++++-----
1027   1 files changed, 5 insertions(+), 5 deletions(-)
1028 
1029  commit b85a934bef315a06bcfe00c9c12a3627fed2b918
1030  Author: Brian Warner <warner@lothar.com>
1031  Date:   Mon Oct 3 23:03:07 2011 -0400
1032 
1033      Publish.bad_servers: fix bug, this should be a set of serverids, not writers
1034 
1035   src/allmydata/mutable/publish.py |    2 +-
1036   1 files changed, 1 insertions(+), 1 deletions(-)
1037 
1038  commit 605ea15ec15ed671513819003ccd211cdb9761e0
1039  Author: Brian Warner <warner@lothar.com>
1040  Date:   Mon Oct 3 23:00:21 2011 -0400
1041 
1042      change .placed
1043 
1044   src/allmydata/mutable/publish.py |    6 +++---
1045   1 files changed, 3 insertions(+), 3 deletions(-)
1046 
1047  commit f7aba37b1b345d5b6d5cb16e3b3f6f3c1afb658e
1048  Author: Brian Warner <warner@lothar.com>
1049  Date:   Mon Oct 3 22:59:22 2011 -0400
1050 
1051      temporarily stash IServer as .server on the "writer" object
1052 
1053   src/allmydata/mutable/publish.py |    2 ++
1054   1 files changed, 2 insertions(+), 0 deletions(-)
1055 
1056  commit f9b551d788e7db1f187fce5ab98ab5d5fe4e1c36
1057  Author: Brian Warner <warner@lothar.com>
1058  Date:   Mon Oct 3 22:48:18 2011 -0400
1059 
1060      change Publish.goal and API of log_goal() to use IServer, not serverid
1061 
1062   src/allmydata/mutable/publish.py |   48 ++++++++++++++--------------
1063   1 files changed, 24 insertions(+), 24 deletions(-)
1064 
1065  commit 75f20616558e4900b8b1f685dd99aa838de6d452
1066  Author: Brian Warner <warner@lothar.com>
1067  Date:   Mon Oct 3 15:27:02 2011 -0400
1068 
1069      API of ServerMap.get_known_shares()
1070 
1071   src/allmydata/mutable/publish.py   |   16 ++++++++++------
1072   src/allmydata/mutable/servermap.py |    7 ++-----
1073   2 files changed, 12 insertions(+), 11 deletions(-)
1074 
1075  commit 1c38c9d37bb08221b4418762234b1a62397b3b4b
1076  Author: Brian Warner <warner@lothar.com>
1077  Date:   Mon Oct 3 15:20:29 2011 -0400
1078 
1079      Publish.full_serverlist
1080 
1081   src/allmydata/mutable/publish.py |   10 +++++-----
1082   1 files changed, 5 insertions(+), 5 deletions(-)
1083 
1084  commit b6cbd215a04b9cde31a7d92a97a7f048622b16f1
1085  Author: Brian Warner <warner@lothar.com>
1086  Date:   Mon Oct 3 15:12:31 2011 -0400
1087 
1088      API of ServerMap.all_servers()
1089 
1090   src/allmydata/mutable/servermap.py |   19 ++++++-------------
1091   1 files changed, 6 insertions(+), 13 deletions(-)
1092 
1093  commit e63cd0315fae65357b1727ec6d5ff3c6e0d27c98
1094  Author: Brian Warner <warner@lothar.com>
1095  Date:   Mon Oct 3 15:10:18 2011 -0400
1096 
1097      remove ServerMap.connections, set_rref_for_serverid()
1098 
1099   src/allmydata/mutable/servermap.py |   11 +----------
1100   1 files changed, 1 insertions(+), 10 deletions(-)
1101 
1102  commit 4df52db2f80eb12eefa5d57103c24893cde89553
1103  Author: Brian Warner <warner@lothar.com>
1104  Date:   Mon Oct 3 15:04:06 2011 -0400
1105 
1106      API of ServerMap.mark_server_reachable()
1107 
1108   src/allmydata/mutable/servermap.py |    7 ++-----
1109   1 files changed, 2 insertions(+), 5 deletions(-)
1110 
1111  commit 69c715bde77944dc25181b3dbbeb042c816f9a1b
1112  Author: Brian Warner <warner@lothar.com>
1113  Date:   Mon Oct 3 15:03:21 2011 -0400
1114 
1115      API of ServerMap.mark_server_unreachable()
1116 
1117   src/allmydata/mutable/servermap.py |    9 +++------
1118   1 files changed, 3 insertions(+), 6 deletions(-)
1119 
1120  commit 3d784d60eec1c508858e3a617e4411ffbcc3c1fa
1121  Author: Brian Warner <warner@lothar.com>
1122  Date:   Mon Oct 3 15:02:03 2011 -0400
1123 
1124      API of status.set_privkey_from()
1125 
1126   src/allmydata/mutable/servermap.py |    7 +++----
1127   1 files changed, 3 insertions(+), 4 deletions(-)
1128 
1129  commit 544ed3ea29bed7e66da7fd29ca3f6f076f27a9e6
1130  Author: Brian Warner <warner@lothar.com>
1131  Date:   Mon Oct 3 15:01:15 2011 -0400
1132 
1133      API of status.add_per_server_time()
1134 
1135   src/allmydata/mutable/servermap.py |    7 ++++---
1136   1 files changed, 4 insertions(+), 3 deletions(-)
1137 
1138  commit fffe5008b6320bd1e04c3c68389a2bf2ee383fa8
1139  Author: Brian Warner <warner@lothar.com>
1140  Date:   Mon Oct 3 14:59:02 2011 -0400
1141 
1142      remove unused .versionmap
1143 
1144   src/allmydata/mutable/servermap.py |    7 -------
1145   1 files changed, 0 insertions(+), 7 deletions(-)
1146 
1147  commit 2816562e090d2294179db3588dafcca18de1bc2b
1148  Author: Brian Warner <warner@lothar.com>
1149  Date:   Mon Oct 3 14:57:51 2011 -0400
1150 
1151      remove serverid from all log messages. Also one unused lambda.
1152 
1153   src/allmydata/mutable/servermap.py |   30 +++++++++++++-------------
1154   1 files changed, 15 insertions(+), 15 deletions(-)
1155 
1156  commit 28fa6b1a2738fa98c1f1dbd3d0e01ae98912d11f
1157  Author: Brian Warner <warner@lothar.com>
1158  Date:   Mon Oct 3 14:54:30 2011 -0400
1159 
1160      removed unused _readers
1161 
1162   src/allmydata/mutable/servermap.py |    3 ---
1163   1 files changed, 0 insertions(+), 3 deletions(-)
1164 
1165  commit a8e4ed3d645ab592d1add6a1e69b6d1ebfb77817
1166  Author: Brian Warner <warner@lothar.com>
1167  Date:   Mon Oct 3 14:54:16 2011 -0400
1168 
1169      remove unused _sharemap
1170 
1171   src/allmydata/mutable/servermap.py |    1 -
1172   1 files changed, 0 insertions(+), 1 deletions(-)
1173 
1174  commit 3f072e55cf1d0700f9fffe23f8f3a475725df588
1175  Author: Brian Warner <warner@lothar.com>
1176  Date:   Mon Oct 3 14:49:03 2011 -0400
1177 
1178      _must_query
1179 
1180   src/allmydata/mutable/servermap.py |    8 ++++----
1181   1 files changed, 4 insertions(+), 4 deletions(-)
1182 
1183  commit c599a059b8df3f5785e4bf89fb6ecc6d8dcd708b
1184  Author: Brian Warner <warner@lothar.com>
1185  Date:   Mon Oct 3 14:48:05 2011 -0400
1186 
1187      _queries_outstanding
1188 
1189   src/allmydata/mutable/servermap.py |   16 +++++++---------
1190   1 files changed, 7 insertions(+), 9 deletions(-)
1191 
1192  commit 7743759f98ac2c07926b2fdbd80bf52dfab33085
1193  Author: Brian Warner <warner@lothar.com>
1194  Date:   Mon Oct 3 14:46:17 2011 -0400
1195 
1196      _empty_servers
1197 
1198   src/allmydata/mutable/servermap.py |    5 ++---
1199   1 files changed, 2 insertions(+), 3 deletions(-)
1200 
1201  commit 6bb1825916828a713a32cdf7f7411fa3ea2e1e5d
1202  Author: Brian Warner <warner@lothar.com>
1203  Date:   Mon Oct 3 14:45:39 2011 -0400
1204 
1205      _good_servers
1206 
1207   src/allmydata/mutable/servermap.py |    4 ++--
1208   1 files changed, 2 insertions(+), 2 deletions(-)
1209 
1210  commit 1768fab1b51d8dd93ecabbaaabfadfa20cf6c3d4
1211  Author: Brian Warner <warner@lothar.com>
1212  Date:   Mon Oct 3 14:44:59 2011 -0400
1213 
1214      _bad_servers
1215 
1216   src/allmydata/mutable/servermap.py |   14 +++++++-------
1217   1 files changed, 7 insertions(+), 7 deletions(-)
1218 
1219  commit dccbaef30f0ba714c746bf6d4a1a803c36e17b65
1220  Author: Brian Warner <warner@lothar.com>
1221  Date:   Mon Oct 3 14:41:54 2011 -0400
1222 
1223      API of _try_to_set_pubkey()
1224 
1225   src/allmydata/mutable/servermap.py |    7 ++++---
1226   1 files changed, 4 insertions(+), 3 deletions(-)
1227 
1228  commit 0481ea70042ba3575f15eac7fd0780f8ece580cc
1229  Author: Brian Warner <warner@lothar.com>
1230  Date:   Mon Oct 3 14:35:02 2011 -0400
1231 
1232      API of notify_server_corruption()
1233 
1234   src/allmydata/mutable/servermap.py |    6 +++---
1235   1 files changed, 3 insertions(+), 3 deletions(-)
1236 
1237  commit bea9cba18fb3b9c11bb22f18356a263ecec7351e
1238  Author: Brian Warner <warner@lothar.com>
1239  Date:   Mon Oct 3 14:34:09 2011 -0400
1240 
1241      API of _got_signature_one_share()
1242 
1243   src/allmydata/mutable/servermap.py |    9 +++++----
1244   1 files changed, 5 insertions(+), 4 deletions(-)
1245 
1246  commit 1520123583cf78650706e114b15bb5b0ac1f4a14
1247  Author: Brian Warner <warner@lothar.com>
1248  Date:   Mon Oct 3 14:32:33 2011 -0400
1249 
1250      API of _try_to_validate_privkey()
1251 
1252   src/allmydata/mutable/servermap.py |    9 +++++----
1253   1 files changed, 5 insertions(+), 4 deletions(-)
1254 
1255  commit 938852c9c8519c7a078f58a9b1f4dd8ec8b6715e
1256  Author: Brian Warner <warner@lothar.com>
1257  Date:   Mon Oct 3 14:31:48 2011 -0400
1258 
1259      API and internals of _add_lease_failed()
1260 
1261   src/allmydata/mutable/servermap.py |    8 ++++----
1262   1 files changed, 4 insertions(+), 4 deletions(-)
1263 
1264  commit 3843dba367e3c19e176a622ab853cb51d2472ddf
1265  Author: Brian Warner <warner@lothar.com>
1266  Date:   Mon Oct 3 14:30:37 2011 -0400
1267 
1268      API of _privkey_query_failed()
1269 
1270   src/allmydata/mutable/servermap.py |    5 +++--
1271   1 files changed, 3 insertions(+), 2 deletions(-)
1272 
1273  commit 2219a710e1633cd57d0ca0786490de87b3e19ba7
1274  Author: Brian Warner <warner@lothar.com>
1275  Date:   Mon Oct 3 14:29:43 2011 -0400
1276 
1277      fix bug in call to _privkey_query_failed, unrelated to refactoring
1278 
1279   src/allmydata/mutable/servermap.py |    2 +-
1280   1 files changed, 1 insertions(+), 1 deletions(-)
1281 
1282  commit ae615bec7d0d1b269710b6902797b12f9592ad62
1283  Author: Brian Warner <warner@lothar.com>
1284  Date:   Mon Oct 3 14:27:17 2011 -0400
1285 
1286      API of _got_corrupt_share()
1287 
1288   src/allmydata/mutable/servermap.py |   17 +++++++++--------
1289   1 files changed, 9 insertions(+), 8 deletions(-)
1290 
1291  commit cb51c95a6f4e077278157a77dab060c8c1ad7a81
1292  Author: Brian Warner <warner@lothar.com>
1293  Date:   Mon Oct 3 14:23:16 2011 -0400
1294 
1295      API of _got_results()
1296 
1297   src/allmydata/mutable/servermap.py |    9 +++++----
1298   1 files changed, 5 insertions(+), 4 deletions(-)
1299 
1300  commit bac9154fe0af18f226999a58ffc2362d8cf4b802
1301  Author: Brian Warner <warner@lothar.com>
1302  Date:   Mon Oct 3 14:19:19 2011 -0400
1303 
1304      API of _query_failed()
1305 
1306   src/allmydata/mutable/servermap.py |    5 +++--
1307   1 files changed, 3 insertions(+), 2 deletions(-)
1308 
1309  commit fdc29a8ca95d4b5c503e5382b9e5d4d02141ba12
1310  Author: Brian Warner <warner@lothar.com>
1311  Date:   Mon Oct 3 14:17:20 2011 -0400
1312 
1313      API of _do_read()
1314 
1315   src/allmydata/mutable/servermap.py |    6 ++++--
1316   1 files changed, 4 insertions(+), 2 deletions(-)
1317 
1318  commit e7e9e338f28d004aa4d423d11c65f1e271ac7322
1319  Author: Brian Warner <warner@lothar.com>
1320  Date:   Mon Oct 3 14:20:21 2011 -0400
1321 
1322      API of _do_query()
1323 
1324   src/allmydata/mutable/servermap.py |   15 +++++++--------
1325   1 files changed, 7 insertions(+), 8 deletions(-)
1326 
1327  commit 330625b9dac4cdbe72a11464a893065b9aeed453
1328  Author: Brian Warner <warner@lothar.com>
1329  Date:   Mon Oct 3 14:43:05 2011 -0400
1330 
1331      next step: first batch of updates to ServermapUpdater
1332 
1333      updates:
1334       most method-local variables in update()
1335       API of _build_initial_querylist()
1336       API of _send_initial_requests()
1337       .full_serverlist
1338       .extra_servers
1339 
1340   src/allmydata/mutable/servermap.py |   39 ++++++++++++++------------
1341   1 files changed, 21 insertions(+), 18 deletions(-)
1342 
1343  commit 4aadc584fa7dcb2daa86b048c81dee0049ba26d9
1344  Author: Brian Warner <warner@lothar.com>
1345  Date:   Mon Oct 3 15:07:00 2011 -0400
1346 
1347      internal change: index _bad_shares with IServer
1348 
1349   src/allmydata/mutable/servermap.py |   20 ++++++++++----------
1350   1 files changed, 10 insertions(+), 10 deletions(-)
1351 
1352  commit 16d4e6fa82a9907dbdc92094213387c6a4164e41
1353  Author: Brian Warner <warner@lothar.com>
1354  Date:   Mon Oct 3 18:20:47 2011 +0100
1355 
1356      internal change: index _known_shares with IServer instead of serverid
1357 
1358      callers are unchanged
1359 
1360   src/allmydata/mutable/servermap.py |   42 +++++++++++++++----------
1361   1 files changed, 25 insertions(+), 17 deletions(-)
1362 
1363  commit ceeb5f4938cc814a0c75d1b8f4018aed965c2176
1364  Author: Brian Warner <warner@lothar.com>
1365  Date:   Mon Oct 3 18:11:43 2011 +0100
1366 
1367      accessors and name cleanup for servermap.Servermap.last_update_mode/time
1368 
1369   src/allmydata/mutable/filenode.py  |    6 +++---
1370   src/allmydata/mutable/publish.py   |    4 ++--
1371   src/allmydata/mutable/servermap.py |   17 +++++++++++------
1372   3 files changed, 16 insertions(+), 11 deletions(-)
1373 
1374  commit 8d3cbda82661c0a7e5c3d3b65cf7a5d5ab7e32c0
1375  Author: Brian Warner <warner@lothar.com>
1376  Date:   Mon Oct 3 18:11:14 2011 +0100
1377 
1378      accessors and name cleanup for servermap.Servermap.problems
1379 
1380   src/allmydata/mutable/servermap.py |   21 +++++++++++++--------
1381   src/allmydata/test/test_mutable.py |    6 +++---
1382   2 files changed, 16 insertions(+), 11 deletions(-)
1383 
1384  commit 348f57988f79389db0aab7672e6eaa9a6d8e3219
1385  Author: Brian Warner <warner@lothar.com>
1386  Date:   Mon Oct 3 18:10:41 2011 +0100
1387 
1388      accessors and name cleanup for servermap.Servermap.bad_shares
1389 
1390   src/allmydata/mutable/publish.py   |    2 +-
1391   src/allmydata/mutable/servermap.py |   30 ++++++++++++++-----------
1392   2 files changed, 18 insertions(+), 14 deletions(-)
1393 
1394  commit 520c9368134673cdf76c653c5e1bb91c2ab5d51e
1395  Author: Brian Warner <warner@lothar.com>
1396  Date:   Mon Oct 3 18:10:05 2011 +0100
1397 
1398      accessors and name cleanup for servermap.Servermap.servermap .
1399 
1400   src/allmydata/mutable/publish.py   |   14 +++++----
1401   src/allmydata/mutable/servermap.py |   38 ++++++++++++++-----------
1402   2 files changed, 29 insertions(+), 23 deletions(-)
1403 
1404  commit b8b8dc38287a91dbdf494426ac801d9381ce5841
1405  Author: Brian Warner <warner@lothar.com>
1406  Date:   Mon Oct 3 18:08:02 2011 +0100
1407 
1408      fix reachable_servers
1409 
1410   src/allmydata/mutable/checker.py   |    3 ++-
1411   src/allmydata/mutable/publish.py   |    4 +++-
1412   src/allmydata/mutable/servermap.py |   12 ++++++++++--
1413   3 files changed, 15 insertions(+), 4 deletions(-)
1414 
1415  commit cb0cfd1adfefad357c187aaaf690c3df68b622bc
1416  Author: Brian Warner <warner@lothar.com>
1417  Date:   Mon Oct 3 18:06:03 2011 +0100
1418 
1419      fix Servermap.unreachable_servers
1420 
1421   src/allmydata/mutable/servermap.py |   11 ++++++++---
1422   1 files changed, 8 insertions(+), 3 deletions(-)
1423 
1424  commit 2d9ea79b94bd4db674d40386fda90825785ac495
1425  Author: Brian Warner <warner@lothar.com>
1426  Date:   Mon Oct 3 18:03:48 2011 +0100
1427 
1428      give ServerMap a StorageFarmBroker, temporary
1429 
1430      this makes it possible for the ServerMap to accept bare serverids and still
1431      build data structures with IServers
1432 
1433   src/allmydata/mutable/checker.py   |    2 +-
1434   src/allmydata/mutable/filenode.py  |    2 +-
1435   src/allmydata/mutable/publish.py   |    2 +-
1436   src/allmydata/mutable/servermap.py |    5 +++--
1437   src/allmydata/test/test_mutable.py |    8 ++++----
1438   5 files changed, 10 insertions(+), 9 deletions(-)
1439 
1440  commit 718d1aeff6fded893f65397806d22ece928b0dd4
1441  Author: Brian Warner <warner@lothar.com>
1442  Date:   Mon Oct 3 13:43:30 2011 -0400
1443 
1444      add StorageFarmBroker.get_server_for_id(), temporary helper
1445 
1446      This will go away once we're passing IServers everywhere.
1447 
1448   src/allmydata/storage_client.py  |    2 ++
1449   src/allmydata/test/no_network.py |   13 +++++++++++++
1450   2 files changed, 15 insertions(+), 0 deletions(-)
1451 
1452  commit ece20231d7fda0d503704842a4aa068dfbc2e54e
1453  Author: Brian Warner <warner@lothar.com>
1454  Date:   Sun Oct 2 01:11:50 2011 +0100
1455 
1456      add proper accessors for Servermap.connections, to make refactoring easier
1457 
1458   src/allmydata/mutable/publish.py   |    6 +++---
1459   src/allmydata/mutable/retrieve.py  |   10 +++++-----
1460   src/allmydata/mutable/servermap.py |   17 +++++++++++------
1461   3 files changed, 19 insertions(+), 14 deletions(-)
1462 
1463  commit 3b943d6bf302ff702668081a612fc4fe2604cf9c
1464  Author: Brian Warner <warner@lothar.com>
1465  Date:   Fri Sep 23 10:34:30 2011 -0700
1466 
1467      mutable/servermap.py and neighbors: s/peer/server/
1468 
1469   src/allmydata/mutable/checker.py   |   22 +-
1470   src/allmydata/mutable/publish.py   |  204 +++++++-------
1471   src/allmydata/mutable/servermap.py |  402 +++++++++++++-------------
1472   src/allmydata/test/test_mutable.py |   18 +-
1473   4 files changed, 323 insertions(+), 323 deletions(-)
1474 IServer refactoring: pass IServer instances around, instead of peerids
1475 
1476 refs #1363
1477 
1478 This collapses 88 small incremental changes (each of which passes all tests)
1479 into one big patch. The development process for the long path started with
1480 adding some temporary scaffolding, changing one method at a time, then
1481 removing the scaffolding. The individual pieces are as follows, in reverse
1482 chronological order (the first patch is at the end of this comment):
1483 
1484  commit 9bbe4174fd0d98a6cf47a8ef96e85d9ef34b2f9a
1485  Author: Brian Warner <warner@lothar.com>
1486  Date:   Tue Oct 4 16:05:00 2011 -0400
1487 
1488      immutable/downloader/status.py: correct comment
1489 
1490   src/allmydata/immutable/downloader/status.py |    2 +-
1491   1 files changed, 1 insertions(+), 1 deletions(-)
1492 
1493  commit 72146a7c7c91eac2f7c3ceb801eb7a1721376889
1494  Author: Brian Warner <warner@lothar.com>
1495  Date:   Tue Oct 4 15:46:20 2011 -0400
1496 
1497      remove temporary ServerMap._storage_broker
1498 
1499   src/allmydata/mutable/checker.py   |    2 +-
1500   src/allmydata/mutable/filenode.py  |    2 +-
1501   src/allmydata/mutable/publish.py   |    2 +-
1502   src/allmydata/mutable/servermap.py |    5 ++---
1503   src/allmydata/test/test_mutable.py |    8 ++++----
1504   5 files changed, 9 insertions(+), 10 deletions(-)
1505 
1506  commit d703096b41632c47d76414b12672e076a422ff5c
1507  Author: Brian Warner <warner@lothar.com>
1508  Date:   Tue Oct 4 15:37:05 2011 -0400
1509 
1510      remove temporary storage_broker.get_server_for_id()
1511 
1512   src/allmydata/storage_client.py  |    3 ---
1513   src/allmydata/test/no_network.py |   13 -------------
1514   2 files changed, 0 insertions(+), 16 deletions(-)
1515 
1516  commit 620cc5d80882ef6f7decfd26af8a6c7c1ddf80d1
1517  Author: Brian Warner <warner@lothar.com>
1518  Date:   Tue Oct 4 12:50:06 2011 -0400
1519 
1520      API of Retrieve._try_to_validate_privkey(), trying to remove reader.server
1521 
1522   src/allmydata/mutable/retrieve.py |   10 +++++-----
1523   1 files changed, 5 insertions(+), 5 deletions(-)
1524 
1525  commit 92f43f856f4a8b36c207d1b190ed8699b5a4ecb4
1526  Author: Brian Warner <warner@lothar.com>
1527  Date:   Tue Oct 4 12:48:08 2011 -0400
1528 
1529      API of Retrieve._validate_block(), trying to remove reader.server
1530 
1531   src/allmydata/mutable/retrieve.py |   14 +++++++-------
1532   1 files changed, 7 insertions(+), 7 deletions(-)
1533 
1534  commit 572d5070761861a2190349d1ed8d85dbc25698a5
1535  Author: Brian Warner <warner@lothar.com>
1536  Date:   Tue Oct 4 12:36:58 2011 -0400
1537 
1538      API of Retrieve._mark_bad_share(), trying to remove reader.server
1539 
1540   src/allmydata/mutable/retrieve.py |   21 +++++++++------------
1541   1 files changed, 9 insertions(+), 12 deletions(-)
1542 
1543  commit a793ff00c0de1e2eec7b46288fdf388c7a2bec89
1544  Author: Brian Warner <warner@lothar.com>
1545  Date:   Tue Oct 4 12:06:13 2011 -0400
1546 
1547      remove now-unused get_rref_for_serverid()
1548 
1549   src/allmydata/mutable/servermap.py |    3 ---
1550   1 files changed, 0 insertions(+), 3 deletions(-)
1551 
1552  commit 1b9827cc9366bf90b93297fdd6832f2ad0480ce7
1553  Author: Brian Warner <warner@lothar.com>
1554  Date:   Tue Oct 4 12:03:09 2011 -0400
1555 
1556      Retrieve: stop adding .serverid attributes to readers
1557 
1558   src/allmydata/mutable/retrieve.py |    1 -
1559   1 files changed, 0 insertions(+), 1 deletions(-)
1560 
1561  commit 5d4e9d491b19e49d2e443a1dfff2c672842c36ef
1562  Author: Brian Warner <warner@lothar.com>
1563  Date:   Tue Oct 4 12:03:34 2011 -0400
1564 
1565      return value of Retrieve(verify=True)
1566 
1567   src/allmydata/mutable/checker.py  |   11 ++++++-----
1568   src/allmydata/mutable/retrieve.py |    3 +--
1569   2 files changed, 7 insertions(+), 7 deletions(-)
1570 
1571  commit e9ab7978c384e1f677cb7779dc449b1044face82
1572  Author: Brian Warner <warner@lothar.com>
1573  Date:   Tue Oct 4 11:54:23 2011 -0400
1574 
1575      Retrieve._bad_shares (but not return value, used by Verifier)
1576 
1577   src/allmydata/mutable/retrieve.py |    7 ++++---
1578   1 files changed, 4 insertions(+), 3 deletions(-)
1579 
1580  commit 2d91926de233ec5c881f30e36b4a30ad92ab42a9
1581  Author: Brian Warner <warner@lothar.com>
1582  Date:   Tue Oct 4 11:51:23 2011 -0400
1583 
1584      Publish: stop adding .serverid attributes to writers
1585 
1586   src/allmydata/mutable/publish.py |    9 ++-------
1587   1 files changed, 2 insertions(+), 7 deletions(-)
1588 
1589  commit 47c7a0105dec7cbf4f7e0a3ce800bbb85b15df4a
1590  Author: Brian Warner <warner@lothar.com>
1591  Date:   Tue Oct 4 11:56:33 2011 -0400
1592 
1593      API of get_write_enabler()
1594 
1595   src/allmydata/mutable/filenode.py |    7 ++++---
1596   src/allmydata/mutable/publish.py  |    4 ++--
1597   src/allmydata/test/no_network.py  |    3 +++
1598   3 files changed, 9 insertions(+), 5 deletions(-)
1599 
1600  commit 9196a5c6590fdbfd660325ea8358b345887d3db0
1601  Author: Brian Warner <warner@lothar.com>
1602  Date:   Tue Oct 4 11:46:24 2011 -0400
1603 
1604      API of get_(renewal|cancel)_secret()
1605 
1606   src/allmydata/mutable/filenode.py  |   14 ++++++++------
1607   src/allmydata/mutable/publish.py   |    8 ++++----
1608   src/allmydata/mutable/servermap.py |    5 ++---
1609   3 files changed, 14 insertions(+), 13 deletions(-)
1610 
1611  commit de7c1552f8c163eff5b6d820b5fb3b21c1b47cb5
1612  Author: Brian Warner <warner@lothar.com>
1613  Date:   Tue Oct 4 11:41:52 2011 -0400
1614 
1615      API of CorruptShareError. Also comment out some related+unused test_web.py code
1616 
1617   src/allmydata/mutable/common.py    |   13 +++++--------
1618   src/allmydata/mutable/retrieve.py  |   10 +++++-----
1619   src/allmydata/mutable/servermap.py |    8 +++-----
1620   src/allmydata/test/common.py       |   13 ++++++++-----
1621   4 files changed, 21 insertions(+), 23 deletions(-)
1622 
1623  commit 2c1c314046b620c16f1e66d030c150d768b7d01e
1624  Author: Brian Warner <warner@lothar.com>
1625  Date:   Tue Oct 4 12:01:46 2011 -0400
1626 
1627      API of ServerMap.mark_bad_share()
1628 
1629   src/allmydata/mutable/publish.py   |    2 +-
1630   src/allmydata/mutable/retrieve.py  |    6 +++---
1631   src/allmydata/mutable/servermap.py |    6 ++----
1632   src/allmydata/test/test_mutable.py |    3 +--
1633   4 files changed, 7 insertions(+), 10 deletions(-)
1634 
1635  commit 1bed349030779fd0c378ae4e821384f953c6f6ff
1636  Author: Brian Warner <warner@lothar.com>
1637  Date:   Tue Oct 4 11:11:17 2011 -0400
1638 
1639      API+name of ServerMap.shares_on_server() : only for tests, so debug_ prefix
1640 
1641   src/allmydata/mutable/servermap.py |    7 ++-----
1642   src/allmydata/test/test_mutable.py |    6 +++---
1643   2 files changed, 5 insertions(+), 8 deletions(-)
1644 
1645  commit 2d32e448677d6b818692e801045d4115b29abf21
1646  Author: Brian Warner <warner@lothar.com>
1647  Date:   Tue Oct 4 11:07:10 2011 -0400
1648 
1649      API of ServerMap.all_servers_for_version()
1650 
1651   src/allmydata/mutable/servermap.py |    4 ++--
1652   1 files changed, 2 insertions(+), 2 deletions(-)
1653 
1654  commit 48f3204d1889c3e7179578125c4bdef515af3d6a
1655  Author: Brian Warner <warner@lothar.com>
1656  Date:   Tue Oct 4 11:04:50 2011 -0400
1657 
1658      internals of ServerMap methods that use make_versionmap(), remove temp copy
1659 
1660   src/allmydata/mutable/servermap.py |   28 +++++++++----------------
1661   1 files changed, 10 insertions(+), 18 deletions(-)
1662 
1663  commit 5c3da77b6c777a145bd5ddfaa4db849dc9495548
1664  Author: Brian Warner <warner@lothar.com>
1665  Date:   Tue Oct 4 11:01:28 2011 -0400
1666 
1667      API of ServerMap.make_versionmap()
1668 
1669   src/allmydata/mutable/checker.py   |    4 ++--
1670   src/allmydata/mutable/retrieve.py  |    5 ++---
1671   src/allmydata/mutable/servermap.py |    4 ++--
1672   src/allmydata/test/test_mutable.py |    7 ++++---
1673   4 files changed, 10 insertions(+), 10 deletions(-)
1674 
1675  commit b6882ece49afb4c507d118af2db346fa329209dc
1676  Author: Brian Warner <warner@lothar.com>
1677  Date:   Tue Oct 4 10:53:38 2011 -0400
1678 
1679      make a copy of ServerMap.make_versionmap() (_make_versionmap2) for internal use
1680 
1681   src/allmydata/mutable/servermap.py |   18 +++++++++++++-----
1682   1 files changed, 13 insertions(+), 5 deletions(-)
1683 
1684  commit 963f8e63faf32b950eb1b8103cd2ff16fe8f0151
1685  Author: Brian Warner <warner@lothar.com>
1686  Date:   Tue Oct 4 00:45:58 2011 -0400
1687 
1688      API of RetrieveStatus.add_problem()
1689 
1690   src/allmydata/mutable/retrieve.py |    5 +++--
1691   1 files changed, 3 insertions(+), 2 deletions(-)
1692 
1693  commit 4976d29ffae565a048851601c29013bbae2976d8
1694  Author: Brian Warner <warner@lothar.com>
1695  Date:   Tue Oct 4 00:45:05 2011 -0400
1696 
1697      API of RetrieveStatus.add_fetch_timing()
1698 
1699   src/allmydata/mutable/retrieve.py |    5 +++--
1700   1 files changed, 3 insertions(+), 2 deletions(-)
1701 
1702  commit d057d3bbba72663ee148a8b916bc2d52be2e3982
1703  Author: Brian Warner <warner@lothar.com>
1704  Date:   Tue Oct 4 00:44:04 2011 -0400
1705 
1706      API of Retrieve.notify_server_corruption()
1707 
1708   src/allmydata/mutable/retrieve.py |    6 +++---
1709   1 files changed, 3 insertions(+), 3 deletions(-)
1710 
1711  commit 8a2a81e46671c860610e0e96d6add1a57551f22d
1712  Author: Brian Warner <warner@lothar.com>
1713  Date:   Tue Oct 4 00:42:32 2011 -0400
1714 
1715      remove unused _outstanding_queries
1716 
1717   src/allmydata/mutable/retrieve.py |    1 -
1718   1 files changed, 0 insertions(+), 1 deletions(-)
1719 
1720  commit 56d12cc9968d03ccd53764455c671122c4f391d1
1721  Author: Brian Warner <warner@lothar.com>
1722  Date:   Tue Oct 4 00:40:57 2011 -0400
1723 
1724      change Retrieve.remaining_sharemap
1725 
1726   src/allmydata/mutable/retrieve.py |    4 ++--
1727   1 files changed, 2 insertions(+), 2 deletions(-)
1728 
1729  commit 4f0b7af4821f43290bfc70f2b1fc30149ad81281
1730  Author: Brian Warner <warner@lothar.com>
1731  Date:   Tue Oct 4 10:40:18 2011 -0400
1732 
1733      accessor for PublishStatus._problems
1734 
1735   src/allmydata/mutable/publish.py |    4 +++-
1736   src/allmydata/web/status.py      |    2 +-
1737   2 files changed, 4 insertions(+), 2 deletions(-)
1738 
1739  commit 627087cf66d0b8cc519f4d551a967a7bd9b6a741
1740  Author: Brian Warner <warner@lothar.com>
1741  Date:   Tue Oct 4 10:36:39 2011 -0400
1742 
1743      accessor for RetrieveStatus._problems
1744 
1745   src/allmydata/mutable/retrieve.py |    8 ++++++--
1746   src/allmydata/web/status.py       |    2 +-
1747   2 files changed, 7 insertions(+), 3 deletions(-)
1748 
1749  commit ca7dea81f03801b1c7353fc00ecba689268109cf
1750  Author: Brian Warner <warner@lothar.com>
1751  Date:   Tue Oct 4 00:35:32 2011 -0400
1752 
1753      add .server to "reader", so we can get at it later
1754 
1755   src/allmydata/mutable/retrieve.py |    5 +++--
1756   1 files changed, 3 insertions(+), 2 deletions(-)
1757 
1758  commit 6ef516e24908ec195af084a7550d1921a5e983b0
1759  Author: Brian Warner <warner@lothar.com>
1760  Date:   Tue Oct 4 00:32:32 2011 -0400
1761 
1762      temporarily give Retrieve a _storage_broker, so it can map serverids to servers
1763 
1764   src/allmydata/mutable/checker.py   |    3 ++-
1765   src/allmydata/mutable/filenode.py  |    6 ++++--
1766   src/allmydata/mutable/retrieve.py  |    5 +++--
1767   src/allmydata/test/test_mutable.py |    4 ++--
1768   4 files changed, 11 insertions(+), 7 deletions(-)
1769 
1770  commit afe08e4dd3f4ff9ff7e8a2a8d28b181e3625bcc9
1771  Author: Brian Warner <warner@lothar.com>
1772  Date:   Tue Oct 4 00:21:51 2011 -0400
1773 
1774      mutable/retrieve.py: s/peer/server/
1775 
1776   src/allmydata/mutable/retrieve.py  |   82 +++++++++++++-------------
1777   src/allmydata/test/test_mutable.py |    6 +-
1778   2 files changed, 44 insertions(+), 44 deletions(-)
1779 
1780  commit 910afcb5d7f274880f68dd6cdb5b05f2bbc29adc
1781  Author: Brian Warner <warner@lothar.com>
1782  Date:   Tue Oct 4 00:16:01 2011 -0400
1783 
1784      web.status.PublishStatusPage: add comment, I think .problems isn't exercised
1785 
1786   src/allmydata/web/status.py |    2 ++
1787   1 files changed, 2 insertions(+), 0 deletions(-)
1788 
1789  commit 311466dd8c931bbba40d590ade867704282e7f1a
1790  Author: Brian Warner <warner@lothar.com>
1791  Date:   Mon Oct 3 23:48:16 2011 -0400
1792 
1793      API of PublishStatus.add_per_server_time()
1794 
1795   src/allmydata/mutable/publish.py |    5 +++--
1796   1 files changed, 3 insertions(+), 2 deletions(-)
1797 
1798  commit 2df5faa1b6cbfbaded520d2320305a62fe961118
1799  Author: Brian Warner <warner@lothar.com>
1800  Date:   Mon Oct 3 23:46:37 2011 -0400
1801 
1802      more simplifications
1803 
1804   src/allmydata/mutable/publish.py |    4 +---
1805   1 files changed, 1 insertions(+), 3 deletions(-)
1806 
1807  commit 6ac4544a3da385f2aad9392f906b90192f4f919a
1808  Author: Brian Warner <warner@lothar.com>
1809  Date:   Mon Oct 3 23:44:08 2011 -0400
1810 
1811      API of ServerMap.version_on_server()
1812 
1813   src/allmydata/mutable/publish.py   |    2 +-
1814   src/allmydata/mutable/servermap.py |    4 ++--
1815   src/allmydata/test/test_mutable.py |    5 ++---
1816   3 files changed, 5 insertions(+), 6 deletions(-)
1817 
1818  commit 3e187e322511072e4683329df6b2c6c733a66dba
1819  Author: Brian Warner <warner@lothar.com>
1820  Date:   Tue Oct 4 00:16:32 2011 -0400
1821 
1822      API of ServerMap.make_sharemap()
1823 
1824   src/allmydata/mutable/servermap.py |    4 ++--
1825   src/allmydata/test/test_mutable.py |    7 ++++---
1826   src/allmydata/web/status.py        |    4 ++--
1827   3 files changed, 8 insertions(+), 7 deletions(-)
1828 
1829  commit 318feed8437bdd8d4943c6569d38f7b54b6313cc
1830  Author: Brian Warner <warner@lothar.com>
1831  Date:   Mon Oct 3 23:36:19 2011 -0400
1832 
1833      small cleanups
1834 
1835   src/allmydata/mutable/publish.py |    4 ++--
1836   1 files changed, 2 insertions(+), 2 deletions(-)
1837 
1838  commit bd459ed5714e1db5a7163935c54b7b0b56db8349
1839  Author: Brian Warner <warner@lothar.com>
1840  Date:   Mon Oct 3 23:33:39 2011 -0400
1841 
1842      API of ServerMap.add_new_share()
1843 
1844   src/allmydata/mutable/publish.py   |    4 ++--
1845   src/allmydata/mutable/servermap.py |    6 ++----
1846   2 files changed, 4 insertions(+), 6 deletions(-)
1847 
1848  commit f2804fb6ed11d80088e0da8ed48e6c2922f2ffef
1849  Author: Brian Warner <warner@lothar.com>
1850  Date:   Mon Oct 3 23:30:26 2011 -0400
1851 
1852      API of ServerMap.get_bad_shares()
1853 
1854   src/allmydata/mutable/publish.py   |    3 +--
1855   src/allmydata/mutable/servermap.py |    9 ++++-----
1856   2 files changed, 5 insertions(+), 7 deletions(-)
1857 
1858  commit 965074a47b3ce1431cb46d9a233840afcf9105f5
1859  Author: Brian Warner <warner@lothar.com>
1860  Date:   Mon Oct 3 23:26:58 2011 -0400
1861 
1862      more small cleanups
1863 
1864   src/allmydata/mutable/publish.py |    6 +++---
1865   1 files changed, 3 insertions(+), 3 deletions(-)
1866 
1867  commit 38020da34f034f8889947dd3dc05e087ffff7106
1868  Author: Brian Warner <warner@lothar.com>
1869  Date:   Mon Oct 3 23:18:47 2011 -0400
1870 
1871      change Publish.bad_share_checkstrings
1872 
1873   src/allmydata/mutable/publish.py |    6 +++---
1874   1 files changed, 3 insertions(+), 3 deletions(-)
1875 
1876  commit 5efebcbd2ee0c2f299ea86f7591d856c0f265304
1877  Author: Brian Warner <warner@lothar.com>
1878  Date:   Mon Oct 3 23:16:31 2011 -0400
1879 
1880      change internals of Publish.update_goal()
1881 
1882   src/allmydata/mutable/publish.py |    8 +++-----
1883   1 files changed, 3 insertions(+), 5 deletions(-)
1884 
1885  commit e91b55ff4c2a69165b71f2c7b217ac319ff4c527
1886  Author: Brian Warner <warner@lothar.com>
1887  Date:   Mon Oct 3 23:11:42 2011 -0400
1888 
1889      get rid of Publish.connections
1890 
1891   src/allmydata/mutable/publish.py |   27 +++++----------------------
1892   1 files changed, 5 insertions(+), 22 deletions(-)
1893 
1894  commit 64e9a53b3229ebe2f9ebf7ed502d539311d0e037
1895  Author: Brian Warner <warner@lothar.com>
1896  Date:   Mon Oct 3 23:05:32 2011 -0400
1897 
1898      change Publish.bad_servers
1899 
1900   src/allmydata/mutable/publish.py |   10 +++++-----
1901   1 files changed, 5 insertions(+), 5 deletions(-)
1902 
1903  commit b85a934bef315a06bcfe00c9c12a3627fed2b918
1904  Author: Brian Warner <warner@lothar.com>
1905  Date:   Mon Oct 3 23:03:07 2011 -0400
1906 
1907      Publish.bad_servers: fix bug, this should be a set of serverids, not writers
1908 
1909   src/allmydata/mutable/publish.py |    2 +-
1910   1 files changed, 1 insertions(+), 1 deletions(-)
1911 
1912  commit 605ea15ec15ed671513819003ccd211cdb9761e0
1913  Author: Brian Warner <warner@lothar.com>
1914  Date:   Mon Oct 3 23:00:21 2011 -0400
1915 
1916      change .placed
1917 
1918   src/allmydata/mutable/publish.py |    6 +++---
1919   1 files changed, 3 insertions(+), 3 deletions(-)
1920 
1921  commit f7aba37b1b345d5b6d5cb16e3b3f6f3c1afb658e
1922  Author: Brian Warner <warner@lothar.com>
1923  Date:   Mon Oct 3 22:59:22 2011 -0400
1924 
1925      temporarily stash IServer as .server on the "writer" object
1926 
1927   src/allmydata/mutable/publish.py |    2 ++
1928   1 files changed, 2 insertions(+), 0 deletions(-)
1929 
1930  commit f9b551d788e7db1f187fce5ab98ab5d5fe4e1c36
1931  Author: Brian Warner <warner@lothar.com>
1932  Date:   Mon Oct 3 22:48:18 2011 -0400
1933 
1934      change Publish.goal and API of log_goal() to use IServer, not serverid
1935 
1936   src/allmydata/mutable/publish.py |   48 ++++++++++++++--------------
1937   1 files changed, 24 insertions(+), 24 deletions(-)
1938 
1939  commit 75f20616558e4900b8b1f685dd99aa838de6d452
1940  Author: Brian Warner <warner@lothar.com>
1941  Date:   Mon Oct 3 15:27:02 2011 -0400
1942 
1943      API of ServerMap.get_known_shares()
1944 
1945   src/allmydata/mutable/publish.py   |   16 ++++++++++------
1946   src/allmydata/mutable/servermap.py |    7 ++-----
1947   2 files changed, 12 insertions(+), 11 deletions(-)
1948 
1949  commit 1c38c9d37bb08221b4418762234b1a62397b3b4b
1950  Author: Brian Warner <warner@lothar.com>
1951  Date:   Mon Oct 3 15:20:29 2011 -0400
1952 
1953      Publish.full_serverlist
1954 
1955   src/allmydata/mutable/publish.py |   10 +++++-----
1956   1 files changed, 5 insertions(+), 5 deletions(-)
1957 
1958  commit b6cbd215a04b9cde31a7d92a97a7f048622b16f1
1959  Author: Brian Warner <warner@lothar.com>
1960  Date:   Mon Oct 3 15:12:31 2011 -0400
1961 
1962      API of ServerMap.all_servers()
1963 
1964   src/allmydata/mutable/servermap.py |   19 ++++++-------------
1965   1 files changed, 6 insertions(+), 13 deletions(-)
1966 
1967  commit e63cd0315fae65357b1727ec6d5ff3c6e0d27c98
1968  Author: Brian Warner <warner@lothar.com>
1969  Date:   Mon Oct 3 15:10:18 2011 -0400
1970 
1971      remove ServerMap.connections, set_rref_for_serverid()
1972 
1973   src/allmydata/mutable/servermap.py |   11 +----------
1974   1 files changed, 1 insertions(+), 10 deletions(-)
1975 
1976  commit 4df52db2f80eb12eefa5d57103c24893cde89553
1977  Author: Brian Warner <warner@lothar.com>
1978  Date:   Mon Oct 3 15:04:06 2011 -0400
1979 
1980      API of ServerMap.mark_server_reachable()
1981 
1982   src/allmydata/mutable/servermap.py |    7 ++-----
1983   1 files changed, 2 insertions(+), 5 deletions(-)
1984 
1985  commit 69c715bde77944dc25181b3dbbeb042c816f9a1b
1986  Author: Brian Warner <warner@lothar.com>
1987  Date:   Mon Oct 3 15:03:21 2011 -0400
1988 
1989      API of ServerMap.mark_server_unreachable()
1990 
1991   src/allmydata/mutable/servermap.py |    9 +++------
1992   1 files changed, 3 insertions(+), 6 deletions(-)
1993 
1994  commit 3d784d60eec1c508858e3a617e4411ffbcc3c1fa
1995  Author: Brian Warner <warner@lothar.com>
1996  Date:   Mon Oct 3 15:02:03 2011 -0400
1997 
1998      API of status.set_privkey_from()
1999 
2000   src/allmydata/mutable/servermap.py |    7 +++----
2001   1 files changed, 3 insertions(+), 4 deletions(-)
2002 
2003  commit 544ed3ea29bed7e66da7fd29ca3f6f076f27a9e6
2004  Author: Brian Warner <warner@lothar.com>
2005  Date:   Mon Oct 3 15:01:15 2011 -0400
2006 
2007      API of status.add_per_server_time()
2008 
2009   src/allmydata/mutable/servermap.py |    7 ++++---
2010   1 files changed, 4 insertions(+), 3 deletions(-)
2011 
2012  commit fffe5008b6320bd1e04c3c68389a2bf2ee383fa8
2013  Author: Brian Warner <warner@lothar.com>
2014  Date:   Mon Oct 3 14:59:02 2011 -0400
2015 
2016      remove unused .versionmap
2017 
2018   src/allmydata/mutable/servermap.py |    7 -------
2019   1 files changed, 0 insertions(+), 7 deletions(-)
2020 
2021  commit 2816562e090d2294179db3588dafcca18de1bc2b
2022  Author: Brian Warner <warner@lothar.com>
2023  Date:   Mon Oct 3 14:57:51 2011 -0400
2024 
2025      remove serverid from all log messages. Also one unused lambda.
2026 
2027   src/allmydata/mutable/servermap.py |   30 +++++++++++++-------------
2028   1 files changed, 15 insertions(+), 15 deletions(-)
2029 
2030  commit 28fa6b1a2738fa98c1f1dbd3d0e01ae98912d11f
2031  Author: Brian Warner <warner@lothar.com>
2032  Date:   Mon Oct 3 14:54:30 2011 -0400
2033 
2034      removed unused _readers
2035 
2036   src/allmydata/mutable/servermap.py |    3 ---
2037   1 files changed, 0 insertions(+), 3 deletions(-)
2038 
2039  commit a8e4ed3d645ab592d1add6a1e69b6d1ebfb77817
2040  Author: Brian Warner <warner@lothar.com>
2041  Date:   Mon Oct 3 14:54:16 2011 -0400
2042 
2043      remove unused _sharemap
2044 
2045   src/allmydata/mutable/servermap.py |    1 -
2046   1 files changed, 0 insertions(+), 1 deletions(-)
2047 
2048  commit 3f072e55cf1d0700f9fffe23f8f3a475725df588
2049  Author: Brian Warner <warner@lothar.com>
2050  Date:   Mon Oct 3 14:49:03 2011 -0400
2051 
2052      _must_query
2053 
2054   src/allmydata/mutable/servermap.py |    8 ++++----
2055   1 files changed, 4 insertions(+), 4 deletions(-)
2056 
2057  commit c599a059b8df3f5785e4bf89fb6ecc6d8dcd708b
2058  Author: Brian Warner <warner@lothar.com>
2059  Date:   Mon Oct 3 14:48:05 2011 -0400
2060 
2061      _queries_outstanding
2062 
2063   src/allmydata/mutable/servermap.py |   16 +++++++---------
2064   1 files changed, 7 insertions(+), 9 deletions(-)
2065 
2066  commit 7743759f98ac2c07926b2fdbd80bf52dfab33085
2067  Author: Brian Warner <warner@lothar.com>
2068  Date:   Mon Oct 3 14:46:17 2011 -0400
2069 
2070      _empty_servers
2071 
2072   src/allmydata/mutable/servermap.py |    5 ++---
2073   1 files changed, 2 insertions(+), 3 deletions(-)
2074 
2075  commit 6bb1825916828a713a32cdf7f7411fa3ea2e1e5d
2076  Author: Brian Warner <warner@lothar.com>
2077  Date:   Mon Oct 3 14:45:39 2011 -0400
2078 
2079      _good_servers
2080 
2081   src/allmydata/mutable/servermap.py |    4 ++--
2082   1 files changed, 2 insertions(+), 2 deletions(-)
2083 
2084  commit 1768fab1b51d8dd93ecabbaaabfadfa20cf6c3d4
2085  Author: Brian Warner <warner@lothar.com>
2086  Date:   Mon Oct 3 14:44:59 2011 -0400
2087 
2088      _bad_servers
2089 
2090   src/allmydata/mutable/servermap.py |   14 +++++++-------
2091   1 files changed, 7 insertions(+), 7 deletions(-)
2092 
2093  commit dccbaef30f0ba714c746bf6d4a1a803c36e17b65
2094  Author: Brian Warner <warner@lothar.com>
2095  Date:   Mon Oct 3 14:41:54 2011 -0400
2096 
2097      API of _try_to_set_pubkey()
2098 
2099   src/allmydata/mutable/servermap.py |    7 ++++---
2100   1 files changed, 4 insertions(+), 3 deletions(-)
2101 
2102  commit 0481ea70042ba3575f15eac7fd0780f8ece580cc
2103  Author: Brian Warner <warner@lothar.com>
2104  Date:   Mon Oct 3 14:35:02 2011 -0400
2105 
2106      API of notify_server_corruption()
2107 
2108   src/allmydata/mutable/servermap.py |    6 +++---
2109   1 files changed, 3 insertions(+), 3 deletions(-)
2110 
2111  commit bea9cba18fb3b9c11bb22f18356a263ecec7351e
2112  Author: Brian Warner <warner@lothar.com>
2113  Date:   Mon Oct 3 14:34:09 2011 -0400
2114 
2115      API of _got_signature_one_share()
2116 
2117   src/allmydata/mutable/servermap.py |    9 +++++----
2118   1 files changed, 5 insertions(+), 4 deletions(-)
2119 
2120  commit 1520123583cf78650706e114b15bb5b0ac1f4a14
2121  Author: Brian Warner <warner@lothar.com>
2122  Date:   Mon Oct 3 14:32:33 2011 -0400
2123 
2124      API of _try_to_validate_privkey()
2125 
2126   src/allmydata/mutable/servermap.py |    9 +++++----
2127   1 files changed, 5 insertions(+), 4 deletions(-)
2128 
2129  commit 938852c9c8519c7a078f58a9b1f4dd8ec8b6715e
2130  Author: Brian Warner <warner@lothar.com>
2131  Date:   Mon Oct 3 14:31:48 2011 -0400
2132 
2133      API and internals of _add_lease_failed()
2134 
2135   src/allmydata/mutable/servermap.py |    8 ++++----
2136   1 files changed, 4 insertions(+), 4 deletions(-)
2137 
2138  commit 3843dba367e3c19e176a622ab853cb51d2472ddf
2139  Author: Brian Warner <warner@lothar.com>
2140  Date:   Mon Oct 3 14:30:37 2011 -0400
2141 
2142      API of _privkey_query_failed()
2143 
2144   src/allmydata/mutable/servermap.py |    5 +++--
2145   1 files changed, 3 insertions(+), 2 deletions(-)
2146 
2147  commit 2219a710e1633cd57d0ca0786490de87b3e19ba7
2148  Author: Brian Warner <warner@lothar.com>
2149  Date:   Mon Oct 3 14:29:43 2011 -0400
2150 
2151      fix bug in call to _privkey_query_failed, unrelated to refactoring
2152 
2153   src/allmydata/mutable/servermap.py |    2 +-
2154   1 files changed, 1 insertions(+), 1 deletions(-)
2155 
2156  commit ae615bec7d0d1b269710b6902797b12f9592ad62
2157  Author: Brian Warner <warner@lothar.com>
2158  Date:   Mon Oct 3 14:27:17 2011 -0400
2159 
2160      API of _got_corrupt_share()
2161 
2162   src/allmydata/mutable/servermap.py |   17 +++++++++--------
2163   1 files changed, 9 insertions(+), 8 deletions(-)
2164 
2165  commit cb51c95a6f4e077278157a77dab060c8c1ad7a81
2166  Author: Brian Warner <warner@lothar.com>
2167  Date:   Mon Oct 3 14:23:16 2011 -0400
2168 
2169      API of _got_results()
2170 
2171   src/allmydata/mutable/servermap.py |    9 +++++----
2172   1 files changed, 5 insertions(+), 4 deletions(-)
2173 
2174  commit bac9154fe0af18f226999a58ffc2362d8cf4b802
2175  Author: Brian Warner <warner@lothar.com>
2176  Date:   Mon Oct 3 14:19:19 2011 -0400
2177 
2178      API of _query_failed()
2179 
2180   src/allmydata/mutable/servermap.py |    5 +++--
2181   1 files changed, 3 insertions(+), 2 deletions(-)
2182 
2183  commit fdc29a8ca95d4b5c503e5382b9e5d4d02141ba12
2184  Author: Brian Warner <warner@lothar.com>
2185  Date:   Mon Oct 3 14:17:20 2011 -0400
2186 
2187      API of _do_read()
2188 
2189   src/allmydata/mutable/servermap.py |    6 ++++--
2190   1 files changed, 4 insertions(+), 2 deletions(-)
2191 
2192  commit e7e9e338f28d004aa4d423d11c65f1e271ac7322
2193  Author: Brian Warner <warner@lothar.com>
2194  Date:   Mon Oct 3 14:20:21 2011 -0400
2195 
2196      API of _do_query()
2197 
2198   src/allmydata/mutable/servermap.py |   15 +++++++--------
2199   1 files changed, 7 insertions(+), 8 deletions(-)
2200 
2201  commit 330625b9dac4cdbe72a11464a893065b9aeed453
2202  Author: Brian Warner <warner@lothar.com>
2203  Date:   Mon Oct 3 14:43:05 2011 -0400
2204 
2205      next step: first batch of updates to ServermapUpdater
2206 
2207      updates:
2208       most method-local variables in update()
2209       API of _build_initial_querylist()
2210       API of _send_initial_requests()
2211       .full_serverlist
2212       .extra_servers
2213 
2214   src/allmydata/mutable/servermap.py |   39 ++++++++++++++------------
2215   1 files changed, 21 insertions(+), 18 deletions(-)
2216 
2217  commit 4aadc584fa7dcb2daa86b048c81dee0049ba26d9
2218  Author: Brian Warner <warner@lothar.com>
2219  Date:   Mon Oct 3 15:07:00 2011 -0400
2220 
2221      internal change: index _bad_shares with IServer
2222 
2223   src/allmydata/mutable/servermap.py |   20 ++++++++++----------
2224   1 files changed, 10 insertions(+), 10 deletions(-)
2225 
2226  commit 16d4e6fa82a9907dbdc92094213387c6a4164e41
2227  Author: Brian Warner <warner@lothar.com>
2228  Date:   Mon Oct 3 18:20:47 2011 +0100
2229 
2230      internal change: index _known_shares with IServer instead of serverid
2231 
2232      callers are unchanged
2233 
2234   src/allmydata/mutable/servermap.py |   42 +++++++++++++++----------
2235   1 files changed, 25 insertions(+), 17 deletions(-)
2236 
2237  commit ceeb5f4938cc814a0c75d1b8f4018aed965c2176
2238  Author: Brian Warner <warner@lothar.com>
2239  Date:   Mon Oct 3 18:11:43 2011 +0100
2240 
2241      accessors and name cleanup for servermap.Servermap.last_update_mode/time
2242 
2243   src/allmydata/mutable/filenode.py  |    6 +++---
2244   src/allmydata/mutable/publish.py   |    4 ++--
2245   src/allmydata/mutable/servermap.py |   17 +++++++++++------
2246   3 files changed, 16 insertions(+), 11 deletions(-)
2247 
2248  commit 8d3cbda82661c0a7e5c3d3b65cf7a5d5ab7e32c0
2249  Author: Brian Warner <warner@lothar.com>
2250  Date:   Mon Oct 3 18:11:14 2011 +0100
2251 
2252      accessors and name cleanup for servermap.Servermap.problems
2253 
2254   src/allmydata/mutable/servermap.py |   21 +++++++++++++--------
2255   src/allmydata/test/test_mutable.py |    6 +++---
2256   2 files changed, 16 insertions(+), 11 deletions(-)
2257 
2258  commit 348f57988f79389db0aab7672e6eaa9a6d8e3219
2259  Author: Brian Warner <warner@lothar.com>
2260  Date:   Mon Oct 3 18:10:41 2011 +0100
2261 
2262      accessors and name cleanup for servermap.Servermap.bad_shares
2263 
2264   src/allmydata/mutable/publish.py   |    2 +-
2265   src/allmydata/mutable/servermap.py |   30 ++++++++++++++-----------
2266   2 files changed, 18 insertions(+), 14 deletions(-)
2267 
2268  commit 520c9368134673cdf76c653c5e1bb91c2ab5d51e
2269  Author: Brian Warner <warner@lothar.com>
2270  Date:   Mon Oct 3 18:10:05 2011 +0100
2271 
2272      accessors and name cleanup for servermap.Servermap.servermap .
2273 
2274   src/allmydata/mutable/publish.py   |   14 +++++----
2275   src/allmydata/mutable/servermap.py |   38 ++++++++++++++-----------
2276   2 files changed, 29 insertions(+), 23 deletions(-)
2277 
2278  commit b8b8dc38287a91dbdf494426ac801d9381ce5841
2279  Author: Brian Warner <warner@lothar.com>
2280  Date:   Mon Oct 3 18:08:02 2011 +0100
2281 
2282      fix reachable_servers
2283 
2284   src/allmydata/mutable/checker.py   |    3 ++-
2285   src/allmydata/mutable/publish.py   |    4 +++-
2286   src/allmydata/mutable/servermap.py |   12 ++++++++++--
2287   3 files changed, 15 insertions(+), 4 deletions(-)
2288 
2289  commit cb0cfd1adfefad357c187aaaf690c3df68b622bc
2290  Author: Brian Warner <warner@lothar.com>
2291  Date:   Mon Oct 3 18:06:03 2011 +0100
2292 
2293      fix Servermap.unreachable_servers
2294 
2295   src/allmydata/mutable/servermap.py |   11 ++++++++---
2296   1 files changed, 8 insertions(+), 3 deletions(-)
2297 
2298  commit 2d9ea79b94bd4db674d40386fda90825785ac495
2299  Author: Brian Warner <warner@lothar.com>
2300  Date:   Mon Oct 3 18:03:48 2011 +0100
2301 
2302      give ServerMap a StorageFarmBroker, temporary
2303 
2304      this makes it possible for the ServerMap to accept bare serverids and still
2305      build data structures with IServers
2306 
2307   src/allmydata/mutable/checker.py   |    2 +-
2308   src/allmydata/mutable/filenode.py  |    2 +-
2309   src/allmydata/mutable/publish.py   |    2 +-
2310   src/allmydata/mutable/servermap.py |    5 +++--
2311   src/allmydata/test/test_mutable.py |    8 ++++----
2312   5 files changed, 10 insertions(+), 9 deletions(-)
2313 
2314  commit 718d1aeff6fded893f65397806d22ece928b0dd4
2315  Author: Brian Warner <warner@lothar.com>
2316  Date:   Mon Oct 3 13:43:30 2011 -0400
2317 
2318      add StorageFarmBroker.get_server_for_id(), temporary helper
2319 
2320      This will go away once we're passing IServers everywhere.
2321 
2322   src/allmydata/storage_client.py  |    2 ++
2323   src/allmydata/test/no_network.py |   13 +++++++++++++
2324   2 files changed, 15 insertions(+), 0 deletions(-)
2325 
2326  commit ece20231d7fda0d503704842a4aa068dfbc2e54e
2327  Author: Brian Warner <warner@lothar.com>
2328  Date:   Sun Oct 2 01:11:50 2011 +0100
2329 
2330      add proper accessors for Servermap.connections, to make refactoring easier
2331 
2332   src/allmydata/mutable/publish.py   |    6 +++---
2333   src/allmydata/mutable/retrieve.py  |   10 +++++-----
2334   src/allmydata/mutable/servermap.py |   17 +++++++++++------
2335   3 files changed, 19 insertions(+), 14 deletions(-)
2336 
2337  commit 3b943d6bf302ff702668081a612fc4fe2604cf9c
2338  Author: Brian Warner <warner@lothar.com>
2339  Date:   Fri Sep 23 10:34:30 2011 -0700
2340 
2341      mutable/servermap.py and neighbors: s/peer/server/
2342 
2343   src/allmydata/mutable/checker.py   |   22 +-
2344   src/allmydata/mutable/publish.py   |  204 +++++++-------
2345   src/allmydata/mutable/servermap.py |  402 +++++++++++++-------------
2346   src/allmydata/test/test_mutable.py |   18 +-
2347   4 files changed, 323 insertions(+), 323 deletions(-)
2348] 
2349[TAG allmydata-tahoe-1.9.0
2350warner@lothar.com**20111031052301
2351 Ignore-this: cf598210dd1f314a1a121bf29a3d5918
2352] 
2353Patch bundle hash:
23548f25b032bd150b042d38fe8cd94df3dbfe325121