Ticket #393: 393-zero-length-reads-todo.darcs.patch

File 393-zero-length-reads-todo.darcs.patch, 47.1 KB (added by davidsarah, at 2011-08-25T03:18:33Z)

test_mutable.py: mark zero-length read tests as TODO. refs #393

Line 
11 patch for repository /home/davidsarah/tahoe/snotty:
2
3Thu Aug 25 03:09:24 BST 2011  david-sarah@jacaranda.org
4  * test_mutable.py: mark zero-length read tests as TODO. refs #393
5
6New patches:
7
8[test_mutable.py: mark zero-length read tests as TODO. refs #393
9david-sarah@jacaranda.org**20110825020924
10 Ignore-this: da6efe6357224e5d58bc0e91a52a5f28
11] hunk ./src/allmydata/test/test_mutable.py 3262
12     def test_partial_read_zero_length_at_segment_boundary(self):
13         return self._test_partial_read(mathutil.next_multiple(128 * 1024, 3), 0)
14 
15+    test_partial_read_zero_length_at_start.todo = "zero-length reads of mutable files don't work"
16+    test_partial_read_zero_length_in_middle.todo = "zero-length reads of mutable files don't work"
17+    test_partial_read_zero_length_at_segment_boundary.todo = "zero-length reads of mutable files don't work"
18+
19     def _test_read_and_download(self, node, expected):
20         d = node.get_best_readable_version()
21         def _read_data(version):
22
23Context:
24
25[Fix interfaces related to MDMF. refs #393
26david-sarah@jacaranda.org**20110825013046
27 Ignore-this: ee510c7261f8b328f0db218d71208ca3
28]
29[interfaces.py: 'which -> that' grammar cleanup.
30david-sarah@jacaranda.org**20110825003217
31 Ignore-this: a3e15f3676de1b346ad78aabdfb8cac6
32]
33[Minor improvements to documentation for MDMF. refs #393
34david-sarah@jacaranda.org**20110823012431
35 Ignore-this: 7a1b1b3a8aea0d69cbc0ed93beb2c7f1
36]
37[docs/configuration.rst: add section about the types of node, and clarify when setting web.port enables web-API service. refs #1444
38david-sarah@jacaranda.org**20110812154808
39 Ignore-this: 817e49edf648f8ec8a291ae11aaa6a96
40]
41[docs/frontends/webapi.txt: minor corrections; remove reference to test grid.
42david-sarah@jacaranda.org**20110811000158
43 Ignore-this: c7adcad548440755902af78f4b424378
44]
45[docs/frontends/webapi.txt: clean up formatting (tabs->spaces).
46david-sarah@jacaranda.org**20110811000013
47 Ignore-this: 4021abb804775e78fe317d577d8e4803
48]
49[docs/frontends/webapi.txt: clean up formatting (reflow).
50david-sarah@jacaranda.org**20110810235706
51 Ignore-this: d87a5a64d906067153182056616d4eeb
52]
53[Additional tests for MDMF URIs and for zero-length files. refs #393
54david-sarah@jacaranda.org**20110823011532
55 Ignore-this: a7cc0c09d1d2d72413f9cd227c47a9d5
56]
57[Additional tests for zero-length partial reads and updates to mutable versions. refs #393
58david-sarah@jacaranda.org**20110822014111
59 Ignore-this: 5fc6f4d06e11910124e4a277ec8a43ea
60]
61[Implementation, tests and docs for blacklists. This version allows listing directories containing a blacklisted child. Inclusion of blacklist.py fixed. fixes #1425
62david-sarah@jacaranda.org**20110824155928
63 Ignore-this: a306f36bb6640eaf046e66dc4beeb11c
64]
65[Make the immutable/read-only constraint checking for MDMF URIs identical to that for SSK URIs. refs #393
66david-sarah@jacaranda.org**20110823012720
67 Ignore-this: e1f59d7ff2007c81dbef2aeb14abd721
68]
69[mutable/layout.py: fix unused import. refs #393
70david-sarah@jacaranda.org**20110816225043
71 Ignore-this: 7c9d6d91521ceb9a7abd14b2c60c0604
72]
73[mutable/retrieve.py: cosmetics and remove a stale comment. refs #393
74david-sarah@jacaranda.org**20110816214612
75 Ignore-this: 916e60c9dff1ef85595822e609ff34b7
76]
77[mutable/filenode.py: don't fetch more segments than necesasry to update the file
78Kevan Carstensen <kevan@isnotajoke.com>**20110813210005
79 Ignore-this: 2b0ad0533baa6f19f18851317dfc9f15
80]
81[test/test_mutable: test for incorrect div_ceil equations
82Kevan Carstensen <kevan@isnotajoke.com>**20110813183936
83 Ignore-this: 74e6061ab2ec5e706a1235611f87d5d6
84]
85[mutable/retrieve.py: use floor division to calculate segment boundaries, don't fetch more segments than necessary
86Kevan Carstensen <kevan@isnotajoke.com>**20110813183833
87 Ignore-this: 3e272249107afd3fbc1dd30c6a4f1e31
88]
89[mdmf: clean up boolean expressions, correct typos, remove self._paused, and don't unconditionally initialize block hash trees, asll as suggested by davidsarahs' review comments
90Kevan Carstensen <kevan@isnotajoke.com>**20110813183710
91 Ignore-this: cc6ad9f98b64f379151aa58b77b6c4e5
92]
93[now that tests pass with full-size keys, return test-keys to normal (522bit)
94warner@lothar.com**20110811175418
95 Ignore-this: dbce8a6699ba9a90d91cffbc8aa87900
96]
97[fix SHARE_HASH_CHAIN_SIZE computation
98warner@lothar.com**20110811175350
99 Ignore-this: 4508359d2207c8c1b7552b546697264
100]
101[More idiomatic resolution of the conflict between ticket393-MDMF-2 and trunk. refs #393
102david-sarah@jacaranda.org**20110810202942
103 Ignore-this: 7fc54a30ab0bc6ce75b7d819800c1182
104]
105[Replace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE constant defined in test/common.py (part 2). refs #393
106david-sarah@jacaranda.org**20110810202310
107 Ignore-this: 7fbd4d004279599bbcb10f7b31fb010f
108]
109[Replace the hard-coded 522-bit RSA key size used for tests with a TEST_RSA_KEY_SIZE constant defined in test/common.py (part 1). refs #393
110david-sarah@jacaranda.org**20110810202243
111 Ignore-this: c58d8130a2f383ff4421c632499b027b
112]
113[merge some minor conflicts in test code from the 393-2 branch and trunk
114zooko@zooko.com**20110810172139
115 Ignore-this: 4a16f13eeae585c7c1dbe18c67072c90
116]
117[doc: eliminate the phrase "rootcap" from doc/frontends/FTP-and-SFTP.rst
118zooko@zooko.com**20110809132601
119 Ignore-this: f7e1dd212daa65c81fb57977bce24304
120 Two different people have asked me for help, saying they couldn't figure out what a "rootcap" is. Hopefully just calling it a "cap" will make it easier for them to find out from the other docs what it is.
121]
122[test_web.py: fix a test failure dependent on whether simplejson.loads returns a unicode or str object.
123david-sarah@jacaranda.org**20110808213925
124 Ignore-this: f7b267be8be56fcabc968e3c89999490
125]
126[immutable/filenode: fix pyflakes warnings
127Kevan Carstensen <kevan@isnotajoke.com>**20110807004514
128 Ignore-this: e8d875bf8b1c5571e31b0eff42ecf64c
129]
130[test: fix assorted tests broken by MDMF changes
131Kevan Carstensen <kevan@isnotajoke.com>**20110807004459
132 Ignore-this: 9a0dc7e5c74bfe840a9fce278619a103
133]
134[uri: add MDMF and MDMF directory caps, add extension hint support
135Kevan Carstensen <kevan@isnotajoke.com>**20110807004436
136 Ignore-this: 6486b7d4dc0e849c6b1e9cdfb6318eac
137]
138[test/test_mutable: tests for MDMF
139Kevan Carstensen <kevan@isnotajoke.com>**20110807004414
140 Ignore-this: 29f9c3a806d67df0ed09c4f0d857d347
141 
142 These are their own patch because they cut across a lot of the changes
143 I've made in implementing MDMF in such a way as to make it difficult to
144 split them up into the other patches.
145]
146[webapi changes for MDMF
147Kevan Carstensen <kevan@isnotajoke.com>**20110807004348
148 Ignore-this: d6d4dac680baa4c99b05882b3828796c
149 
150     - Learn how to create MDMF files and directories through the
151       mutable-type argument.
152     - Operate with the interface changes associated with MDMF and #993.
153     - Learn how to do partial updates of mutable files.
154]
155[mutable/servermap: Rework the servermap to work with MDMF mutable files
156Kevan Carstensen <kevan@isnotajoke.com>**20110807004259
157 Ignore-this: 154b987fa0af716c41185b88ff7ee2e1
158]
159[dirnode: teach dirnode to make MDMF directories
160Kevan Carstensen <kevan@isnotajoke.com>**20110807004224
161 Ignore-this: 765ccd6a07ff752bf6057a3dab9e5abd
162]
163[Fix some test failures caused by #393 patch.
164david-sarah@jacaranda.org**20110802032810
165 Ignore-this: 7f65e5adb5c859af289cea7011216fef
166]
167[docs: amend configuration, webapi documentation to talk about MDMF
168Kevan Carstensen <kevan@isnotajoke.com>**20110802022056
169 Ignore-this: 4cab9b7e4ab79cc1efdabe2d457f27a6
170]
171[cli: teach CLI how to create MDMF mutable files
172Kevan Carstensen <kevan@isnotajoke.com>**20110802021613
173 Ignore-this: 18d0ff98e75be231eed3c53319e76936
174 
175 Specifically, 'tahoe mkdir' and 'tahoe put' now take a --mutable-type
176 argument.
177]
178[frontends/sftpd: Resolve incompatibilities between SFTP frontend and MDMF changes
179Kevan Carstensen <kevan@isnotajoke.com>**20110802021207
180 Ignore-this: 5e0f6e961048f71d4eed6d30210ffd2e
181]
182[mutable/layout: Define MDMF share format, write tools for working with MDMF share format
183Kevan Carstensen <kevan@isnotajoke.com>**20110802021120
184 Ignore-this: fa76ef4800939e19ba3cbc22a2eab4e
185 
186 The changes in layout.py are mostly concerned with the MDMF share
187 format. In particular, we define read and write proxy objects used by
188 retrieval, publishing, and other code to write and read the MDMF share
189 format. We create equivalent proxies for SDMF objects so that these
190 objects can be suitably general.
191]
192[immutable/filenode: implement unified filenode interface
193Kevan Carstensen <kevan@isnotajoke.com>**20110802020905
194 Ignore-this: d9a442fc285157f134f5d1b4607c6a48
195]
196[immutable/literal.py: Implement interface changes in literal nodes.
197Kevan Carstensen <kevan@isnotajoke.com>**20110802020814
198 Ignore-this: 4371e71a50e65ce2607c4d67d3a32171
199]
200[test/common: Alter common test code to work with MDMF.
201Kevan Carstensen <kevan@isnotajoke.com>**20110802015643
202 Ignore-this: e564403182d0030439b168dd9f8726fa
203 
204 This mostly has to do with making the test code implement the new
205 unified filenode interfaces.
206]
207[mutable: train checker and repairer to work with MDMF mutable files
208Kevan Carstensen <kevan@isnotajoke.com>**20110802015140
209 Ignore-this: 8b1928925bed63708b71ab0de8d4306f
210]
211[nodemaker: teach nodemaker about MDMF caps
212Kevan Carstensen <kevan@isnotajoke.com>**20110802014926
213 Ignore-this: 430c73121b6883b99626cfd652fc65c4
214]
215[client: teach client how to create and work with MDMF files
216Kevan Carstensen <kevan@isnotajoke.com>**20110802014811
217 Ignore-this: d72fbc4c2ca63f00d9ab9dc2919098ff
218]
219[mutable/filenode: Modify mutable filenodes for use with MDMF
220Kevan Carstensen <kevan@isnotajoke.com>**20110802014501
221 Ignore-this: 3c230bb0ebe60a94c667b0ee0c3b28e0
222 
223 In particular:
224     - Break MutableFileNode and MutableFileVersion into distinct classes.
225     - Implement the interface modifications made for MDMF.
226     - Be aware of MDMF caps.
227     - Learn how to create and work with MDMF files.
228]
229[nodemaker: teach nodemaker how to create MDMF mutable files
230Kevan Carstensen <kevan@isnotajoke.com>**20110802014258
231 Ignore-this: 2bf1fd4f8c1d1ad0e855c678347b76c2
232]
233[interfaces: change interfaces to work with MDMF
234Kevan Carstensen <kevan@isnotajoke.com>**20110802014119
235 Ignore-this: 2f441022cf888c044bc9e6dd609db139
236 
237 A lot of this work concerns #993, in that it unifies (to an extent) the
238 interfaces of mutable and immutable files.
239]
240[mutable/publish: teach the publisher how to publish MDMF mutable files
241Kevan Carstensen <kevan@isnotajoke.com>**20110802013931
242 Ignore-this: 115217ec2b289452ec774cb725da8a86
243 
244 Like the downloader, the publisher needs some substantial changes to handle multiple segment mutable files.
245]
246[mutable/retrieve: rework the mutable downloader to handle multiple-segment files
247Kevan Carstensen <kevan@isnotajoke.com>**20110802013524
248 Ignore-this: 398d11b5cb993b50e5e4fa6e7a3856dc
249 
250 The downloader needs substantial reworking to handle multiple segment
251 mutable files, which it needs to handle for MDMF.
252]
253[Fix repeated 'the' in license text.
254david-sarah@jacaranda.org**20110819204836
255 Ignore-this: b3bd4e9ec22029fe15533ad2a60003ad
256]
257[Remove Non-Profit Open Software License from the set of 'added permission' licenses. Although it actually does qualify as an Open Source license (because it allows relicensing under plain OSL), its wording is unclear and could easily be misunderstood, and it contributes to incompatible license proliferation.
258david-sarah@jacaranda.org**20110819204742
259 Ignore-this: 7373819a6b5367581356728ea62cabb1
260]
261[docs: change links that pointed to COPYING.TGPPL.html to point to COPYING.TGPPL.rst instead
262zooko@zooko.com**20110819060142
263 Ignore-this: 301652554fd7ab4bfa5aa8f8a2863a9e
264]
265[docs: formatting: reflow to fill-column 77
266zooko@zooko.com**20110819060110
267 Ignore-this: ed1317c126f07c63b944bd2fa6aa2d21
268]
269[docs: formatting: M-x whitespace-cleanup
270zooko@zooko.com**20110819060041
271 Ignore-this: 8554b16a25067094d0dc4dc71e1b3950
272]
273[licensing: add to the list of licenses that we grant the added permission for
274zooko@zooko.com**20110819054656
275 Ignore-this: eb1490416ac6b7414a27f150a8a8a047
276 Added: most of the ones listed on the FSF's "List of Free Software, GPL Incompatible Licenses", plus the Non-Profit Open Software License.
277]
278[docs: reflow the added text at the top of COPYING.GPL to fill-column 77
279zooko@zooko.com**20110819053059
280 Ignore-this: e994ed6ffbcc12656406f11cb862ce99
281]
282[docs: reformat COPYING.TGPPL.html to COPYING.TGPPL.rst
283zooko@zooko.com**20110819052753
284 Ignore-this: 34ddf623e0a6de008ba859ca9c92b2fd
285]
286[docs: reflow docs/logging.rst to fill-column 77
287zooko@zooko.com**20110819044103
288 Ignore-this: a6901f2244995f278ddf8d75d29410bf
289]
290[doc: fix formatting error in docs/logging.rst
291zooko@zooko.com**20110819043946
292 Ignore-this: fa182dbbe7f4fda15e0a8bfcf7f00051
293]
294[Cleanups for suppression of UserWarnings. refs #1435
295david-sarah@jacaranda.org**20110818040749
296 Ignore-this: 3863ef399c1c382a1365d51f000d314c
297]
298[suppress warning emitted by newer zope.interface with Nevow 0.10
299zooko@zooko.com**20110817203134
300 Ignore-this: b86d4ce0ed1c0da76d1f9eaf8d08d9c4
301 refs #1435
302]
303[doc: formatting: reflow to fill-column=77
304zooko@zooko.com**20110809132510
305 Ignore-this: 2d6d2e203d52925968b4451f36364792
306]
307[_auto_deps.py: change the requirement for zope.interface to <= 3.6.2, >= 3.6.6. fixes #1435
308david-sarah@jacaranda.org**20110815025347
309 Ignore-this: 17a88c0f6573f044fbcd6b666667bd37
310]
311[allmydata/__init__.py, test_version.py: make version parsing understand '<=', with test. refs #1435
312david-sarah@jacaranda.org**20110815035153
313 Ignore-this: 8c3a75f4a2b42b56bac48b5053c5e9c2
314]
315[Makefile and setup.py: remove setup.py commands that we no longer need, and their uses in the Makefile. Delete a stale and incorrect comment about updating _version.py. Also fix some coding style checks in the Makefile to operate on all source files.
316david-sarah@jacaranda.org**20110801031952
317 Ignore-this: 80a435dee3bc6e29058d4b37ff579922
318]
319[remove misc/debian[_helpers], rely upon official packaging instead. fixes #1454
320warner@lothar.com**20110811182705
321 Ignore-this: 79673cafc7c108db49b5ab908d7b4668
322]
323[Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454
324david-sarah@jacaranda.org**20110801031857
325 Ignore-this: 347cbeff45757db630ce34d0cfb84f92
326]
327[replace tabs with spaces in the #1441 'tahoe debug' synopsis
328warner@lothar.com**20110811173704
329 Ignore-this: 513fbfb18a3dd93119ea3700118df7ee
330]
331[Correct the information printed by '/usr/bin/tahoe debug --help' on Debian/Ubuntu. fixes #1441
332david-sarah@jacaranda.org**20110724162530
333 Ignore-this: 30d4b8c20e420e9a9d1b73eba1113ae
334]
335[doc: edit the explanation of K-of-N tradeoffs
336zooko@zooko.com**20110804193409
337 Ignore-this: ab6f4e35a995c2099340b5c9c5d30f40
338]
339[doc: clean up formatting of doc/configuration.rst
340zooko@zooko.com**20110804192722
341 Ignore-this: 7a98a3a8afb7e5441ff1f534211199ba
342 reflow to 77 chars line width, M-x white-space cleanup, blank link between name and definition
343]
344[Add test for webopen. fixes #1149
345david-sarah@jacaranda.org**20110724211659
346 Ignore-this: 1e22853f7eb05e24c3141d56a513f661
347]
348[test_client.py: relax a check in test_create_drop_uploader so that it should pass on Python 2.4.x. refs #1429
349david-sarah@jacaranda.org**20110810052504
350 Ignore-this: 1380749ceaf33c30e26c50d57476616c
351]
352[test/common_util.py: correct fix to mkdir_nonascii. refs #1472
353david-sarah@jacaranda.org**20110810051906
354 Ignore-this: 93c0c33370bc47d95c26c4cce8e05290
355]
356[test/common_util.py: fix a typo. refs #1472
357david-sarah@jacaranda.org**20110810044235
358 Ignore-this: f88643d7c82cb3577686d77bbff9e2bc
359]
360[test_client.py, test_drop_upload.py: fix pyflakes warnings.
361david-sarah@jacaranda.org**20110810034505
362 Ignore-this: 1e2d71bf2f43d63cbb423d32a6f96793
363]
364[Factor out methods dealing with non-ASCII directories and filenames from test_drop_upload.py into common_util.py. refs #1429, #1472
365david-sarah@jacaranda.org**20110810031558
366 Ignore-this: 3de8f945fa7a58fc318a1184bad0fd1a
367]
368[test_client.py: add a test that the drop-uploader is initialized correctly by client.py. Also give the DropUploader service a name, which is necessary for the test. refs #1429
369david-sarah@jacaranda.org**20110810030538
370 Ignore-this: 13d511ea9bbe9da2dcffe4a91ce94eae
371]
372[drop-upload: rename 'start' method to 'startService', which is what you're supposed to use to start a Service. refs #1429
373david-sarah@jacaranda.org**20110810030345
374 Ignore-this: d1f5e5c63937ea37be37324e2f1ae99d
375]
376[test_drop_upload.py: add comment explaining why we don't use FilePath.setContent. refs #1429
377david-sarah@jacaranda.org**20110810025942
378 Ignore-this: b95358030b63cb467d1d7f1b9a9b6978
379]
380[test_drop_upload.py: fix some grammatical and spelling nits. refs #1429
381david-sarah@jacaranda.org**20110809221231
382 Ignore-this: fd331acddd9f754173f274a34fe62f03
383]
384[drop-upload: report the configured local directory being absent differently from it being a file
385zooko@zooko.com**20110809220930
386 Ignore-this: a08879100f5f20e609be3f0ffa3b25cc
387 refs #1429
388]
389[drop-upload: rename the 'upload.uri' parameter to 'upload.dircap', and a couple of cleanups to error messages. refs #1429
390zooko@zooko.com**20110809220508
391 Ignore-this: 4846368cbe331e8653bdce1f314e276b
392 I rerecorded this patch, originally by David-Sarah, to use "darcs replace" instead of editing to do the renames. This uncovered one missed rename in Client.init_drop_uploader. (Which also means that code isn't exercised by the current unit tests.)
393 refs #1429
394]
395[drop-upload test for non-existent local dir separately from test for non-directory local dir
396zooko@zooko.com**20110809220115
397 Ignore-this: cd85f345c02f5cb71b1c1527bd4ebddc
398 A candidate patch for #1429 has a bug when it is using FilePath.is_dir() to detect whether the configured local dir exists and is a directory. FilePath.is_dir() raises exception, instead of returning False, if the thing doesn't exist. This test is to make sure that DropUploader.__init__ raise different exceptions for those two cases.
399 refs #1429
400]
401[drop-upload: unit tests for the configuration options being named "cap" instead of "uri"
402zooko@zooko.com**20110809215913
403 Ignore-this: 958c78fffb3d76b3e4817647f824e7f9
404 This is a subset of a patch that David-Sarah attached to #1429. This is just the unit-tests part of that patch, and uses darcs record instead of hunks to change the names.
405 refs #1429
406]
407[src/allmydata/storage/server.py: use the filesystem of storage/shares/, rather than storage/, to calculate remaining space. fixes #1384
408david-sarah@jacaranda.org**20110719022752
409 Ignore-this: a4781043cfd453dbb66ae4f108d80bea
410]
411[test_storage.py: test that we are using the filesystem of storage/shares/, rather than storage/, to calculate remaining space, and that the HTML status output reflects the values returned by fileutil.get_disk_stats. This version works with older versions of the mock library. refs #1384
412david-sarah@jacaranda.org**20110809190722
413 Ignore-this: db447caca37a459ca49563efa58db58c
414]
415[Work around ref #1472 by having test_drop_upload delete the non-ASCII directories it creates.
416david-sarah@jacaranda.org**20110809012334
417 Ignore-this: 5881fd5db419ba8ad12e0b2a82f6c4f0
418]
419[Remove all trailing whitespace from .py files.
420david-sarah@jacaranda.org**20110809001117
421 Ignore-this: d2658b5ce44af70cc606ae4d3085b7cc
422]
423[test_drop_upload.py: fix unused imports. refs #1429
424david-sarah@jacaranda.org**20110808235422
425 Ignore-this: 834f6b946bfea699d7d8c743edd66671
426]
427[Documentation for drop-upload frontend. refs #1429
428david-sarah@jacaranda.org**20110808182146
429 Ignore-this: b33110834e586c0b784d1736c2af5779
430]
431[Drop-upload frontend, rerecorded for 1.9 beta (and correcting a minor mistake). Includes some fixes for Windows but not the Windows inotify implementation. fixes #1429
432david-sarah@jacaranda.org**20110808234049
433 Ignore-this: 67f824c7f554e9a3a85f9fd2e1123d97
434]
435[node.py: ensure that client and introducer nodes record their port number and use that port on the next restart, fixing a regression caused by #1385. fixes #1469.
436david-sarah@jacaranda.org**20110806221934
437 Ignore-this: 1aa9d340b6570320ab2f9edc89c9e0a8
438]
439[test_runner.py: fix a race condition in the test when NODE_URL_FILE is written before PORTNUM_FILE. refs #1469
440david-sarah@jacaranda.org**20110806231842
441 Ignore-this: ab01ae7cec3a073e29eec473e64052a0
442]
443[test_runner.py: cleanups of HOTLINE_FILE writing and removal.
444david-sarah@jacaranda.org**20110806231652
445 Ignore-this: 25f5c5d6f5d8faebb26a4ce80110a335
446]
447[test_runner.py: remove an unused constant.
448david-sarah@jacaranda.org**20110806221416
449 Ignore-this: eade2695cbabbea9cafeaa8debe410bb
450]
451[node.py: fix the error path for a missing config option so that it works for a Unicode base directory.
452david-sarah@jacaranda.org**20110806221007
453 Ignore-this: 4eb9cc04b2ce05182a274a0d69dafaf3
454]
455[test_runner.py: test that client and introducer nodes record their port number and use that port on the next restart. This tests for a regression caused by ref #1385.
456david-sarah@jacaranda.org**20110806220635
457 Ignore-this: 40a0c040b142dbddd47e69b3c3712f5
458]
459[test_runner.py: fix a bug in CreateNode.do_create introduced in changeset [5114] when the tahoe.cfg file has been written with CRLF line endings. refs #1385
460david-sarah@jacaranda.org**20110804003032
461 Ignore-this: 7b7afdcf99da6671afac2d42828883eb
462]
463[test_client.py: repair Basic.test_error_on_old_config_files. refs #1385
464david-sarah@jacaranda.org**20110803235036
465 Ignore-this: 31e2a9c3febe55948de7e144353663e
466]
467[test_checker.py: increase timeout for TooParallel.test_immutable again. The ARM buildslave took 38 seconds, so 40 seconds is too close to the edge; make it 80.
468david-sarah@jacaranda.org**20110803214042
469 Ignore-this: 2d8026a6b25534e01738f78d6c7495cb
470]
471[test_runner.py: fix RunNode.test_introducer to not rely on the mtime of introducer.furl to detect when the node has restarted. Instead we detect when node.url has been written. refs #1385
472david-sarah@jacaranda.org**20110803180917
473 Ignore-this: 11ddc43b107beca42cb78af88c5c394c
474]
475[Further improve error message about old config files. refs #1385
476david-sarah@jacaranda.org**20110803174546
477 Ignore-this: 9d6cc3c288d9863dce58faafb3855917
478]
479[Slightly improve error message about old config files (avoid unnecessary Unicode escaping). refs #1385
480david-sarah@jacaranda.org**20110803163848
481 Ignore-this: a3e3930fba7ccf90b8db3d2ed5829df4
482]
483[test_checker.py: increase timeout for TooParallel.test_immutable (was consistently failing on ARM buildslave).
484david-sarah@jacaranda.org**20110803163213
485 Ignore-this: d0efceaf12628e8791862b80c85b5d56
486]
487[Fix the bug that prevents an introducer from starting when introducer.furl already exists. Also remove some dead code that used to read old config files, and rename 'warn_about_old_config_files' to reflect that it's not a warning. refs #1385
488david-sarah@jacaranda.org**20110803013212
489 Ignore-this: 2d6cd14bd06a7493b26f2027aff78f4d
490]
491[test_runner.py: modify RunNode.test_introducer to test that starting an introducer works when the introducer.furl file already exists. refs #1385
492david-sarah@jacaranda.org**20110803012704
493 Ignore-this: 8cf7f27ac4bfbb5ad8ca4a974106d437
494]
495[verifier: correct a bug introduced in changeset [5106] that caused us to only verify the first block of a file. refs #1395
496david-sarah@jacaranda.org**20110802172437
497 Ignore-this: 87fb77854a839ff217dce73544775b11
498]
499[test_repairer: add a deterministic test of share data corruption that always flips the bits of the last byte of the share data. refs #1395
500david-sarah@jacaranda.org**20110802175841
501 Ignore-this: 72f54603785007e88220c8d979e08be7
502]
503[verifier: serialize the fetching of blocks within a share so that we don't use too much RAM
504zooko@zooko.com**20110802063703
505 Ignore-this: debd9bac07dcbb6803f835a9e2eabaa1
506 
507 Shares are still verified in parallel, but within a share, don't request a
508 block until the previous block has been verified and the memory we used to hold
509 it has been freed up.
510 
511 Patch originally due to Brian. This version has a mockery-patchery-style test
512 which is "low tech" (it implements the patching inline in the test code instead
513 of using an extension of the mock.patch() function from the mock library) and
514 which unpatches in case of exception.
515 
516 fixes #1395
517]
518[add docs about timing-channel attacks
519Brian Warner <warner@lothar.com>**20110802044541
520 Ignore-this: 73114d5f5ed9ce252597b707dba3a194
521]
522['test-coverage' now needs PYTHONPATH=. to find TOP/twisted/plugins/
523Brian Warner <warner@lothar.com>**20110802041952
524 Ignore-this: d40f1f4cb426ea1c362fc961baedde2
525]
526[remove nodeid from WriteBucketProxy classes and customers
527warner@lothar.com**20110801224317
528 Ignore-this: e55334bb0095de11711eeb3af827e8e8
529 refs #1363
530]
531[remove get_serverid() from ReadBucketProxy and customers, including Checker
532warner@lothar.com**20110801224307
533 Ignore-this: 837aba457bc853e4fd413ab1a94519cb
534 and debug.py dump-share commands
535 refs #1363
536]
537[reject old-style (pre-Tahoe-LAFS-v1.3) configuration files
538zooko@zooko.com**20110801232423
539 Ignore-this: b58218fcc064cc75ad8f05ed0c38902b
540 Check for the existence of any of them and if any are found raise exception which will abort the startup of the node.
541 This is a backwards-incompatible change for anyone who is still using old-style configuration files.
542 fixes #1385
543]
544[whitespace-cleanup
545zooko@zooko.com**20110725015546
546 Ignore-this: 442970d0545183b97adc7bd66657876c
547]
548[tests: use fileutil.write() instead of open() to ensure timely close even without CPython-style reference counting
549zooko@zooko.com**20110331145427
550 Ignore-this: 75aae4ab8e5fa0ad698f998aaa1888ce
551 Some of these already had an explicit close() but I went ahead and replaced them with fileutil.write() as well for the sake of uniformity.
552]
553[Address Kevan's comment in #776 about Options classes missed when adding 'self.command_name'. refs #776, #1359
554david-sarah@jacaranda.org**20110801221317
555 Ignore-this: 8881d42cf7e6a1d15468291b0cb8fab9
556]
557[docs/frontends/webapi.rst: change some more instances of 'delete' or 'remove' to 'unlink', change some section titles, and use two blank lines between all sections. refs #776, #1104
558david-sarah@jacaranda.org**20110801220919
559 Ignore-this: 572327591137bb05c24c44812d4b163f
560]
561[cleanup: implement rm as a synonym for unlink rather than vice-versa. refs #776
562david-sarah@jacaranda.org**20110801220108
563 Ignore-this: 598dcbed870f4f6bb9df62de9111b343
564]
565[docs/webapi.rst: address Kevan's comments about use of 'delete' on ref #1104
566david-sarah@jacaranda.org**20110801205356
567 Ignore-this: 4fbf03864934753c951ddeff64392491
568]
569[docs: some changes of 'delete' or 'rm' to 'unlink'. refs #1104
570david-sarah@jacaranda.org**20110713002722
571 Ignore-this: 304d2a330d5e6e77d5f1feed7814b21c
572]
573[WUI: change the label of the button to unlink a file from 'del' to 'unlink'. Also change some internal names to 'unlink', and allow 't=unlink' as a synonym for 't=delete' in the web-API interface. Incidentally, improve a test to check for the rename button as well as the unlink button. fixes #1104
574david-sarah@jacaranda.org**20110713001218
575 Ignore-this: 3eef6b3f81b94a9c0020a38eb20aa069
576]
577[src/allmydata/web/filenode.py: delete a stale comment that was made incorrect by changeset [3133].
578david-sarah@jacaranda.org**20110801203009
579 Ignore-this: b3912e95a874647027efdc97822dd10e
580]
581[fix typo introduced during rebasing of 'remove get_serverid from
582Brian Warner <warner@lothar.com>**20110801200341
583 Ignore-this: 4235b0f585c0533892193941dbbd89a8
584 DownloadStatus.add_dyhb_request and customers' patch, to fix test failure.
585]
586[remove get_serverid from DownloadStatus.add_dyhb_request and customers
587zooko@zooko.com**20110801185401
588 Ignore-this: db188c18566d2d0ab39a80c9dc8f6be6
589 This patch is a rebase of a patch originally written by Brian. I didn't change any of the intent of Brian's patch, just ported it to current trunk.
590 refs #1363
591]
592[remove get_serverid from DownloadStatus.add_block_request and customers
593zooko@zooko.com**20110801185344
594 Ignore-this: 8bfa8201d6147f69b0fbe31beea9c1e
595 This is a rebase of a patch Brian originally wrote. I haven't changed the intent of that patch, just ported it to trunk.
596 refs #1363
597]
598[apply zooko's advice: storage_client get_known_servers() returns a frozenset, caller sorts
599warner@lothar.com**20110801174452
600 Ignore-this: 2aa13ea6cbed4e9084bd604bf8633692
601 refs #1363
602]
603[test_immutable.Test: rewrite to use NoNetworkGrid, now takes 2.7s not 97s
604warner@lothar.com**20110801174444
605 Ignore-this: 54f30b5d7461d2b3514e2a0172f3a98c
606 remove now-unused ShareManglingMixin
607 refs #1363
608]
609[DownloadStatus.add_known_share wants to be used by Finder, web.status
610warner@lothar.com**20110801174436
611 Ignore-this: 1433bcd73099a579abe449f697f35f9
612 refs #1363
613]
614[replace IServer.name() with get_name(), and get_longname()
615warner@lothar.com**20110801174428
616 Ignore-this: e5a6f7f6687fd7732ddf41cfdd7c491b
617 
618 This patch was originally written by Brian, but was re-recorded by Zooko to use
619 darcs replace instead of hunks for any file in which it would result in fewer
620 total hunks.
621 refs #1363
622]
623[upload.py: apply David-Sarah's advice rename (un)contacted(2) trackers to first_pass/second_pass/next_pass
624zooko@zooko.com**20110801174143
625 Ignore-this: e36e1420bba0620a0107bd90032a5198
626 This patch was written by Brian but was re-recorded by Zooko (with David-Sarah looking on) to use darcs replace instead of editing to rename the three variables to their new names.
627 refs #1363
628]
629[Coalesce multiple Share.loop() calls, make downloads faster. Closes #1268.
630Brian Warner <warner@lothar.com>**20110801151834
631 Ignore-this: 48530fce36c01c0ff708f61c2de7e67a
632]
633[src/allmydata/_auto_deps.py: 'i686' is another way of spelling x86.
634david-sarah@jacaranda.org**20110801034035
635 Ignore-this: 6971e0621db2fba794d86395b4d51038
636]
637[tahoe_rm.py: better error message when there is no path. refs #1292
638david-sarah@jacaranda.org**20110122064212
639 Ignore-this: ff3bb2c9f376250e5fd77eb009e09018
640]
641[test_cli.py: Test for error message when 'tahoe rm' is invoked without a path. refs #1292
642david-sarah@jacaranda.org**20110104105108
643 Ignore-this: 29ec2f2e0251e446db96db002ad5dd7d
644]
645[src/allmydata/__init__.py: suppress a spurious warning from 'bin/tahoe --version[-and-path]' about twisted-web and twisted-core packages.
646david-sarah@jacaranda.org**20110801005209
647 Ignore-this: 50e7cd53cca57b1870d9df0361c7c709
648]
649[test_cli.py: use to_str on fields loaded using simplejson.loads in new tests. refs #1304
650david-sarah@jacaranda.org**20110730032521
651 Ignore-this: d1d6dfaefd1b4e733181bf127c79c00b
652]
653[cli: make 'tahoe cp' overwrite mutable files in-place
654Kevan Carstensen <kevan@isnotajoke.com>**20110729202039
655 Ignore-this: b2ad21a19439722f05c49bfd35b01855
656]
657[SFTP: write an error message to standard error for unrecognized shell commands. Change the existing message for shell sessions to be written to standard error, and refactor some duplicated code. Also change the lines of the error messages to end in CRLF, and take into account Kevan's review comments. fixes #1442, #1446
658david-sarah@jacaranda.org**20110729233102
659 Ignore-this: d2f2bb4664f25007d1602bf7333e2cdd
660]
661[src/allmydata/scripts/cli.py: fix pyflakes warning.
662david-sarah@jacaranda.org**20110728021402
663 Ignore-this: 94050140ddb99865295973f49927c509
664]
665[Fix the help synopses of CLI commands to include [options] in the right place. fixes #1359, fixes #636
666david-sarah@jacaranda.org**20110724225440
667 Ignore-this: 2a8e488a5f63dabfa9db9efd83768a5
668]
669[encodingutil: argv and output encodings are always the same on all platforms. Lose the unnecessary generality of them being different. fixes #1120
670david-sarah@jacaranda.org**20110629185356
671 Ignore-this: 5ebacbe6903dfa83ffd3ff8436a97787
672]
673[docs/man/tahoe.1: add man page. fixes #1420
674david-sarah@jacaranda.org**20110724171728
675 Ignore-this: fc7601ec7f25494288d6141d0ae0004c
676]
677[Update the dependency on zope.interface to fix an incompatiblity between Nevow and zope.interface 3.6.4. fixes #1435
678david-sarah@jacaranda.org**20110721234941
679 Ignore-this: 2ff3fcfc030fca1a4d4c7f1fed0f2aa9
680]
681[frontends/ftpd.py: remove the check for IWriteFile.close since we're now guaranteed to be using Twisted >= 10.1 which has it.
682david-sarah@jacaranda.org**20110722000320
683 Ignore-this: 55cd558b791526113db3f83c00ec328a
684]
685[Update the dependency on Twisted to >= 10.1. This allows us to simplify some documentation: it's no longer necessary to install pywin32 on Windows, or apply a patch to Twisted in order to use the FTP frontend. fixes #1274, #1438. refs #1429
686david-sarah@jacaranda.org**20110721233658
687 Ignore-this: 81b41745477163c9b39c0b59db91cc62
688]
689[misc/build_helpers/run_trial.py: undo change to block pywin32 (it didn't work because run_trial.py is no longer used). refs #1334
690david-sarah@jacaranda.org**20110722035402
691 Ignore-this: 5d03f544c4154f088e26c7107494bf39
692]
693[misc/build_helpers/run_trial.py: ensure that pywin32 is not on the sys.path when running the test suite. Includes some temporary debugging printouts that will be removed. refs #1334
694david-sarah@jacaranda.org**20110722024907
695 Ignore-this: 5141a9f83a4085ed4ca21f0bbb20bb9c
696]
697[docs/running.rst: use 'tahoe run ~/.tahoe' instead of 'tahoe run' (the default is the current directory, unlike 'tahoe start').
698david-sarah@jacaranda.org**20110718005949
699 Ignore-this: 81837fbce073e93d88a3e7ae3122458c
700]
701[docs/running.rst: say to put the introducer.furl in tahoe.cfg.
702david-sarah@jacaranda.org**20110717194315
703 Ignore-this: 954cc4c08e413e8c62685d58ff3e11f3
704]
705[README.txt: say that quickstart.rst is in the docs directory.
706david-sarah@jacaranda.org**20110717192400
707 Ignore-this: bc6d35a85c496b77dbef7570677ea42a
708]
709[setup: remove the dependency on foolscap's "secure_connections" extra, add a dependency on pyOpenSSL
710zooko@zooko.com**20110717114226
711 Ignore-this: df222120d41447ce4102616921626c82
712 fixes #1383
713]
714[test_sftp.py cleanup: remove a redundant definition of failUnlessReallyEqual.
715david-sarah@jacaranda.org**20110716181813
716 Ignore-this: 50113380b368c573f07ac6fe2eb1e97f
717]
718[docs: add missing link in NEWS.rst
719zooko@zooko.com**20110712153307
720 Ignore-this: be7b7eb81c03700b739daa1027d72b35
721]
722[contrib: remove the contributed fuse modules and the entire contrib/ directory, which is now empty
723zooko@zooko.com**20110712153229
724 Ignore-this: 723c4f9e2211027c79d711715d972c5
725 Also remove a couple of vestigial references to figleaf, which is long gone.
726 fixes #1409 (remove contrib/fuse)
727]
728[add Protovis.js-based download-status timeline visualization
729Brian Warner <warner@lothar.com>**20110629222606
730 Ignore-this: 477ccef5c51b30e246f5b6e04ab4a127
731 
732 provide status overlap info on the webapi t=json output, add decode/decrypt
733 rate tooltips, add zoomin/zoomout buttons
734]
735[add more download-status data, fix tests
736Brian Warner <warner@lothar.com>**20110629222555
737 Ignore-this: e9e0b7e0163f1e95858aa646b9b17b8c
738]
739[prepare for viz: improve DownloadStatus events
740Brian Warner <warner@lothar.com>**20110629222542
741 Ignore-this: 16d0bde6b734bb501aa6f1174b2b57be
742 
743 consolidate IDownloadStatusHandlingConsumer stuff into DownloadNode
744]
745[docs: fix error in crypto specification that was noticed by Taylor R Campbell <campbell+tahoe@mumble.net>
746zooko@zooko.com**20110629185711
747 Ignore-this: b921ed60c1c8ba3c390737fbcbe47a67
748]
749[setup.py: don't make bin/tahoe.pyscript executable. fixes #1347
750david-sarah@jacaranda.org**20110130235809
751 Ignore-this: 3454c8b5d9c2c77ace03de3ef2d9398a
752]
753[Makefile: remove targets relating to 'setup.py check_auto_deps' which no longer exists. fixes #1345
754david-sarah@jacaranda.org**20110626054124
755 Ignore-this: abb864427a1b91bd10d5132b4589fd90
756]
757[Makefile: add 'make check' as an alias for 'make test'. Also remove an unnecessary dependency of 'test' on 'build' and 'src/allmydata/_version.py'. fixes #1344
758david-sarah@jacaranda.org**20110623205528
759 Ignore-this: c63e23146c39195de52fb17c7c49b2da
760]
761[Rename test_package_initialization.py to (much shorter) test_import.py .
762Brian Warner <warner@lothar.com>**20110611190234
763 Ignore-this: 3eb3dbac73600eeff5cfa6b65d65822
764 
765 The former name was making my 'ls' listings hard to read, by forcing them
766 down to just two columns.
767]
768[tests: fix tests to accomodate [20110611153758-92b7f-0ba5e4726fb6318dac28fb762a6512a003f4c430]
769zooko@zooko.com**20110611163741
770 Ignore-this: 64073a5f39e7937e8e5e1314c1a302d1
771 Apparently none of the two authors (stercor, terrell), three reviewers (warner, davidsarah, terrell), or one committer (me) actually ran the tests. This is presumably due to #20.
772 fixes #1412
773]
774[wui: right-align the size column in the WUI
775zooko@zooko.com**20110611153758
776 Ignore-this: 492bdaf4373c96f59f90581c7daf7cd7
777 Thanks to Ted "stercor" Rolle Jr. and Terrell Russell.
778 fixes #1412
779]
780[docs: three minor fixes
781zooko@zooko.com**20110610121656
782 Ignore-this: fec96579eb95aceb2ad5fc01a814c8a2
783 CREDITS for arc for stats tweak
784 fix link to .zip file in quickstart.rst (thanks to ChosenOne for noticing)
785 English usage tweak
786]
787[docs/running.rst: fix stray HTML (not .rst) link noticed by ChosenOne.
788david-sarah@jacaranda.org**20110609223719
789 Ignore-this: fc50ac9c94792dcac6f1067df8ac0d4a
790]
791[server.py:  get_latencies now reports percentiles _only_ if there are sufficient observations for the interpretation of the percentile to be unambiguous.
792wilcoxjg@gmail.com**20110527120135
793 Ignore-this: 2e7029764bffc60e26f471d7c2b6611e
794 interfaces.py:  modified the return type of RIStatsProvider.get_stats to allow for None as a return value
795 NEWS.rst, stats.py: documentation of change to get_latencies
796 stats.rst: now documents percentile modification in get_latencies
797 test_storage.py:  test_latencies now expects None in output categories that contain too few samples for the associated percentile to be unambiguously reported.
798 fixes #1392
799]
800[docs: revert link in relnotes.txt from NEWS.rst to NEWS, since the former did not exist at revision 5000.
801david-sarah@jacaranda.org**20110517011214
802 Ignore-this: 6a5be6e70241e3ec0575641f64343df7
803]
804[docs: convert NEWS to NEWS.rst and change all references to it.
805david-sarah@jacaranda.org**20110517010255
806 Ignore-this: a820b93ea10577c77e9c8206dbfe770d
807]
808[docs: remove out-of-date docs/testgrid/introducer.furl and containing directory. fixes #1404
809david-sarah@jacaranda.org**20110512140559
810 Ignore-this: 784548fc5367fac5450df1c46890876d
811]
812[scripts/common.py: don't assume that the default alias is always 'tahoe' (it is, but the API of get_alias doesn't say so). refs #1342
813david-sarah@jacaranda.org**20110130164923
814 Ignore-this: a271e77ce81d84bb4c43645b891d92eb
815]
816[setup: don't catch all Exception from check_requirement(), but only PackagingError and ImportError
817zooko@zooko.com**20110128142006
818 Ignore-this: 57d4bc9298b711e4bc9dc832c75295de
819 I noticed this because I had accidentally inserted a bug which caused AssertionError to be raised from check_requirement().
820]
821[M-x whitespace-cleanup
822zooko@zooko.com**20110510193653
823 Ignore-this: dea02f831298c0f65ad096960e7df5c7
824]
825[docs: fix typo in running.rst, thanks to arch_o_median
826zooko@zooko.com**20110510193633
827 Ignore-this: ca06de166a46abbc61140513918e79e8
828]
829[relnotes.txt: don't claim to work on Cygwin (which has been untested for some time). refs #1342
830david-sarah@jacaranda.org**20110204204902
831 Ignore-this: 85ef118a48453d93fa4cddc32d65b25b
832]
833[relnotes.txt: forseeable -> foreseeable. refs #1342
834david-sarah@jacaranda.org**20110204204116
835 Ignore-this: 746debc4d82f4031ebf75ab4031b3a9
836]
837[replace remaining .html docs with .rst docs
838zooko@zooko.com**20110510191650
839 Ignore-this: d557d960a986d4ac8216d1677d236399
840 Remove install.html (long since deprecated).
841 Also replace some obsolete references to install.html with references to quickstart.rst.
842 Fix some broken internal references within docs/historical/historical_known_issues.txt.
843 Thanks to Ravi Pinjala and Patrick McDonald.
844 refs #1227
845]
846[docs: FTP-and-SFTP.rst: fix a minor error and update the information about which version of Twisted fixes #1297
847zooko@zooko.com**20110428055232
848 Ignore-this: b63cfb4ebdbe32fb3b5f885255db4d39
849]
850[munin tahoe_files plugin: fix incorrect file count
851francois@ctrlaltdel.ch**20110428055312
852 Ignore-this: 334ba49a0bbd93b4a7b06a25697aba34
853 fixes #1391
854]
855[corrected "k must never be smaller than N" to "k must never be greater than N"
856secorp@allmydata.org**20110425010308
857 Ignore-this: 233129505d6c70860087f22541805eac
858]
859[Fix a test failure in test_package_initialization on Python 2.4.x due to exceptions being stringified differently than in later versions of Python. refs #1389
860david-sarah@jacaranda.org**20110411190738
861 Ignore-this: 7847d26bc117c328c679f08a7baee519
862]
863[tests: add test for including the ImportError message and traceback entry in the summary of errors from importing dependencies. refs #1389
864david-sarah@jacaranda.org**20110410155844
865 Ignore-this: fbecdbeb0d06a0f875fe8d4030aabafa
866]
867[allmydata/__init__.py: preserve the message and last traceback entry (file, line number, function, and source line) of ImportErrors in the package versions string. fixes #1389
868david-sarah@jacaranda.org**20110410155705
869 Ignore-this: 2f87b8b327906cf8bfca9440a0904900
870]
871[remove unused variable detected by pyflakes
872zooko@zooko.com**20110407172231
873 Ignore-this: 7344652d5e0720af822070d91f03daf9
874]
875[allmydata/__init__.py: Nicer reporting of unparseable version numbers in dependencies. fixes #1388
876david-sarah@jacaranda.org**20110401202750
877 Ignore-this: 9c6bd599259d2405e1caadbb3e0d8c7f
878]
879[update FTP-and-SFTP.rst: the necessary patch is included in Twisted-10.1
880Brian Warner <warner@lothar.com>**20110325232511
881 Ignore-this: d5307faa6900f143193bfbe14e0f01a
882]
883[control.py: remove all uses of s.get_serverid()
884warner@lothar.com**20110227011203
885 Ignore-this: f80a787953bd7fa3d40e828bde00e855
886]
887[web: remove some uses of s.get_serverid(), not all
888warner@lothar.com**20110227011159
889 Ignore-this: a9347d9cf6436537a47edc6efde9f8be
890]
891[immutable/downloader/fetcher.py: remove all get_serverid() calls
892warner@lothar.com**20110227011156
893 Ignore-this: fb5ef018ade1749348b546ec24f7f09a
894]
895[immutable/downloader/fetcher.py: fix diversity bug in server-response handling
896warner@lothar.com**20110227011153
897 Ignore-this: bcd62232c9159371ae8a16ff63d22c1b
898 
899 When blocks terminate (either COMPLETE or CORRUPT/DEAD/BADSEGNUM), the
900 _shares_from_server dict was being popped incorrectly (using shnum as the
901 index instead of serverid). I'm still thinking through the consequences of
902 this bug. It was probably benign and really hard to detect. I think it would
903 cause us to incorrectly believe that we're pulling too many shares from a
904 server, and thus prefer a different server rather than asking for a second
905 share from the first server. The diversity code is intended to spread out the
906 number of shares simultaneously being requested from each server, but with
907 this bug, it might be spreading out the total number of shares requested at
908 all, not just simultaneously. (note that SegmentFetcher is scoped to a single
909 segment, so the effect doesn't last very long).
910]
911[immutable/downloader/share.py: reduce get_serverid(), one left, update ext deps
912warner@lothar.com**20110227011150
913 Ignore-this: d8d56dd8e7b280792b40105e13664554
914 
915 test_download.py: create+check MyShare instances better, make sure they share
916 Server objects, now that finder.py cares
917]
918[immutable/downloader/finder.py: reduce use of get_serverid(), one left
919warner@lothar.com**20110227011146
920 Ignore-this: 5785be173b491ae8a78faf5142892020
921]
922[immutable/offloaded.py: reduce use of get_serverid() a bit more
923warner@lothar.com**20110227011142
924 Ignore-this: b48acc1b2ae1b311da7f3ba4ffba38f
925]
926[immutable/upload.py: reduce use of get_serverid()
927warner@lothar.com**20110227011138
928 Ignore-this: ffdd7ff32bca890782119a6e9f1495f6
929]
930[immutable/checker.py: remove some uses of s.get_serverid(), not all
931warner@lothar.com**20110227011134
932 Ignore-this: e480a37efa9e94e8016d826c492f626e
933]
934[add remaining get_* methods to storage_client.Server, NoNetworkServer, and
935warner@lothar.com**20110227011132
936 Ignore-this: 6078279ddf42b179996a4b53bee8c421
937 MockIServer stubs
938]
939[upload.py: rearrange _make_trackers a bit, no behavior changes
940warner@lothar.com**20110227011128
941 Ignore-this: 296d4819e2af452b107177aef6ebb40f
942]
943[happinessutil.py: finally rename merge_peers to merge_servers
944warner@lothar.com**20110227011124
945 Ignore-this: c8cd381fea1dd888899cb71e4f86de6e
946]
947[test_upload.py: factor out FakeServerTracker
948warner@lothar.com**20110227011120
949 Ignore-this: 6c182cba90e908221099472cc159325b
950]
951[test_upload.py: server-vs-tracker cleanup
952warner@lothar.com**20110227011115
953 Ignore-this: 2915133be1a3ba456e8603885437e03
954]
955[happinessutil.py: server-vs-tracker cleanup
956warner@lothar.com**20110227011111
957 Ignore-this: b856c84033562d7d718cae7cb01085a9
958]
959[upload.py: more tracker-vs-server cleanup
960warner@lothar.com**20110227011107
961 Ignore-this: bb75ed2afef55e47c085b35def2de315
962]
963[upload.py: fix var names to avoid confusion between 'trackers' and 'servers'
964warner@lothar.com**20110227011103
965 Ignore-this: 5d5e3415b7d2732d92f42413c25d205d
966]
967[refactor: s/peer/server/ in immutable/upload, happinessutil.py, test_upload
968warner@lothar.com**20110227011100
969 Ignore-this: 7ea858755cbe5896ac212a925840fe68
970 
971 No behavioral changes, just updating variable/method names and log messages.
972 The effects outside these three files should be minimal: some exception
973 messages changed (to say "server" instead of "peer"), and some internal class
974 names were changed. A few things still use "peer" to minimize external
975 changes, like UploadResults.timings["peer_selection"] and
976 happinessutil.merge_peers, which can be changed later.
977]
978[storage_client.py: clean up test_add_server/test_add_descriptor, remove .test_servers
979warner@lothar.com**20110227011056
980 Ignore-this: efad933e78179d3d5fdcd6d1ef2b19cc
981]
982[test_client.py, upload.py:: remove KiB/MiB/etc constants, and other dead code
983warner@lothar.com**20110227011051
984 Ignore-this: dc83c5794c2afc4f81e592f689c0dc2d
985]
986[test: increase timeout on a network test because Francois's ARM machine hit that timeout
987zooko@zooko.com**20110317165909
988 Ignore-this: 380c345cdcbd196268ca5b65664ac85b
989 I'm skeptical that the test was proceeding correctly but ran out of time. It seems more likely that it had gotten hung. But if we raise the timeout to an even more extravagant number then we can be even more certain that the test was never going to finish.
990]
991[docs/configuration.rst: add a "Frontend Configuration" section
992Brian Warner <warner@lothar.com>**20110222014323
993 Ignore-this: 657018aa501fe4f0efef9851628444ca
994 
995 this points to docs/frontends/*.rst, which were previously underlinked
996]
997[web/filenode.py: avoid calling req.finish() on closed HTTP connections. Closes #1366
998"Brian Warner <warner@lothar.com>"**20110221061544
999 Ignore-this: 799d4de19933f2309b3c0c19a63bb888
1000]
1001[Add unit tests for cross_check_pkg_resources_versus_import, and a regression test for ref #1355. This requires a little refactoring to make it testable.
1002david-sarah@jacaranda.org**20110221015817
1003 Ignore-this: 51d181698f8c20d3aca58b057e9c475a
1004]
1005[allmydata/__init__.py: .name was used in place of the correct .__name__ when printing an exception. Also, robustify string formatting by using %r instead of %s in some places. fixes #1355.
1006david-sarah@jacaranda.org**20110221020125
1007 Ignore-this: b0744ed58f161bf188e037bad077fc48
1008]
1009[Refactor StorageFarmBroker handling of servers
1010Brian Warner <warner@lothar.com>**20110221015804
1011 Ignore-this: 842144ed92f5717699b8f580eab32a51
1012 
1013 Pass around IServer instance instead of (peerid, rref) tuple. Replace
1014 "descriptor" with "server". Other replacements:
1015 
1016  get_all_servers -> get_connected_servers/get_known_servers
1017  get_servers_for_index -> get_servers_for_psi (now returns IServers)
1018 
1019 This change still needs to be pushed further down: lots of code is now
1020 getting the IServer and then distributing (peerid, rref) internally.
1021 Instead, it ought to distribute the IServer internally and delay
1022 extracting a serverid or rref until the last moment.
1023 
1024 no_network.py was updated to retain parallelism.
1025]
1026[TAG allmydata-tahoe-1.8.2
1027warner@lothar.com**20110131020101]
1028Patch bundle hash:
1029bb5a3fafa564ec0225b72d53378e434179f5f7b5