Ticket #948: fix-948-darcspatch.txt

File fix-948-darcspatch.txt, 69.4 KB (added by davidsarah, at 2010-02-22T03:01:44Z)

Change direct accesses to an_uri.storage_index to calls to .get_storage_index() (fixes #948)

Line 
1Mon Feb 22 02:45:04 GMT Standard Time 2010  david-sarah@jacaranda.org
2  * Change direct accesses to an_uri.storage_index to calls to .get_storage_index() (fixes #948)
3
4New patches:
5
6[Change direct accesses to an_uri.storage_index to calls to .get_storage_index() (fixes #948)
7david-sarah@jacaranda.org**20100222024504
8 Ignore-this: 91f6fccb5fd9456aa0e02d312f902928
9] {
10hunk ./src/allmydata/dirnode.py 349
11         return self._uri
12 
13     def get_storage_index(self):
14-        return self._uri._filenode_uri.storage_index
15+        return self._uri.get_storage_index()
16 
17     def check(self, monitor, verify=False, add_lease=False):
18         """Perform a file check. See IChecker.check for details."""
19hunk ./src/allmydata/immutable/checker.py 42
20         for (serverid, serverrref) in servers:
21             assert precondition(isinstance(serverid, str))
22 
23-        prefix = "%s" % base32.b2a_l(verifycap.storage_index[:8], 60)
24+        prefix = "%s" % base32.b2a_l(verifycap.get_storage_index()[:8], 60)
25         log.PrefixingLogMixin.__init__(self, facility="tahoe.immutable.checker", prefix=prefix)
26 
27         self._verifycap = verifycap
28hunk ./src/allmydata/immutable/checker.py 53
29         self._add_lease = add_lease
30 
31         frs = file_renewal_secret_hash(secret_holder.get_renewal_secret(),
32-                                       self._verifycap.storage_index)
33+                                       self._verifycap.get_storage_index())
34         self.file_renewal_secret = frs
35         fcs = file_cancel_secret_hash(secret_holder.get_cancel_secret(),
36hunk ./src/allmydata/immutable/checker.py 56
37-                                      self._verifycap.storage_index)
38+                                      self._verifycap.get_storage_index())
39         self.file_cancel_secret = fcs
40 
41     def _get_renewal_secret(self, peerid):
42hunk ./src/allmydata/immutable/checker.py 148
43         results."""
44 
45         vcap = self._verifycap
46-        b = layout.ReadBucketProxy(bucket, serverid, vcap.storage_index)
47+        b = layout.ReadBucketProxy(bucket, serverid, vcap.get_storage_index())
48         veup = download.ValidatedExtendedURIProxy(b, vcap)
49         d = veup.start()
50 
51hunk ./src/allmydata/immutable/checker.py 252
52         then disconnected and ceased responding, or returned a failure, it is
53         still marked with the True flag for 'success'.
54         """
55-        d = self._get_buckets(ss, self._verifycap.storage_index, serverid)
56+        d = self._get_buckets(ss, self._verifycap.get_storage_index(), serverid)
57 
58         def _got_buckets(result):
59             bucketdict, serverid, success = result
60hunk ./src/allmydata/immutable/checker.py 299
61         def _curry_empty_corrupted(res):
62             buckets, serverid, responded = res
63             return (set(buckets), serverid, set(), set(), responded)
64-        d = self._get_buckets(ss, self._verifycap.storage_index, serverid)
65+        d = self._get_buckets(ss, self._verifycap.get_storage_index(), serverid)
66         d.addCallback(_curry_empty_corrupted)
67         return d
68 
69hunk ./src/allmydata/immutable/checker.py 304
70     def _format_results(self, results):
71-        cr = CheckResults(self._verifycap, self._verifycap.storage_index)
72+        cr = CheckResults(self._verifycap, self._verifycap.get_storage_index())
73         d = {}
74         d['count-shares-needed'] = self._verifycap.needed_shares
75         d['count-shares-expected'] = self._verifycap.total_shares
76hunk ./src/allmydata/immutable/checker.py 319
77             for sharenum in theseverifiedshares:
78                 verifiedshares.setdefault(sharenum, set()).add(thisserverid)
79             for sharenum in thesecorruptshares:
80-                corruptsharelocators.append((thisserverid, self._verifycap.storage_index, sharenum))
81+                corruptsharelocators.append((thisserverid, self._verifycap.get_storage_index(), sharenum))
82             for sharenum in theseincompatibleshares:
83hunk ./src/allmydata/immutable/checker.py 321
84-                incompatiblesharelocators.append((thisserverid, self._verifycap.storage_index, sharenum))
85+                incompatiblesharelocators.append((thisserverid, self._verifycap.get_storage_index(), sharenum))
86 
87         d['count-shares-good'] = len(verifiedshares)
88         d['count-good-share-hosts'] = len([s for s in servers.keys() if servers[s]])
89hunk ./src/allmydata/immutable/download.py 754
90         precondition(IVerifierURI.providedBy(v), v)
91         precondition(IDownloadTarget.providedBy(target), target)
92 
93-        prefix=base32.b2a_l(v.storage_index[:8], 60)
94-        log.PrefixingLogMixin.__init__(self, facility="tahoe.immutable.download", prefix=prefix)
95         self._storage_broker = storage_broker
96hunk ./src/allmydata/immutable/download.py 755
97-
98         self._verifycap = v
99hunk ./src/allmydata/immutable/download.py 756
100-        self._storage_index = v.storage_index
101+        self._storage_index = v.get_storage_index()
102         self._uri_extension_hash = v.uri_extension_hash
103 
104hunk ./src/allmydata/immutable/download.py 759
105+        prefix=base32.b2a_l(self._storage_index[:8], 60)
106+        log.PrefixingLogMixin.__init__(self, facility="tahoe.immutable.download", prefix=prefix)
107+
108         self._started = time.time()
109         self._status = s = DownloadStatus()
110         s.set_status("Starting")
111hunk ./src/allmydata/immutable/filenode.py 228
112         return self.u.to_string()
113 
114     def get_storage_index(self):
115-        return self.u.storage_index
116+        return self.u.get_storage_index()
117 
118     def check_and_repair(self, monitor, verify=False, add_lease=False):
119         verifycap = self.get_verify_cap()
120hunk ./src/allmydata/immutable/filenode.py 241
121                     monitor=monitor)
122         d = c.start()
123         def _maybe_repair(cr):
124-            crr = CheckAndRepairResults(self.u.storage_index)
125+            crr = CheckAndRepairResults(self.u.get_storage_index())
126             crr.pre_repair_results = cr
127             if cr.is_healthy():
128                 crr.post_repair_results = cr
129hunk ./src/allmydata/immutable/repairer.py 49
130     def __init__(self, storage_broker, secret_holder, verifycap, monitor):
131         assert precondition(isinstance(verifycap, CHKFileVerifierURI))
132 
133-        logprefix = si_b2a(verifycap.storage_index)[:5]
134+        logprefix = si_b2a(verifycap.get_storage_index())[:5]
135         log.PrefixingLogMixin.__init__(self, "allmydata.immutable.repairer",
136                                        prefix=logprefix)
137 
138hunk ./src/allmydata/scripts/debug.py 392
139         print >>out, " UEB hash:", base32.b2a(u.uri_extension_hash)
140         print >>out, " size:", u.size
141         print >>out, " k/N: %d/%d" % (u.needed_shares, u.total_shares)
142-        print >>out, " storage index:", si_b2a(u.storage_index)
143-        _dump_secrets(u.storage_index, secret, nodeid, out)
144+        print >>out, " storage index:", si_b2a(u.get_storage_index())
145+        _dump_secrets(u.get_storage_index(), secret, nodeid, out)
146     elif isinstance(u, uri.CHKFileVerifierURI):
147         if show_header:
148             print >>out, "CHK Verifier URI:"
149hunk ./src/allmydata/scripts/debug.py 400
150         print >>out, " UEB hash:", base32.b2a(u.uri_extension_hash)
151         print >>out, " size:", u.size
152         print >>out, " k/N: %d/%d" % (u.needed_shares, u.total_shares)
153-        print >>out, " storage index:", si_b2a(u.storage_index)
154+        print >>out, " storage index:", si_b2a(u.get_storage_index())
155 
156     elif isinstance(u, uri.LiteralFileURI):
157         if show_header:
158hunk ./src/allmydata/scripts/debug.py 412
159             print >>out, "SSK Writeable URI:"
160         print >>out, " writekey:", base32.b2a(u.writekey)
161         print >>out, " readkey:", base32.b2a(u.readkey)
162-        print >>out, " storage index:", si_b2a(u.storage_index)
163+        print >>out, " storage index:", si_b2a(u.get_storage_index())
164         print >>out, " fingerprint:", base32.b2a(u.fingerprint)
165         print >>out
166         if nodeid:
167hunk ./src/allmydata/scripts/debug.py 419
168             we = hashutil.ssk_write_enabler_hash(u.writekey, nodeid)
169             print >>out, " write_enabler:", base32.b2a(we)
170             print >>out
171-        _dump_secrets(u.storage_index, secret, nodeid, out)
172+        _dump_secrets(u.get_storage_index(), secret, nodeid, out)
173 
174     elif isinstance(u, uri.ReadonlySSKFileURI):
175         if show_header:
176hunk ./src/allmydata/scripts/debug.py 425
177             print >>out, "SSK Read-only URI:"
178         print >>out, " readkey:", base32.b2a(u.readkey)
179-        print >>out, " storage index:", si_b2a(u.storage_index)
180+        print >>out, " storage index:", si_b2a(u.get_storage_index())
181         print >>out, " fingerprint:", base32.b2a(u.fingerprint)
182     elif isinstance(u, uri.SSKVerifierURI):
183         if show_header:
184hunk ./src/allmydata/scripts/debug.py 430
185             print >>out, "SSK Verifier URI:"
186-        print >>out, " storage index:", si_b2a(u.storage_index)
187+        print >>out, " storage index:", si_b2a(u.get_storage_index())
188         print >>out, " fingerprint:", base32.b2a(u.fingerprint)
189 
190     elif isinstance(u, uri.DirectoryURI):
191hunk ./src/allmydata/test/common.py 48
192     bad_shares = {}
193 
194     def __init__(self, filecap):
195-        precondition(isinstance(filecap, uri.CHKFileURI), filecap)
196+        precondition(isinstance(filecap, (uri.CHKFileURI, uri.LiteralFileURI)), filecap)
197         self.my_uri = filecap
198hunk ./src/allmydata/test/common.py 50
199-        self.storage_index = self.my_uri.storage_index
200+        self.storage_index = self.my_uri.get_storage_index()
201 
202     def get_uri(self):
203         return self.my_uri.to_string()
204hunk ./src/allmydata/test/common.py 193
205         assert isinstance(filecap, (uri.WriteableSSKFileURI,
206                                     uri.ReadonlySSKFileURI))
207         self.my_uri = filecap
208-        self.storage_index = self.my_uri.storage_index
209+        self.storage_index = self.my_uri.get_storage_index()
210         return self
211     def get_cap(self):
212         return self.my_uri
213hunk ./src/allmydata/test/common.py 1005
214         else:
215             k = random.choice(ks)
216         del shares[k]
217-        self.replace_shares(shares, storage_index=self.uri.storage_index)
218+        self.replace_shares(shares, storage_index=self.uri.get_storage_index())
219 
220         return unused
221 
222hunk ./src/allmydata/test/common.py 1015
223         assert ks, (shares.keys(), sharenum)
224         k = ks[0]
225         shares[k] = corruptor_func(shares[k])
226-        self.replace_shares(shares, storage_index=self.uri.storage_index)
227+        self.replace_shares(shares, storage_index=self.uri.get_storage_index())
228         return corruptor_func
229 
230     def _corrupt_all_shares(self, unused, corruptor_func):
231hunk ./src/allmydata/test/test_checker.py 71
232         serverid_1 = "\x00"*20
233         serverid_f = "\xff"*20
234         u = uri.CHKFileURI("\x00"*16, "\x00"*32, 3, 10, 1234)
235-        cr = check_results.CheckResults(u, u.storage_index)
236+        cr = check_results.CheckResults(u, u.get_storage_index())
237         cr.set_healthy(True)
238         cr.set_needs_rebalancing(False)
239         cr.set_summary("groovy")
240hunk ./src/allmydata/test/test_checker.py 111
241         cr.set_healthy(False)
242         cr.set_recoverable(False)
243         cr.set_summary("rather dead")
244-        data["list-corrupt-shares"] = [(serverid_1, u.storage_index, 2)]
245+        data["list-corrupt-shares"] = [(serverid_1, u.get_storage_index(), 2)]
246         cr.set_data(data)
247         html = self.render2(w)
248         s = self.remove_tags(html)
249hunk ./src/allmydata/test/test_checker.py 170
250         serverid_f = "\xff"*20
251         u = uri.CHKFileURI("\x00"*16, "\x00"*32, 3, 10, 1234)
252 
253-        pre_cr = check_results.CheckResults(u, u.storage_index)
254+        pre_cr = check_results.CheckResults(u, u.get_storage_index())
255         pre_cr.set_healthy(False)
256         pre_cr.set_recoverable(True)
257         pre_cr.set_needs_rebalancing(False)
258hunk ./src/allmydata/test/test_checker.py 188
259                  }
260         pre_cr.set_data(data)
261 
262-        post_cr = check_results.CheckResults(u, u.storage_index)
263+        post_cr = check_results.CheckResults(u, u.get_storage_index())
264         post_cr.set_healthy(True)
265         post_cr.set_recoverable(True)
266         post_cr.set_needs_rebalancing(False)
267hunk ./src/allmydata/test/test_checker.py 206
268                  }
269         post_cr.set_data(data)
270 
271-        crr = check_results.CheckAndRepairResults(u.storage_index)
272+        crr = check_results.CheckAndRepairResults(u.get_storage_index())
273         crr.pre_repair_results = pre_cr
274         crr.post_repair_results = post_cr
275         crr.repair_attempted = False
276hunk ./src/allmydata/test/test_dirnode.py 552
277             self.expected_verifycaps.add(u_v)
278             si = n.get_storage_index()
279             self.expected_storage_indexes.add(base32.b2a(si))
280-            expected_si = n._uri._filenode_uri.storage_index
281+            expected_si = n._uri.get_storage_index()
282             self.failUnlessEqual(si, expected_si)
283 
284             d = n.list()
285hunk ./src/allmydata/test/test_filenode.py 49
286         self.failUnlessEqual(fn1.get_write_uri(), None)
287         self.failUnlessEqual(fn1.get_readonly_uri(), u.to_string())
288         self.failUnlessEqual(fn1.get_size(), 1000)
289-        self.failUnlessEqual(fn1.get_storage_index(), u.storage_index)
290+        self.failUnlessEqual(fn1.get_storage_index(), u.get_storage_index())
291         fn1.raise_error()
292         fn2.raise_error()
293         d = {}
294hunk ./src/allmydata/test/test_immutable.py 24
295         # The following process of deleting 8 of the shares and asserting that you can't
296         # download it is more to test this test code than to test the Tahoe code...
297         def _then_delete_8(unused=None):
298-            self.replace_shares(stash[0], storage_index=self.uri.storage_index)
299+            self.replace_shares(stash[0], storage_index=self.uri.get_storage_index())
300             for i in range(8):
301                 self._delete_a_share()
302         d.addCallback(_then_delete_8)
303hunk ./src/allmydata/test/test_mutable.py 1926
304             privkey_s = privkey.serialize()
305             u = uri.WriteableSSKFileURI(ssk_writekey_hash(privkey_s),
306                                         ssk_pubkey_fingerprint_hash(pubkey_s))
307-            self._storage_index = u.storage_index
308+            self._storage_index = u.get_storage_index()
309         d.addCallback(_got_key)
310         def _break_peer0(res):
311             si = self._storage_index
312hunk ./src/allmydata/test/test_repairer.py 660
313             return res
314         d.addCallback(_stash_it)
315         def _put_it_all_back(ignored):
316-            self.replace_shares(stash[0], storage_index=self.uri.storage_index)
317+            self.replace_shares(stash[0], storage_index=self.uri.get_storage_index())
318             return ignored
319 
320         def _repair_from_corruption(shnum, corruptor_func):
321hunk ./src/allmydata/test/test_upload.py 260
322     def _check_large(self, newuri, size):
323         u = uri.from_string(newuri)
324         self.failUnless(isinstance(u, uri.CHKFileURI))
325-        self.failUnless(isinstance(u.storage_index, str))
326-        self.failUnlessEqual(len(u.storage_index), 16)
327+        self.failUnless(isinstance(u.get_storage_index(), str))
328+        self.failUnlessEqual(len(u.get_storage_index()), 16)
329         self.failUnless(isinstance(u.key, str))
330         self.failUnlessEqual(len(u.key), 16)
331         self.failUnlessEqual(u.size, size)
332hunk ./src/allmydata/test/test_upload.py 385
333     def _check_large(self, newuri, size):
334         u = uri.from_string(newuri)
335         self.failUnless(isinstance(u, uri.CHKFileURI))
336-        self.failUnless(isinstance(u.storage_index, str))
337-        self.failUnlessEqual(len(u.storage_index), 16)
338+        self.failUnless(isinstance(u.get_storage_index(), str))
339+        self.failUnlessEqual(len(u.get_storage_index()), 16)
340         self.failUnless(isinstance(u.key, str))
341         self.failUnlessEqual(len(u.key), 16)
342         self.failUnlessEqual(u.size, size)
343hunk ./src/allmydata/test/test_upload.py 473
344     def _check_large(self, newuri, size):
345         u = uri.from_string(newuri)
346         self.failUnless(isinstance(u, uri.CHKFileURI))
347-        self.failUnless(isinstance(u.storage_index, str))
348-        self.failUnlessEqual(len(u.storage_index), 16)
349+        self.failUnless(isinstance(u.get_storage_index(), str))
350+        self.failUnlessEqual(len(u.get_storage_index()), 16)
351         self.failUnless(isinstance(u.key, str))
352         self.failUnlessEqual(len(u.key), 16)
353         self.failUnlessEqual(u.size, size)
354hunk ./src/allmydata/test/test_uri.py 105
355                            needed_shares=needed_shares,
356                            total_shares=total_shares,
357                            size=size)
358-        self.failUnlessEqual(u.storage_index, storage_index)
359+        self.failUnlessEqual(u.get_storage_index(), storage_index)
360         self.failUnlessEqual(u.key, key)
361         self.failUnlessEqual(u.uri_extension_hash, uri_extension_hash)
362         self.failUnlessEqual(u.needed_shares, needed_shares)
363hunk ./src/allmydata/test/test_uri.py 125
364         self.failUnlessEqual(uri.CHKFileURI.init_from_human_encoding(he), u)
365 
366         u2 = uri.from_string(u.to_string())
367-        self.failUnlessEqual(u2.storage_index, storage_index)
368+        self.failUnlessEqual(u2.get_storage_index(), storage_index)
369         self.failUnlessEqual(u2.key, key)
370         self.failUnlessEqual(u2.uri_extension_hash, uri_extension_hash)
371         self.failUnlessEqual(u2.needed_shares, needed_shares)
372hunk ./src/allmydata/test/test_uri.py 322
373 
374         u5 = u4.get_verify_cap()
375         self.failUnless(IVerifierURI.providedBy(u5))
376-        self.failUnlessEqual(u5.storage_index, u.storage_index)
377+        self.failUnlessEqual(u5.get_storage_index(), u.get_storage_index())
378         u7 = u.get_verify_cap()
379         self.failUnless(IVerifierURI.providedBy(u7))
380hunk ./src/allmydata/test/test_uri.py 325
381-        self.failUnlessEqual(u7.storage_index, u.storage_index)
382+        self.failUnlessEqual(u7.get_storage_index(), u.get_storage_index())
383 
384         he = u5.to_human_encoding()
385         u5_h = uri.SSKVerifierURI.init_from_human_encoding(he)
386hunk ./src/allmydata/test/test_web.py 1521
387             self.failUnless(filecap.startswith("URI:SSK:"), filecap)
388             self.filecap = filecap
389             u = uri.WriteableSSKFileURI.init_from_string(filecap)
390-            self.failUnless(u.storage_index in FakeMutableFileNode.all_contents)
391+            self.failUnless(u.get_storage_index() in FakeMutableFileNode.all_contents)
392             n = self.s.create_node_from_uri(filecap)
393             return n.download_best_version()
394         d.addCallback(_check)
395hunk ./src/allmydata/test/test_web.py 2773
396             self.failUnless(filecap.startswith("URI:SSK:"), filecap)
397             self.filecap = filecap
398             u = uri.WriteableSSKFileURI.init_from_string(filecap)
399-            self.failUnless(u.storage_index in FakeMutableFileNode.all_contents)
400+            self.failUnless(u.get_storage_index() in FakeMutableFileNode.all_contents)
401             n = self.s.create_node_from_uri(filecap)
402             return n.download_best_version()
403         d.addCallback(_check1)
404hunk ./src/allmydata/uri.py 437
405         return self._filenode_uri.to_string().split(':')[2][:5]
406 
407     def abbrev_si(self):
408-        return base32.b2a(self._filenode_uri.storage_index)[:5]
409+        return base32.b2a(self._filenode_uri.get_storage_index())[:5]
410 
411     def is_mutable(self):
412         return True
413}
414
415Context:
416
417[setup: comment-out the dependency on pycrypto, see #953
418zooko@zooko.com**20100215050844
419 Ignore-this: 2751120921ff35b8189d8fcd896da149
420]
421[Add tests for #939
422Kevan Carstensen <kevan@isnotajoke.com>**20100212062137
423 Ignore-this: 5459e8c64ba76cca70aa720e68549637
424]
425[Alter CLI utilities to handle nonexistent aliases better
426Kevan Carstensen <kevan@isnotajoke.com>**20100211024318
427 Ignore-this: e698ea4a57f5fe27c24336581ca0cf65
428]
429[web/storage.py: display total-seen on the last-complete-cycle line. For #940.
430Brian Warner <warner@lothar.com>**20100208002010
431 Ignore-this: c0ed860f3e9628d3171d2b055d96c5aa
432]
433[adding pycrypto to the auto dependencies
434secorp@allmydata.com**20100206054314
435 Ignore-this: b873fc00a6a5b001d30d479e6053cf2f
436]
437[docs running.html - "tahoe run ." does not work with the current installation, replaced with "tahoe start ."
438secorp@allmydata.com**20100206165320
439 Ignore-this: fdb2dcb0e417d303cd43b1951a4f8c03
440]
441[code coverage: replace figleaf with coverage.py, should work on py2.6 now.
442Brian Warner <warner@lothar.com>**20100203165421
443 Ignore-this: 46ab590360be6a385cb4fc4e68b6b42c
444 
445 It still lacks the right HTML report (the builtin report is very pretty, but
446 lacks the "lines uncovered" numbers that I want), and the half-finished
447 delta-from-last-run measurements.
448]
449[More cleanups to test_cli using new utilities for reading and writing files.
450david-sarah@jacaranda.org**20100206013855
451 Ignore-this: 9fd2294406b346bfe9144fff6a61f789
452]
453[Fix race conditions and missing callback in allmydata.test.test_cli.Cp.test_copy_using_filecap, add utilities for one-liner reading and writing of files, and fix cases in test_cli where files were not being closed after writing.
454david-sarah@jacaranda.org**20100206013727
455 Ignore-this: 49da6c33190d526a4ae84c472f04d5f4
456]
457[docs: install.html: link into Python 2.5.5 download page
458zooko@zooko.com**20100202065852
459 Ignore-this: 1a9471b8175b7de5741d8445a7ede29d
460]
461[TAG allmydata-tahoe-1.6.0
462zooko@zooko.com**20100202061125
463 Ignore-this: dee6ade7ac1452cf5d1d9c69a8146d84
464]
465[docs: install.html: recommend Python 2.5 (because I can build extension modules for it with mingw), architecture.txt: point out that our Proof of Retrievability feature is client-side-only
466zooko@zooko.com**20100202053842
467 Ignore-this: e33fd413a91771c77b17d7de0f215bea
468]
469[architecture.txt: remove trailing whitespace, wrap lines: no content changes
470Brian Warner <warner@lothar.com>**20100202055304
471 Ignore-this: 1662f37d1162858ac2619db27bcc411f
472]
473[docs: a couple of small edits to release notes (thanks Peter)
474zooko@zooko.com**20100202054832
475 Ignore-this: 1d0963c43ff19c92775b124c49c8a88a
476]
477[docs: CREDITS: where due
478zooko@zooko.com**20100202053831
479 Ignore-this: 11646dd603ac715ae8277a4bb9562215
480]
481[docs: a few small edits to performance.txt and README
482zooko@zooko.com**20100202052750
483 Ignore-this: bf8b1b7438e8fb6da09eec9713c78533
484]
485[More comprehensive changes and ticket references for NEWS
486david-sarah@jacaranda.org**20100202061256
487 Ignore-this: 696cf0106e8a7fd388afc5b55fba8a1b
488]
489[docs: a few edits to architecture.txt, most significantly highlighting "future work" to avoid confusing it with the current version, and adding a "future work" about a random-sampling Proof of Retrievability verifier
490zooko@zooko.com**20100202045117
491 Ignore-this: 81122b3042ea9ee6bc12e795c2386d59
492]
493[docs: a few edits and updates to relnotes.txt, relnotes-short.txt, and NEWS in preparation for v1.6.0
494zooko@zooko.com**20100202043222
495 Ignore-this: d90c644fa61d78e33cbdf0be428bb07a
496]
497[Fill in 'docs/performance.txt' with some performance information
498Kevan Carstensen <kevan@isnotajoke.com>**20100202005914
499 Ignore-this: c66b255b2bd2e7e11f5707b25e7b38be
500]
501[Document leakage of cap URLs via phishing filters in known_issues.txt
502david-sarah@jacaranda.org**20100202015238
503 Ignore-this: 78e668dbca77c0e3a73e10c0b74cf024
504]
505[docs: updates to relnotes.txt, NEWS, architecture, historical_known_issues, install.html, etc.
506zooko@zooko.com**20100201181809
507 Ignore-this: f4fc924652af746862c8ee4d9ba97bf6
508]
509[immutable: downloader accepts notifications of buckets even if those notifications arrive after he has begun downloading shares.
510zooko@zooko.com**20100201061610
511 Ignore-this: 5b09709f27603a3157eba7ba70028955
512 This can be useful if one of the ones that he has already begun downloading fails. See #287 for discussion. This fixes part of #287 which part was a regression caused by #928, namely this fixes fail-over in case a share is corrupted (or the server returns an error or disconnects). This does not fix the related issue mentioned in #287 if a server hangs and doesn't reply to requests for blocks.
513 
514]
515[tests: don't require tahoe to run with no noise if we are using an old twisted that emits DeprecationWarnings
516zooko@zooko.com**20100201052323
517 Ignore-this: 69668c772cce612a0c6936a2195ebd2a
518]
519[tests: stop being surprised that Nevow no longer prints out warnings when it tries to find its static files
520zooko@zooko.com**20100201041144
521 Ignore-this: 77b4ac383165d98dfe2a9008ce794742
522 Unless we are using a sufficiently new version of Nevow, in which case if it prints out warnings then this is a hard test failure. :-)
523]
524[cli: suppress DeprecationWarnings emitted from importing nevow and twisted. Fixes #859
525david-sarah@jacaranda.org**20100201004429
526 Ignore-this: 22d7216921cd5f04381c0194ed501bbe
527]
528[Improvements to test_hung_server, and fix for status updates in download.py
529david-sarah@jacaranda.org**20100130064303
530 Ignore-this: dd889c643afdcf0f86d55855aafda6ad
531]
532[Improvements to test_unknownnode to cover invalid cap URIs with known prefixes
533david-sarah@jacaranda.org**20100130063908
534 Ignore-this: e1a298942c21207473e418ea5efd6276
535]
536[immutable: fix bug in tests, change line-endings to unix style, add comment
537zooko@zooko.com**20100129184237
538 Ignore-this: f6bd875fe974c55c881e05eddf8d3436
539]
540[Fix invalid trailing commas in JSON example
541david-sarah@jacaranda.org**20100129201742
542 Ignore-this: d99e0a8ead4fafabf39a1daf11ec450b
543]
544[docs: update relnotes.txt for Tahoe-LAFS v1.6
545zooko@zooko.com**20100128171257
546 Ignore-this: 920df92152aead69ef861b9b2e8ff218
547]
548[Address comments by Kevan on 833 and add test for stripping spaces
549david-sarah@jacaranda.org**20100127230642
550 Ignore-this: de36aeaf4afb3ba05dbeb49a5e9a6b26
551]
552[New tests for #928
553david-sarah@jacaranda.org**20100129123845
554 Ignore-this: 5c520f40141f0d9c000ffb05a4698995
555]
556[immutable: download from the first servers which provide at least K buckets instead of waiting for all servers to reply
557zooko@zooko.com**20100127233417
558 Ignore-this: c855355a40d96827e1d0c469a8d8ab3f
559 This should put an end to the phenomenon I've been seeing that a single hung server can cause all downloads on a grid to hang.  Also it should speed up all downloads by (a) not-waiting for responses to queries that it doesn't need, and (b) downloading shares from the servers which answered the initial query the fastest.
560 Also, do not count how many buckets you've gotten when deciding whether the download has enough shares or not -- instead count how many buckets to *unique* shares that you've gotten.  This appears to improve a slightly weird behavior in the current download code in which receiving >= K different buckets all to the same sharenumber would make it think it had enough to download the file when in fact it hadn't.
561 This patch needs tests before it is actually ready for trunk.
562]
563[Eliminate 'foo if test else bar' syntax that isn't supported by Python 2.4
564david-sarah@jacaranda.org**20100129035210
565 Ignore-this: 70eafd487b4b6299beedd63b4a54a0c
566]
567[Fix example JSON in webapi.txt that cannot occur in practice
568david-sarah@jacaranda.org**20100129032742
569 Ignore-this: 361a1ba663d77169aeef93caef870097
570]
571[Add mutable field to t=json output for unknown nodes, when mutability is known
572david-sarah@jacaranda.org**20100129031424
573 Ignore-this: 1516d63559bdfeb6355485dff0f5c04e
574]
575[Show -IMM and -RO suffixes for types of immutable and read-only unknown nodes in directory listings
576david-sarah@jacaranda.org**20100128220800
577 Ignore-this: dc5c17c0a566398f88e4303c41321e66
578]
579[Fix inaccurate comment in test_mutant_dirnodes_are_omitted
580david-sarah@jacaranda.org**20100128202456
581 Ignore-this: 9fa17ed7feac9e4d084f1b2338c76fca
582]
583[test_runner: cleanup, refactor common code into a non-executable method
584Brian Warner <warner@lothar.com>**20100127224040
585 Ignore-this: 4cb4aada87777771f688edfd8129ffca
586 
587 Having both test_node() and test_client() (one of which calls the other) felt
588 confusing to me, so I changed it to have test_node(), test_client(), and a
589 common do_create() helper method.
590]
591[scripts/runner.py: simplify David-Sarah's clever grouped-commands usage trick
592Brian Warner <warner@lothar.com>**20100127223758
593 Ignore-this: 70877ebf06ae59f32960b0aa4ce1d1ae
594]
595[tahoe backup: skip all symlinks, with warning. Fixes #850, addresses #641.
596Brian Warner <warner@lothar.com>**20100127223517
597 Ignore-this: ab5cf05158d32a575ca8efc0f650033f
598]
599[NEWS: update with all recent user-visible changes
600Brian Warner <warner@lothar.com>**20100127222209
601 Ignore-this: 277d24568018bf4f3fb7736fda64eceb
602]
603["tahoe backup": fix --exclude-vcs docs to include Git
604Brian Warner <warner@lothar.com>**20100127201044
605 Ignore-this: 756a58dde21bdc65aa62b81803605b5
606]
607[docs: fix references to --no-storage, explanation of [storage] section
608Brian Warner <warner@lothar.com>**20100127200956
609 Ignore-this: f4be1763a585e1ac6299a4f1b94a59e0
610]
611[cli: merge the better version of David-Sarah's split-usage-and-help patch with the earlier version that I mistakenly committed
612zooko@zooko.com**20100126044559
613 Ignore-this: 284d188e13b7901013cbb650168e6447
614]
615[Split tahoe --help options into groups.
616david-sarah@jacaranda.org**20100112043935
617 Ignore-this: 610f9c41b00e6863e3cd047379733e3a
618]
619[Miscellaneous documentation, test, and code formatting tweaks.
620david-sarah@jacaranda.org**20100127070309
621 Ignore-this: 84ca7e4bb7c64221ae2c61144ef5edef
622]
623[Prevent mutable objects from being retrieved from an immutable directory, and associated forward-compatibility improvements.
624david-sarah@jacaranda.org**20100127064430
625 Ignore-this: 5ef6a3554cf6bef0bf0712cc7d6c0252
626]
627[Use if instead of assert to check for twisted ftp patch
628david-sarah@jacaranda.org**20100127015529
629 Ignore-this: 66959d946bd1a835ece6f074e75086b2
630]
631[docs: further CREDITS level-ups for Nils, Kevan, David-Sarah
632zooko@zooko.com**20100126170021
633 Ignore-this: 1e513e85cf7b7abf57f056e6d7544b38
634]
635[ftpd: clearer error message if Twisted needs a patch (by Nils Durner)
636zooko@zooko.com**20100126143411
637 Ignore-this: 440e6831ae6da5135c1edd081c93871f
638]
639[Add 'docs/performance.txt', which (for the moment) describes mutable file performance issues
640Kevan Carstensen <kevan@isnotajoke.com>**20100115204500
641 Ignore-this: ade4e500217db2509aee35aacc8c5dbf
642]
643[docs: more CREDITS for François, Kevan, and David-Sarah
644zooko@zooko.com**20100126132133
645 Ignore-this: f37d4977c13066fcac088ba98a31b02e
646]
647[tahoe_backup.py: display warnings on errors instead of stopping the whole backup. Fix #729.
648francois@ctrlaltdel.ch**20100120094249
649 Ignore-this: 7006ea4b0910b6d29af6ab4a3997a8f9
650 
651 This patch displays a warning to the user in two cases:
652   
653   1. When special files like symlinks, fifos, devices, etc. are found in the
654      local source.
655   
656   2. If files or directories are not readables by the user running the 'tahoe
657      backup' command.
658 
659 In verbose mode, the number of skipped files and directories is printed at the
660 end of the backup.
661 
662 Exit status returned by 'tahoe backup':
663 
664   - 0 everything went fine
665   - 1 the backup failed
666   - 2 files were skipped during the backup
667 
668]
669[Message saying that we couldn't find bin/tahoe should say where we looked
670david-sarah@jacaranda.org**20100116204556
671 Ignore-this: 1068576fd59ea470f1e19196315d1bb
672]
673[Change running.html to describe 'tahoe run'
674david-sarah@jacaranda.org**20100112044409
675 Ignore-this: 23ad0114643ce31b56e19bb14e011e4f
676]
677[cli: split usage strings into groups (patch by David-Sarah Hopwood)
678zooko@zooko.com**20100126043921
679 Ignore-this: 51928d266a7292b873f87f7d53c9a01e
680]
681[Add create-node CLI command, and make create-client equivalent to create-node --no-storage (fixes #760)
682david-sarah@jacaranda.org**20100116052055
683 Ignore-this: 47d08b18c69738685e13ff365738d5a
684]
685[contrib/fuse/runtests.py: Fix #888, configure settings in tahoe.cfg and don't treat warnings as failure
686francois@ctrlaltdel.ch**20100109123010
687 Ignore-this: 2590d44044acd7dfa3690c416cae945c
688 
689 Fix a few bitrotten pieces in the FUSE test script.  It now configures tahoe
690 node settings by editing tahoe.cfg which is the new supported method.
691 
692 It alos tolerate warnings issued by the mount command, the cause of these
693 warnings is the same as in #876 (contrib/fuse/runtests.py doesn't tolerate
694 deprecations warnings).
695 
696]
697[Fix webapi t=mkdir with multpart/form-data, as on the Welcome page. Closes #919.
698Brian Warner <warner@lothar.com>**20100121065052
699 Ignore-this: 1f20ea0a0f1f6d6c1e8e14f193a92c87
700]
701[Fix boodlegrid use of set_children
702david-sarah@jacaranda.org**20100126063414
703 Ignore-this: 3aa2d4836f76303b2bacecd09611f999
704]
705[Remove replace= parameter to mkdir-immutable and mkdir-with-children
706david-sarah@jacaranda.org**20100124224325
707 Ignore-this: 25207bcc946c0c43d9528718e76ba7b
708]
709[Warn about test failures due to setting FLOG* env vars
710david-sarah@jacaranda.org**20100124220629
711 Ignore-this: 1c25247ca0f0840390a1b7259a9f4a3c
712]
713[Patch to accept t=set-children as well as t=set_children
714david-sarah@jacaranda.org**20100124030020
715 Ignore-this: 2c061f12af817cdf77feeeb64098ec3a
716]
717[tahoe_add_alias.py: minor refactoring
718Brian Warner <warner@lothar.com>**20100115064220
719 Ignore-this: 29910e81ad11209c9e493d65fd2dab9b
720]
721[test_dirnode.py: reduce scope of a Client instance, suggested by Kevan.
722Brian Warner <warner@lothar.com>**20100115062713
723 Ignore-this: b35efd9e6027e43de6c6f509bfb4ccaa
724]
725[test_provisioning: STAN is not always a list. Fix by David-Sarah Hopwood.
726Brian Warner <warner@lothar.com>**20100115014632
727 Ignore-this: 9989de7f1e00907706d2b63153138219
728]
729[web/directory.py mkdir-immutable: hush pyflakes, add TODO for #903 behavior
730Brian Warner <warner@lothar.com>**20100114222804
731 Ignore-this: 717cd3b9a1c8aeee76938c9641db7356
732]
733[hush pyflakes-0.4.0 warnings: slightly less-trivial fixes. Closes #900.
734Brian Warner <warner@lothar.com>**20100114221719
735 Ignore-this: f774f4637e256ad55502659413a811a8
736 
737 This includes one fix (in test_web) which was testing the wrong thing.
738]
739[hush pyflakes-0.4.0 warnings: remove trivial unused variables. For #900.
740Brian Warner <warner@lothar.com>**20100114221529
741 Ignore-this: e96106c8f1a99fbf93306fbfe9a294cf
742]
743[tahoe add-alias/create-alias: don't corrupt non-newline-terminated alias
744Brian Warner <warner@lothar.com>**20100114210246
745 Ignore-this: 9c994792e53a85159d708760a9b1b000
746 file. Closes #741.
747]
748[change docs and --help to use "grid" instead of "virtual drive": closes #892.
749Brian Warner <warner@lothar.com>**20100114201119
750 Ignore-this: a20d4a4dcc4de4e3b404ff72d40fc29b
751 
752 Thanks to David-Sarah Hopwood for the patch.
753]
754[backupdb.txt: fix ST_CTIME reference
755Brian Warner <warner@lothar.com>**20100114194052
756 Ignore-this: 5a189c7a1181b07dd87f0a08ea31b6d3
757]
758[client.py: fix/update comments on KeyGenerator
759Brian Warner <warner@lothar.com>**20100113004226
760 Ignore-this: 2208adbb3fd6a911c9f44e814583cabd
761]
762[Clean up log.err calls, for one of the issues in #889.
763Brian Warner <warner@lothar.com>**20100112013343
764 Ignore-this: f58455ce15f1fda647c5fb25d234d2db
765 
766 allmydata.util.log.err() either takes a Failure as the first positional
767 argument, or takes no positional arguments and must be invoked in an
768 exception handler. Fixed its signature to match both foolscap.logging.log.err
769 and twisted.python.log.err . Included a brief unit test.
770]
771[tidy up DeadReferenceError handling, ignore them in add_lease calls
772Brian Warner <warner@lothar.com>**20100112000723
773 Ignore-this: 72f1444e826fd0b9db6d318f89603c38
774 
775 Stop checking separately for ConnectionDone/ConnectionLost, since those have
776 been folded into DeadReferenceError since foolscap-0.3.1 . Write
777 rrefutil.trap_deadref() in terms of rrefutil.trap_and_discard() to improve
778 code coverage.
779]
780[NEWS: improve "tahoe backup" notes, mention first-backup-after-upgrade duration
781Brian Warner <warner@lothar.com>**20100111190132
782 Ignore-this: 10347c590b3375964579ba6c2b0edb4f
783 
784 Thanks to Francois Deppierraz for the suggestion.
785]
786[test_repairer: add (commented-out) test_each_byte, to see exactly what the
787Brian Warner <warner@lothar.com>**20100110203552
788 Ignore-this: 8e84277d5304752edeff052b97821815
789 Verifier misses
790 
791 The results (described in #819) match our expectations: it misses corruption
792 in unused share fields and in most container fields (which are only visible
793 to the storage server, not the client). 1265 bytes of a 2753 byte
794 share (hosting a 56-byte file with an artifically small segment size) are
795 unused, mostly in the unused tail of the overallocated UEB space (765 bytes),
796 and the allocated-but-unwritten plaintext_hash_tree (480 bytes).
797]
798[repairer: fix some wrong offsets in the randomized verifier tests, debugged by Brian
799zooko@zooko.com**20100110203721
800 Ignore-this: 20604a609db8706555578612c1c12feb
801 fixes #819
802]
803[test_repairer: fix colliding basedir names, which caused test inconsistencies
804Brian Warner <warner@lothar.com>**20100110084619
805 Ignore-this: b1d56dd27e6ab99a7730f74ba10abd23
806]
807[repairer: add deterministic test for #819, mark as TODO
808zooko@zooko.com**20100110013619
809 Ignore-this: 4cb8bb30b25246de58ed2b96fa447d68
810]
811[contrib/fuse/runtests.py: Tolerate the tahoe CLI returning deprecation warnings
812francois@ctrlaltdel.ch**20100109175946
813 Ignore-this: 419c354d9f2f6eaec03deb9b83752aee
814 
815 Depending on the versions of external libraries such as Twisted of Foolscap,
816 the tahoe CLI can display deprecation warnings on stdout.  The tests should
817 not interpret those warnings as a failure if the node is in fact correctly
818 started.
819   
820 See http://allmydata.org/trac/tahoe/ticket/859 for an example of deprecation
821 warnings.
822 
823 fixes #876
824]
825[contrib: fix fuse_impl_c to use new Python API
826zooko@zooko.com**20100109174956
827 Ignore-this: 51ca1ec7c2a92a0862e9b99e52542179
828 original patch by Thomas Delaet, fixed by François, reviewed by Brian, committed by me
829]
830[docs: CREDITS: add David-Sarah to the CREDITS file
831zooko@zooko.com**20100109060435
832 Ignore-this: 896062396ad85f9d2d4806762632f25a
833]
834[mutable/publish: don't loop() right away upon DeadReferenceError. Closes #877
835Brian Warner <warner@lothar.com>**20100102220841
836 Ignore-this: b200e707b3f13aa8251981362b8a3e61
837 
838 The bug was that a disconnected server could cause us to re-enter the initial
839 loop() call, sending multiple queries to a single server, provoking an
840 incorrect UCWE. To fix it, stall the loop() with an eventual.fireEventually()
841]
842[immutable/checker.py: oops, forgot some imports. Also hush pyflakes.
843Brian Warner <warner@lothar.com>**20091229233909
844 Ignore-this: 4d61bd3f8113015a4773fd4768176e51
845]
846[mutable repair: return successful=False when numshares<k (thus repair fails),
847Brian Warner <warner@lothar.com>**20091229233746
848 Ignore-this: d881c3275ff8c8bee42f6a80ca48441e
849 instead of weird errors. Closes #874 and #786.
850 
851 Previously, if the file had 0 shares, this would raise TypeError as it tried
852 to call download_version(None). If the file had some shares but fewer than
853 'k', it would incorrectly raise MustForceRepairError.
854 
855 Added get_successful() to the IRepairResults API, to give repair() a place to
856 report non-code-bug problems like this.
857]
858[node.py/interfaces.py: minor docs fixes
859Brian Warner <warner@lothar.com>**20091229230409
860 Ignore-this: c86ad6342ef0f95d50639b4f99cd4ddf
861]
862[NEWS: fix 1.4.1 announcement w.r.t. add-lease behavior in older releases
863Brian Warner <warner@lothar.com>**20091229230310
864 Ignore-this: bbbbb9c961f3bbcc6e5dbe0b1594822
865]
866[checker: don't let failures in add-lease affect checker results. Closes #875.
867Brian Warner <warner@lothar.com>**20091229230108
868 Ignore-this: ef1a367b93e4d01298c2b1e6ca59c492
869 
870 Mutable servermap updates and the immutable checker, when run with
871 add_lease=True, send both the do-you-have-block and add-lease commands in
872 parallel, to avoid an extra round trip time. Many older servers have problems
873 with add-lease and raise various exceptions, which don't generally matter.
874 The client-side code was catching+ignoring some of them, but unrecognized
875 exceptions were passed through to the DYHB code, concealing the DYHB results
876 from the checker, making it think the server had no shares.
877 
878 The fix is to separate the code paths. Both commands are sent at the same
879 time, but the errback path from add-lease is handled separately. Known
880 exceptions are ignored, the others (both unknown-remote and all-local) are
881 logged (log.WEIRD, which will trigger an Incident), but neither will affect
882 the DYHB results.
883 
884 The add-lease message is sent first, and we know that the server handles them
885 synchronously. So when the checker is done, we can be sure that all the
886 add-lease messages have been retired. This makes life easier for unit tests.
887]
888[test_cli: verify fix for "tahoe get" not creating empty file on error (#121)
889Brian Warner <warner@lothar.com>**20091227235444
890 Ignore-this: 6444d52413b68eb7c11bc3dfdc69c55f
891]
892[addendum to "Fix 'tahoe ls' on files (#771)"
893Brian Warner <warner@lothar.com>**20091227232149
894 Ignore-this: 6dd5e25f8072a3153ba200b7fdd49491
895 
896 tahoe_ls.py: tolerate missing metadata
897 web/filenode.py: minor cleanups
898 test_cli.py: test 'tahoe ls FILECAP'
899]
900[Fix 'tahoe ls' on files (#771). Patch adapted from Kevan Carstensen.
901Brian Warner <warner@lothar.com>**20091227225443
902 Ignore-this: 8bf8c7b1cd14ea4b0ebd453434f4fe07
903 
904 web/filenode.py: also serve edge metadata when using t=json on a
905                  DIRCAP/childname object.
906 tahoe_ls.py: list file objects as if we were listing one-entry directories.
907              Show edge metadata if we have it, which will be true when doing
908              'tahoe ls DIRCAP/filename' and false when doing 'tahoe ls
909              FILECAP'
910]
911[tahoe_get: don't create the output file on error. Closes #121.
912Brian Warner <warner@lothar.com>**20091227220404
913 Ignore-this: 58d5e793a77ec6e87d9394ade074b926
914]
915[webapi: don't accept zero-length childnames during traversal. Closes #358, #676.
916Brian Warner <warner@lothar.com>**20091227201043
917 Ignore-this: a9119dec89e1c7741f2289b0cad6497b
918 
919 This forbids operations that would implicitly create a directory with a
920 zero-length (empty string) name, like what you'd get if you did "tahoe put
921 local /oops/blah" (#358) or "POST /uri/CAP//?t=mkdir" (#676). The error
922 message is fairly friendly too.
923 
924 Also added code to "tahoe put" to catch this error beforehand and suggest the
925 correct syntax (i.e. without the leading slash).
926]
927[CLI: send 'Accept:' header to ask for text/plain tracebacks. Closes #646.
928Brian Warner <warner@lothar.com>**20091227195828
929 Ignore-this: 44c258d4d4c7dac0ed58adb22f73331
930 
931 The webapi has been looking for an Accept header since 1.4.0, but it treats a
932 missing header as equal to */* (to honor RFC2616). This change finally
933 modifies our CLI tools to ask for "text/plain, application/octet-stream",
934 which seems roughly correct (we either want a plain-text traceback or error
935 message, or an uninterpreted chunk of binary data to save to disk). Some day
936 we'll figure out how JSON fits into this scheme.
937]
938[Makefile: upload-tarballs: switch from xfer-client to flappclient, closes #350
939Brian Warner <warner@lothar.com>**20091227163703
940 Ignore-this: 3beeecdf2ad9c2438ab57f0e33dcb357
941 
942 I've also set up a new flappserver on source@allmydata.org to receive the
943 tarballs. We still need to replace the gutsy buildslave (which is where the
944 tarballs used to be generated+uploaded) and give it the new FURL.
945]
946[misc/ringsim.py: make it deterministic, more detail about grid-is-full behavior
947Brian Warner <warner@lothar.com>**20091227024832
948 Ignore-this: a691cc763fb2e98a4ce1767c36e8e73f
949]
950[misc/ringsim.py: tool to discuss #302
951Brian Warner <warner@lothar.com>**20091226060339
952 Ignore-this: fc171369b8f0d97afeeb8213e29d10ed
953]
954[docs: fix helper.txt to describe new config style
955zooko@zooko.com**20091224223522
956 Ignore-this: 102e7692dc414a4b466307f7d78601fe
957]
958[docs/stats.txt: add TOC, notes about controlling gatherer's listening port
959Brian Warner <warner@lothar.com>**20091224202133
960 Ignore-this: 8eef63b0e18db5aa8249c2eafde02c05
961 
962 Thanks to Jody Harris for the suggestions.
963]
964[Add docs/stats.py, explaining Tahoe stats, the gatherer, and the munin plugins.
965Brian Warner <warner@lothar.com>**20091223052400
966 Ignore-this: 7c9eeb6e5644eceda98b59a67730ccd5
967]
968[more #859: avoid deprecation warning for unit tests too, hush pyflakes
969Brian Warner <warner@lothar.com>**20091215000147
970 Ignore-this: 193622e24d31077da825a11ed2325fd3
971 
972 * factor maybe-import-sha logic into util.hashutil
973]
974[use hashlib module if available, thus avoiding a DeprecationWarning for importing the old sha module; fixes #859
975zooko@zooko.com**20091214212703
976 Ignore-this: 8d0f230a4bf8581dbc1b07389d76029c
977]
978[docs: reflow architecture.txt to 78-char lines
979zooko@zooko.com**20091208232943
980 Ignore-this: 88f55166415f15192e39407815141f77
981]
982[docs: update the about.html a little
983zooko@zooko.com**20091208212737
984 Ignore-this: 3fe2d9653c6de0727d3e82bd70f2a8ed
985]
986[docs: remove obsolete doc file "codemap.txt"
987zooko@zooko.com**20091113163033
988 Ignore-this: 16bc21a1835546e71d1b344c06c61ebb
989 I started to update this to reflect the current codebase, but then I thought (a) nobody seemed to notice that it hasn't been updated since December 2007, and (b) it will just bit-rot again, so I'm removing it.
990]
991[mutable/retrieve.py: stop reaching into private MutableFileNode attributes
992Brian Warner <warner@lothar.com>**20091208172921
993 Ignore-this: 61e548798c1105aed66a792bf26ceef7
994]
995[mutable/servermap.py: stop reaching into private MutableFileNode attributes
996Brian Warner <warner@lothar.com>**20091208172608
997 Ignore-this: b40a6b62f623f9285ad96fda139c2ef2
998]
999[mutable/servermap.py: oops, query N+e servers in MODE_WRITE, not k+e
1000Brian Warner <warner@lothar.com>**20091208171156
1001 Ignore-this: 3497f4ab70dae906759007c3cfa43bc
1002 
1003 under normal conditions, this wouldn't cause any problems, but if the shares
1004 are really sparse (perhaps because new servers were added), then
1005 file-modifies might stop looking too early and leave old shares in place
1006]
1007[control.py: fix speedtest: use download_best_version (not read) on mutable nodes
1008Brian Warner <warner@lothar.com>**20091207060512
1009 Ignore-this: 7125eabfe74837e05f9291dd6414f917
1010]
1011[FTP-and-SFTP.txt: fix ssh-keygen pointer
1012Brian Warner <warner@lothar.com>**20091207052803
1013 Ignore-this: bc2a70ee8c58ec314e79c1262ccb22f7
1014]
1015[setup: ignore _darcs in the "test-clean" test and make the "clean" step remove all .egg's in the root dir
1016zooko@zooko.com**20091206184835
1017 Ignore-this: 6066bd160f0db36d7bf60aba405558d2
1018]
1019[remove MutableFileNode.download(), prefer download_best_version() instead
1020Brian Warner <warner@lothar.com>**20091201225438
1021 Ignore-this: 5733eb373a902063e09fd52cc858dec0
1022]
1023[Simplify immutable download API: use just filenode.read(consumer, offset, size)
1024Brian Warner <warner@lothar.com>**20091201225330
1025 Ignore-this: bdedfb488ac23738bf52ae6d4ab3a3fb
1026 
1027 * remove Downloader.download_to_data/download_to_filename/download_to_filehandle
1028 * remove download.Data/FileName/FileHandle targets
1029 * remove filenode.download/download_to_data/download_to_filename methods
1030 * leave Downloader.download (the whole Downloader will go away eventually)
1031 * add util.consumer.MemoryConsumer/download_to_data, for convenience
1032   (this is mostly used by unit tests, but it gets used by enough non-test
1033    code to warrant putting it in allmydata.util)
1034 * update tests
1035 * removes about 180 lines of code. Yay negative code days!
1036 
1037 Overall plan is to rewrite immutable/download.py and leave filenode.read() as
1038 the sole read-side API.
1039]
1040[server.py: undo my bogus 'correction' of David-Sarah's comment fix
1041Brian Warner <warner@lothar.com>**20091201024607
1042 Ignore-this: ff4bb58f6a9e045b900ac3a89d6f506a
1043 
1044 and move it to a better line
1045]
1046[Implement more coherent behavior when copying with dircaps/filecaps (closes #761). Patch by Kevan Carstensen.
1047"Brian Warner <warner@lothar.com>"**20091130211009]
1048[storage.py: update comment
1049"Brian Warner <warner@lothar.com>"**20091130195913]
1050[storage server: detect disk space usage on Windows too (fixes #637)
1051david-sarah@jacaranda.org**20091121055644
1052 Ignore-this: 20fb30498174ce997befac7701fab056
1053]
1054[make status of finished operations consistently "Finished"
1055david-sarah@jacaranda.org**20091121061543
1056 Ignore-this: 97d483e8536ccfc2934549ceff7055a3
1057]
1058[NEWS: update with all user-visible changes since the last release
1059Brian Warner <warner@lothar.com>**20091127224217
1060 Ignore-this: 741da6cd928e939fb6d21a61ea3daf0b
1061]
1062[update "tahoe backup" docs, and webapi.txt's mkdir-with-children
1063Brian Warner <warner@lothar.com>**20091127055900
1064 Ignore-this: defac1fb9a2335b0af3ef9dbbcc67b7e
1065]
1066[Add dirnodes to backupdb and "tahoe backup", closes #606.
1067Brian Warner <warner@lothar.com>**20091126234257
1068 Ignore-this: fa88796fcad1763c6a2bf81f56103223
1069 
1070 * backups now share dirnodes with any previous backup, in any location,
1071   so renames and moves are handled very efficiently
1072 * "tahoe backup" no longer bothers reading the previous snapshot
1073 * if you switch grids, you should delete ~/.tahoe/private/backupdb.sqlite,
1074   to force new uploads of all files and directories
1075]
1076[webapi: fix t=check for DIR2-LIT (i.e. empty immutable directories)
1077Brian Warner <warner@lothar.com>**20091126232731
1078 Ignore-this: 8513c890525c69c1eca0e80d53a231f8
1079]
1080[PipelineError: fix str() on python2.4 . Closes #842.
1081Brian Warner <warner@lothar.com>**20091124212512
1082 Ignore-this: e62c92ea9ede2ab7d11fe63f43b9c942
1083]
1084[test_uri.py: s/NewDirnode/Dirnode/ , now that they aren't "new" anymore
1085Brian Warner <warner@lothar.com>**20091120075553
1086 Ignore-this: 61c8ef5e45a9d966873a610d8349b830
1087]
1088[interface name cleanups: IFileNode, IImmutableFileNode, IMutableFileNode
1089Brian Warner <warner@lothar.com>**20091120075255
1090 Ignore-this: e3d193c229e2463e1d0b0c92306de27f
1091 
1092 The proper hierarchy is:
1093  IFilesystemNode
1094  +IFileNode
1095  ++IMutableFileNode
1096  ++IImmutableFileNode
1097  +IDirectoryNode
1098 
1099 Also expand test_client.py (NodeMaker) to hit all IFilesystemNode types.
1100]
1101[class name cleanups: s/FileNode/ImmutableFileNode/
1102Brian Warner <warner@lothar.com>**20091120072239
1103 Ignore-this: 4b3218f2d0e585c62827e14ad8ed8ac1
1104 
1105 also fix test/bench_dirnode.py for recent dirnode changes
1106]
1107[Use DIR-IMM and t=mkdir-immutable for "tahoe backup", for #828
1108Brian Warner <warner@lothar.com>**20091118192813
1109 Ignore-this: a4720529c9bc6bc8b22a3d3265925491
1110]
1111[web/directory.py: use "DIR-IMM" to describe immutable directories, not DIR-RO
1112Brian Warner <warner@lothar.com>**20091118191832
1113 Ignore-this: aceafd6ab4bf1cc0c2a719ef7319ac03
1114]
1115[web/info.py: hush pyflakes
1116Brian Warner <warner@lothar.com>**20091118191736
1117 Ignore-this: edc5f128a2b8095fb20686a75747c8
1118]
1119[make get_size/get_current_size consistent for all IFilesystemNode classes
1120Brian Warner <warner@lothar.com>**20091118191624
1121 Ignore-this: bd3449cf96e4827abaaf962672c1665a
1122 
1123 * stop caching most_recent_size in dirnode, rely upon backing filenode for it
1124 * start caching most_recent_size in MutableFileNode
1125 * return None when you don't know, not "?"
1126 * only render None as "?" in the web "more info" page
1127 * add get_size/get_current_size to UnknownNode
1128]
1129[ImmutableDirectoryURIVerifier: fix verifycap handling
1130Brian Warner <warner@lothar.com>**20091118164238
1131 Ignore-this: 6bba5c717b54352262eabca6e805d590
1132]
1133[Add t=mkdir-immutable to the webapi. Closes #607.
1134Brian Warner <warner@lothar.com>**20091118070900
1135 Ignore-this: 311e5fab9a5f28b9e8a28d3d08f3c0d
1136 
1137 * change t=mkdir-with-children to not use multipart/form encoding. Instead,
1138   the request body is all JSON. t=mkdir-immutable uses this format too.
1139 * make nodemaker.create_immutable_dirnode() get convergence from SecretHolder,
1140   but let callers override it
1141 * raise NotDeepImmutableError instead of using assert()
1142 * add mutable= argument to DirectoryNode.create_subdirectory(), default True
1143]
1144[move convergence secret into SecretHolder, next to lease secret
1145Brian Warner <warner@lothar.com>**20091118015444
1146 Ignore-this: 312f85978a339f2d04deb5bcb8f511bc
1147]
1148[nodemaker: implement immutable directories (internal interface), for #607
1149Brian Warner <warner@lothar.com>**20091112002233
1150 Ignore-this: d09fccf41813fdf7e0db177ed9e5e130
1151 
1152 * nodemaker.create_from_cap() now handles DIR2-CHK and DIR2-LIT
1153 * client.create_immutable_dirnode() is used to create them
1154 * no webapi yet
1155]
1156[stop using IURI()/etc as an adapter
1157Brian Warner <warner@lothar.com>**20091111224542
1158 Ignore-this: 9611da7ea6a4696de2a3b8c08776e6e0
1159]
1160[clean up uri-vs-cap terminology, emphasize cap instances instead of URI strings
1161Brian Warner <warner@lothar.com>**20091111222619
1162 Ignore-this: 93626385f6e7f039ada71f54feefe267
1163 
1164  * "cap" means a python instance which encapsulates a filecap/dircap (uri.py)
1165  * "uri" means a string with a "URI:" prefix
1166  * FileNode instances are created with (and retain) a cap instance, and
1167    generate uri strings on demand
1168  * .get_cap/get_readcap/get_verifycap/get_repaircap return cap instances
1169  * .get_uri/get_readonly_uri return uri strings
1170 
1171 * add filenode.download_to_filename() for control.py, should find a better way
1172 * use MutableFileNode.init_from_cap, not .init_from_uri
1173 * directory URI instances: use get_filenode_cap, not get_filenode_uri
1174 * update/cleanup bench_dirnode.py to match, add Makefile target to run it
1175]
1176[add parser for immutable directory caps: DIR2-CHK, DIR2-LIT, DIR2-CHK-Verifier
1177Brian Warner <warner@lothar.com>**20091104181351
1178 Ignore-this: 854398cc7a75bada57fa97c367b67518
1179]
1180[wui: s/TahoeLAFS/Tahoe-LAFS/
1181zooko@zooko.com**20091029035050
1182 Ignore-this: 901e64cd862e492ed3132bd298583c26
1183]
1184[tests: bump up the timeout on test_repairer to see if 120 seconds was too short for François's ARM box to do the test even when it was doing it right.
1185zooko@zooko.com**20091027224800
1186 Ignore-this: 95e93dc2e018b9948253c2045d506f56
1187]
1188[dirnode.pack_children(): add deep_immutable= argument
1189Brian Warner <warner@lothar.com>**20091026162809
1190 Ignore-this: d5a2371e47662c4bc6eff273e8181b00
1191 
1192 This will be used by DIR2:CHK to enforce the deep-immutability requirement.
1193]
1194[webapi: use t=mkdir-with-children instead of a children= arg to t=mkdir .
1195Brian Warner <warner@lothar.com>**20091026011321
1196 Ignore-this: 769cab30b6ab50db95000b6c5a524916
1197 
1198 This is safer: in the earlier API, an old webapi server would silently ignore
1199 the initial children, and clients trying to set them would have to fetch the
1200 newly-created directory to discover the incompatibility. In the new API,
1201 clients using t=mkdir-with-children against an old webapi server will get a
1202 clear error.
1203]
1204[nodemaker.create_new_mutable_directory: pack_children() in initial_contents=
1205Brian Warner <warner@lothar.com>**20091020005118
1206 Ignore-this: bd43c4eefe06fd32b7492bcb0a55d07e
1207 instead of creating an empty file and then adding the children later.
1208 
1209 This should speed up mkdir(initial_children) considerably, removing two
1210 roundtrips and an entire read-modify-write cycle, probably bringing it down
1211 to a single roundtrip. A quick test (against the volunteergrid) suggests a
1212 30% speedup.
1213 
1214 test_dirnode: add new tests to enforce the restrictions that interfaces.py
1215 claims for create_new_mutable_directory(): no UnknownNodes, metadata dicts
1216]
1217[test_dirnode.py: add tests of initial_children= args to client.create_dirnode
1218Brian Warner <warner@lothar.com>**20091017194159
1219 Ignore-this: 2e2da28323a4d5d815466387914abc1b
1220 and nodemaker.create_new_mutable_directory
1221]
1222[update many dirnode interfaces to accept dict-of-nodes instead of dict-of-caps
1223Brian Warner <warner@lothar.com>**20091017192829
1224 Ignore-this: b35472285143862a856bf4b361d692f0
1225 
1226 interfaces.py: define INodeMaker, document argument values, change
1227                create_new_mutable_directory() to take dict-of-nodes. Change
1228                dirnode.set_nodes() and dirnode.create_subdirectory() too.
1229 nodemaker.py: use INodeMaker, update create_new_mutable_directory()
1230 client.py: have create_dirnode() delegate initial_children= to nodemaker
1231 dirnode.py (Adder): take dict-of-nodes instead of list-of-nodes, which
1232                     updates set_nodes() and create_subdirectory()
1233 web/common.py (convert_initial_children_json): create dict-of-nodes
1234 web/directory.py: same
1235 web/unlinked.py: same
1236 test_dirnode.py: update tests to match
1237]
1238[dirnode.py: move pack_children() out to a function, for eventual use by others
1239Brian Warner <warner@lothar.com>**20091017180707
1240 Ignore-this: 6a823fb61f2c180fd38d6742d3196a7a
1241]
1242[move dirnode.CachingDict to dictutil.AuxValueDict, generalize method names,
1243Brian Warner <warner@lothar.com>**20091017180005
1244 Ignore-this: b086933cf429df0fcea16a308d2640dd
1245 improve tests. Let dirnode _pack_children accept either dict or AuxValueDict.
1246]
1247[test/common.py: update FakeMutableFileNode to new contents= callable scheme
1248Brian Warner <warner@lothar.com>**20091013052154
1249 Ignore-this: 62f00a76454a2190d1c8641c5993632f
1250]
1251[The initial_children= argument to nodemaker.create_new_mutable_directory is
1252Brian Warner <warner@lothar.com>**20091013031922
1253 Ignore-this: 72e45317c21f9eb9ec3bd79bd4311f48
1254 now enabled.
1255]
1256[client.create_mutable_file(contents=) now accepts a callable, which is
1257Brian Warner <warner@lothar.com>**20091013031232
1258 Ignore-this: 3c89d2f50c1e652b83f20bd3f4f27c4b
1259 invoked with the new MutableFileNode and is supposed to return the initial
1260 contents. This can be used by e.g. a new dirnode which needs the filenode's
1261 writekey to encrypt its initial children.
1262 
1263 create_mutable_file() still accepts a bytestring too, or None for an empty
1264 file.
1265]
1266[webapi: t=mkdir now accepts initial children, using the same JSON that t=json
1267Brian Warner <warner@lothar.com>**20091013023444
1268 Ignore-this: 574a46ed46af4251abf8c9580fd31ef7
1269 emits.
1270 
1271 client.create_dirnode(initial_children=) now works.
1272]
1273[replace dirnode.create_empty_directory() with create_subdirectory(), which
1274Brian Warner <warner@lothar.com>**20091013021520
1275 Ignore-this: 6b57cb51bcfcc6058d0df569fdc8a9cf
1276 takes an initial_children= argument
1277]
1278[dirnode.set_children: change return value: fire with self instead of None
1279Brian Warner <warner@lothar.com>**20091013015026
1280 Ignore-this: f1d14e67e084e4b2a4e25fa849b0e753
1281]
1282[dirnode.set_nodes: change return value: fire with self instead of None
1283Brian Warner <warner@lothar.com>**20091013014546
1284 Ignore-this: b75b3829fb53f7399693f1c1a39aacae
1285]
1286[dirnode.set_children: take a dict, not a list
1287Brian Warner <warner@lothar.com>**20091013002440
1288 Ignore-this: 540ce72ce2727ee053afaae1ff124e21
1289]
1290[dirnode.set_uri/set_children: change signature to take writecap+readcap
1291Brian Warner <warner@lothar.com>**20091012235126
1292 Ignore-this: 5df617b2d379a51c79148a857e6026b1
1293 instead of a single cap. The webapi t=set_children call benefits too.
1294]
1295[replace Client.create_empty_dirnode() with create_dirnode(), in anticipation
1296Brian Warner <warner@lothar.com>**20091012224506
1297 Ignore-this: cbdaa4266ecb3c6496ffceab4f95709d
1298 of adding initial_children= argument.
1299 
1300 Includes stubbed-out initial_children= support.
1301]
1302[test_web.py: use a less-fake client, making test harness smaller
1303Brian Warner <warner@lothar.com>**20091012222808
1304 Ignore-this: 29e95147f8c94282885c65b411d100bb
1305]
1306[webapi.txt: document t=set_children, other small edits
1307Brian Warner <warner@lothar.com>**20091009200446
1308 Ignore-this: 4d7e76b04a7b8eaa0a981879f778ea5d
1309]
1310[Verifier: check the full cryptext-hash tree on each share. Removed .todos
1311Brian Warner <warner@lothar.com>**20091005221849
1312 Ignore-this: 6fb039c5584812017d91725e687323a5
1313 from the last few test_repairer tests that were waiting on this.
1314]
1315[Verifier: check the full block-hash-tree on each share
1316Brian Warner <warner@lothar.com>**20091005214844
1317 Ignore-this: 3f7ccf6d253f32340f1bf1da27803eee
1318 
1319 Removed the .todo from two test_repairer tests that check this. The only
1320 remaining .todos are on the three crypttext-hash-tree tests.
1321]
1322[Verifier: check the full share-hash chain on each share
1323Brian Warner <warner@lothar.com>**20091005213443
1324 Ignore-this: 3d30111904158bec06a4eac22fd39d17
1325 
1326 Removed the .todo from two test_repairer tests that check this.
1327]
1328[test_repairer: rename Verifier test cases to be more precise and less verbose
1329Brian Warner <warner@lothar.com>**20091005201115
1330 Ignore-this: 64be7094e33338c7c2aea9387e138771
1331]
1332[immutable/checker.py: rearrange code a little bit, make it easier to follow
1333Brian Warner <warner@lothar.com>**20091005200252
1334 Ignore-this: 91cc303fab66faf717433a709f785fb5
1335]
1336[test/common.py: wrap docstrings to 80cols so I can read them more easily
1337Brian Warner <warner@lothar.com>**20091005200143
1338 Ignore-this: b180a3a0235cbe309c87bd5e873cbbb3
1339]
1340[immutable/download.py: wrap to 80cols, no functional changes
1341Brian Warner <warner@lothar.com>**20091005192542
1342 Ignore-this: 6b05fe3dc6d78832323e708b9e6a1fe
1343]
1344[CHK-hashes.svg: cross out plaintext hashes, since we don't include
1345Brian Warner <warner@lothar.com>**20091005010803
1346 Ignore-this: bea2e953b65ec7359363aa20de8cb603
1347 them (until we finish #453)
1348]
1349[docs: a few licensing clarifications requested by Ubuntu
1350zooko@zooko.com**20090927033226
1351 Ignore-this: 749fc8c9aeb6dc643669854a3e81baa7
1352]
1353[setup: remove binary WinFUSE modules
1354zooko@zooko.com**20090924211436
1355 Ignore-this: 8aefc571d2ae22b9405fc650f2c2062
1356 I would prefer to have just source code, or indications of what 3rd-party packages are required, under revision control, and have the build process generate o
1357 r acquire the binaries as needed.  Also, having these in our release tarballs is interfering with getting Tahoe-LAFS uploaded into Ubuntu Karmic.  (Technicall
1358 y, they would accept binary modules as long as they came with the accompanying source so that they could satisfy their obligations under GPL2+ and TGPPL1+, bu
1359 t it is easier for now to remove the binaries from the source tree.)
1360 In this case, the binaries are from the tahoe-w32-client project: http://allmydata.org/trac/tahoe-w32-client , from which you can also get the source.
1361]
1362[setup: remove binary _fusemodule.so 's
1363zooko@zooko.com**20090924211130
1364 Ignore-this: 74487bbe27d280762ac5dd5f51e24186
1365 I would prefer to have just source code, or indications of what 3rd-party packages are required, under revision control, and have the build process generate or acquire the binaries as needed.  Also, having these in our release tarballs is interfering with getting Tahoe-LAFS uploaded into Ubuntu Karmic.  (Technically, they would accept binary modules as long as they came with the accompanying source so that they could satisfy their obligations under GPL2+ and TGPPL1+, but it is easier for now to remove the binaries from the source tree.)
1366 In this case, these modules come from the MacFUSE project: http://code.google.com/p/macfuse/
1367]
1368[doc: add a copy of LGPL2 for documentation purposes for ubuntu
1369zooko@zooko.com**20090924054218
1370 Ignore-this: 6a073b48678a7c84dc4fbcef9292ab5b
1371]
1372[setup: remove a convenience copy of figleaf, to ease inclusion into Ubuntu Karmic Koala
1373zooko@zooko.com**20090924053215
1374 Ignore-this: a0b0c990d6e2ee65c53a24391365ac8d
1375 We need to carefully document the licence of figleaf in order to get Tahoe-LAFS into Ubuntu Karmic Koala.  However, figleaf isn't really a part of Tahoe-LAFS per se -- this is just a "convenience copy" of a development tool.  The quickest way to make Tahoe-LAFS acceptable for Karmic then, is to remove figleaf from the Tahoe-LAFS tarball itself.  People who want to run figleaf on Tahoe-LAFS (as everyone should want) can install figleaf themselves.  I haven't tested this -- there may be incompatibilities between upstream figleaf and the copy that we had here...
1376]
1377[setup: shebang for misc/build-deb.py to fail quickly
1378zooko@zooko.com**20090819135626
1379 Ignore-this: 5a1b893234d2d0bb7b7346e84b0a6b4d
1380 Without this patch, when I ran "chmod +x ./misc/build-deb.py && ./misc/build-deb.py" then it hung indefinitely.  (I wonder what it was doing.)
1381]
1382[docs: Shawn Willden grants permission for his contributions under GPL2+|TGPPL1+
1383zooko@zooko.com**20090921164651
1384 Ignore-this: ef1912010d07ff2ffd9678e7abfd0d57
1385]
1386[docs: Csaba Henk granted permission to license fuse.py under the same terms as Tahoe-LAFS itself
1387zooko@zooko.com**20090921154659
1388 Ignore-this: c61ba48dcb7206a89a57ca18a0450c53
1389]
1390[setup: mark setup.py as having utf-8 encoding in it
1391zooko@zooko.com**20090920180343
1392 Ignore-this: 9d3850733700a44ba7291e9c5e36bb91
1393]
1394[doc: licensing cleanups
1395zooko@zooko.com**20090920171631
1396 Ignore-this: 7654f2854bf3c13e6f4d4597633a6630
1397 Use nice utf-8 © instead of "(c)". Remove licensing statements on utility modules that have been assigned to allmydata.com by their original authors. (Nattraverso was not assigned to allmydata.com -- it was LGPL'ed -- but I checked and src/allmydata/util/iputil.py was completely rewritten and doesn't contain any line of code from nattraverso.)  Add notes to misc/debian/copyright about licensing on files that aren't just allmydata.com-licensed.
1398]
1399[build-deb.py: run darcsver early, otherwise we get the wrong version later on
1400Brian Warner <warner@lothar.com>**20090918033620
1401 Ignore-this: 6635c5b85e84f8aed0d8390490c5392a
1402]
1403[new approach for debian packaging, sharing pieces across distributions. Still experimental, still only works for sid.
1404warner@lothar.com**20090818190527
1405 Ignore-this: a75eb63db9106b3269badbfcdd7f5ce1
1406]
1407[new experimental deb-packaging rules. Only works for sid so far.
1408Brian Warner <warner@lothar.com>**20090818014052
1409 Ignore-this: 3a26ad188668098f8f3cc10a7c0c2f27
1410]
1411[setup.py: read _version.py and pass to setup(version=), so more commands work
1412Brian Warner <warner@lothar.com>**20090818010057
1413 Ignore-this: b290eb50216938e19f72db211f82147e
1414 like "setup.py --version" and "setup.py --fullname"
1415]
1416[test/check_speed.py: fix shbang line
1417Brian Warner <warner@lothar.com>**20090818005948
1418 Ignore-this: 7f3a37caf349c4c4de704d0feb561f8d
1419]
1420[setup: remove bundled version of darcsver-1.2.1
1421zooko@zooko.com**20090816233432
1422 Ignore-this: 5357f26d2803db2d39159125dddb963a
1423 That version of darcsver emits a scary error message when the darcs executable or the _darcs subdirectory is not found.
1424 This error is hidden (unless the --loud option is passed) in darcsver >= 1.3.1.
1425 Fixes #788.
1426]
1427[de-Service-ify Helper, pass in storage_broker and secret_holder directly.
1428Brian Warner <warner@lothar.com>**20090815201737
1429 Ignore-this: 86b8ac0f90f77a1036cd604dd1304d8b
1430 This makes it more obvious that the Helper currently generates leases with
1431 the Helper's own secrets, rather than getting values from the client, which
1432 is arguably a bug that will likely be resolved with the Accounting project.
1433]
1434[immutable.Downloader: pass StorageBroker to constructor, stop being a Service
1435Brian Warner <warner@lothar.com>**20090815192543
1436 Ignore-this: af5ab12dbf75377640a670c689838479
1437 child of the client, access with client.downloader instead of
1438 client.getServiceNamed("downloader"). The single "Downloader" instance is
1439 scheduled for demolition anyways, to be replaced by individual
1440 filenode.download calls.
1441]
1442[tests: double the timeout on test_runner.RunNode.test_introducer since feisty hit a timeout
1443zooko@zooko.com**20090815160512
1444 Ignore-this: ca7358bce4bdabe8eea75dedc39c0e67
1445 I'm not sure if this is an actual timing issue (feisty is running on an overloaded VM if I recall correctly), or it there is a deeper bug.
1446]
1447[stop making History be a Service, it wasn't necessary
1448Brian Warner <warner@lothar.com>**20090815114415
1449 Ignore-this: b60449231557f1934a751c7effa93cfe
1450]
1451[Overhaul IFilesystemNode handling, to simplify tests and use POLA internally.
1452Brian Warner <warner@lothar.com>**20090815112846
1453 Ignore-this: 1db1b9c149a60a310228aba04c5c8e5f
1454 
1455 * stop using IURI as an adapter
1456 * pass cap strings around instead of URI instances
1457 * move filenode/dirnode creation duties from Client to new NodeMaker class
1458 * move other Client duties to KeyGenerator, SecretHolder, History classes
1459 * stop passing Client reference to dirnode/filenode constructors
1460   - pass less-powerful references instead, like StorageBroker or Uploader
1461 * always create DirectoryNodes by wrapping a filenode (mutable for now)
1462 * remove some specialized mock classes from unit tests
1463 
1464 Detailed list of changes (done one at a time, then merged together)
1465 
1466 always pass a string to create_node_from_uri(), not an IURI instance
1467 always pass a string to IFilesystemNode constructors, not an IURI instance
1468 stop using IURI() as an adapter, switch on cap prefix in create_node_from_uri()
1469 client.py: move SecretHolder code out to a separate class
1470 test_web.py: hush pyflakes
1471 client.py: move NodeMaker functionality out into a separate object
1472 LiteralFileNode: stop storing a Client reference
1473 immutable Checker: remove Client reference, it only needs a SecretHolder
1474 immutable Upload: remove Client reference, leave SecretHolder and StorageBroker
1475 immutable Repairer: replace Client reference with StorageBroker and SecretHolder
1476 immutable FileNode: remove Client reference
1477 mutable.Publish: stop passing Client
1478 mutable.ServermapUpdater: get StorageBroker in constructor, not by peeking into Client reference
1479 MutableChecker: reference StorageBroker and History directly, not through Client
1480 mutable.FileNode: removed unused indirection to checker classes
1481 mutable.FileNode: remove Client reference
1482 client.py: move RSA key generation into a separate class, so it can be passed to the nodemaker
1483 move create_mutable_file() into NodeMaker
1484 test_dirnode.py: stop using FakeClient mockups, use NoNetworkGrid instead. This simplifies the code, but takes longer to run (17s instead of 6s). This should come down later when other cleanups make it possible to use simpler (non-RSA) fake mutable files for dirnode tests.
1485 test_mutable.py: clean up basedir names
1486 client.py: move create_empty_dirnode() into NodeMaker
1487 dirnode.py: get rid of DirectoryNode.create
1488 remove DirectoryNode.init_from_uri, refactor NodeMaker for customization, simplify test_web's mock Client to match
1489 stop passing Client to DirectoryNode, make DirectoryNode.create_with_mutablefile the normal DirectoryNode constructor, start removing client from NodeMaker
1490 remove Client from NodeMaker
1491 move helper status into History, pass History to web.Status instead of Client
1492 test_mutable.py: fix minor typo
1493]
1494[docs: edits for docs/running.html from Sam Mason
1495zooko@zooko.com**20090809201416
1496 Ignore-this: 2207e80449943ebd4ed50cea57c43143
1497]
1498[docs: install.html: instruct Debian users to use this document and not to go find the DownloadDebianPackages page, ignore the warning at the top of it, and try it
1499zooko@zooko.com**20090804123840
1500 Ignore-this: 49da654f19d377ffc5a1eff0c820e026
1501 http://allmydata.org/pipermail/tahoe-dev/2009-August/002507.html
1502]
1503[docs: relnotes.txt: reflow to 63 chars wide because google groups and some web forms seem to wrap to that
1504zooko@zooko.com**20090802135016
1505 Ignore-this: 53b1493a0491bc30fb2935fad283caeb
1506]
1507[docs: about.html: fix English usage noticed by Amber
1508zooko@zooko.com**20090802050533
1509 Ignore-this: 89965c4650f9bd100a615c401181a956
1510]
1511[docs: fix mis-spelled word in about.html
1512zooko@zooko.com**20090802050320
1513 Ignore-this: fdfd0397bc7cef9edfde425dddeb67e5
1514]
1515[TAG allmydata-tahoe-1.5.0
1516zooko@zooko.com**20090802031303
1517 Ignore-this: 94e5558e7225c39a86aae666ea00f166
1518]
1519Patch bundle hash:
152099ad51d4bb784b120f07580a9cef1ab41a381ee2