Changeset 06c4ed1 in trunk

Timestamp:

2021-04-12T13:28:51Z (4 years ago)

Author:

Itamar Turner-Trauring <itamar@…>

Branches:

master

Children:

069fcb9

Parents:

d6406d5

Message:

Some progress towards passing Python 3 tests.

Location:

src/allmydata/scripts

Files:

• common.py (modified) (3 diffs)
• tahoe_backup.py (modified) (3 diffs)

src/allmydata/scripts/common.py ¶

@@ -2 +2 @@
 
 from __future__ import print_function
-from six import ensure_binary
+from six import ensure_str
 
 import os, sys, textwrap
@@ -277 +277 @@
 
 def escape_path(path):
-    # type: (Union[str,bytes]) -> bytes
+    # type: (Union[str,bytes]) -> str
     u"""
     Return path quoted to US-ASCII, valid URL characters.
@@ -284 +284 @@
     >>> escaped = escape_path(path)
     >>> escaped
-    b'/f%C3%B8%C3%B6/bar/%E2%98%83'
+    u'/f%C3%B8%C3%B6/bar/%E2%98%83'
     """
     if isinstance(path, str):
         path = path.encode("utf-8")
     segments = path.split(b"/")
-    return b"/".join([urllib.parse.quote(s).encode("ascii") for s in segments])
-
+    result = str(
+        b"/".join([
+            urllib.parse.quote(s).encode("ascii") for s in segments
+        ]),
+        "ascii"
+    )
+    # Eventually (i.e. as part of Python 3 port) we want this to always return
+    # Unicode strings. However, to reduce diff sizes in the short term it'll
+    # return native string (i.e. bytes) on Python 2.
+    if PY2:
+        result = result.encode("ascii").__native__()
+    return result

src/allmydata/scripts/tahoe_backup.py ¶

@@ -1 +1 @@
 from __future__ import print_function
+
+from past.builtins import unicode
 
 import os.path
@@ -346 +348 @@
             return target.backup(progress, upload_file, upload_directory)
         else:
-            assert isinstance(childcap, str)
+            assert isinstance(childcap, bytes)
             if created:
                 return progress.created_file(self._path, childcap, metadata)
@@ -526 +528 @@
             os.path.basename(create_path): create_value
             for (create_path, create_value)
-            in self._create_contents.iteritems()
+            in self._create_contents.items()
             if os.path.dirname(create_path) == dirpath
         }, {
             os.path.basename(compare_path): compare_value
             for (compare_path, compare_value)
-            in self._compare_contents.iteritems()
+            in self._compare_contents.items()
             if os.path.dirname(compare_path) == dirpath
         }