Changeset 54248f33 in trunk

Timestamp:

2020-07-09T18:35:14Z (5 years ago)

Author:

Sajith Sasidharan <sajith@…>

Branches:

master

Children:

2e160c1

Parents:

f9e864c5

git-author:

Sajith Sasidharan <sajith@…> (2020-07-09 14:01:13)

git-committer:

Sajith Sasidharan <sajith@…> (2020-07-09 18:35:14)

Message:

Use WebError?, not RuntimeError?, to indicate error

Several problems with using RuntimeError? to signal error here:

• It dumps a rather unhelpful webpage at the user.
• The exception backtrace on Tahoe console is not quite necessary here.
• It really is not a runtime error: it is just an expected failure.
• But mainly, testing for RuntimeError? is harder.

File:

• src/allmydata/web/status.py (modified) (2 diffs)

src/allmydata/web/status.py ¶

@@ -26 +26 @@
     MultiFormatResource,
     SlotsSequenceElement,
+    WebError,
 )
 
@@ -1172 +1173 @@
             stype, count_s = path.split("-")
         except ValueError:
-            raise RuntimeError(
-                "no - in '{}'".format(path)
-            )
+            raise WebError("no '-' in '{}'".format(path))
         count = int(count_s)
         if stype == "up":