Changeset 57a3c11 in trunk

Timestamp:

2021-09-15T11:03:31Z (4 years ago)

Author:

Florian Sesser <florian@…>

Branches:

master

Children:

d864cab

Parents:

88a2e7a

Message:

OpenMetrics?: Use list of strings instead of string concatenation

File:

• src/allmydata/web/status.py (modified) (2 diffs)

src/allmydata/web/status.py ¶

@@ -1557 +1557 @@
         req.setHeader("content-type", "application/openmetrics-text; version=1.0.0; charset=utf-8")
         stats = self._provider.get_stats()
-        ret = u""
+        ret = []
 
         def mangle_name(name):
@@ -1570 +1570 @@
 
         for (k, v) in sorted(stats['counters'].items()):
-            ret += u"tahoe_counters_%s %s\n" % (mangle_name(k), mangle_value(v))
+            ret.append(u"tahoe_counters_%s %s" % (mangle_name(k), mangle_value(v)))
         for (k, v) in sorted(stats['stats'].items()):
-            ret += u"tahoe_stats_%s %s\n" % (mangle_name(k), mangle_value(v))
-
-        ret += u"# EOF\n"
-
-        return ret
+            ret.append(u"tahoe_stats_%s %s" % (mangle_name(k), mangle_value(v)))
+
+        ret.append(u"# EOF")
+
+        return u"\n".join(ret)
 
 class StatisticsElement(Element):