Changeset e113cba in trunk

Timestamp:

2020-08-13T19:02:59Z (5 years ago)

Author:

Itamar Turner-Trauring <itamar@…>

Branches:

master

Children:

2157da52

Parents:

7505abe8

git-author:

Itamar Turner-Trauring <itamar@…> (2020-08-13 19:02:49)

git-committer:

Itamar Turner-Trauring <itamar@…> (2020-08-13 19:02:59)

Message:

Address review comments.

Location:

src/allmydata

Files:

• test/test_encodingutil.py (modified) (1 diff)
• util/encodingutil.py (modified) (1 diff)

src/allmydata/test/test_encodingutil.py ¶

@@ -54 +54 @@
             open(os.path.join(tmpdir, fname), 'w').close()
 
-        # Use Unicode API under Windows or MacOS X
+        # On Python 2, listing directories returns unicode under Windows or
+        # MacOS X if the input is unicode. On Python 3, it always returns
+        # Unicode.
         if PY2 and sys.platform in ('win32', 'darwin'):
             dirlist = os.listdir(unicode(tmpdir))

src/allmydata/util/encodingutil.py ¶

@@ -215 +215 @@
 
 def _str_escape(m, quote_newlines):  # TODO rename to _bytes_escape
+    """
+    Takes a re match on bytes, the result is escaped bytes of group(0).
+    """
     c = m.group(0)
     if c == b'"' or c == b'$' or c == b'`' or c == b'\\':