Changeset fd28160 in trunk

Timestamp:

2024-11-04T16:31:45Z (5 months ago)

Author:

JW Jacobson <116485484+jwjacobson@…>

Children:

0c76148

Parents:

d55b8f1

Message:

WIP 1101 Add verbose flag to check command

This commit adds the verbose option to the command 'check' so that if
you choose verbose, you do not get an error message. The full verbose
output is not yet implemented. When verbose is fully supported, the
option should return more detailed output.

modified: src/allmydata/scripts/cli.py
modified: src/allmydata/test/cli/test_check.py

Location:

src/allmydata

Files:

• scripts/cli.py (modified) (1 diff)
• test/cli/test_check.py (modified) (1 diff)

src/allmydata/scripts/cli.py ¶

@@ -446 +446 @@
         ("repair", None, "Automatically repair any problems found."),
         ("add-lease", None, "Add/renew lease on all shares."),
+        ("verbose", None, "Provide verbose output (unimplemented)."),
         ]
     def parseArgs(self, *locations):

src/allmydata/test/cli/test_check.py ¶

@@ -152 +152 @@
         d.addCallback(_check5)
 
+        # Testing verbose option
+        d.addCallback(lambda ign: self.do_cli("check", "--verbose", self.uri))
+        def _check6(args):
+            (rc, out, err) = args
+            self.assertEqual(len(err), 0, err)
+            self.failUnlessReallyEqual(rc, 0)
+            lines = out.splitlines()
+            self.failUnless("Summary: Healthy" in lines, out)
+            self.failUnless(" good-shares: 10 (encoding is 3-of-10)" in lines, out)
+        d.addCallback(_check1)
+
+
         return d