Changeset ff64a0fe in trunk

Timestamp:

2013-03-19T00:34:57Z (12 years ago)

Author:

Brian Warner <warner@…>

Branches:

master

Children:

3e26c78

Parents:

7130a24

git-author:

Brian Warner <warner@…> (2013-03-19 00:30:57)

git-committer:

Brian Warner <warner@…> (2013-03-19 00:34:57)

Message:

fileutil.write: accept mode=, and use it in Node.write_config

I want mode="w" (i.e. text, with newline conversion) for code that
writes newline-terminated strings (which should also be human readable)
to files. I like to use things like "cat .tahoe/permutation-seed"
without seeing the seed jammed together with the next command prompt.

Location:

src/allmydata

Files:

• node.py (modified) (1 diff)
• util/fileutil.py (modified) (1 diff)

src/allmydata/node.py ¶

@@ -280 +280 @@
         fn = os.path.join(self.basedir, name)
         try:
-            open(fn, mode).write(value)
+            fileutil.write(fn, value, mode)
         except EnvironmentError, e:
             self.log("Unable to write config file '%s'" % fn)

src/allmydata/util/fileutil.py ¶

@@ -256 +256 @@
     move_into_place(target+".tmp", target)
 
-def write(path, data):
-    wf = open(path, "wb")
+def write(path, data, mode="wb"):
+    wf = open(path, mode)
     try:
         wf.write(data)