Changes between Initial Version and Version 1 of Ticket #1010, comment 60


Ignore:
Timestamp:
2016-03-28T01:43:29Z (8 years ago)
Author:
dawuud
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1010, comment 60

    initial v1  
    44https://github.com/david415/tahoe-lafs/tree/1010-anonymous-client-mode
    55
    6 It seems like we need to fix at least two things in the above changeset:
     6It seems like we need to fix the above changeset:
     7- the tub.port = UNREACHABLE isn't correct. currently it's "tub.port=" to express "no listening"
    78
    8 1. the tub.port = UNREACHABLE isn't correct. currently it's "tub.port=" to express "no listening"
    9 2. the ``is_anonymous`` helper function seems to not account for storage server operators who specify their listening port via a TCP endpoint instead of tor/i2p. Referring to code here:
     9fixed here:
     10https://github.com/david415/tahoe-lafs/tree/1010-anonymous-client-mode.2
    1011
    11 https://github.com/david415/tahoe-lafs/blob/1010-anonymous-client-mode/src/allmydata/util/anonymize.py
    12 
    13 Question: Should ``is_anonymous`` only check for "tub.port=AUTO" condition?
    14 
    15 We should not assume that tor will be listening on loopback. As various virtualization environments are becoming more popular tor might well be listening on a bridge interface or something like that.