Changes between Initial Version and Version 1 of Ticket #1274, comment 21


Ignore:
Timestamp:
2011-01-20T20:55:38Z (14 years ago)
Author:
davidsarah
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1274, comment 21

    initial v1  
    2323With this patch, we no longer use anything that calls {{{reactor.spawnProcess}}} (either in test or non-test code). Does that resolve the problem?
    2424
    25 {{{iputil.py}}} is the only place where we previously used {{{getProcessOutput}}} and now uses {{{subprocess.Popen}}}. Note that it is done in a {{{deferToThread}}} (I'm not sure whether that helps, since the SIGCHLD handler is process-global).
     25{{{iputil.py}}} is the only place [in non-test code] where we previously used {{{getProcessOutput}}} and now use {{{subprocess.Popen}}}. Note that it is done in a {{{deferToThread}}} (I'm not sure whether that helps, since the SIGCHLD handler is process-global).