Changes between Initial Version and Version 1 of Ticket #1382, comment 65


Ignore:
Timestamp:
2013-12-31T20:56:02Z (11 years ago)
Author:
daira
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1382, comment 65

    initial v1  
    77Calling {{{allmydata.util.happinessutil.servers_of_happiness}}} from {{{is_happy_enough}}} and trusting the result would not preserve the intent of the test, because there might be a bug in {{{happinessutil}}} that would then propagate to the test and result in a false pass.
    88
    9 Since the test only checks for happiness rather than unhappiness, it would be possible to call a function in {{{servers_of_happiness}}} that returns a purported maximum matching, and check that it actually is a matching. It is not necessary to check that the matching is maximum, because not being maximum could only cause the test to fail; it could not cause a false pass.
     9Since the test only checks for happiness rather than unhappiness, it would be possible to call a function that returns a purported maximum matching, and check that it actually is a matching. It is not necessary to check that the matching is maximum, because not being maximum could only cause the test to fail; it could not cause a false pass.