Changes between Initial Version and Version 1 of Ticket #1392, comment 21


Ignore:
Timestamp:
2011-05-24T00:08:12Z (14 years ago)
Author:
arch_o_median
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1392, comment 21

    initial v1  
    1   When I ran the whole test suite "python ./setup.py test" two tests failed.   The dictionary returned by get_stats no longer conformed to the constraints expected in interfaces.py as it contained "None" values.  I modified the ChoiceOf call in the relevant interface to include a "None", element as an argument.  This allows the test suite to pass.  Beyond the fact that the tests now pass I do not know what effects such a change might have, i.e. I've not examined the definition of ChoiceOf, so review is certainly called for.
     1  When I ran the whole test suite "python ./setup.py test" two tests failed.   The dictionary returned by get_stats no longer conformed to the constraints expected in interfaces.py as it contained "None" values.  I modified the !ChoiceOf call in the relevant interface to include a "None", element as an argument.  This allows the test suite to pass.  Beyond the fact that the tests now pass I do not know what effects such a change might have, i.e. I've not examined the definition of !ChoiceOf, so review is certainly called for.