Changes between Initial Version and Version 1 of Ticket #145, comment 23


Ignore:
Timestamp:
2010-07-27T06:10:00Z (14 years ago)
Author:
davidsarah
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #145, comment 23

    initial v1  
    11See #1137 for a reoccurrence of this problem, in the test-from-egg and test-from-prefixdir buildbot steps.
    22
    3 Why do we think it was fixed for {{{setup.py trial}}}? I see no test that would fail if we were testing the wrong code. ({{{test_path}}} test_runner.py checks that we run the ''same'' code by invoking {{{bin/tahoe}}} that we are currently testing, but if {{{bin/tahoe}}} and {{{setup.py trial}}} were running the same installed version -- which is entirely plausible because they both work by setting PYTHONPATH -- then we wouldn't detect that.)
     3Why do we think it was fixed for {{{setup.py trial}}}? I see no test that would fail if we were testing the wrong code. ([source:src/allmydata/test/test_runner.py@4581#L35 test_path in test_runner.py] checks that we run the ''same'' code by invoking {{{bin/tahoe}}} that we are currently testing, but if {{{bin/tahoe}}} and {{{setup.py trial}}} were running the same installed version -- which is entirely plausible because they both work by setting PYTHONPATH -- then we wouldn't detect that.)