Changes between Version 2 and Version 3 of Ticket #1531


Ignore:
Timestamp:
2014-04-30T14:53:47Z (11 years ago)
Author:
zooko
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1531 – Description

    v2 v3  
    1 We have some code in [source:src/allmydata/windows/fixups.py] and [source:src/allmydata/util/fileutil.py] that calls Windows API functions, and then calls GetLastError if the API function fails. In theory, the Python interpreter could run code in-between on the same thread that changes the error code. See [http://bugs.python.org/issue1798].
     1We have some code in [source:src/allmydata/windows/fixups.py] and [source:src/allmydata/util/fileutil.py] that calls Windows API functions, and then calls !GetLastError if the API function fails. In theory, the Python interpreter could run code in-between on the same thread that changes the error code. See [http://bugs.python.org/issue1798].
    22
    3 (We don't have any code in Tahoe proper that calls C runtime library functions, so this issue only affects us for GetLastError, not errno. It is somewhat less likely to happen with GetLastError than with errno, at least in CPython, but still possible.)
     3(We don't have any code in Tahoe proper that calls C runtime library functions, so this issue only affects us for !GetLastError, not errno. It is somewhat less likely to happen with !GetLastError than with errno, at least in CPython, but still possible.)