error message gets downloaded instead of rendered by Konqueror

[zooko]

I chose a file to upload, left the radiobutton set to Immutable, and clicked the "Upload" button. Konqueror then prompted me to save a file or open the file with a helper app. I chose to save the file. The contents of the resulting saved file were:

upload requires a name

There was no trailing newline.

This is with Konqueror 4.8.3.

Grepping the Tahoe source shows that this line is producing that error message.

[zooko]

See #1809 for the separate issue that the name should have been provided.

[davidsarah]

Konqueror is quite unhelpful in the way it decides whether to download or view. I think it will download anything that is not HTML :-( This may mean we need to wrap any text error messages as HTML to fix this (if the Accept header of the request includes text/html, which it will for Konqueror).

[davidsarah]

It looks as though raised exceptions (such as WebError in this case) get converted into an HTTP response body in only one place: MyExceptionHandler at src/allmydata/web/common.py@5324#L287​. That makes things easier.

[davidsarah]

Hmm, can you test whether this works for Konqueror (at line 293):

req.setHeader("content-disposition", "inline")